Compare commits

...
38 Commits
Author SHA1 Message Date
dahyeon f649490cd2 fix(auction): harden lifecycle and durable bid storage
Serialize lifecycle changes and make cancellation, deadlines, and match side effects recoverable and idempotent.

Archive accepted bids durably, quarantine invalid payloads, and preserve compatibility with empty round IDs. Synchronize HTTP polling and socket state with scoped resync events.

Add cancellation cleanup index migration and regression coverage. Validated with 744 API tests, 65 Redis integration tests, and 28 Mongo integration tests.
2026-11-09 23:24:11 +09:00
dahyeon f2eec479d9 fix(api): correct champion history and deduplicate stats builds
Apply participant and champion filters before pagination and exclude timeline payloads. Route result statistics through the durable outbox, reuse current fragments, and serialize projection effects without spending retries on contention.

Validated with 716 API tests, 32 isolated Redis integration tests, API typecheck and build, and lint on changed files.
2026-11-09 18:40:51 +09:00
dahyeon ef141a13d0 fix(web): align staging redirect and release identifiers 2026-11-09 18:04:16 +09:00
dahyeon f622ee5b1f chore: remove legacy agent and skill configuration 2026-11-09 18:04:02 +09:00
dahyeon 4b8ccf0077 fix: harden result polling and Redis 8.10 operations
Preserve tournament result jobs through lock contention and transient failures,
atomically schedule retries before acknowledgement, and publish initial polls
after releasing the preparation lock.

Fix Redis connection blocking, durability Hash cleanup, duplicate auction
request ordering, and scheduled-job promotion. Use native Redis 8.10 stream,
lock, counter, and field-expiring cache operations with invalidation fencing.

Repair 90 test type errors and add a repeatable API typecheck command.

Validation: 704 API tests, 129 web tests, 31 real Redis integration tests,
3 dependency checks, workspace type checks and builds, and changed-file lint.
2026-11-09 17:33:13 +09:00
dahyeon 0c4c4239ec fix(redis): share Garnet endpoint and update database versions 2026-11-09 16:30:12 +09:00
dahyeon 9117c9c0a4 fix(deps): resolve production high and critical vulnerabilities
Pin vulnerable transitive dependencies to patched releases and replace Infisical SDK bootstrap calls with a compatible HTTP client. Add dependency-security and secret-loading regression coverage.
2026-11-07 20:21:54 +09:00
dahyeon 5bc748dc4d fix(auction): prevent skipped players and incomplete completion 2026-11-05 23:14:14 +09:00
dahyeon de84ad5309 Merge pull request 'fix(dakao): clarify command usage messages' (#15) from release/88 into main
Reviewed-on: #15
2026-09-26 15:37:04 +00:00
dahyeon f223157542 fix(dakao): clarify command usage messages 2026-09-26 08:36:27 -07:00
dahyeon cd1525c87a Merge pull request 'chore: remove bundled skills directory' (#14) from release/88 into main
Reviewed-on: #14
2026-09-19 11:25:40 +00:00
dahyeon 337970a12b chore: remove bundled skills directory 2026-09-19 20:22:13 +09:00
dahyeon 58e24ccd75 Merge pull request 'fix(deps): patch Socket.IO parser, nanoid and multer vulnerabilities' (#13) from release/88 into main
Reviewed-on: #13
2026-09-19 10:51:05 +00:00
dahyeon 827fc5b6b4 fix(deps): patch Socket.IO parser, nanoid and multer vulnerabilities 2026-09-19 19:50:46 +09:00
dahyeon 384d460ad6 Merge pull request 'feat(dakao): transfer existing users to new KakaoTalk IDs' (#12) from release/88 into main
Reviewed-on: #12
2026-09-19 10:44:08 +00:00
dahyeon 71085d0ac4 feat(dakao): transfer existing users to new KakaoTalk IDs 2026-09-19 19:40:35 +09:00
dahyeon 904f1fc4a4 Merge pull request 'refactor(web): hide history connection status' (#11) from agent/hide-history-realtime-status into main
Reviewed-on: #11
2026-07-25 18:07:21 +00:00
dahyeon f526257d9c refactor(web): hide history connection status 2026-07-25 11:06:28 -07:00
dahyeon 34a47c053e Merge pull request 'feat(api): refresh Riot ID during background updates' (#10) from agent/refresh-riot-id-by-puuid into main
Reviewed-on: #10
2026-07-25 16:13:18 +00:00
dahyeon e3f39fd8b8 feat(api): refresh Riot ID during background updates 2026-07-25 09:08:29 -07:00
dahyeon 4385ba7b8b Merge pull request 'feat(api): refresh Riot ID by PUUID' (#9) from agent/refresh-riot-id-by-puuid into main
Reviewed-on: #9
2026-07-25 15:38:33 +00:00
dahyeon 9cd5850d43 feat(api): refresh Riot ID by PUUID 2026-07-25 08:37:42 -07:00
dahyeon 79534cf43c Merge pull request 'refactor(web): remove redundant history result column' (#8) from agent/remove-history-result-column into main
Reviewed-on: #8
2026-07-25 14:38:57 +00:00
dahyeon 03be85d07b refactor(web): remove redundant history result column 2026-07-25 07:37:32 -07:00
dahyeon d269bdd92b Merge pull request 'chore(deps): resolve high audit findings' (#7) from release/87 into main
Reviewed-on: #7
2026-07-25 08:52:22 +00:00
dahyeon 2bac89d3dc chore(deps): resolve high audit findings
Upgrade direct dependencies and pin patched transitive versions so the high-severity pnpm audit gate passes. Document the dev-only brace-expansion exception and the separate Mongoose type-migration follow-up.
2026-07-25 01:51:00 -07:00
dahyeon 760da1cbea Merge pull request 'fix(dakao): hide started matches from schedule' (#6) from release/87 into main
Reviewed-on: #6
2026-07-25 08:07:42 +00:00
dahyeon ca786fd80a fix(dakao): hide started matches from schedule 2026-07-25 01:01:57 -07:00
dahyeon ac0d2b53f0 Merge pull request 'fix(web): satisfy React hook lint rules' (#5) from release/87 into main
Reviewed-on: #5
2026-07-25 06:40:40 +00:00
dahyeon a4215f86fb fix(web): satisfy React hook lint rules 2026-07-24 22:36:53 -07:00
dahyeon a24726d7da Merge pull request 'fix(api): eliminate unsafe lint warnings' (#4) from release/87 into main
Reviewed-on: #4
2026-07-25 05:23:15 +00:00
dahyeon bb68be14fa fix(api): eliminate unsafe lint warnings 2026-07-24 22:16:53 -07:00
dahyeon 9e2f2c61e7 Merge pull request 'release/87' (#3) from release/87 into main
Reviewed-on: #3
2026-07-25 04:59:34 +00:00
dahyeon fd1fa2366c fix(api): resolve lint errors 2026-07-24 21:52:35 -07:00
dahyeon 96fede9fe5 style(api): apply prettier formatting 2026-07-24 21:42:28 -07:00
dahyeon 80fef25af3 chore: upgrade runtime to Node.js 26 2026-07-18 05:21:49 +00:00
dahyeon 1f75c6318a Merge pull request 'release/86' (#2) from release/86 into main
Reviewed-on: #2
2026-07-15 08:56:05 +00:00
dahyeon c155f26272 Merge pull request 'Release 77' (#1) from release/77 into main
Reviewed-on: #1
2026-06-09 13:36:48 +00:00
253 changed files with 14719 additions and 11962 deletions

No files matched your search

+1 -5
View File
@@ -19,19 +19,15 @@ website/LICENSE
*.log
!.claude/settings.json
*.temp.MD
*.md
!README.md
!AGENTS.md
!docs/specs/internal-match-game-analysis.md
!docs/plans/internal-match-game-analysis-p0-p1.md
!docs/specs/double-elimination-connector-routing.md
!docs/plans/double-elimination-connector-routing.md
!agents/**/*.md
!skills/**/*.md
!docs/plans/redis-8.10-optimization.md
/tmp/
/user-game-history/
/*.txt
+1
View File
@@ -0,0 +1 @@
26
-189
View File
@@ -1,189 +0,0 @@
# AGENTS.md
This file provides guidance to AI coding agents (Claude Code, Cursor, Copilot, Antigravity, etc.) when working with code in this repository.
## Repository Overview
A collection of skills for Claude.ai and Claude Code for senior software engineers. Skills are packaged instructions and scripts that extend Claude and your coding agents capabilities.
## OpenCode Integration
OpenCode uses a **skill-driven execution model** powered by the `skill` tool and this repository's `/skills` directory.
### Core Rules
- If a task matches a skill, you MUST invoke it
- Skills are located in `skills/<skill-name>/SKILL.md`
- Never implement directly if a skill applies
- Always follow the skill instructions exactly (do not partially apply them)
### Intent → Skill Mapping
The agent should automatically map user intent to skills:
- Feature / new functionality → `spec-driven-development`, then `incremental-implementation`, `test-driven-development`
- Planning / breakdown → `planning-and-task-breakdown`
- Bug / failure / unexpected behavior → `debugging-and-error-recovery`
- Code review → `code-review-and-quality`
- Refactoring / simplification → `code-simplification`
- API or interface design → `api-and-interface-design`
- UI work → `frontend-ui-engineering`
### Lifecycle Mapping (Implicit Commands)
OpenCode does not support slash commands like `/spec` or `/plan`.
Instead, the agent must internally follow this lifecycle:
- DEFINE → `spec-driven-development`
- PLAN → `planning-and-task-breakdown`
- BUILD → `incremental-implementation` + `test-driven-development`
- VERIFY → `debugging-and-error-recovery`
- REVIEW → `code-review-and-quality`
- SHIP → `shipping-and-launch`
### Execution Model
For every request:
1. Determine if any skill applies (even 1% chance)
2. Invoke the appropriate skill using the `skill` tool
3. Follow the skill workflow strictly
4. Only proceed to implementation after required steps (spec, plan, etc.) are complete
### Anti-Rationalization
The following thoughts are incorrect and must be ignored:
- "This is too small for a skill"
- "I can just quickly implement this"
- "I’ll gather context first"
Correct behavior:
- Always check for and use skills first
This ensures OpenCode behaves similarly to Claude Code with full workflow enforcement.
## Orchestration: Personas, Skills, and Commands
This repo has three composable layers. They have different jobs and should not be confused:
- **Skills** (`skills/<name>/SKILL.md`) — workflows with steps and exit criteria. The *how*. Mandatory hops when an intent matches.
- **Personas** (`agents/<role>.md`) — roles with a perspective and an output format. The *who*.
- **Slash commands** (`.claude/commands/*.md`) — user-facing entry points. The *when*. The orchestration layer.
Composition rule: **the user (or a slash command) is the orchestrator. Personas do not invoke other personas.** A persona may invoke skills.
The only multi-persona orchestration pattern this repo endorses is **parallel fan-out with a merge step** — used by `/ship` to run `code-reviewer`, `security-auditor`, and `test-engineer` concurrently and synthesize their reports. Do not build a "router" persona that decides which other persona to call; that's the job of slash commands and intent mapping.
See [agents/README.md](agents/README.md) for the decision matrix and [references/orchestration-patterns.md](references/orchestration-patterns.md) for the full pattern catalog.
**Claude Code interop:** the personas in `agents/` work as Claude Code subagents (auto-discovered from this plugin's `agents/` directory) and as Agent Teams teammates (referenced by name when spawning). Two platform constraints align with our rules: subagents cannot spawn other subagents, and teams cannot nest. Plugin agents silently ignore the `hooks`, `mcpServers`, and `permissionMode` frontmatter fields.
## Creating a New Skill
### Directory Structure
```
skills/
{skill-name}/ # kebab-case directory name
SKILL.md # Required: skill definition
scripts/ # Required: executable scripts
{script-name}.sh # Bash scripts (preferred)
{skill-name}.zip # Required: packaged for distribution
```
### Naming Conventions
- **Skill directory**: `kebab-case` (e.g. `web-quality`)
- **SKILL.md**: Always uppercase, always this exact filename
- **Scripts**: `kebab-case.sh` (e.g., `deploy.sh`, `fetch-logs.sh`)
- **Zip file**: Must match directory name exactly: `{skill-name}.zip`
### SKILL.md Format
```markdown
---
name: {skill-name}
description: {One sentence describing what the skill does, followed by one or more "Use when" trigger conditions. Include trigger phrases like "Deploy my app" or "Check logs" when helpful.}
---
# {Skill Title}
{Brief overview of what the skill does and why it matters.}
## How It Works
{Numbered list explaining the skill's workflow}
Equivalent headings like `Workflow`, `Core Process`, or `When to Use` are fine when they communicate the same structure clearly.
## Usage (Optional)
Include this section only if the skill ships runnable helpers under `scripts/`. Markdown-only skills can omit both the section and the directory entirely.
```bash
bash /mnt/skills/user/{skill-name}/scripts/{script}.sh [args]
```
**Arguments:**
- `arg1` - Description (defaults to X)
**Examples:**
{Show 2-3 common usage patterns}
## Output
{Show example output users will see}
## Present Results to User
{Template for how Claude should format results when presenting to users}
## Troubleshooting
{Common issues and solutions, especially network/permissions errors}
```
### Best Practices for Context Efficiency
Skills are loaded on-demand — only the skill name and description are loaded at startup. The full `SKILL.md` loads into context only when the agent decides the skill is relevant. To minimize context usage:
- **Keep SKILL.md under 500 lines** — put detailed reference material in separate files
- **Write specific descriptions** — helps the agent know exactly when to activate the skill
- **Use progressive disclosure** — reference supporting files that get read only when needed
- **Prefer scripts over inline code** — script execution doesn't consume context (only output does)
- **File references work one level deep** — link directly from SKILL.md to supporting files
### Script Requirements
- Use `#!/bin/bash` shebang
- Use `set -e` for fail-fast behavior
- Write status messages to stderr: `echo "Message" >&2`
- Write machine-readable output (JSON) to stdout
- Include a cleanup trap for temp files
- Reference the script path as `/mnt/skills/user/{skill-name}/scripts/{script}.sh`
### Creating the Zip Package
After creating or updating a skill:
```bash
cd skills
zip -r {skill-name}.zip {skill-name}/
```
### End-User Installation
Document these two installation methods for users:
**Claude Code:**
```bash
cp -r skills/{skill-name} ~/.claude/skills/
```
**claude.ai:**
Add the skill to project knowledge or paste SKILL.md contents into the conversation.
If the skill requires network access, instruct users to add required domains at `claude.ai/settings/capabilities`.
+2 -2
View File
@@ -1,11 +1,11 @@
# syntax=docker/dockerfile:1.7
FROM node:24-bookworm-slim AS pnpm-base
FROM node:26-bookworm-slim AS pnpm-base
ENV PNPM_HOME=/pnpm
ENV PATH="${PNPM_HOME}:${PATH}"
RUN corepack enable
RUN npm install --global pnpm@10.4.1
WORKDIR /app
+21 -5
View File
@@ -94,9 +94,8 @@ LOLYMPUS는 이 반복 작업을 줄이는 데 초점을 맞췄습니다. 운영
- TypeScript
- TanStack Query
- NestJS
- MongoDB
- Redis
- Redis 8.4 (경매 실시간 상태 전용)
- MongoDB 8.3
- Redis 8.10 (일반 캐시/스트림과 경매 실시간 상태 공유)
- NATS
- Riot API
- pnpm workspace
@@ -118,9 +117,9 @@ scripts/ deployment and maintenance scripts
- Node.js 24 이상
- pnpm 10.4.1 (`packageManager` 기준, `corepack enable`로 활성화 권장)
- MongoDB 7.0, 일반 캐시/스트림용 Redis, 경매 실시간 상태 전용 Redis 8.4, NATS 실행 환경
- MongoDB 8.3, Redis 8.10, NATS 실행 환경
경매 Redis는 라이브 경매 상태의 source of truth로 사용되므로 일반 캐시/스트림 Redis와 물리적으로 분리해야 합니다. API는 `REDIS_URL`/`REDIS_ENDPOINT`와 별도로 `AUCTION_REDIS_URL`/`AUCTION_REDIS_ENDPOINT`를 읽고, 두 값이 같은 호스트/포트를 가리키면 부팅을 거부합니다.
일반 캐시/스트림, 경매 실시간 상태, WebSocket Pub/Sub는 `GARNET_ENDPOINT`로 지정한 하나의 Redis 인스턴스를 공유합니다. 값은 `host:port`, `redis://...`, `rediss://...` 형식을 지원합니다. 인증이 필요하면 기존 `GARNET_USERID`(또는 `GARNET_USERNAME`)와 `GARNET_PASSWORD`를 설정합니다. `REDIS_*`, `AUCTION_REDIS_*`, `GARNET_URL` 연결 설정은 사용하지 않습니다. 경매 점검 스크립트도 같은 설정을 사용합니다.
## 실행 방법
@@ -132,6 +131,21 @@ pnpm start:web:dev
웹 앱은 기본적으로 `apps/web/.env.development` 값을 사용합니다. API 환경값은 `apps/project.env`와 실행 환경의 시크릿 설정을 함께 확인합니다.
### Redis 변경 검증
Redis 8.10.x의 `XREADGROUP CLAIM`, `XACKDEL ACKED`, `DELEX`, `SET IFEQ`, `INCREX`, `HSETEX`를 사용합니다. 스트림의 대기 읽기는 별도 연결에서 실행하며, 처리되지 않은 작업은 길이 제한을 초과해도 보존합니다.
```bash
pnpm --filter api test -- --runInBand
pnpm --filter api typecheck
pnpm --filter api test:redis
pnpm --filter api build
```
`test:redis`는 PATH의 `redis-server` 또는 `REDIS_TEST_SERVER`에 지정한 실행 파일로 Redis 8.10.x를 직접 실행합니다. 임의의 로컬 포트와 일회용 암호를 사용하고, 저장을 비활성화하며, 종료 후 프로세스와 임시 디렉터리를 정리합니다. 애플리케이션 Redis 연결 설정은 사용하지 않습니다. Windows에서는 PowerShell에서 `$env:REDIS_TEST_SERVER = 'C:\tools\redis\redis-server.exe'`처럼 지정할 수 있습니다.
커뮤니티 통계 캐시는 `riot:communitystats:v2:{communityId}:scope` Hash로 전환됩니다. 항목별 TTL은 일반 5분, 완성된 상세 24시간, 미완성 상세 60초를 유지합니다. 이전 String 캐시는 기존 TTL로 만료되며 새 캐시는 첫 조회에 생성됩니다. 구버전과 신버전은 무효화 대상이 다르므로 API 인스턴스를 같은 버전으로 함께 전환해야 합니다. 구현 범위와 검증 기록은 [Redis 변경 계획](docs/plans/redis-8.10-optimization.md)을 참고하세요.
### API New Relic APM
API 서버는 `newrelic` Node.js agent를 앱 코드보다 먼저 preload합니다. Docker 런타임과 `pnpm start:api:*` 스크립트 모두 `NEW_RELIC_HOME`을 API 패키지로 지정해 `apps/api/newrelic.cjs` 설정을 읽습니다.
@@ -164,6 +178,8 @@ API 성능 계측은 기본 비활성화이며 필요할 때 `API_PERF_OBSERVABI
| `pnpm start:web:dev` | 웹 앱 개발 서버 실행 |
| `pnpm start:api:dev` | API 서버 dev 환경 실행 |
| `pnpm --filter api test` | API 테스트 실행 |
| `pnpm --filter api typecheck` | 테스트를 포함한 API 타입 검사 |
| `pnpm --filter api test:redis` | 격리된 Redis 8.10 통합 테스트 실행 |
| `pnpm --filter api perf:routes` | API 성능 리포트 대상 route 출력 |
| `pnpm --filter api perf:report` | API 성능 리포트 생성 |
| `pnpm --filter web build:staging` | 웹 staging 빌드 검증 |
-120
View File
@@ -1,120 +0,0 @@
# Agent Personas
Specialist personas that play a single role with a single perspective. Each persona is a Markdown file consumed as a system prompt by your harness (Claude Code, Cursor, Copilot, etc.).
| Persona | Role | Best for |
|---------|------|----------|
| [code-reviewer](code-reviewer.md) | Senior Staff Engineer | Five-axis review before merge |
| [security-auditor](security-auditor.md) | Security Engineer | Vulnerability detection, OWASP-style audit |
| [test-engineer](test-engineer.md) | QA Engineer | Test strategy, coverage analysis, Prove-It pattern |
## How personas relate to skills and commands
Three layers, each with a distinct job:
| Layer | What it is | Example | Composition role |
|-------|-----------|---------|------------------|
| **Skill** | A workflow with steps and exit criteria | `code-review-and-quality` | The *how* — invoked from inside a persona or command |
| **Persona** | A role with a perspective and an output format | `code-reviewer` | The *who* — adopts a viewpoint, produces a report |
| **Command** | A user-facing entry point | `/review`, `/ship` | The *when* — composes personas and skills |
The user (or a slash command) is the orchestrator. **Personas do not call other personas.** Skills are mandatory hops inside a persona's workflow.
## When to use each
### Direct persona invocation
Pick this when you want one perspective on the current change and the user is in the loop.
- "Review this PR" → invoke `code-reviewer` directly
- "Are there security issues in `auth.ts`?" → invoke `security-auditor` directly
- "What tests are missing for the checkout flow?" → invoke `test-engineer` directly
### Slash command (single persona behind it)
Pick this when there's a repeatable workflow you'd otherwise re-explain every time.
- `/review` → wraps `code-reviewer` with the project's review skill
- `/test` → wraps `test-engineer` with TDD skill
### Slash command (orchestrator — fan-out)
Pick this only when **independent** investigations can run in parallel and produce reports that a single agent then merges.
- `/ship` → fans out to `code-reviewer` + `security-auditor` + `test-engineer` in parallel, then synthesizes their reports into a go/no-go decision
This is the only orchestration pattern this repo endorses. See [references/orchestration-patterns.md](../references/orchestration-patterns.md) for the full pattern catalog and anti-patterns.
## Decision matrix
```
Is the work a single perspective on a single artifact?
├── Yes → Direct persona invocation
└── No → Are the sub-tasks independent (no shared mutable state, no ordering)?
├── Yes → Slash command with parallel fan-out (e.g. /ship)
└── No → Sequential slash commands run by the user (/spec → /plan → /build → /test → /review)
```
## Worked example: valid orchestration
`/ship` is the canonical fan-out orchestrator in this repo:
```
/ship
├── (parallel) code-reviewer → review report
├── (parallel) security-auditor → audit report
└── (parallel) test-engineer → coverage report
↓
merge phase (main agent)
↓
go/no-go decision + rollback plan
```
Why this works:
- Each sub-agent operates on the same diff but produces a **different perspective**
- They have no dependencies on each other → genuine parallelism, real wall-clock savings
- Each runs in a fresh context window → main session stays uncluttered
- The merge step is small and benefits from full context, so it stays in the main agent
## Worked example: invalid orchestration (do not build this)
A `meta-orchestrator` persona whose job is "decide which other persona to call":
```
/work-on-pr → meta-orchestrator
↓ (decides "this needs a review")
code-reviewer
↓ (returns)
meta-orchestrator (paraphrases result)
↓
user
```
Why this fails:
- Pure routing layer with no domain value
- Adds two paraphrasing hops → information loss + 2× token cost
- The user already knows they want a review; let them call `/review` directly
- Replicates work that slash commands and `AGENTS.md` intent-mapping already do
## Rules for personas
1. A persona is a single role with a single output format. If you find yourself adding a second role, create a second persona.
2. **Personas do not invoke other personas.** Composition is the job of slash commands or the user. On Claude Code this is also a hard platform constraint — *"subagents cannot spawn other subagents"* — so the rule is enforced for you.
3. A persona may invoke skills (the *how*).
4. Every persona file ends with a "Composition" block stating where it fits.
## Claude Code interop
The personas in this repo are designed to work as Claude Code subagents and as Agent Teams teammates without modification:
- **As subagents:** auto-discovered when this plugin is enabled (no path config needed). Use the Agent tool with `subagent_type: code-reviewer` (or `security-auditor`, `test-engineer`). `/ship` is the canonical example.
- **As Agent Teams teammates** (experimental, requires `CLAUDE_CODE_EXPERIMENTAL_AGENT_TEAMS=1`): reference the same persona name when spawning a teammate. The persona's body is **appended to** the teammate's system prompt as additional instructions (not a replacement), so your persona text sits on top of the team-coordination instructions the lead installs (SendMessage, task-list tools, etc.).
Subagents only report results back to the main agent. Agent Teams let teammates message each other directly. Use subagents when reports are enough; use Agent Teams when sub-agents need to challenge each other's findings (e.g. competing-hypothesis debugging). See [references/orchestration-patterns.md](../references/orchestration-patterns.md) for the full mapping.
Plugin agents do not support `hooks`, `mcpServers`, or `permissionMode` frontmatter — those fields are silently ignored. Avoid relying on them when authoring new personas here.
## Adding a new persona
1. Create `agents/<role>.md` with the same frontmatter format used by existing personas.
2. Define the role, scope, output format, and rules.
3. Add a **Composition** block at the bottom (Invoke directly when / Invoke via / Do not invoke from another persona).
4. Add the persona to the table at the top of this file.
5. If the persona enables a new orchestration pattern, document it in `references/orchestration-patterns.md` rather than inventing the pattern in the persona file itself.
-97
View File
@@ -1,97 +0,0 @@
---
name: code-reviewer
description: Senior code reviewer that evaluates changes across five dimensions — correctness, readability, architecture, security, and performance. Use for thorough code review before merge.
---
# Senior Code Reviewer
You are an experienced Staff Engineer conducting a thorough code review. Your role is to evaluate the proposed changes and provide actionable, categorized feedback.
## Review Framework
Evaluate every change across these five dimensions:
### 1. Correctness
- Does the code do what the spec/task says it should?
- Are edge cases handled (null, empty, boundary values, error paths)?
- Do the tests actually verify the behavior? Are they testing the right things?
- Are there race conditions, off-by-one errors, or state inconsistencies?
### 2. Readability
- Can another engineer understand this without explanation?
- Are names descriptive and consistent with project conventions?
- Is the control flow straightforward (no deeply nested logic)?
- Is the code well-organized (related code grouped, clear boundaries)?
### 3. Architecture
- Does the change follow existing patterns or introduce a new one?
- If a new pattern, is it justified and documented?
- Are module boundaries maintained? Any circular dependencies?
- Is the abstraction level appropriate (not over-engineered, not too coupled)?
- Are dependencies flowing in the right direction?
### 4. Security
- Is user input validated and sanitized at system boundaries?
- Are secrets kept out of code, logs, and version control?
- Is authentication/authorization checked where needed?
- Are queries parameterized? Is output encoded?
- Any new dependencies with known vulnerabilities?
### 5. Performance
- Any N+1 query patterns?
- Any unbounded loops or unconstrained data fetching?
- Any synchronous operations that should be async?
- Any unnecessary re-renders (in UI components)?
- Any missing pagination on list endpoints?
## Output Format
Categorize every finding:
**Critical** — Must fix before merge (security vulnerability, data loss risk, broken functionality)
**Important** — Should fix before merge (missing test, wrong abstraction, poor error handling)
**Suggestion** — Consider for improvement (naming, code style, optional optimization)
## Review Output Template
```markdown
## Review Summary
**Verdict:** APPROVE | REQUEST CHANGES
**Overview:** [1-2 sentences summarizing the change and overall assessment]
### Critical Issues
- [File:line] [Description and recommended fix]
### Important Issues
- [File:line] [Description and recommended fix]
### Suggestions
- [File:line] [Description]
### What's Done Well
- [Positive observation — always include at least one]
### Verification Story
- Tests reviewed: [yes/no, observations]
- Build verified: [yes/no]
- Security checked: [yes/no, observations]
```
## Rules
1. Review the tests first — they reveal intent and coverage
2. Read the spec or task description before reviewing code
3. Every Critical and Important finding should include a specific fix recommendation
4. Don't approve code with Critical issues
5. Acknowledge what's done well — specific praise motivates good practices
6. If you're uncertain about something, say so and suggest investigation rather than guessing
## Composition
- **Invoke directly when:** the user asks for a review of a specific change, file, or PR.
- **Invoke via:** `/review` (single-perspective review) or `/ship` (parallel fan-out alongside `security-auditor` and `test-engineer`).
- **Do not invoke from another persona.** If you find yourself wanting to delegate to `security-auditor` or `test-engineer`, surface that as a recommendation in your report instead — orchestration belongs to slash commands, not personas. See [agents/README.md](README.md).
-101
View File
@@ -1,101 +0,0 @@
---
name: security-auditor
description: Security engineer focused on vulnerability detection, threat modeling, and secure coding practices. Use for security-focused code review, threat analysis, or hardening recommendations.
---
# Security Auditor
You are an experienced Security Engineer conducting a security review. Your role is to identify vulnerabilities, assess risk, and recommend mitigations. You focus on practical, exploitable issues rather than theoretical risks.
## Review Scope
### 1. Input Handling
- Is all user input validated at system boundaries?
- Are there injection vectors (SQL, NoSQL, OS command, LDAP)?
- Is HTML output encoded to prevent XSS?
- Are file uploads restricted by type, size, and content?
- Are URL redirects validated against an allowlist?
### 2. Authentication & Authorization
- Are passwords hashed with a strong algorithm (bcrypt, scrypt, argon2)?
- Are sessions managed securely (httpOnly, secure, sameSite cookies)?
- Is authorization checked on every protected endpoint?
- Can users access resources belonging to other users (IDOR)?
- Are password reset tokens time-limited and single-use?
- Is rate limiting applied to authentication endpoints?
### 3. Data Protection
- Are secrets in environment variables (not code)?
- Are sensitive fields excluded from API responses and logs?
- Is data encrypted in transit (HTTPS) and at rest (if required)?
- Is PII handled according to applicable regulations?
- Are database backups encrypted?
### 4. Infrastructure
- Are security headers configured (CSP, HSTS, X-Frame-Options)?
- Is CORS restricted to specific origins?
- Are dependencies audited for known vulnerabilities?
- Are error messages generic (no stack traces or internal details to users)?
- Is the principle of least privilege applied to service accounts?
### 5. Third-Party Integrations
- Are API keys and tokens stored securely?
- Are webhook payloads verified (signature validation)?
- Are third-party scripts loaded from trusted CDNs with integrity hashes?
- Are OAuth flows using PKCE and state parameters?
## Severity Classification
| Severity | Criteria | Action |
|----------|----------|--------|
| **Critical** | Exploitable remotely, leads to data breach or full compromise | Fix immediately, block release |
| **High** | Exploitable with some conditions, significant data exposure | Fix before release |
| **Medium** | Limited impact or requires authenticated access to exploit | Fix in current sprint |
| **Low** | Theoretical risk or defense-in-depth improvement | Schedule for next sprint |
| **Info** | Best practice recommendation, no current risk | Consider adopting |
## Output Format
```markdown
## Security Audit Report
### Summary
- Critical: [count]
- High: [count]
- Medium: [count]
- Low: [count]
### Findings
#### [CRITICAL] [Finding title]
- **Location:** [file:line]
- **Description:** [What the vulnerability is]
- **Impact:** [What an attacker could do]
- **Proof of concept:** [How to exploit it]
- **Recommendation:** [Specific fix with code example]
#### [HIGH] [Finding title]
...
### Positive Observations
- [Security practices done well]
### Recommendations
- [Proactive improvements to consider]
```
## Rules
1. Focus on exploitable vulnerabilities, not theoretical risks
2. Every finding must include a specific, actionable recommendation
3. Provide proof of concept or exploitation scenario for Critical/High findings
4. Acknowledge good security practices — positive reinforcement matters
5. Check the OWASP Top 10 as a minimum baseline
6. Review dependencies for known CVEs
7. Never suggest disabling security controls as a "fix"
## Composition
- **Invoke directly when:** the user wants a security-focused pass on a specific change, file, or system component.
- **Invoke via:** `/ship` (parallel fan-out alongside `code-reviewer` and `test-engineer`), or any future `/audit` command.
- **Do not invoke from another persona.** If `code-reviewer` flags something that warrants a deeper security pass, the user or a slash command initiates that pass — not the reviewer. See [agents/README.md](README.md).
-95
View File
@@ -1,95 +0,0 @@
---
name: test-engineer
description: QA engineer specialized in test strategy, test writing, and coverage analysis. Use for designing test suites, writing tests for existing code, or evaluating test quality.
---
# Test Engineer
You are an experienced QA Engineer focused on test strategy and quality assurance. Your role is to design test suites, write tests, analyze coverage gaps, and ensure that code changes are properly verified.
## Approach
### 1. Analyze Before Writing
Before writing any test:
- Read the code being tested to understand its behavior
- Identify the public API / interface (what to test)
- Identify edge cases and error paths
- Check existing tests for patterns and conventions
### 2. Test at the Right Level
```
Pure logic, no I/O → Unit test
Crosses a boundary → Integration test
Critical user flow → E2E test
```
Test at the lowest level that captures the behavior. Don't write E2E tests for things unit tests can cover.
### 3. Follow the Prove-It Pattern for Bugs
When asked to write a test for a bug:
1. Write a test that demonstrates the bug (must FAIL with current code)
2. Confirm the test fails
3. Report the test is ready for the fix implementation
### 4. Write Descriptive Tests
```
describe('[Module/Function name]', () => {
it('[expected behavior in plain English]', () => {
// Arrange → Act → Assert
});
});
```
### 5. Cover These Scenarios
For every function or component:
| Scenario | Example |
|----------|---------|
| Happy path | Valid input produces expected output |
| Empty input | Empty string, empty array, null, undefined |
| Boundary values | Min, max, zero, negative |
| Error paths | Invalid input, network failure, timeout |
| Concurrency | Rapid repeated calls, out-of-order responses |
## Output Format
When analyzing test coverage:
```markdown
## Test Coverage Analysis
### Current Coverage
- [X] tests covering [Y] functions/components
- Coverage gaps identified: [list]
### Recommended Tests
1. **[Test name]** — [What it verifies, why it matters]
2. **[Test name]** — [What it verifies, why it matters]
### Priority
- Critical: [Tests that catch potential data loss or security issues]
- High: [Tests for core business logic]
- Medium: [Tests for edge cases and error handling]
- Low: [Tests for utility functions and formatting]
```
## Rules
1. Test behavior, not implementation details
2. Each test should verify one concept
3. Tests should be independent — no shared mutable state between tests
4. Avoid snapshot tests unless reviewing every change to the snapshot
5. Mock at system boundaries (database, network), not between internal functions
6. Every test name should read like a specification
7. A test that never fails is as useless as a test that always fails
## Composition
- **Invoke directly when:** the user asks for test design, coverage analysis, or a Prove-It test for a specific bug.
- **Invoke via:** `/test` (TDD workflow) or `/ship` (parallel fan-out for coverage gap analysis alongside `code-reviewer` and `security-auditor`).
- **Do not invoke from another persona.** Recommendations to add tests belong in your report; the user or a slash command decides when to act on them. See [agents/README.md](README.md).
+53
View File
@@ -62,8 +62,61 @@ $ pnpm run test:e2e
# test coverage
$ pnpm run test:cov
# auction cancellation/undo transactions against a real local MongoDB replica set
$ pnpm run test:mongodb
```
`test:mongodb` requires `mongod` on PATH, or `MONGODB_TEST_SERVER` set to its
executable path. The runner starts an isolated replica set on a random loopback
port, uses a temporary database directory, and removes it after the tests. It
does not use the application's database connection settings.
## Auction durability
Accepted Redis bids now enter `auction:bidArchivePayloads` and
`auction:bidArchiveQueue` atomically with the bid. The durability scheduler saves
them to `auctionBidRecords` using deterministic IDs before removing queue entries.
Recent state snapshots remain capped at 1000 bids; the archive is not capped and
retains accepted bids across undo/cancellation for audit. These records begin with
this deployment; bids already discarded by an older version cannot be recovered.
`GET /communities/:communityId/matches/:matchId/auction/bids/history` pages through
the current lifecycle's persisted archive using `afterRevision` and `limit` (1–200).
Persistence is asynchronous, so an empty last page may gain entries afterward.
Invalid archive entries are moved atomically to `auction:bidArchiveDeadLetterQueue`
and `auction:bidArchiveDeadLetterPayloads`. The payload stores the original text
(or `null` for a missing payload), error, ID, and quarantine time. Monitor these
keys and review quarantined data before repairing/requeuing it; it is not retried
automatically or expired. Other bids continue to persist. Mongo write failures
leave valid entries in the pending queue for idempotent retries.
Older in-flight rounds can produce `bidRoundId: ''`; the archive treats this as
an absent optional round ID. Empty player IDs and other invalid field types
remain validation errors.
Cancellation commits its completion marker and pending cleanup fields in Match.
The scheduler retries cleanup after restarts, with a delay capped at 60 seconds.
Reset notifications include the lifecycle to protect a newly started auction.
Dead-letter status notifications use `auction:deadLetterStatusQueue`; failures to
persist or mirror the terminal status are retried without rerunning the side effect.
Older side-effect dead letters are also reconciled automatically.
Before deploying the cleanup worker, create its partial Match index using the
additive, repeatable migration below. Schema declarations alone do not create
indexes when `MONGODB_AUTO_INDEX` is disabled (the default). Choose the target
environment explicitly; dry-run does not create indexes or modify documents.
```bash
pnpm --filter api auction:indexes -- --env staging --dry-run
pnpm --filter api auction:indexes -- --env staging --apply
# Use --env prod for production.
```
The index is `{ auctionCancellationCleanupRetryAt: 1 }`, restricted to
`{ auctionCancellationCleanupPending: true }`. The worker only reads due pending
entries; it no longer scans legacy cancellation markers without a pending flag.
## Deployment
When you're ready to deploy your NestJS application to production, there are some key steps you can take to ensure it runs as efficiently as possible. Check out the [deployment documentation](https://docs.nestjs.com/deployment) for more information.
+22 -1
View File
@@ -29,7 +29,28 @@ export default tseslint.config(
'@typescript-eslint/no-explicit-any': 'off',
'@typescript-eslint/no-floating-promises': 'warn',
'@typescript-eslint/no-unsafe-argument': 'warn',
"prettier/prettier": ["error", { endOfLine: "auto" }],
'prettier/prettier': ['error', { endOfLine: 'auto' }],
},
},
{
files: ['**/*.spec.ts', 'test/**/*.ts'],
rules: {
'@typescript-eslint/no-unsafe-assignment': 'off',
'@typescript-eslint/no-unsafe-call': 'off',
'@typescript-eslint/no-unsafe-member-access': 'off',
'@typescript-eslint/no-unsafe-return': 'off',
'@typescript-eslint/no-this-alias': 'off',
'@typescript-eslint/require-await': 'off',
'@typescript-eslint/unbound-method': 'off',
},
},
{
files: ['src/modules/global/database/migrations/**/*.ts'],
rules: {
'@typescript-eslint/no-unsafe-assignment': 'off',
'@typescript-eslint/no-unsafe-call': 'off',
'@typescript-eslint/no-unsafe-member-access': 'off',
'@typescript-eslint/no-unsafe-return': 'off',
},
},
);
+13 -9
View File
@@ -9,6 +9,7 @@
"build": "nest build",
"format": "prettier --write \"src/**/*.ts\" \"test/**/*.ts\"",
"competition:migrate": "ts-node src/modules/global/database/migrations/run-competition-domain.ts",
"auction:indexes": "ts-node src/modules/global/database/migrations/run-auction-cancellation-index.ts",
"seed:dev": "ts-node src/seed.ts",
"seed:dakao-participant": "ts-node src/seed-dakao-participant.ts",
"start:dev": "NODE_ENV=dev NEW_RELIC_HOME=. node --import newrelic/esm-loader.mjs -r newrelic dist/main.js",
@@ -22,6 +23,9 @@
"start:debug": "nest start --debug --watch",
"lint": "eslint \"{src,apps,libs,test}/**/*.ts\" --fix",
"test": "jest",
"typecheck": "tsc --noEmit --incremental false",
"test:redis": "node test/run-redis-tests.mjs",
"test:mongodb": "node test/run-mongo-tests.mjs",
"test:watch": "jest --watch",
"test:cov": "jest --coverage",
"test:debug": "node --inspect-brk -r tsconfig-paths/register -r ts-node/register node_modules/.bin/jest --runInBand",
@@ -29,20 +33,20 @@
},
"dependencies": {
"@lolympus/contracts": "workspace:*",
"@nestjs/common": "^11.0.1",
"@nestjs/common": "^11.1.28",
"@nestjs/config": "^4.0.4",
"@nestjs/core": "^11.0.1",
"@nestjs/platform-express": "^11.0.1",
"@nestjs/platform-socket.io": "^11.1.19",
"@nestjs/swagger": "^11.2.7",
"@nestjs/websockets": "^11.1.19",
"@nestjs/core": "^11.1.28",
"@nestjs/platform-express": "^11.1.28",
"@nestjs/platform-socket.io": "^11.1.28",
"@nestjs/swagger": "^11.4.6",
"@nestjs/websockets": "^11.1.28",
"@socket.io/redis-adapter": "^8.3.0",
"class-transformer": "^0.5.1",
"class-validator": "^0.15.1",
"jose": "^6.2.2",
"mongoose": "^9.4.1",
"mongoose": "9.4.1",
"nats": "^2.29.3",
"newrelic": "^14.1.2",
"newrelic": "^14.3.3",
"redis": "^5.12.1",
"reflect-metadata": "^0.2.2",
"rxjs": "^7.8.1",
@@ -57,7 +61,7 @@
"@nestjs/testing": "^11.0.1",
"@types/express": "^5.0.0",
"@types/jest": "^30.0.0",
"@types/node": "^24.0.0",
"@types/node": "^26.1.1",
"@types/supertest": "^7.0.0",
"eslint": "^9.18.0",
"eslint-config-prettier": "^10.0.1",
@@ -0,0 +1,82 @@
import mongoose from 'mongoose';
import { AuctionBidArchiveService } from './auction-bid-archive.service';
const matchId = new mongoose.Types.ObjectId().toString();
function bid(overrides: Record<string, unknown> = {}) {
return {
_id: `${matchId}:life:${String(1).padStart(16, '0')}`,
matchId,
auctionLifecycleId: 'life',
revision: 1,
bidRequestId: 'bid-1',
bidderUserId: new mongoose.Types.ObjectId().toString(),
playerUserId: new mongoose.Types.ObjectId().toString(),
bidderTeamIndex: 1,
bidPointAmount: 10,
bidPlacedAtTimestampMS: 1_700_000_000_000,
...overrides,
};
}
function fixture(payload: Record<string, unknown>) {
const raw = JSON.stringify(payload);
const commands: string[][] = [];
const sendCommand = jest.fn(async (command: string[]) => {
commands.push(command);
if (command[0] === 'ZRANGE') return [payload._id];
if (command[0] === 'HMGET') return [raw];
return 1;
});
const bulkWrite = jest.fn(async (operations: unknown[]) => ({
matchedCount: 0,
upsertedCount: operations.length,
}));
const service = new AuctionBidArchiveService(
{ getModel: async () => ({ bulkWrite }) } as never,
{ raw: () => ({ sendCommand }) } as never,
);
return { service, bulkWrite, commands };
}
function savedEvent(bulkWrite: jest.Mock) {
const [[operations]] = bulkWrite.mock.calls as unknown as [
[
Array<{
updateOne: { update: { $setOnInsert: Record<string, unknown> } };
}>,
],
];
return operations[0].updateOne.update.$setOnInsert;
}
function quarantined(commands: string[][]) {
return commands.some(
(command) =>
command[0] === 'EVAL' &&
command[1].includes("redis.call('ZADD', KEYS[4]"),
);
}
it('archives a pre-upgrade bid with an empty round ID without the field', async () => {
const f = fixture(bid({ bidRoundId: '' }));
await expect(f.service.persistPendingBids()).resolves.toBe(1);
expect(quarantined(f.commands)).toBe(false);
expect(savedEvent(f.bulkWrite)).not.toHaveProperty('bidRoundId');
});
it('keeps a non-empty round ID on the archived bid', async () => {
const f = fixture(bid({ bidRoundId: 'round-1' }));
await expect(f.service.persistPendingBids()).resolves.toBe(1);
expect(savedEvent(f.bulkWrite)).toMatchObject({ bidRoundId: 'round-1' });
});
it.each([' ', null, 1])(
'still quarantines an invalid round ID %j',
async (bidRoundId) => {
const f = fixture(bid({ bidRoundId }));
await expect(f.service.persistPendingBids()).resolves.toBe(0);
expect(f.bulkWrite).not.toHaveBeenCalled();
expect(quarantined(f.commands)).toBe(true);
},
);
@@ -0,0 +1,242 @@
import {
BadRequestException,
Injectable,
Logger,
NotFoundException,
} from '@nestjs/common';
import mongoose from 'mongoose';
import type { AuctionBidRecord } from '../global/database/schema';
import { ConnectionService } from '../global/database/connection.service';
import { AuctionRedisService } from './redis/auction-redis.service';
import {
AUCTION_BID_ARCHIVE_PAYLOADS_KEY,
AUCTION_BID_ARCHIVE_QUEUE_KEY,
AUCTION_BID_ARCHIVE_DEAD_LETTER_QUEUE_KEY,
AUCTION_BID_ARCHIVE_DEAD_LETTER_PAYLOADS_KEY,
} from './redis/auction-redis.keys';
// Compare the payload as well as the ID: a concurrent repair must not be moved
// or acknowledged by a worker that read an older value.
const QUARANTINE_BID_ARCHIVE_SCRIPT = `
local moved = 0
for i = 2, #ARGV, 4 do
local current = redis.call('HGET', KEYS[1], ARGV[i])
local matches = (ARGV[i+1] == '0' and current == false) or (ARGV[i+1] == '1' and current == ARGV[i+2])
if matches and redis.call('ZSCORE', KEYS[2], ARGV[i]) then
redis.call('HSET', KEYS[3], ARGV[i], ARGV[i+3])
redis.call('ZADD', KEYS[4], ARGV[1], ARGV[i])
redis.call('HDEL', KEYS[1], ARGV[i])
redis.call('ZREM', KEYS[2], ARGV[i])
moved = moved + 1
end
end
return moved
`;
@Injectable()
export class AuctionBidArchiveService {
private readonly logger = new Logger(AuctionBidArchiveService.name);
constructor(
private readonly database: ConnectionService,
private readonly redis: AuctionRedisService,
) {}
public async persistPendingBids(limit = 200): Promise<number> {
const client = this.redis.raw();
const reply = await client.sendCommand([
'ZRANGE',
AUCTION_BID_ARCHIVE_QUEUE_KEY,
'0',
String(limit - 1),
]);
const ids = Array.isArray(reply) ? reply.map(String) : [];
if (!ids.length) return 0;
const values = await client.sendCommand<Array<string | null>>([
'HMGET',
AUCTION_BID_ARCHIVE_PAYLOADS_KEY,
...ids,
]);
const valid: Array<{ event: AuctionBidRecord; raw: string }> = [];
const invalid: Array<{ id: string; raw: string | null; error: string }> =
[];
for (let index = 0; index < ids.length; index++) {
const raw = values[index] ?? null;
try {
valid.push({ event: parseBidArchiveEvent(ids[index], raw), raw: raw! });
} catch (error) {
invalid.push({
id: ids[index],
raw,
error: String(error).slice(0, 2000),
});
}
}
if (invalid.length) {
const now = Date.now();
const moved = await client.sendCommand<number>([
'EVAL',
QUARANTINE_BID_ARCHIVE_SCRIPT,
'4',
AUCTION_BID_ARCHIVE_PAYLOADS_KEY,
AUCTION_BID_ARCHIVE_QUEUE_KEY,
AUCTION_BID_ARCHIVE_DEAD_LETTER_PAYLOADS_KEY,
AUCTION_BID_ARCHIVE_DEAD_LETTER_QUEUE_KEY,
String(now),
...invalid.flatMap(({ id, raw, error }) => [
id,
raw === null ? '0' : '1',
raw ?? '',
JSON.stringify({
id,
rawPayload: raw,
error,
quarantinedAtTimestampMS: now,
}),
]),
]);
if (moved > 0)
this.logger.warn(`Quarantined ${moved} invalid bid archive events.`);
}
if (valid.length) {
const model = await this.database.getModel('auctionBidRecord');
// The deterministic _id is the dedupe key, including after a crash between
// Mongo acknowledgement and Redis cleanup. Never trim unpersisted events.
const result = await model.bulkWrite(
valid.map(({ event }) => ({
updateOne: {
filter: { _id: event._id },
update: { $setOnInsert: event },
upsert: true,
},
})),
{ ordered: false, throwOnValidationError: true },
);
// A partial/ambiguous write leaves valid entries queued. Replaying the
// upserts is safe; assuming that a resolved bulkWrite saved all is not.
if (result.matchedCount + result.upsertedCount !== valid.length) {
throw new Error(
'Bid archive batch was not fully acknowledged by MongoDB.',
);
}
await client.sendCommand([
'EVAL',
"for i = 1, #ARGV, 2 do if redis.call('HGET', KEYS[1], ARGV[i]) == ARGV[i+1] then redis.call('HDEL', KEYS[1], ARGV[i]); redis.call('ZREM', KEYS[2], ARGV[i]) end end return 1",
'2',
AUCTION_BID_ARCHIVE_PAYLOADS_KEY,
AUCTION_BID_ARCHIVE_QUEUE_KEY,
...valid.flatMap(({ event, raw }) => [event._id, raw]),
]);
}
return valid.length;
}
public async list(
matchId: mongoose.Types.ObjectId,
afterRevision = -1,
limit = 100,
) {
if (
!Number.isSafeInteger(afterRevision) ||
afterRevision < -1 ||
!Number.isSafeInteger(limit) ||
limit < 1 ||
limit > 200
) {
throw new BadRequestException('Invalid bid history cursor or limit.');
}
const AuctionModel = await this.database.getModel('auction');
const auction = await AuctionModel.findOne({ matchId })
.select({ auctionLifecycleId: 1 })
.lean()
.exec();
if (!auction) throw new NotFoundException('Auction not found.');
const prefix = `${matchId.toString()}:${auction.auctionLifecycleId}:`;
const model = await this.database.getModel('auctionBidRecord');
// The built-in _id index supports ordered pagination without an additional
// production index or an unbounded array inside an Auction document.
const items = await model
.find({
_id: {
$gt:
afterRevision < 0
? prefix
: prefix + String(afterRevision).padStart(16, '0'),
$lt: prefix + '\uffff',
},
})
.sort({ _id: 1 })
.limit(limit + 1)
.lean()
.exec();
const hasMore = items.length > limit;
if (hasMore) items.pop();
return {
items,
hasMore,
nextRevision: items.at(-1)?.revision ?? afterRevision,
};
}
}
function parseBidArchiveEvent(
id: string,
raw: string | null,
): AuctionBidRecord {
if (raw === null) throw new Error('Missing bid archive payload.');
const value: unknown = JSON.parse(raw);
if (!value || typeof value !== 'object' || Array.isArray(value)) {
throw new Error('Bid archive payload must be an object.');
}
const event = value as Record<string, unknown>;
const string = (field: string): string => {
const value = event[field];
if (typeof value !== 'string' || !value.trim()) {
throw new Error(`Invalid bid archive ${field}.`);
}
return value;
};
const integer = (field: string, minimum = 0): number => {
const value = event[field];
if (
typeof value !== 'number' ||
!Number.isSafeInteger(value) ||
value < minimum
) {
throw new Error(`Invalid bid archive ${field}.`);
}
return value;
};
const objectId = (field: string): mongoose.Types.ObjectId => {
const value = string(field);
if (!mongoose.isObjectIdOrHexString(value)) {
throw new Error(`Invalid bid archive ${field}.`);
}
return new mongoose.Types.ObjectId(value);
};
const matchId = objectId('matchId');
const auctionLifecycleId = string('auctionLifecycleId');
const revision = integer('revision');
const expectedId = `${matchId.toString()}:${auctionLifecycleId}:${String(revision).padStart(16, '0')}`;
if (event._id !== id || id !== expectedId) {
throw new Error('Bid archive identity does not match its payload.');
}
return {
_id: id,
matchId,
auctionLifecycleId,
revision,
bidRequestId: string('bidRequestId'),
bidderUserId: objectId('bidderUserId'),
bidderTeamIndex: integer('bidderTeamIndex', 1),
bidPointAmount: integer('bidPointAmount'),
bidPlacedAtTimestampMS: integer('bidPlacedAtTimestampMS'),
...(event.playerUserId !== undefined
? { playerUserId: objectId('playerUserId') }
: {}),
// Pre-upgrade rounds have no Redis round ID; the bid Lua records ''.
...(event.bidRoundId !== undefined && event.bidRoundId !== ''
? { bidRoundId: string('bidRoundId') }
: {}),
};
}
@@ -0,0 +1,154 @@
import { NotFoundException } from '@nestjs/common';
import mongoose from 'mongoose';
import { AuctionService } from './auction.service';
const matchId = new mongoose.Types.ObjectId();
const communityId = new mongoose.Types.ObjectId();
function sessionQuery<T>(value: T) {
return { session: async () => value };
}
function fixture(options: {
auction: Record<string, unknown> | null;
match: Record<string, unknown>;
failRedisCleanup?: boolean;
}) {
const session = {
startTransaction: jest.fn(),
commitTransaction: jest.fn().mockResolvedValue(undefined),
abortTransaction: jest.fn().mockResolvedValue(undefined),
endSession: jest.fn().mockResolvedValue(undefined),
};
const deleteMany = jest.fn(() => sessionQuery(undefined));
const models: Record<string, unknown> = {
auction: { findOne: () => sessionQuery(options.auction) },
auctionHistory: { deleteMany },
auctionSideEffectApplication: { deleteMany },
match: { findById: () => sessionQuery(options.match) },
};
const redisCommands: string[][] = [];
const sendCommand = jest.fn(async (command: string[]) => {
redisCommands.push(command);
if (command[0] === 'EVAL' && options.failRedisCleanup)
throw new Error('redis unavailable');
return command[0] === 'SCAN' ? ['0', []] : 1;
});
const service = new AuctionService(
{
getModel: async (name: string) => models[name],
createSession: async () => session,
} as never,
{} as never,
{ releaseFromMatch: jest.fn().mockResolvedValue(undefined) } as never,
{ cancelPolling: jest.fn().mockResolvedValue(undefined) } as never,
{
acquireTokenLock: async () => true,
releaseTokenLock: async () => true,
raw: () => ({ sendCommand }),
} as never,
{} as never,
{} as never,
);
return { service, session, redisCommands };
}
function liveMatch(): Record<string, unknown> {
return {
communityId,
status: 'team-built',
teams: [],
tournamentCodeIds: [],
gameSchedule: [],
participants: [],
save: jest.fn().mockResolvedValue(undefined),
};
}
function redisAuction() {
return {
_id: new mongoose.Types.ObjectId(),
auctionEngineVersion: 'redis-v1',
auctionLifecycleId: 'life',
deleteOne: jest.fn().mockResolvedValue(undefined),
};
}
it('records the cancelled lifecycle and still succeeds when Redis cleanup fails', async () => {
const match = liveMatch();
const f = fixture({
auction: redisAuction(),
match,
failRedisCleanup: true,
});
await expect(
f.service.reset({
matchId,
communityId,
clientObservedAuctionLifecycleId: 'life',
}),
).resolves.toBeUndefined();
expect(f.session.commitTransaction).toHaveBeenCalledTimes(1);
expect(match.lastCancelledAuctionLifecycleId).toBe('life');
expect(match.status).toBe('recruiting');
});
it('answers a retransmitted cancellation and durably schedules Redis cleanup', async () => {
const match = { ...liveMatch(), lastCancelledAuctionLifecycleId: 'life' };
const f = fixture({ auction: null, match });
await expect(
f.service.reset({
matchId,
communityId,
clientObservedAuctionLifecycleId: 'life',
}),
).resolves.toBeUndefined();
expect(match).toMatchObject({
auctionCancellationCleanupPending: true,
auctionCancellationCleanupRetryAt: expect.any(Date),
});
expect(f.redisCommands).toEqual([]);
});
it('preserves a committed cancellation even if its lock renewal fails before returning', async () => {
jest.useFakeTimers();
try {
const match = liveMatch();
const f = fixture({ auction: redisAuction(), match });
f.session.commitTransaction.mockImplementation(async () => {
await jest.advanceTimersByTimeAsync(10000);
});
await expect(
f.service.reset({
matchId,
communityId,
clientObservedAuctionLifecycleId: 'life',
}),
).resolves.toBeUndefined();
expect(match.auctionCancellationCleanupPending).toBe(true);
expect(f.session.commitTransaction).toHaveBeenCalledTimes(1);
} finally {
jest.useRealTimers();
}
});
it('keeps 404 for a missing auction that was not cancelled with this lifecycle', async () => {
for (const [observed, recorded] of [
['other', 'life'],
[undefined, 'life'],
['life', undefined],
] as const) {
const f = fixture({
auction: null,
match: { ...liveMatch(), lastCancelledAuctionLifecycleId: recorded },
});
await expect(
f.service.reset({
matchId,
communityId,
clientObservedAuctionLifecycleId: observed,
}),
).rejects.toBeInstanceOf(NotFoundException);
expect(f.session.abortTransaction).toHaveBeenCalled();
}
});
@@ -0,0 +1,607 @@
import mongoose from 'mongoose';
import { AuctionService } from './auction.service';
import {
AuctionDurabilityScheduler,
buildAuctionProjectionGuardedUpdate,
type AuctionDurabilityPayload,
} from './auction-durability.scheduler';
import { AuctionDeadlineScheduler } from './auction-deadline.scheduler';
import { AuctionLifecycleLock } from './auction-lifecycle-lock';
const query = <T>(value: T) => ({
select() {
return this;
},
session() {
return this;
},
lean() {
return this;
},
exec: async () => value,
});
const session = () => ({
startTransaction: jest.fn(),
commitTransaction: jest.fn(),
abortTransaction: jest.fn(),
endSession: jest.fn(),
});
const state = {
auctionLifecycleId: 'life',
revision: 12,
phase: 'presenting',
currentAuctionHistorySequence: 7,
currentAuctionPlayerOrderIndex: 0,
currentAuctionRound: 1,
auctionTeams: [],
auctionPlayerOrder: [],
passedAuctionPlayerQueue: [],
currentHighestBidPointAmount: 0,
currentHighestBidderTeamIndex: -1,
auctionCompletedAtTimestampMS: 0,
currentBidRoundDeadlineTimestampMS: 0,
};
beforeEach(() => {
jest
.spyOn(AuctionLifecycleLock.prototype, 'run')
.mockImplementation(async (_id, work) => work());
});
afterEach(() => jest.restoreAllMocks());
function matches(
document: Record<string, unknown>,
filter: Record<string, unknown>,
): boolean {
return Object.entries(filter).every(([key, value]) => {
if (key === '$or')
return (value as Record<string, unknown>[]).some((alternative) =>
matches(document, alternative),
);
if (value && typeof value === 'object') {
return Object.entries(value).every(([operator, limit]) => {
if (operator === '$exists')
return (document[key] !== undefined) === limit;
if (operator === '$lt') return Number(document[key]) < Number(limit);
if (operator === '$lte') return Number(document[key]) <= Number(limit);
return false;
});
}
return document[key] === value;
});
}
function update(
document: Record<string, unknown>,
mutation: Record<string, Record<string, unknown>>,
) {
Object.assign(document, mutation.$set);
for (const [key, amount] of Object.entries(mutation.$inc ?? {}))
document[key] = Number(document[key] ?? 0) + Number(amount);
for (const key of Object.keys(mutation.$unset ?? {})) delete document[key];
}
function sideEffectFixture(withReader = false) {
const projection: Record<string, unknown> = {
_id: 'auction',
auctionLifecycleId: 'life',
revision: 9,
matchSideEffectRevision: 0,
};
const application: Record<string, unknown> = {};
const payload: AuctionDurabilityPayload = {
auctionId: 'auction',
matchId: 'match',
auctionLifecycleId: 'life',
auctionStateTransitionId: 'complete',
auctionActionType: 'complete',
auctionHistorySequence: 10,
revision: 10,
snapshotBefore: {},
historyMutation: { type: 'append' },
matchSideEffectMutation: { type: 'syncMatchTeamsAfterComplete' },
afterAuctionMongoProjection: {
auctionLifecycleId: 'life',
revision: 10,
phase: 'complete',
matchSideEffectRevision: 1,
matchSideEffectStatus: 'pending',
matchSideEffectTransitionId: 'complete',
auctionTeams: [{ teamIndex: 1, captainUserId: 'captain', members: [] }],
},
};
const AuctionModel = {
findById: () => query({ ...projection }),
updateOne: (
filter: Record<string, unknown>,
mutation: Record<string, Record<string, unknown>>,
) => {
const matchedCount = Number(matches(projection, filter));
if (matchedCount) update(projection, mutation);
return query({ matchedCount });
},
findOneAndUpdate: (
filter: Record<string, unknown>,
mutation: Record<string, Record<string, unknown>>,
) => {
if (!matches(projection, filter)) return query(null);
update(projection, mutation);
return query({ ...projection });
},
};
const ApplicationModel = {
findOne: () => query({ ...application }),
updateOne: (
filter: Record<string, unknown>,
mutation: Record<string, Record<string, unknown>>,
) => {
if (mutation.$setOnInsert) {
if (!application.state)
Object.assign(application, mutation.$setOnInsert);
return query({ matchedCount: 1 });
}
const matchedCount = Number(matches(application, filter));
if (matchedCount) update(application, mutation);
return query({ matchedCount });
},
};
const match = {
participants: [],
teams: [],
save: jest.fn().mockResolvedValue(undefined),
};
const historyFindOne = jest.fn().mockReturnValue(query(null));
const historyUpdateOne = jest
.fn()
.mockReturnValue(query({ matchedCount: 1 }));
const models: Record<string, unknown> = {
auction: AuctionModel,
auctionHistory: {
findOne: historyFindOne,
updateOne: historyUpdateOne,
},
auctionSideEffectApplication: ApplicationModel,
match: {
findById: () => ({ ...query(match), session: async () => match }),
},
};
const reserveForMatch = jest
.fn()
.mockRejectedValueOnce(new Error('temporary reservation error'))
.mockResolvedValue(match);
const scheduleInitialPoll = jest.fn().mockResolvedValue(undefined);
const releaseFromMatch = jest.fn().mockResolvedValue(undefined);
const cancelPolling = jest.fn().mockResolvedValue(undefined);
let queued = true;
const sendCommand = jest.fn(async (command: string[]) => {
if (command[0] === 'ZRANGEBYSCORE') return queued ? ['payload'] : [];
if (command[0] === 'HGETALL')
return { payloadJson: JSON.stringify(payload) };
if (command[0] === 'DEL') queued = false;
if (command[0] === 'HINCRBY') return 1;
return 1;
});
const scheduler = new AuctionDurabilityScheduler(
{
getModel: async (name: string) => models[name],
createSession: async () => session(),
} as never,
{
getCurrentRedisTimestampMS: async () => 10000,
raw: () => ({ sendCommand }),
} as never,
{ reserveForMatch, releaseFromMatch } as never,
{ scheduleInitialPoll, cancelPolling } as never,
undefined,
undefined,
withReader
? ({
readAuctionStateView: async () => ({
auctionLifecycleId: 'life',
phase: payload.afterAuctionMongoProjection.phase,
matchSideEffectTransitionId: 'complete',
}),
} as never)
: undefined,
);
return {
scheduler,
payload,
projection,
application,
reserveForMatch,
scheduleInitialPoll,
sendCommand,
match,
historyFindOne,
historyUpdateOne,
releaseFromMatch,
cancelPolling,
};
}
it('retries failed completion work with the current generation and only then deletes the payload', async () => {
const f = sideEffectFixture();
expect(await f.scheduler.processDueDurabilityPayloads(20)).toMatchObject({
failed: 1,
});
expect(f.projection.matchSideEffectStatus).toBe('failed');
expect(await f.scheduler.processDueDurabilityPayloads(20)).toMatchObject({
applied: 1,
});
expect(f.reserveForMatch).toHaveBeenCalledTimes(2);
expect(f.scheduleInitialPoll).toHaveBeenCalledTimes(1);
expect(f.application.state).toBe('completed');
expect(f.projection.matchSideEffectStatus).toBe('completed');
expect(f.projection.matchSideEffectRevision).toBe(5);
expect(f.sendCommand).toHaveBeenCalledWith(['DEL', 'payload']);
});
it('keeps an outbox payload while another worker owns its side-effect lease', async () => {
const f = sideEffectFixture();
Object.assign(f.application, {
auctionId: 'auction',
auctionStateTransitionId: 'complete',
sideEffectType: 'syncMatchTeamsAfterComplete',
state: 'processing',
processingOwnerToken: 'other',
processingLeaseExpiresAtTimestampMS: 50000,
});
expect(await f.scheduler.processDueDurabilityPayloads(20)).toEqual({
applied: 0,
failed: 0,
skipped: 1,
});
expect(f.sendCommand).not.toHaveBeenCalledWith(['DEL', 'payload']);
expect(
f.sendCommand.mock.calls.some(([command]) => command[0] === 'HINCRBY'),
).toBe(false);
expect(f.reserveForMatch).not.toHaveBeenCalled();
});
it('recovers side effects when a later ordinary projection was persisted first', async () => {
const f = sideEffectFixture(true);
f.reserveForMatch.mockReset().mockResolvedValue(undefined);
Object.assign(f.projection, { revision: 12 });
await f.scheduler.applyDurabilityPayload(f.payload);
expect(f.reserveForMatch).toHaveBeenCalledTimes(1);
expect(f.projection.revision).toBe(12);
expect(f.projection.matchSideEffectTransitionId).toBe('complete');
expect(f.projection.matchSideEffectStatus).toBe('completed');
});
it('still cleans up completed Match state when a second undo invalidates the first undo history', async () => {
const f = sideEffectFixture(true);
Object.assign(f.projection, { revision: 12 });
Object.assign(f.payload, {
matchSideEffectMutation: { type: 'undoCompletedAuctionSideEffects' },
});
f.payload.afterAuctionMongoProjection.phase = 'presenting';
Object.assign(f.match, {
teams: [{ teamIndex: 1 }],
teamBuiltAt: new Date(),
tournamentCodeIds: ['code'],
gameSchedule: [{}],
});
f.historyFindOne.mockReturnValue(
query({
sequence: 12,
historyMutation: {
type: 'deleteAfterSequenceAndAppendUndo',
targetHistorySequence: 2,
},
}),
);
await f.scheduler.applyDurabilityPayload(f.payload);
expect(f.historyUpdateOne).not.toHaveBeenCalled();
expect(f.releaseFromMatch).toHaveBeenCalledTimes(1);
expect(f.cancelPolling).toHaveBeenCalledTimes(1);
expect(f.match).toMatchObject({
teams: [],
teamBuiltAt: undefined,
tournamentCodeIds: [],
gameSchedule: [],
});
expect(f.projection.matchSideEffectStatus).toBe('completed');
});
it('does not let a superseded side effect overwrite the newer generation', async () => {
const f = sideEffectFixture();
Object.assign(f.projection, {
revision: 12,
matchSideEffectTransitionId: 'undo',
matchSideEffectRevision: 6,
});
await f.scheduler.applyDurabilityPayload(f.payload);
expect(f.reserveForMatch).not.toHaveBeenCalled();
expect(f.projection.matchSideEffectTransitionId).toBe('undo');
});
it('removes obsolete projection fields both from Mongo updates and subsequent undo snapshots', () => {
const service = new AuctionService(
{} as never,
{} as never,
{} as never,
{} as never,
{} as never,
{} as never,
{} as never,
);
const internal = service as unknown as {
buildAuctionMongoProjectionFromState(
auction: unknown,
state: Record<string, unknown>,
): Record<string, unknown>;
buildAuctionSnapshotFromRedisState(
auction: unknown,
state: Record<string, unknown>,
): Record<string, unknown>;
};
const old = {
_id: new mongoose.Types.ObjectId(),
matchId: new mongoose.Types.ObjectId(),
completedAt: new Date(),
auctionCompletedAtTimestampMS: 100,
currentHighestBidderTeamIndex: 2,
currentBidderTeamIndex: 2,
};
const projection = internal.buildAuctionMongoProjectionFromState(old, state);
const mutation = buildAuctionProjectionGuardedUpdate({
auctionId: old._id,
auctionLifecycleId: 'life',
revision: 12,
afterAuctionMongoProjection: projection,
} as AuctionDurabilityPayload).update;
const stored = { ...old } as Record<string, unknown>;
update(stored, mutation);
const snapshot = internal.buildAuctionSnapshotFromRedisState(old, state);
for (const record of [stored, snapshot]) {
expect(record).not.toHaveProperty('completedAt');
expect(record).not.toHaveProperty('currentHighestBidderTeamIndex');
expect(record.phase).toBe('presenting');
}
});
it('applies delayed undo history cleanup without deleting newer branch entries or rolling back projection', async () => {
const deleteMany = jest.fn().mockReturnValue(query({}));
const updateOne = jest.fn().mockReturnValue(query({}));
const projectionUpdate = jest.fn();
const models: Record<string, unknown> = {
auction: {
findById: () => query({ auctionLifecycleId: 'life', revision: 12 }),
updateOne: projectionUpdate,
},
auctionHistory: { findOne: () => query(null), deleteMany, updateOne },
auctionSideEffectApplication: {},
};
const scheduler = new AuctionDurabilityScheduler(
{
getModel: async (name: string) => models[name],
createSession: async () => null,
} as never,
{} as never,
);
await scheduler.applyDurabilityPayload({
auctionId: 'auction',
matchId: 'match',
auctionStateTransitionId: 'undo',
auctionLifecycleId: 'life',
revision: 11,
auctionHistorySequence: 9,
auctionActionType: 'undo',
historyMutation: {
type: 'deleteAfterSequenceAndAppendUndo',
targetHistorySequence: 3,
},
matchSideEffectMutation: { type: 'none' },
afterAuctionMongoProjection: {},
snapshotBefore: {},
} as AuctionDurabilityPayload);
expect(deleteMany).toHaveBeenCalledWith(
{ auctionId: 'auction', sequence: { $gt: 3, $lt: 9 } },
{ session: null },
);
expect(updateOne).toHaveBeenCalledTimes(1);
expect(projectionUpdate).not.toHaveBeenCalled();
});
it('rejects a cancellation from a prior lifecycle before deleting anything', async () => {
const matchId = new mongoose.Types.ObjectId(),
communityId = new mongoose.Types.ObjectId();
const deleteOne = jest.fn();
const service = new AuctionService(
{
createSession: async () => session(),
getModel: async () => ({
findOne: () => ({
session: async () => ({
auctionEngineVersion: 'redis-v1',
auctionLifecycleId: 'new-life',
deleteOne,
}),
}),
}),
} as never,
{} as never,
{} as never,
{} as never,
{} as never,
{} as never,
{} as never,
);
await expect(
service.reset({
matchId,
communityId,
clientObservedAuctionLifecycleId: 'old-life',
}),
).rejects.toThrow('lifecycle has changed');
expect(deleteOne).not.toHaveBeenCalled();
});
it('resumes startup after Mongo creation instead of returning an unfinished auction', async () => {
const matchId = new mongoose.Types.ObjectId(),
communityId = new mongoose.Types.ObjectId();
const captain = new mongoose.Types.ObjectId(),
player = new mongoose.Types.ObjectId(),
lateJoiner = new mongoose.Types.ObjectId();
const auction = {
_id: new mongoose.Types.ObjectId(),
matchId,
auctionLifecycleId: 'life',
revision: 1,
phase: 'presenting',
startupCompleted: false,
startAuctionRequestId: 'same-request',
teams: [{ captainUserId: captain, members: [], teamIndex: 1 }],
order: [{ userId: player }],
};
const match = {
communityId,
status: 'recruiting',
participants: [captain, player, lateJoiner].map((userId) => ({
userId,
excluded: false,
})),
save: jest.fn(),
};
const updateOne = jest.fn();
const historyUpdate = jest.fn();
const models: Record<string, unknown> = {
auction: { findOne: async () => auction, updateOne },
match: { findById: async () => match },
auctionHistory: { updateOne: historyUpdate },
};
const hydrateState = jest.fn().mockResolvedValue({ hydrated: true });
const service = new AuctionService(
{ getModel: async (name: string) => models[name] } as never,
{} as never,
{} as never,
{} as never,
{} as never,
{ hydrateState } as never,
{} as never,
);
await service.start({
matchId,
communityId,
startAuctionRequestId: 'same-request',
} as never);
expect(hydrateState).toHaveBeenCalledTimes(1);
expect(historyUpdate).toHaveBeenCalledTimes(1);
expect(match.save).toHaveBeenCalledTimes(1);
expect(match.status).toBe('team-built');
expect(auction.startupCompleted).toBe(true);
expect(match.participants.map((entry) => entry.excluded)).toEqual([
false,
false,
true,
]);
});
it('does not open bidding until interrupted startup has been completed', async () => {
const service = new AuctionService(
{
getModel: async () => ({
findOne: async () => ({
auctionEngineVersion: 'redis-v1',
startupCompleted: false,
}),
}),
} as never,
{} as never,
{} as never,
{} as never,
{} as never,
{} as never,
{} as never,
);
await expect(
service.openBidding(new mongoose.Types.ObjectId()),
).rejects.toThrow('startup is not complete');
});
it('uses Redis completion state to schedule cleanup despite a delayed Mongo projection', async () => {
const matchId = new mongoose.Types.ObjectId(),
communityId = new mongoose.Types.ObjectId();
const auction = {
_id: new mongoose.Types.ObjectId(),
matchId,
auctionEngineVersion: 'redis-v1',
auctionLifecycleId: 'life',
phase: 'sold',
revision: 9,
};
const snapshot = { ...state, phase: 'bidding', revision: 5 };
const models: Record<string, unknown> = {
auction: { findOne: () => ({ session: async () => auction }) },
match: { findById: () => ({ session: async () => ({ communityId }) }) },
auctionHistory: { findOne: () => query({ snapshotBefore: snapshot }) },
};
const applyTransition = jest.fn().mockResolvedValue({ ok: true });
const commands = {
reserveActionRequest: async () => ({
reserved: true,
actionRequestScopeKey: 'scope',
auctionStateTransitionId: 'undo',
observedProcessingLeaseVersion: 1,
}),
applyTransition,
};
const service = new AuctionService(
{
getModel: async (name: string) => models[name],
createSession: async () => session(),
} as never,
{} as never,
{} as never,
{} as never,
{} as never,
commands as never,
{
readAuctionStateView: async () => ({
...state,
phase: 'complete',
revision: 10,
}),
} as never,
);
await service.undoTo({ matchId, communityId, sequence: 2 });
const input = applyTransition.mock.calls[0][1] as {
durabilityPayloadJson: string;
};
expect(JSON.parse(input.durabilityPayloadJson)).toMatchObject({
matchSideEffectMutation: { type: 'undoCompletedAuctionSideEffects' },
});
});
it.each(['deadline', 'durability'])(
'continues %s ticks when lock release fails',
async (kind) => {
const redis = {
acquireTokenLock: jest.fn().mockResolvedValue(true),
releaseTokenLock: jest
.fn()
.mockRejectedValue(new Error('redis disconnected')),
};
const scheduler =
kind === 'deadline'
? new AuctionDeadlineScheduler(
redis as never,
{} as never,
{} as never,
{} as never,
)
: new AuctionDurabilityScheduler({} as never, redis as never);
const work = jest.fn().mockResolvedValue({});
Object.assign(
scheduler,
kind === 'deadline'
? { processDueBidRoundDeadlines: work }
: { processDueDurabilityPayloads: work },
);
const internal = scheduler as unknown as { safeTick(): Promise<void> };
await internal.safeTick();
await internal.safeTick();
expect(work).toHaveBeenCalledTimes(2);
},
);
@@ -79,7 +79,9 @@ describe('AuctionDeadlineScheduler', () => {
.spyOn(scheduler, 'processDueBidRoundDeadlines')
.mockResolvedValue({ completed: 0, prepared: 0, skipped: 0 });
await (scheduler as unknown as { safeTick: () => Promise<void> }).safeTick();
await (
scheduler as unknown as { safeTick: () => Promise<void> }
).safeTick();
const leaderLockToken = redis.acquireTokenLock.mock.calls[0]?.[1];
expect(redis.acquireTokenLock).toHaveBeenCalledWith(
@@ -100,7 +102,9 @@ describe('AuctionDeadlineScheduler', () => {
.spyOn(scheduler, 'processDueBidRoundDeadlines')
.mockResolvedValue({ completed: 0, prepared: 0, skipped: 0 });
await (scheduler as unknown as { safeTick: () => Promise<void> }).safeTick();
await (
scheduler as unknown as { safeTick: () => Promise<void> }
).safeTick();
expect(processDueBidRoundDeadlinesSpy).not.toHaveBeenCalled();
expect(redis.releaseTokenLock).not.toHaveBeenCalled();
@@ -129,10 +133,12 @@ describe('AuctionDeadlineScheduler', () => {
it('prepares and completes due auction deadlines', async () => {
const matchId = '665f2f01f1f1f1f1f1f1f1f1';
const completedState = { phase: 'passed', revision: 3 };
const { auctionService, eventBus, redisCommand, scheduler } = makeScheduler({
dueReply: [matchId],
completedState,
});
const { auctionService, eventBus, redisCommand, scheduler } = makeScheduler(
{
dueReply: [matchId],
completedState,
},
);
await expect(scheduler.processDueBidRoundDeadlines(10)).resolves.toEqual({
completed: 1,
@@ -149,7 +155,10 @@ describe('AuctionDeadlineScheduler', () => {
expect(auctionService.completePreparedExpiry).toHaveBeenCalledTimes(1);
// 만료 확정 결과는 즉시 1차 broadcast돼야 한다(클라가 입찰 라운드에 멈춰
// 후속 액션에서 CONFLICT가 반복되는 것을 막는 핵심 동작).
expect(eventBus.broadcastState).toHaveBeenCalledWith(matchId, completedState);
expect(eventBus.broadcastState).toHaveBeenCalledWith(
matchId,
completedState,
);
});
it('skips noop expiry preparations', async () => {
@@ -189,10 +198,7 @@ describe('AuctionDeadlineScheduler', () => {
});
it('continues processing later deadline items after one item fails', async () => {
const matchIds = [
'665f2f01f1f1f1f1f1f1f1f1',
'665f2f02f1f1f1f1f1f1f1f1',
];
const matchIds = ['665f2f01f1f1f1f1f1f1f1f1', '665f2f02f1f1f1f1f1f1f1f1'];
const { auctionService, redisCommand, scheduler } = makeScheduler({
dueReply: matchIds,
});
@@ -88,10 +88,13 @@ export class AuctionDeadlineScheduler implements OnModuleInit, OnModuleDestroy {
);
} finally {
if (leaderLockAcquired) {
await this.auctionRedisService.releaseTokenLock(
BID_ROUND_DEADLINE_LEADER_LOCK_KEY,
leaderLockToken,
);
await this.auctionRedisService
.releaseTokenLock(BID_ROUND_DEADLINE_LEADER_LOCK_KEY, leaderLockToken)
.catch((error: unknown) => {
this.logger.warn(
`Auction deadline lock release failed: ${String(error)}`,
);
});
}
this.tickInProgress = false;
}
@@ -101,15 +104,17 @@ export class AuctionDeadlineScheduler implements OnModuleInit, OnModuleDestroy {
currentRedisTimestampMS: number,
batchLimit: number,
): Promise<string[]> {
const reply = await this.auctionRedisService.raw().sendCommand([
'ZRANGEBYSCORE',
BID_ROUND_DEADLINE_QUEUE_KEY,
'-inf',
String(currentRedisTimestampMS),
'LIMIT',
'0',
String(batchLimit),
]);
const reply = await this.auctionRedisService
.raw()
.sendCommand([
'ZRANGEBYSCORE',
BID_ROUND_DEADLINE_QUEUE_KEY,
'-inf',
String(currentRedisTimestampMS),
'LIMIT',
'0',
String(batchLimit),
]);
return Array.isArray(reply) ? reply.map(String) : [];
}
@@ -177,11 +182,11 @@ export class AuctionDeadlineScheduler implements OnModuleInit, OnModuleDestroy {
return { completed, prepared, skipped };
}
private async removeBidRoundDeadlineQueueEntry(matchId: string): Promise<void> {
await this.auctionRedisService.raw().sendCommand([
'ZREM',
BID_ROUND_DEADLINE_QUEUE_KEY,
matchId,
]);
private async removeBidRoundDeadlineQueueEntry(
matchId: string,
): Promise<void> {
await this.auctionRedisService
.raw()
.sendCommand(['ZREM', BID_ROUND_DEADLINE_QUEUE_KEY, matchId]);
}
}
@@ -1,3 +1,5 @@
import { AuctionLifecycleLock } from './auction-lifecycle-lock';
import { buildAuctionProjectionUnset } from './auction-projection';
import {
AuctionDurabilityScheduler,
buildAuctionHistoryUpsert,
@@ -23,6 +25,12 @@ const payload = {
} as const;
describe('auction durability projection helpers', () => {
beforeEach(() => {
jest
.spyOn(AuctionLifecycleLock.prototype, 'run')
.mockImplementation(async (_id, work) => work());
});
afterEach(() => jest.restoreAllMocks());
it('builds idempotent history upsert by auction and transition id', () => {
expect(buildAuctionHistoryUpsert(payload)).toEqual({
updateOne: {
@@ -59,6 +67,9 @@ describe('auction durability projection helpers', () => {
},
update: {
$set: { phase: 'sold', revision: 9 },
$unset: buildAuctionProjectionUnset(
payload.afterAuctionMongoProjection,
),
},
});
});
@@ -210,7 +221,12 @@ describe('auction durability projection helpers', () => {
auctionLifecycleId: 'life-1',
revision: { $lt: 9 },
},
{ $set: { phase: 'sold', revision: 9 } },
{
$set: { phase: 'sold', revision: 9 },
$unset: buildAuctionProjectionUnset(
payload.afterAuctionMongoProjection,
),
},
{ session },
);
expect(session.commitTransaction).toHaveBeenCalledTimes(1);
@@ -370,7 +386,7 @@ describe('auction durability projection helpers', () => {
expect(historyDeleteMany).toHaveBeenCalledWith(
{
auctionId: 'auction-1',
sequence: { $gt: 2 },
sequence: { $gt: 2, $lt: 4 },
},
{ session },
);
@@ -811,21 +827,14 @@ describe('auction durability projection helpers', () => {
skipped: 0,
});
expect(sendCommand).toHaveBeenNthCalledWith(5, [
'ZREM',
'EVAL',
expect.stringContaining("redis.call('HEXISTS'"),
'4',
'payload-1',
'auction:auctionDurabilityRetryQueue',
'payload-1',
]);
expect(sendCommand).toHaveBeenNthCalledWith(6, [
'HSET',
'payload-1',
'deadLetteredAtRedisTimestampMS',
'1000',
]);
expect(sendCommand).toHaveBeenNthCalledWith(7, [
'ZADD',
'auction:auctionDurabilityDeadLetterQueue',
'auction:deadLetterStatusQueue',
'1000',
'payload-1',
]);
});
@@ -1030,11 +1039,20 @@ describe('auction durability projection helpers', () => {
{
_id: 'auction-1',
auctionLifecycleId: 'life-1',
matchSideEffectRevision: 1,
$or: [
{ matchSideEffectTransitionId: 'transition-1' },
{
matchSideEffectTransitionId: { $exists: false },
matchSideEffectRevision: 1,
},
],
},
{
$inc: { matchSideEffectRevision: 1 },
$set: { matchSideEffectStatus: 'processing' },
$set: {
matchSideEffectStatus: 'processing',
matchSideEffectTransitionId: 'transition-1',
},
$unset: { matchSideEffectError: '' },
},
expect.objectContaining({ returnDocument: 'after' }),
@@ -1045,34 +1063,42 @@ describe('auction durability projection helpers', () => {
_id: 'auction-1',
auctionLifecycleId: 'life-1',
matchSideEffectRevision: 2,
matchSideEffectTransitionId: 'transition-1',
},
{
$inc: { matchSideEffectRevision: 1 },
$set: { matchSideEffectStatus: 'completed' },
$set: {
matchSideEffectStatus: 'completed',
matchSideEffectTransitionId: 'transition-1',
},
$unset: { matchSideEffectError: '' },
},
expect.objectContaining({ returnDocument: 'after' }),
);
expect(mirrorMatchSideEffectStatus).toHaveBeenCalledWith({
auctionLifecycleId: 'life-1',
auctionStateTransitionId: 'transition-1',
matchId: 'match-1',
matchSideEffectRevision: 2,
matchSideEffectStatus: 'processing',
});
expect(mirrorMatchSideEffectStatus).toHaveBeenLastCalledWith({
auctionLifecycleId: 'life-1',
auctionStateTransitionId: 'transition-1',
matchId: 'match-1',
matchSideEffectRevision: 3,
matchSideEffectStatus: 'completed',
});
expect(broadcastMatchSideEffect).toHaveBeenNthCalledWith(1, 'match-1', {
auctionLifecycleId: 'life-1',
auctionStateTransitionId: 'transition-1',
currentServerTimestampMS: 2000,
matchSideEffectRevision: 2,
matchSideEffectStatus: 'processing',
});
expect(broadcastMatchSideEffect).toHaveBeenNthCalledWith(2, 'match-1', {
auctionLifecycleId: 'life-1',
auctionStateTransitionId: 'transition-1',
currentServerTimestampMS: 3000,
matchSideEffectRevision: 3,
matchSideEffectStatus: 'completed',
@@ -1080,7 +1106,7 @@ describe('auction durability projection helpers', () => {
expect(sendCommand).toHaveBeenCalledWith([
'EVAL',
expect.stringContaining("redis.call('EXPIRE'"),
'11',
'12',
'auction:match-1:liveAuctionState',
'auction:bidRoundDeadlineQueue',
'auction:match-1:auctionStructureState',
@@ -1092,6 +1118,7 @@ describe('auction durability projection helpers', () => {
'auction:match-1:auctionActionRequestResultOrder',
'auction:match-1:rehydrateLock',
'auction:match-1:auctionStateTransitionLock',
'auction:match-1:rejectedBidRequestResultOrder',
'match-1',
'life-1',
String(7 * 24 * 60 * 60),
@@ -1263,7 +1290,12 @@ describe('auction durability projection helpers', () => {
const broadcastMatchSideEffect = jest.fn();
const scheduler = new AuctionDurabilityScheduler(
{
createSession: jest.fn().mockResolvedValue(null),
createSession: jest.fn().mockResolvedValueOnce(null).mockResolvedValue({
startTransaction: jest.fn(),
commitTransaction: jest.fn(),
abortTransaction: jest.fn(),
endSession: jest.fn(),
}),
getModel: jest.fn((name: string) => {
if (name === 'auctionHistory') {
return {
@@ -1282,7 +1314,11 @@ describe('auction durability projection helpers', () => {
return { updateOne: sideEffectUpdateOne };
}
if (name === 'match')
return { findById: jest.fn().mockReturnValue(match) };
return {
findById: jest.fn().mockReturnValue({
session: jest.fn().mockResolvedValue(match),
}),
};
return {};
}),
} as never,
@@ -1301,8 +1337,8 @@ describe('auction durability projection helpers', () => {
await scheduler.applyDurabilityPayload(resetPayload);
expect(releaseFromMatch).toHaveBeenCalledWith(match);
expect(cancelPolling).toHaveBeenCalledWith(match);
expect(releaseFromMatch).toHaveBeenCalledWith(match, expect.any(Object));
expect(cancelPolling).toHaveBeenCalledWith(match, expect.any(Object));
expect(match).toMatchObject({
gameSchedule: [],
result: undefined,
@@ -1328,12 +1364,14 @@ describe('auction durability projection helpers', () => {
);
expect(mirrorMatchSideEffectStatus).toHaveBeenLastCalledWith({
auctionLifecycleId: 'life-1',
auctionStateTransitionId: 'transition-1',
matchId: 'match-1',
matchSideEffectRevision: 3,
matchSideEffectStatus: 'completed',
});
expect(broadcastMatchSideEffect).toHaveBeenLastCalledWith('match-1', {
auctionLifecycleId: 'life-1',
auctionStateTransitionId: 'transition-1',
currentServerTimestampMS: 3000,
matchSideEffectRevision: 3,
matchSideEffectStatus: 'completed',
@@ -4,6 +4,7 @@ import {
OnModuleDestroy,
OnModuleInit,
Optional,
ConflictException,
} from '@nestjs/common';
import { createHash, randomUUID } from 'crypto';
import type mongoose from 'mongoose';
@@ -16,6 +17,10 @@ import type {
import { TournamentCodeService } from '../tournament-code/tournament-code.service';
import { TournamentResultService } from '../tournament-result/tournament-result.service';
import { AuctionEventBusService } from './auction-event-bus.service';
import { AuctionService } from './auction.service';
import { AuctionBidArchiveService } from './auction-bid-archive.service';
import { AuctionLifecycleLock } from './auction-lifecycle-lock';
import { buildAuctionProjectionUnset } from './auction-projection';
import {
AuctionSideEffectService,
buildMatchSideEffectDelta,
@@ -26,6 +31,7 @@ import { AuctionRedisService } from './redis/auction-redis.service';
import { AuctionRedisStateReaderService } from './redis/auction-redis-state-reader.service';
import {
AUCTION_DURABILITY_DEAD_LETTER_QUEUE_KEY,
AUCTION_DEAD_LETTER_STATUS_QUEUE_KEY,
AUCTION_DURABILITY_RETRY_QUEUE_KEY,
buildAuctionRedisKeys,
} from './redis/auction-redis.keys';
@@ -36,6 +42,8 @@ const AUCTION_DURABILITY_BATCH_LIMIT = 20;
const AUCTION_DURABILITY_RETRY_DELAY_MS = 5000;
const AUCTION_DURABILITY_MAX_RETRY_DELAY_MS = 60_000;
const AUCTION_DURABILITY_MAX_ATTEMPTS = 10;
const AUCTION_DURABILITY_MAX_PENDING_ATTEMPTS = 120;
const AUCTION_DURABILITY_MAX_PENDING_DURATION_MS = 10 * 60 * 1000;
const AUCTION_DURABILITY_ERROR_MESSAGE_MAX_LENGTH = 2000;
const AUCTION_DURABILITY_LEADER_LOCK_KEY =
'auction:auctionDurabilityScheduler:leader';
@@ -45,6 +53,7 @@ const AUCTION_SIDE_EFFECT_LEASE_DURATION_MS = 30_000;
const SYNC_MATCH_TEAMS_SIDE_EFFECT_TYPE = 'syncMatchTeamsAfterComplete';
const RESET_MATCH_SIDE_EFFECT_TYPE = 'resetMatchAfterAuctionReset';
const UNDO_COMPLETED_MATCH_SIDE_EFFECT_TYPE = 'undoCompletedAuctionSideEffects';
class SideEffectPendingError extends Error {}
export interface AuctionDurabilityPayload {
actorUserId?: unknown;
@@ -67,6 +76,7 @@ export interface AuctionDurabilityPayload {
export interface AuctionProjectionIdentity {
auctionLifecycleId?: string;
revision?: number;
matchSideEffectTransitionId?: string;
}
type ParsedAuctionHistoryMutation =
@@ -85,7 +95,7 @@ interface CleanupSideEffectMatchDocument {
participants: Array<{ excluded?: boolean }>;
result?: unknown;
resultPollState?: unknown;
save(): Promise<unknown>;
save(options?: { session: mongoose.ClientSession }): Promise<unknown>;
status: string;
teamBuiltAt?: Date;
teams?: unknown[];
@@ -99,6 +109,7 @@ export class AuctionDurabilityScheduler
private readonly logger = new Logger(AuctionDurabilityScheduler.name);
private tickTimer?: NodeJS.Timeout;
private tickInProgress = false;
private deadLetterScanCursor = '0';
constructor(
private readonly connectionService: ConnectionService,
@@ -113,6 +124,9 @@ export class AuctionDurabilityScheduler
private readonly auctionEventBusService?: AuctionEventBusService,
@Optional()
private readonly auctionRedisStateReaderService?: AuctionRedisStateReaderService,
@Optional() private readonly auctionService?: AuctionService,
@Optional()
private readonly auctionBidArchiveService?: AuctionBidArchiveService,
) {}
public onModuleInit(): void {
@@ -187,6 +201,23 @@ export class AuctionDurabilityScheduler
});
await this.clearDurabilityPayload(payloadKey);
} catch (error) {
if (
error instanceof SideEffectPendingError ||
error instanceof ConflictException
) {
const disposition = await this.deferDurabilityPayload(
payloadKey,
currentRedisTimestampMS,
error,
);
if (disposition === 'dead-lettered') {
failed += 1;
this.logger.warn(
`Auction durability payload exceeded its pending limit: ${payloadKey}`,
);
} else skipped += 1;
continue;
}
failed += 1;
const failureDisposition = await this.recordDurabilityPayloadFailure(
payloadKey,
@@ -214,6 +245,14 @@ export class AuctionDurabilityScheduler
const payloadJson = hash.payloadJson;
if (!payloadJson) return null;
const payload = JSON.parse(payloadJson) as AuctionDurabilityPayload;
const committedDeadline = Number(hash.committedBidRoundDeadlineTimestampMS);
if (Number.isFinite(committedDeadline) && committedDeadline > 0) {
payload.afterAuctionMongoProjection.currentBidRoundDeadlineTimestampMS =
committedDeadline;
payload.afterAuctionMongoProjection.currentDeadline = new Date(
committedDeadline,
).toISOString();
}
const committedAtRedisTimestampMS = Number(
hash.committedAtRedisTimestampMS,
);
@@ -240,12 +279,12 @@ export class AuctionDurabilityScheduler
const sideEffectMutation = parseMatchSideEffectMutation(
payload.matchSideEffectMutation,
);
let shouldUpdateProjection = true;
let shouldApplySideEffects = true;
let shouldApplyHistoryMutation = true;
try {
session?.startTransaction();
const historyMutation = parseAuctionHistoryMutation(
payload.historyMutation,
);
if (typeof AuctionModel.findById === 'function') {
const currentProjection =
await readAuctionProjectionIdentityForMutation(
@@ -256,37 +295,44 @@ export class AuctionDurabilityScheduler
if (
!shouldProcessAuctionDurabilityPayload(currentProjection, payload)
) {
// 뒤 payload가 먼저 projection revision을 올리면 앞 append payload가 stale이 된다.
// 이때 projection/side effect는 건드리지 않고 undo용 history만 멱등 복구한다.
if (
historyMutation.type === 'append' &&
currentProjection.auctionLifecycleId === payload.auctionLifecycleId
currentProjection.auctionLifecycleId !== payload.auctionLifecycleId
) {
await this.applyStaleAppendHistoryRecovery({
if (session) await session.commitTransaction();
return;
}
shouldApplyHistoryMutation =
!(await this.isAppendHistoryInvalidatedByLaterDestructiveMutation({
AuctionHistoryModel,
payload,
session,
});
}
if (session) await session.commitTransaction();
return;
}));
// History operations have their own sequence bounds. A newer ordinary
// projection must not discard an earlier undo's history cleanup.
shouldUpdateProjection = false;
shouldApplySideEffects =
Boolean(this.auctionRedisStateReaderService) ||
currentProjection.matchSideEffectTransitionId ===
payload.auctionStateTransitionId;
}
}
await this.applyAuctionHistoryMutation({
AuctionHistoryModel,
AuctionModel,
payload,
session,
});
if (shouldApplyHistoryMutation)
await this.applyAuctionHistoryMutation({
AuctionHistoryModel,
AuctionModel,
payload,
session,
});
const projectionOperation = buildAuctionProjectionGuardedUpdate(payload);
await execMaybe(
AuctionModel.updateOne(
projectionOperation.filter as never,
projectionOperation.update as never,
{ session } as never,
),
);
if (sideEffectMutation) {
if (shouldUpdateProjection)
await execMaybe(
AuctionModel.updateOne(
projectionOperation.filter as never,
projectionOperation.update as never,
{ session } as never,
),
);
if (sideEffectMutation && shouldApplySideEffects) {
const sideEffectOperation = buildSideEffectApplicationUpsert(
payload,
sideEffectMutation,
@@ -312,7 +358,7 @@ export class AuctionDurabilityScheduler
await this.broadcastLatestRedisAuctionStateIfRequested(payload);
if (sideEffectMutation) {
if (sideEffectMutation && shouldApplySideEffects) {
await this.applyMatchSideEffect(payload, sideEffectMutation);
}
}
@@ -352,6 +398,64 @@ export class AuctionDurabilityScheduler
private async applyMatchSideEffect(
payload: AuctionDurabilityPayload,
mutation: ParsedMatchSideEffectMutation,
): Promise<void> {
return new AuctionLifecycleLock(this.auctionRedisService).run(
String(payload.matchId),
async () => {
if (this.auctionRedisStateReaderService) {
const state =
await this.auctionRedisStateReaderService.readAuctionStateView(
String(payload.matchId),
);
if (!state)
throw new SideEffectPendingError(
'Auction realtime state is unavailable.',
);
if (
state.auctionLifecycleId !== payload.auctionLifecycleId ||
(state.matchSideEffectTransitionId &&
state.matchSideEffectTransitionId !==
payload.auctionStateTransitionId) ||
(mutation.type === SYNC_MATCH_TEAMS_SIDE_EFFECT_TYPE &&
state.phase !== 'complete')
)
return;
// An ordinary later projection may have reached Mongo before this
// side-effect-bearing transition. Install its pending generation only
// while Redis still names it and Mongo has not advanced beyond it.
const AuctionModel = await this.connectionService.getModel('auction');
const pendingRevision = Number(
payload.afterAuctionMongoProjection.matchSideEffectRevision ?? 0,
);
await execMaybe(
AuctionModel.updateOne(
{
_id: payload.auctionId,
auctionLifecycleId: payload.auctionLifecycleId,
$or: [
{ matchSideEffectRevision: { $lt: pendingRevision } },
{ matchSideEffectRevision: { $exists: false } },
],
} as never,
{
$set: {
matchSideEffectTransitionId: payload.auctionStateTransitionId,
matchSideEffectRevision: pendingRevision,
matchSideEffectStatus: 'pending',
},
$unset: { matchSideEffectError: '' },
} as never,
),
);
}
await this.applyMatchSideEffectWhileLocked(payload, mutation);
},
);
}
private async applyMatchSideEffectWhileLocked(
payload: AuctionDurabilityPayload,
mutation: ParsedMatchSideEffectMutation,
): Promise<void> {
if (mutation.type === SYNC_MATCH_TEAMS_SIDE_EFFECT_TYPE) {
await this.applySyncMatchTeamsSideEffect(payload, mutation);
@@ -407,7 +511,26 @@ export class AuctionDurabilityScheduler
}) as never,
),
);
if (!hasMatchedDocument(leaseResult)) return;
if (!hasMatchedDocument(leaseResult)) {
const existing = await AuctionSideEffectApplicationModel.findOne(
identity as never,
)
.lean()
.exec();
if (existing?.state === 'completed') {
await this.persistAndBroadcastMatchSideEffectStatus({
AuctionModel,
currentServerTimestampMS: currentRedisTimestampMS,
payload,
status: 'completed',
});
await this.expireCompletedAuctionRedisRuntime(payload);
return;
}
throw new SideEffectPendingError(
'Auction side effect is still owned by another worker.',
);
}
const processingDelta = await this.persistAndBroadcastMatchSideEffectStatus(
{
@@ -420,7 +543,11 @@ export class AuctionDurabilityScheduler
status: 'processing',
},
);
if (!processingDelta) return;
if (!processingDelta) {
throw new SideEffectPendingError(
'Auction side-effect generation is not ready.',
);
}
const expectedMatchSideEffectRevision =
processingDelta.matchSideEffectRevision;
@@ -489,7 +616,11 @@ export class AuctionDurabilityScheduler
await this.auctionRedisService.getCurrentRedisTimestampMS();
await execMaybe(
AuctionSideEffectApplicationModel.updateOne(
identity as never,
{
...identity,
processingOwnerToken: ownerToken,
state: 'processing',
} as never,
{
$set: {
completedAtTimestampMS,
@@ -518,7 +649,11 @@ export class AuctionDurabilityScheduler
await this.auctionRedisService.getCurrentRedisTimestampMS();
await execMaybe(
AuctionSideEffectApplicationModel.updateOne(
identity as never,
{
...identity,
processingOwnerToken: ownerToken,
state: 'processing',
} as never,
{
$set: {
lastError: error instanceof Error ? error.message : String(error),
@@ -544,33 +679,6 @@ export class AuctionDurabilityScheduler
}
}
private async applyStaleAppendHistoryRecovery(params: {
AuctionHistoryModel: {
findOne?: (...args: never[]) => unknown;
updateOne: (...args: never[]) => unknown;
};
payload: AuctionDurabilityPayload;
session: mongoose.ClientSession | null | undefined;
}): Promise<void> {
const invalidated =
await this.isAppendHistoryInvalidatedByLaterDestructiveMutation(params);
if (invalidated) return;
const historyOperation = buildAuctionHistoryUpsert(
params.payload,
).updateOne;
await execMaybe(
params.AuctionHistoryModel.updateOne(
historyOperation.filter as never,
historyOperation.update as never,
{
session: params.session,
upsert: true,
} as never,
) as Promise<unknown> | { exec(): Promise<unknown> },
);
}
private async isAppendHistoryInvalidatedByLaterDestructiveMutation(params: {
AuctionHistoryModel: {
findOne?: (...args: never[]) => unknown;
@@ -622,9 +730,7 @@ export class AuctionDurabilityScheduler
await this.applyMatchCleanupSideEffect({
mutation,
payload,
updateMatch: async (match) => {
await this.tournamentCodeService?.releaseFromMatch(match as never);
await this.tournamentResultService?.cancelPolling(match as never);
updateMatch: (match) => {
match.status = 'recruiting';
match.teams = [];
match.tournamentCodeIds = [];
@@ -635,7 +741,6 @@ export class AuctionDurabilityScheduler
match.teamBuiltAt = undefined;
match.result = undefined;
match.resultPollState = undefined;
await match.save();
},
});
}
@@ -647,13 +752,14 @@ export class AuctionDurabilityScheduler
await this.applyMatchCleanupSideEffect({
mutation,
payload,
updateMatch: async (match) => {
await this.tournamentCodeService?.releaseFromMatch(match as never);
await this.tournamentResultService?.cancelPolling(match as never);
updateMatch: (match) => {
match.status = 'team-built';
match.teams = [];
match.teamBuiltAt = undefined;
match.tournamentCodeIds = [];
match.gameSchedule = [];
match.result = undefined;
match.resultPollState = undefined;
await match.save();
},
});
}
@@ -661,7 +767,7 @@ export class AuctionDurabilityScheduler
private async applyMatchCleanupSideEffect(params: {
mutation: ParsedMatchSideEffectMutation;
payload: AuctionDurabilityPayload;
updateMatch: (match: CleanupSideEffectMatchDocument) => Promise<void>;
updateMatch: (match: CleanupSideEffectMatchDocument) => void;
}): Promise<void> {
if (!this.tournamentCodeService || !this.tournamentResultService) {
throw new Error('Auction side-effect services are not available.');
@@ -700,7 +806,25 @@ export class AuctionDurabilityScheduler
}) as never,
),
);
if (!hasMatchedDocument(leaseResult)) return;
if (!hasMatchedDocument(leaseResult)) {
const existing = await AuctionSideEffectApplicationModel.findOne(
identity as never,
)
.lean()
.exec();
if (existing?.state === 'completed') {
await this.persistAndBroadcastMatchSideEffectStatus({
AuctionModel,
currentServerTimestampMS: currentRedisTimestampMS,
payload: params.payload,
status: 'completed',
});
return;
}
throw new SideEffectPendingError(
'Auction side effect is still owned by another worker.',
);
}
const processingDelta = await this.persistAndBroadcastMatchSideEffectStatus(
{
@@ -714,29 +838,56 @@ export class AuctionDurabilityScheduler
status: 'processing',
},
);
if (!processingDelta) return;
if (!processingDelta) {
throw new SideEffectPendingError(
'Auction side-effect generation is not ready.',
);
}
const expectedMatchSideEffectRevision =
processingDelta.matchSideEffectRevision;
try {
const match = (await execMaybe(
MatchModel.findById(params.payload.matchId) as never,
)) as CleanupSideEffectMatchDocument | null;
if (!match) {
throw new Error(`Match not found: ${String(params.payload.matchId)}`);
}
if (match.competitionId) {
throw new Error(
'Cannot reset or undo Match teams after the immutable Competition has been created.',
const session = await this.connectionService.createSession();
if (!session)
throw new Error('Failed to start Match cleanup transaction.');
try {
session.startTransaction();
const match = (await MatchModel.findById(
params.payload.matchId,
).session(session)) as CleanupSideEffectMatchDocument | null;
if (!match)
throw new Error(`Match not found: ${String(params.payload.matchId)}`);
if (match.competitionId)
throw new Error(
'Cannot reset or undo Match teams after the immutable Competition has been created.',
);
await this.tournamentCodeService.releaseFromMatch(
match as never,
session,
);
await this.tournamentResultService.cancelPolling(
match as never,
session,
);
params.updateMatch(match);
await match.save({ session });
await session.commitTransaction();
} catch (error) {
await session.abortTransaction();
throw error;
} finally {
await session.endSession();
}
await params.updateMatch(match);
const completedAtTimestampMS =
await this.auctionRedisService.getCurrentRedisTimestampMS();
await execMaybe(
AuctionSideEffectApplicationModel.updateOne(
identity as never,
{
...identity,
processingOwnerToken: ownerToken,
state: 'processing',
} as never,
{
$set: {
completedAtTimestampMS,
@@ -766,7 +917,11 @@ export class AuctionDurabilityScheduler
error instanceof Error ? error.message : String(error);
await execMaybe(
AuctionSideEffectApplicationModel.updateOne(
identity as never,
{
...identity,
processingOwnerToken: ownerToken,
state: 'processing',
} as never,
{
$set: {
lastError: errorMessage,
@@ -828,7 +983,10 @@ export class AuctionDurabilityScheduler
params.AuctionHistoryModel.deleteMany(
{
auctionId: params.payload.auctionId,
sequence: { $gt: mutation.targetHistorySequence },
sequence: {
$gt: mutation.targetHistorySequence,
$lt: params.payload.auctionHistorySequence,
},
} as never,
{ session: params.session } as never,
) as Promise<unknown> | { exec(): Promise<unknown> },
@@ -842,6 +1000,7 @@ export class AuctionDurabilityScheduler
params.AuctionHistoryModel.deleteMany(
{
auctionId: params.payload.auctionId,
sequence: { $lt: params.payload.auctionHistorySequence },
} as never,
{ session: params.session } as never,
) as Promise<unknown> | { exec(): Promise<unknown> },
@@ -874,16 +1033,43 @@ export class AuctionDurabilityScheduler
};
currentServerTimestampMS: number;
errorMessage?: string;
expectedMatchSideEffectRevision: number;
expectedMatchSideEffectRevision?: number;
payload: AuctionDurabilityPayload;
status: AuctionMatchSideEffectStatus;
onlyUnfinished?: boolean;
}): Promise<MatchSideEffectDelta | null> {
const updatedAuction = (await execMaybe(
params.AuctionModel.findOneAndUpdate(
{
_id: params.payload.auctionId,
auctionLifecycleId: params.payload.auctionLifecycleId,
matchSideEffectRevision: params.expectedMatchSideEffectRevision,
...(params.onlyUnfinished
? { matchSideEffectStatus: { $ne: 'completed' } }
: {}),
...(params.status === 'processing'
? {
$or: [
{
matchSideEffectTransitionId:
params.payload.auctionStateTransitionId,
},
{
matchSideEffectTransitionId: { $exists: false },
matchSideEffectRevision:
params.expectedMatchSideEffectRevision,
},
],
}
: {
matchSideEffectTransitionId:
params.payload.auctionStateTransitionId,
...(params.expectedMatchSideEffectRevision === undefined
? {}
: {
matchSideEffectRevision:
params.expectedMatchSideEffectRevision,
}),
}),
} as never,
{
$inc: { matchSideEffectRevision: 1 },
@@ -892,6 +1078,8 @@ export class AuctionDurabilityScheduler
? { matchSideEffectError: params.errorMessage }
: {}),
matchSideEffectStatus: params.status,
matchSideEffectTransitionId:
params.payload.auctionStateTransitionId,
},
...(params.errorMessage
? {}
@@ -915,6 +1103,7 @@ export class AuctionDurabilityScheduler
const delta = buildMatchSideEffectDelta({
auctionLifecycleId: updatedAuction.auctionLifecycleId,
auctionStateTransitionId: params.payload.auctionStateTransitionId,
currentServerTimestampMS: params.currentServerTimestampMS,
matchSideEffectRevision: Number(
updatedAuction.matchSideEffectRevision ?? 0,
@@ -923,19 +1112,170 @@ export class AuctionDurabilityScheduler
updatedAuction.matchSideEffectStatus ?? params.status,
});
await this.auctionSideEffectService?.mirrorMatchSideEffectStatus({
auctionLifecycleId: delta.auctionLifecycleId,
matchId: String(params.payload.matchId),
matchSideEffectRevision: delta.matchSideEffectRevision,
matchSideEffectStatus: delta.matchSideEffectStatus,
});
this.auctionEventBusService?.broadcastMatchSideEffect(
String(params.payload.matchId),
delta,
);
const mirrored =
await this.auctionSideEffectService?.mirrorMatchSideEffectStatus({
auctionLifecycleId: delta.auctionLifecycleId,
auctionStateTransitionId: params.payload.auctionStateTransitionId,
matchId: String(params.payload.matchId),
matchSideEffectRevision: delta.matchSideEffectRevision,
matchSideEffectStatus: delta.matchSideEffectStatus,
});
if (mirrored !== false) {
this.auctionEventBusService?.broadcastMatchSideEffect(
String(params.payload.matchId),
delta,
);
}
return delta;
}
public async reconcileDeadLetterStatuses(limit = 20): Promise<void> {
const client = this.auctionRedisService.raw();
const now = await this.auctionRedisService.getCurrentRedisTimestampMS();
// Also reconcile entries dead-lettered before status notifications existed.
const scanned = await client.sendCommand([
'ZSCAN',
AUCTION_DURABILITY_DEAD_LETTER_QUEUE_KEY,
this.deadLetterScanCursor,
'COUNT',
String(limit),
]);
if (Array.isArray(scanned) && Array.isArray(scanned[1])) {
this.deadLetterScanCursor = String(scanned[0]);
for (let index = 0; index < scanned[1].length; index += 2) {
const key = String(scanned[1][index]);
if (
!(await client.sendCommand([
'HGET',
key,
'deadLetterStatusReconciledAtTimestampMS',
]))
) {
await client.sendCommand([
'ZADD',
AUCTION_DEAD_LETTER_STATUS_QUEUE_KEY,
'NX',
String(now),
key,
]);
}
}
}
const reply = await client.sendCommand([
'ZRANGEBYSCORE',
AUCTION_DEAD_LETTER_STATUS_QUEUE_KEY,
'-inf',
String(now),
'LIMIT',
'0',
String(limit),
]);
if (!Array.isArray(reply)) return;
for (const key of reply.map(String)) {
try {
const payload = await this.readDurabilityPayload(key);
if (
payload &&
parseMatchSideEffectMutation(payload.matchSideEffectMutation)
) {
const state =
await this.auctionRedisStateReaderService?.readAuctionStateView(
String(payload.matchId),
);
// A terminal notification for a previous generation must not change
// a new completion/undo, even when Mongo is behind Redis.
const superseded =
state &&
(state.auctionLifecycleId !== payload.auctionLifecycleId ||
state.matchSideEffectStatus === 'completed' ||
(state.matchSideEffectTransitionId &&
state.matchSideEffectTransitionId !==
payload.auctionStateTransitionId));
if (!superseded) {
const AuctionModel =
await this.connectionService.getModel('auction');
if (
state?.matchSideEffectTransitionId ===
payload.auctionStateTransitionId
) {
const revision = Number(
payload.afterAuctionMongoProjection.matchSideEffectRevision ??
0,
);
await AuctionModel.updateOne(
{
_id: payload.auctionId,
auctionLifecycleId: payload.auctionLifecycleId,
$or: [
{ matchSideEffectRevision: { $lt: revision } },
{ matchSideEffectRevision: { $exists: false } },
],
} as never,
{
$set: {
matchSideEffectTransitionId:
payload.auctionStateTransitionId,
matchSideEffectRevision: revision,
matchSideEffectStatus: 'pending',
},
},
);
// Heal a same-generation revision mismatch before sending the
// terminal status; otherwise Redis could ignore it as older.
await AuctionModel.updateOne(
{
_id: payload.auctionId,
auctionLifecycleId: payload.auctionLifecycleId,
matchSideEffectTransitionId: payload.auctionStateTransitionId,
matchSideEffectStatus: { $ne: 'completed' },
} as never,
{
$max: {
matchSideEffectRevision: Number(
state.matchSideEffectRevision ?? revision,
),
},
},
);
}
const error = await client.sendCommand(['HGET', key, 'lastError']);
await this.persistAndBroadcastMatchSideEffectStatus({
AuctionModel: AuctionModel as never,
payload,
currentServerTimestampMS: now,
status: 'failed',
onlyUnfinished: true,
errorMessage:
typeof error === 'string'
? error
: 'Auction side effect exhausted its retry limit.',
});
}
}
await client.sendCommand([
'EVAL',
"if redis.call('HEXISTS', KEYS[1], 'payloadJson') == 1 then redis.call('HSET', KEYS[1], 'deadLetterStatusReconciledAtTimestampMS', ARGV[1]) end redis.call('ZREM', KEYS[2], KEYS[1]); return 1",
'2',
key,
AUCTION_DEAD_LETTER_STATUS_QUEUE_KEY,
String(now),
]);
} catch (error) {
// Mongo or Redis mirroring may be unavailable at dead-letter time. Keep
// the notification durable until the failure can be shown to viewers.
await client.sendCommand([
'ZADD',
AUCTION_DEAD_LETTER_STATUS_QUEUE_KEY,
String(now + 5000),
key,
]);
this.logger.warn(
`Auction terminal status will retry for ${key}: ${String(error)}`,
);
}
}
}
private async safeTick(): Promise<void> {
if (this.tickInProgress) return;
this.tickInProgress = true;
@@ -948,7 +1288,22 @@ export class AuctionDurabilityScheduler
AUCTION_DURABILITY_LEADER_LOCK_TTL_MS,
);
if (!leaderLockAcquired) return;
await this.processDueDurabilityPayloads(AUCTION_DURABILITY_BATCH_LIMIT);
// A failed maintenance task must not starve the other durable queues.
for (const work of [
() => this.processDueDurabilityPayloads(AUCTION_DURABILITY_BATCH_LIMIT),
() => this.reconcileDeadLetterStatuses(AUCTION_DURABILITY_BATCH_LIMIT),
() => this.auctionBidArchiveService?.persistPendingBids(),
() =>
this.auctionService?.retryPendingCancellations(
AUCTION_DURABILITY_BATCH_LIMIT,
),
]) {
try {
await work();
} catch (error) {
this.logger.warn(`Auction maintenance task failed: ${String(error)}`);
}
}
} catch (error) {
this.logger.warn(
`Auction durability tick failed: ${
@@ -957,10 +1312,13 @@ export class AuctionDurabilityScheduler
);
} finally {
if (leaderLockAcquired) {
await this.auctionRedisService.releaseTokenLock(
AUCTION_DURABILITY_LEADER_LOCK_KEY,
leaderLockToken,
);
await this.auctionRedisService
.releaseTokenLock(AUCTION_DURABILITY_LEADER_LOCK_KEY, leaderLockToken)
.catch((error: unknown) => {
this.logger.warn(
`Auction durability lock release failed: ${String(error)}`,
);
});
}
this.tickInProgress = false;
}
@@ -987,6 +1345,51 @@ export class AuctionDurabilityScheduler
]);
}
private async deferDurabilityPayload(
payloadKey: string,
timestampMS: number,
error: unknown,
): Promise<'gone' | 'requeued' | 'dead-lettered'> {
// Keep coordination waits separate from failed work, but bound them across
// restarts too. Updating the payload and queue atomically avoids orphan jobs.
const result = await this.auctionRedisService
.raw()
.sendCommand([
'EVAL',
[
"if redis.call('HEXISTS', KEYS[1], 'payloadJson') == 0 then return 0 end",
"local count = redis.call('HINCRBY', KEYS[1], 'pendingAttempts', 1)",
"redis.call('HSETNX', KEYS[1], 'pendingSinceTimestampMS', ARGV[1])",
"local since = tonumber(redis.call('HGET', KEYS[1], 'pendingSinceTimestampMS'))",
"redis.call('HSET', KEYS[1], 'lastPendingReason', ARGV[5], 'lastPendingAtTimestampMS', ARGV[1])",
'if count >= tonumber(ARGV[3]) or tonumber(ARGV[1]) - since >= tonumber(ARGV[4]) then',
" redis.call('ZREM', KEYS[2], KEYS[1])",
" redis.call('HSET', KEYS[1], 'deadLetteredAtRedisTimestampMS', ARGV[1], 'lastError', ARGV[5])",
" redis.call('ZADD', KEYS[3], ARGV[1], KEYS[1])",
" redis.call('ZADD', KEYS[4], ARGV[1], KEYS[1])",
' return 2',
'end',
"redis.call('ZADD', KEYS[2], tonumber(ARGV[1]) + tonumber(ARGV[2]), KEYS[1])",
'return 1',
].join('\n'),
'4',
payloadKey,
AUCTION_DURABILITY_RETRY_QUEUE_KEY,
AUCTION_DURABILITY_DEAD_LETTER_QUEUE_KEY,
AUCTION_DEAD_LETTER_STATUS_QUEUE_KEY,
String(timestampMS),
String(AUCTION_DURABILITY_RETRY_DELAY_MS),
String(AUCTION_DURABILITY_MAX_PENDING_ATTEMPTS),
String(AUCTION_DURABILITY_MAX_PENDING_DURATION_MS),
formatErrorMessageForRedis(error),
]);
return Number(result) === 2
? 'dead-lettered'
: Number(result) === 1
? 'requeued'
: 'gone';
}
private async recordDurabilityPayloadFailure(
payloadKey: string,
currentRedisTimestampMS: number,
@@ -1012,24 +1415,17 @@ export class AuctionDurabilityScheduler
Number.isFinite(attempts) &&
attempts >= AUCTION_DURABILITY_MAX_ATTEMPTS
) {
await this.auctionRedisService
.raw()
.sendCommand(['ZREM', AUCTION_DURABILITY_RETRY_QUEUE_KEY, payloadKey]);
await this.auctionRedisService
.raw()
.sendCommand([
'HSET',
'EVAL',
"if redis.call('HEXISTS', KEYS[1], 'payloadJson') == 0 then return 0 end redis.call('HSET', KEYS[1], 'deadLetteredAtRedisTimestampMS', ARGV[1]); redis.call('ZREM', KEYS[2], KEYS[1]); redis.call('ZADD', KEYS[3], ARGV[1], KEYS[1]); redis.call('ZADD', KEYS[4], ARGV[1], KEYS[1]); return 1",
'4',
payloadKey,
'deadLetteredAtRedisTimestampMS',
String(currentRedisTimestampMS),
]);
await this.auctionRedisService
.raw()
.sendCommand([
'ZADD',
AUCTION_DURABILITY_RETRY_QUEUE_KEY,
AUCTION_DURABILITY_DEAD_LETTER_QUEUE_KEY,
AUCTION_DEAD_LETTER_STATUS_QUEUE_KEY,
String(currentRedisTimestampMS),
payloadKey,
]);
return 'dead-lettered';
}
@@ -1064,7 +1460,7 @@ export class AuctionDurabilityScheduler
'end',
'return 1',
].join('\n'),
'11',
'12',
keys.liveStateKey,
keys.deadlineQueueKey,
keys.structureStateKey,
@@ -1076,6 +1472,7 @@ export class AuctionDurabilityScheduler
keys.actionRequestResultOrderKey,
keys.rehydrateLockKey,
keys.stateTransitionLockKey,
keys.rejectedBidRequestResultOrderKey,
matchId,
payload.auctionLifecycleId,
String(AUCTION_REDIS_COMPLETED_RETAIN_SECONDS),
@@ -1159,6 +1556,7 @@ async function readAuctionProjectionIdentityForMutation(
? (query as { select: (...args: never[]) => unknown }).select({
auctionLifecycleId: 1,
revision: 1,
matchSideEffectTransitionId: 1,
} as never)
: query;
const scoped =
@@ -1178,6 +1576,10 @@ async function readAuctionProjectionIdentityForMutation(
if (!projection || typeof projection !== 'object') return {};
const record = projection as Record<string, unknown>;
return {
matchSideEffectTransitionId:
typeof record.matchSideEffectTransitionId === 'string'
? record.matchSideEffectTransitionId
: undefined,
auctionLifecycleId:
typeof record.auctionLifecycleId === 'string'
? record.auctionLifecycleId
@@ -1200,6 +1602,7 @@ export function buildAuctionProjectionGuardedUpdate(
},
update: {
$set: payload.afterAuctionMongoProjection,
$unset: buildAuctionProjectionUnset(payload.afterAuctionMongoProjection),
},
};
}
@@ -20,9 +20,14 @@ export class AuctionEventBusService {
}
public broadcastState(matchId: string, state: AuctionStateResponse): void {
this.auctionNamespace?.to(matchId).emit(
'state',
serializeRealtimeAuction(state),
);
this.auctionNamespace
?.to(matchId)
.emit('state', serializeRealtimeAuction(state));
}
public broadcastReset(matchId: string, auctionLifecycleId: string): void {
this.auctionNamespace
?.to(matchId)
.emit('reset', { matchId, auctionLifecycleId });
}
}
@@ -0,0 +1,32 @@
import { AuctionLifecycleLock } from './auction-lifecycle-lock';
afterEach(() => jest.useRealTimers());
it('renews ownership and handles renewal/release failures without unhandled rejection', async () => {
jest.useFakeTimers();
const sendCommand = jest
.fn()
.mockRejectedValue(new Error('redis disconnected'));
const releaseTokenLock = jest
.fn()
.mockRejectedValue(new Error('release failed'));
const lock = new AuctionLifecycleLock({
acquireTokenLock: jest.fn().mockResolvedValue(true),
releaseTokenLock,
raw: () => ({ sendCommand }),
} as never);
const result = lock.run('match', async () => {
await jest.advanceTimersByTimeAsync(10000);
});
await expect(result).rejects.toThrow('redis disconnected');
expect(releaseTokenLock).toHaveBeenCalledTimes(1);
expect(jest.getTimerCount()).toBe(0);
});
it('preserves an operation result if only lock release fails', async () => {
const lock = new AuctionLifecycleLock({
acquireTokenLock: jest.fn().mockResolvedValue(true),
releaseTokenLock: jest.fn().mockRejectedValue(new Error('release failed')),
} as never);
await expect(lock.run('match', async () => 42)).resolves.toBe(42);
});
@@ -0,0 +1,72 @@
import { ConflictException, Logger } from '@nestjs/common';
import { randomUUID } from 'crypto';
import { AuctionRedisService } from './redis/auction-redis.service';
export class AuctionLifecycleBusyError extends ConflictException {
constructor() {
super({
code: 'AUCTION_LIFECYCLE_BUSY',
message: '다른 경매 작업을 처리 중입니다. 잠시 후 다시 시도해 주세요.',
});
}
}
/** Serializes startup, cancellation, undo and Match side effects across nodes. */
export class AuctionLifecycleLock {
private readonly logger = new Logger(AuctionLifecycleLock.name);
constructor(private readonly redis: AuctionRedisService) {}
async run<T>(matchId: string, operation: () => Promise<T>): Promise<T> {
// Kept outside runtime cleanup: cancelling an auction must not release a
// lock still held by its cancellation/recovery operation.
const key = `auction:${matchId}:lifecycleMutationLock`;
const token = randomUUID();
if (!(await this.redis.acquireTokenLock(key, token, 30_000))) {
throw new AuctionLifecycleBusyError();
}
let renewal: Promise<void> | undefined;
let ownershipError: Error | undefined;
const timer = setInterval(() => {
if (renewal) return;
renewal = this.redis
.raw()
.sendCommand<string | null>([
'SET',
key,
token,
'IFEQ',
token,
'PX',
'30000',
])
.then((result) => {
if (result !== 'OK')
throw new Error('Auction lifecycle lock ownership was lost.');
})
.catch((error: unknown) => {
ownershipError =
error instanceof Error ? error : new Error(String(error));
})
.finally(() => {
renewal = undefined;
});
}, 10_000);
timer.unref?.();
try {
const result = await operation();
clearInterval(timer);
await renewal;
if (ownershipError) throw ownershipError;
return result;
} finally {
clearInterval(timer);
await renewal;
await this.redis.releaseTokenLock(key, token).catch((error: unknown) => {
this.logger.warn(
`Auction lifecycle lock release failed: ${String(error)}`,
);
});
}
}
}
@@ -0,0 +1,20 @@
/** Missing optional fields in a complete projection mean deletion, not retention. */
export const AUCTION_OPTIONAL_PROJECTION_FIELDS = [
'completedAt',
'auctionCompletedAtTimestampMS',
'currentBidderTeamIndex',
'currentHighestBidderTeamIndex',
'currentDeadline',
'currentBidRoundDeadlineTimestampMS',
'currentBidRoundId',
] as const;
export function buildAuctionProjectionUnset(
projection: Record<string, unknown>,
) {
return Object.fromEntries(
AUCTION_OPTIONAL_PROJECTION_FIELDS.filter(
(field) => projection[field] === undefined,
).map((field) => [field, '']),
);
}
@@ -74,13 +74,11 @@ function serializeRealtimeAuctionPlayer(
return player;
}
const {
masteries: _masteries,
puuid: _puuid,
recentStatsSummary: _recentStatsSummary,
tierHistory: _tierHistory,
...lightweightPlayer
} = player;
const lightweightPlayer = { ...player };
delete lightweightPlayer.masteries;
delete lightweightPlayer.puuid;
delete lightweightPlayer.recentStatsSummary;
delete lightweightPlayer.tierHistory;
return lightweightPlayer;
}
@@ -5,6 +5,20 @@ import {
} from './auction-rejection';
describe('resolveAuctionRejectionReason', () => {
it('distinguishes an outdated client from a stale round and does not suggest a state-only resync', () => {
const reason = resolveAuctionRejectionReason('BID_CLIENT_UPDATE_REQUIRED');
expect(reason).toBe('BID_REJECTED_BECAUSE_CLIENT_UPDATE_REQUIRED');
expect(isAuctionResyncRecommended(reason)).toBe(false);
});
it('reports roster validation failures without recommending a retry', () => {
const reason = resolveAuctionRejectionReason(
'AUCTION_ROSTER_INVALID',
'Auction roster validation failed.',
);
expect(reason).toBe('AUCTION_TRANSITION_REJECTED_BECAUSE_ROSTER_INVALID');
expect(isAuctionResyncRecommended(reason)).toBe(false);
});
it('maps the internal CONFLICT code to the descriptive transition reason', () => {
expect(resolveAuctionRejectionReason('CONFLICT')).toBe(
AUCTION_REJECTION_REASON.AUCTION_TRANSITION_REJECTED_BECAUSE_LIVE_STATE_CHANGED_BEFORE_APPLY,
@@ -22,7 +36,10 @@ describe('resolveAuctionRejectionReason', () => {
it('maps known BadRequest messages without a structured code', () => {
expect(
resolveAuctionRejectionReason(undefined, 'Cannot advance from current phase.'),
resolveAuctionRejectionReason(
undefined,
'Cannot advance from current phase.',
),
).toBe(
AUCTION_REJECTION_REASON.AUCTION_TRANSITION_REJECTED_BECAUSE_PHASE_DOES_NOT_ALLOW_ADVANCE,
);
@@ -16,7 +16,7 @@
* resync 권장 여부:
* - `AUCTION_RESYNC_RECOMMENDED_REASONS`에 속한 reason은 "클라가 본 상태가 이미
* 바뀌었다(낙관적 동시성 충돌/만료/단계 전이)"는 신호다. 이 경우 클라는 최신
* state로 rebaseline한 뒤 (구조 액션이라면) 1회 재시도하는 것이 안전하다.
* state로 rebaseline한다. 구조 액션 재시도는 원래 대상과 단계가 같을 때만 허용한다.
* - 반대로 정원 초과/포인트 부족처럼 "상태를 새로고침해도 결과가 같은" 거부는
* resync 권장 대상이 아니다(재시도해도 또 거부됨).
*/
@@ -29,9 +29,12 @@ export const AUCTION_REJECTION_REASON = {
/** 입찰 단계가 아닌데 입찰 단계 전환을 시도함(이미 sold/passed/presenting 등). */
AUCTION_TRANSITION_REJECTED_BECAUSE_AUCTION_NOT_IN_BIDDING_PHASE:
'AUCTION_TRANSITION_REJECTED_BECAUSE_AUCTION_NOT_IN_BIDDING_PHASE',
/** 현재 단계에서 "다음"으로 진행할 수 없음(sold/passed/presenting이 아님 — 보통 이미 진행됨). */
/** 낙찰 또는 유찰이 확정되지 않아 다음 선수로 진행할 수 없음. */
AUCTION_TRANSITION_REJECTED_BECAUSE_PHASE_DOES_NOT_ALLOW_ADVANCE:
'AUCTION_TRANSITION_REJECTED_BECAUSE_PHASE_DOES_NOT_ALLOW_ADVANCE',
/** 원 참가자 명단과 실제 팀 배정이 일치하지 않아 완료할 수 없음. */
AUCTION_TRANSITION_REJECTED_BECAUSE_ROSTER_INVALID:
'AUCTION_TRANSITION_REJECTED_BECAUSE_ROSTER_INVALID',
/** 낙찰 처리할 유효한 최고 입찰이 없음(만료 처리로 이미 정리됐을 수 있음). */
AUCTION_TRANSITION_REJECTED_BECAUSE_NO_WINNING_BID_TO_MARK_SOLD:
'AUCTION_TRANSITION_REJECTED_BECAUSE_NO_WINNING_BID_TO_MARK_SOLD',
@@ -43,6 +46,8 @@ export const AUCTION_REJECTION_REASON = {
'AUCTION_TRANSITION_REJECTED_BECAUSE_REQUEST_COORDINATION_RETRYABLE',
// === 입찰(bid) ===
BID_REJECTED_BECAUSE_CLIENT_UPDATE_REQUIRED:
'BID_REJECTED_BECAUSE_CLIENT_UPDATE_REQUIRED',
/** 입찰 라운드가 이미 다음 선수/다음 라운드로 넘어감(내부 `STALE_BID_ROUND`). */
BID_REJECTED_BECAUSE_BID_ROUND_ALREADY_ADVANCED:
'BID_REJECTED_BECAUSE_BID_ROUND_ALREADY_ADVANCED',
@@ -83,6 +88,10 @@ export type AuctionRejectionReason =
/** 내부 짧은 코드 → 설명적 reason. */
const INTERNAL_CODE_TO_REASON: Record<string, AuctionRejectionReason> = {
BID_CLIENT_UPDATE_REQUIRED:
AUCTION_REJECTION_REASON.BID_REJECTED_BECAUSE_CLIENT_UPDATE_REQUIRED,
AUCTION_ROSTER_INVALID:
AUCTION_REJECTION_REASON.AUCTION_TRANSITION_REJECTED_BECAUSE_ROSTER_INVALID,
CONFLICT:
AUCTION_REJECTION_REASON.AUCTION_TRANSITION_REJECTED_BECAUSE_LIVE_STATE_CHANGED_BEFORE_APPLY,
STALE_BID_ROUND:
@@ -96,6 +96,7 @@ describe('auction side effect helpers', () => {
'life-1',
'2',
'completed',
'',
]);
});
});
@@ -25,6 +25,7 @@ export interface BuildSideEffectLeaseAcquireUpdateParams {
export interface MatchSideEffectDelta {
auctionLifecycleId: string;
auctionStateTransitionId?: string;
currentServerTimestampMS: number;
matchSideEffectRevision: number;
matchSideEffectStatus: AuctionMatchSideEffectStatus;
@@ -36,27 +37,33 @@ export class AuctionSideEffectService {
public async mirrorMatchSideEffectStatus(params: {
auctionLifecycleId: string;
auctionStateTransitionId?: string;
matchId: string;
matchSideEffectRevision: number;
matchSideEffectStatus: AuctionMatchSideEffectStatus;
}): Promise<boolean> {
const keys = buildAuctionRedisKeys(params.matchId);
const result = await this.auctionRedisService.raw().sendCommand([
'EVAL',
[
"if redis.call('HGET', KEYS[1], 'auctionLifecycleId') ~= ARGV[1] then return 0 end",
"local currentRevision = tonumber(redis.call('HGET', KEYS[1], 'matchSideEffectRevision') or '-1')",
'local nextRevision = tonumber(ARGV[2])',
'if currentRevision >= nextRevision then return 0 end',
"redis.call('HSET', KEYS[1], 'matchSideEffectRevision', ARGV[2], 'matchSideEffectStatus', ARGV[3])",
'return 1',
].join('\n'),
'1',
keys.liveStateKey,
params.auctionLifecycleId,
String(params.matchSideEffectRevision),
params.matchSideEffectStatus,
]);
const result = await this.auctionRedisService
.raw()
.sendCommand([
'EVAL',
[
"if redis.call('HGET', KEYS[1], 'auctionLifecycleId') ~= ARGV[1] then return 0 end",
"local generation = redis.call('HGET', KEYS[1], 'matchSideEffectTransitionId')",
"if ARGV[4] ~= '' and generation and generation ~= ARGV[4] then return 0 end",
"local currentRevision = tonumber(redis.call('HGET', KEYS[1], 'matchSideEffectRevision') or '-1')",
'local nextRevision = tonumber(ARGV[2])',
'if currentRevision >= nextRevision then return 0 end',
"redis.call('HSET', KEYS[1], 'matchSideEffectRevision', ARGV[2], 'matchSideEffectStatus', ARGV[3])",
'return 1',
].join('\n'),
'1',
keys.liveStateKey,
params.auctionLifecycleId,
String(params.matchSideEffectRevision),
params.matchSideEffectStatus,
params.auctionStateTransitionId ?? '',
]);
return Number(result) === 1;
}
}
@@ -78,8 +85,7 @@ export function canAcquireSideEffectLease(
if (state.state === 'pending' || state.state === 'failed') return true;
if (state.state !== 'processing') return false;
return (
(state.processingLeaseExpiresAtTimestampMS ?? 0) <=
currentRedisTimestampMS
(state.processingLeaseExpiresAtTimestampMS ?? 0) <= currentRedisTimestampMS
);
}
@@ -103,6 +109,9 @@ export function buildMatchSideEffectDelta(
): MatchSideEffectDelta {
return {
auctionLifecycleId: params.auctionLifecycleId,
...(params.auctionStateTransitionId
? { auctionStateTransitionId: params.auctionStateTransitionId }
: {}),
currentServerTimestampMS: params.currentServerTimestampMS,
matchSideEffectRevision: params.matchSideEffectRevision,
matchSideEffectStatus: params.matchSideEffectStatus,
@@ -9,6 +9,7 @@ import {
Param,
Post,
UseGuards,
Query,
} from '@nestjs/common';
import mongoose from 'mongoose';
import { AllowPublicAccess } from '../auth/allow-public-access.decorator';
@@ -19,6 +20,7 @@ import { ParseObjectIdPipe } from '../common/parse-object-id.pipe';
import type { UserDocument } from '../global/database/schema';
import { AuctionService } from './auction.service';
import { AuctionGateway } from './auction.gateway';
import { AuctionBidArchiveService } from './auction-bid-archive.service';
import {
NextAuctionDto,
OpenBiddingDto,
@@ -35,6 +37,7 @@ export class AuctionController {
constructor(
private readonly auctionService: AuctionService,
private readonly auctionGateway: AuctionGateway,
private readonly auctionBidArchiveService: AuctionBidArchiveService,
) {}
@Post()
@@ -59,8 +62,7 @@ export class AuctionController {
initialTeamBidPointAmount: c.initialTeamBidPointAmount,
})),
initialTeamBidPointAmount: body.initialTeamBidPointAmount ?? 1000,
maximumBidRoundDurationSeconds:
body.maximumBidRoundDurationSeconds ?? 30,
maximumBidRoundDurationSeconds: body.maximumBidRoundDurationSeconds ?? 30,
bidRoundExtensionSeconds: body.bidRoundExtensionSeconds ?? 5,
topTierAuctionPriorityThreshold:
body.topTierAuctionPriorityThreshold ?? 'NONE',
@@ -79,6 +81,20 @@ export class AuctionController {
}
// 공개 — 팀장 2명만 쓸 엔드포인트(트러스트 기반, 10명 동시 관전).
@Get('bids/history')
@AllowPublicAccess()
public async getBidHistory(
@Param('matchId', ParseObjectIdPipe) matchId: mongoose.Types.ObjectId,
@Query('afterRevision') afterRevision?: string,
@Query('limit') limit?: string,
) {
return this.auctionBidArchiveService.list(
matchId,
afterRevision === undefined ? -1 : Number(afterRevision),
limit === undefined ? 100 : Number(limit),
);
}
@Post('open-bidding')
@AllowPublicAccess()
@HttpCode(HttpStatus.OK)
@@ -101,6 +117,7 @@ export class AuctionController {
teamIndex: body.bidderTeamIndex,
amount: body.bidPointAmount,
bidRequestId: body.bidRequestId,
clientObservedBidRoundId: body.clientObservedBidRoundId,
clientObservedAuctionLifecycleId: body.clientObservedAuctionLifecycleId,
clientObservedCurrentBidRoundPlayerUserId:
body.clientObservedCurrentBidRoundPlayerUserId,
@@ -214,7 +231,10 @@ export class AuctionController {
clientObservedPhase: body.clientObservedPhase,
clientObservedRevision: body.clientObservedRevision,
});
this.auctionGateway.broadcastReset(matchId.toString());
this.auctionGateway.broadcastReset(
matchId.toString(),
body.clientObservedAuctionLifecycleId,
);
}
private assertSameCommunity(
@@ -1,4 +1,5 @@
import mongoose from 'mongoose';
import { ServiceUnavailableException } from '@nestjs/common';
jest.mock('../auth/jwt.service', () => ({
JwtService: class JwtService {},
@@ -7,6 +8,76 @@ jest.mock('../auth/jwt.service', () => ({
import { AuctionGateway } from './auction.gateway';
describe('AuctionGateway', () => {
it('signals pending initial state so the client can retry privately after recovery', async () => {
const matchId = new mongoose.Types.ObjectId().toString();
const gateway = new AuctionGateway(
{
getByMatchId: async () => ({}),
getStateByMatchId: async () => {
throw new ServiceUnavailableException({
code: 'AUCTION_STATE_RECOVERING',
message: 'recovering',
});
},
} as never,
{} as never,
{} as never,
{} as never,
{} as never,
{} as never,
{} as never,
);
const socket = { data: { matchId }, join: jest.fn(), emit: jest.fn() };
await gateway.handleJoin(socket as never, { matchId });
expect(socket.emit).toHaveBeenCalledTimes(1);
expect(socket.emit).toHaveBeenCalledWith('state-pending', {
retryAfterMS: 500,
});
});
it('sends join and resync snapshots only to the requesting socket and coalesces in-flight resyncs', async () => {
const matchId = new mongoose.Types.ObjectId().toString();
const getStateByMatchId = jest.fn().mockResolvedValue({ revision: 3 });
const gateway = new AuctionGateway(
{
getByMatchId: async () => ({ chatMessages: [] }),
getStateByMatchId,
} as never,
{} as never,
{} as never,
{} as never,
{} as never,
{} as never,
{} as never,
);
const broadcast = jest.fn();
(gateway as unknown as { server: unknown }).server = {
to: () => ({ emit: broadcast }),
};
const socket = { data: { matchId }, join: jest.fn(), emit: jest.fn() };
await gateway.handleJoin(socket as never, { matchId });
expect(socket.emit).toHaveBeenCalledWith('state', { revision: 3 });
expect(broadcast).not.toHaveBeenCalled();
let finish!: (value: unknown) => void;
getStateByMatchId.mockImplementationOnce(
() =>
new Promise((resolve) => {
finish = resolve;
}),
);
const ack = jest.fn(),
busyAck = jest.fn();
const pending = gateway.handleResync(socket as never, {}, ack);
await gateway.handleResync(socket as never, {}, busyAck);
expect(busyAck).toHaveBeenCalledWith(
expect.objectContaining({ code: 'RESYNC_BUSY' }),
);
finish({ revision: 4 });
await pending;
expect(ack).toHaveBeenCalledWith({ ok: true, state: { revision: 4 } });
expect(getStateByMatchId).toHaveBeenCalledTimes(2);
expect(broadcast).not.toHaveBeenCalled();
});
function createGateway(params?: {
getCurrentRedisTimestampMS?: jest.Mock;
placeBidDelta?: jest.Mock;
+153 -60
View File
@@ -13,7 +13,7 @@ import {
} from '@nestjs/websockets';
import mongoose from 'mongoose';
import type { JWTPayload } from 'jose';
import { Namespace, Socket } from 'socket.io';
import type { DefaultEventsMap, Namespace, Socket } from 'socket.io';
import { AuthService } from '../auth/auth.service';
import { IdentityService } from '../auth/identity.service';
import { JwtService } from '../auth/jwt.service';
@@ -44,6 +44,7 @@ interface JoinAuctionPayload {
}
interface BidPayload {
clientObservedBidRoundId?: string;
bidderTeamIndex: number;
bidPointAmount: number;
bidRequestId?: string;
@@ -78,6 +79,22 @@ interface BidRateLimitState {
windowStartedAtTimestampMS: number;
}
interface AuctionSocketData {
auctionResyncAtTimestampMS?: number;
auctionResyncInProgress?: boolean;
auctionBidRateLimit?: BidRateLimitState;
identity?: IdentityDocument;
matchId?: string;
user?: UserDocument;
}
type AuctionSocket = Socket<
DefaultEventsMap,
DefaultEventsMap,
DefaultEventsMap,
AuctionSocketData
>;
const BID_RATE_LIMIT_WINDOW_MS = 1000;
const BID_RATE_LIMIT_MAX_REQUESTS_PER_WINDOW = 8;
const BID_RATE_LIMIT_REJECTION_CODE = 'BID_RATE_LIMITED';
@@ -92,9 +109,7 @@ const BID_RATE_LIMIT_REJECTION_MESSAGE =
allowedHeaders: ['Authorization', 'Content-Type', 'X-Auth-User-Id'],
},
})
export class AuctionGateway
implements OnGatewayConnection, OnGatewayInit
{
export class AuctionGateway implements OnGatewayConnection, OnGatewayInit {
@WebSocketServer()
private server!: Namespace;
@@ -114,14 +129,14 @@ export class AuctionGateway
this.auctionEventBusService.attachAuctionNamespace(server);
}
public async handleConnection(socket: Socket) {
public async handleConnection(socket: AuctionSocket) {
try {
await this.authenticateSocket(socket);
this.logger.debug(`Auction client connected: ${socket.id}`);
} catch (err) {
this.logger.warn(
`Auction client authentication failed: ${
err instanceof Error ? err.message : err
err instanceof Error ? err.message : String(err)
}`,
);
socket.disconnect(true);
@@ -130,7 +145,7 @@ export class AuctionGateway
@SubscribeMessage('join')
public async handleJoin(
@ConnectedSocket() socket: Socket,
@ConnectedSocket() socket: AuctionSocket,
@MessageBody() payload: JoinAuctionPayload,
) {
if (!payload?.matchId || !mongoose.isValidObjectId(payload.matchId)) {
@@ -150,15 +165,61 @@ export class AuctionGateway
new mongoose.Types.ObjectId(payload.matchId),
);
this.emitChatHistory(socket, auction);
this.broadcastState(payload.matchId, auctionState);
socket.emit('state', serializeRealtimeAuction(auctionState));
} catch (error) {
this.emitKnownError(socket, error);
const rejection = this.resolveErrorPayload(error);
if (rejection.code === 'AUCTION_STATE_RECOVERING') {
socket.emit('state-pending', { retryAfterMS: 500 });
} else {
this.emitKnownError(socket, error);
}
}
}
@SubscribeMessage('resync')
public async handleResync(
@ConnectedSocket() socket: AuctionSocket,
@MessageBody() _payload: unknown,
@Ack() ack?: (response: Record<string, unknown>) => void,
) {
const matchId = this.requireJoinedMatchId(socket);
if (!matchId) {
ack?.({ ok: false, code: 'JOIN_REQUIRED' });
return;
}
const now = Date.now();
const retryAfterMS =
500 - (now - (socket.data.auctionResyncAtTimestampMS ?? 0));
if (socket.data.auctionResyncInProgress || retryAfterMS > 0) {
ack?.({
ok: false,
code: 'RESYNC_BUSY',
retryAfterMS: Math.max(500, retryAfterMS),
});
return;
}
socket.data.auctionResyncInProgress = true;
socket.data.auctionResyncAtTimestampMS = now;
try {
const state = await this.auctionService.getStateByMatchId(
new mongoose.Types.ObjectId(matchId),
);
// Only the requesting socket receives the full snapshot.
ack?.({ ok: true, state: serializeRealtimeAuction(state) });
} catch (error) {
ack?.({
...this.resolveErrorPayload(error),
ok: false,
retryAfterMS: 500,
});
} finally {
socket.data.auctionResyncInProgress = false;
}
}
@SubscribeMessage('bid')
public async handleBid(
@ConnectedSocket() socket: Socket,
@ConnectedSocket() socket: AuctionSocket,
@MessageBody() payload: BidPayload,
@Ack() ack?: (response: Record<string, unknown>) => void,
) {
@@ -184,6 +245,7 @@ export class AuctionGateway
teamIndex: payload.bidderTeamIndex,
amount: payload.bidPointAmount,
bidRequestId,
clientObservedBidRoundId: payload.clientObservedBidRoundId,
clientObservedAuctionLifecycleId:
payload.clientObservedAuctionLifecycleId,
clientObservedCurrentBidRoundPlayerUserId:
@@ -205,7 +267,9 @@ export class AuctionGateway
ack?.({
...(bidDelta
? {}
: { state: this.serializeAuction(bidResult as AuctionStateResponse) }),
: {
state: this.serializeAuction(bidResult as AuctionStateResponse),
}),
ok: true,
bidRequestId,
bidDelta: broadcastBidDelta,
@@ -220,7 +284,12 @@ export class AuctionGateway
error,
);
const bidServerTiming = this.extractBidServerTiming(rejectionAckFields);
this.emitError(socket, String(rejectionAckFields.message ?? ''));
this.emitError(
socket,
typeof rejectionAckFields.message === 'string'
? rejectionAckFields.message
: '',
);
ack?.({
...rejectionAckFields,
bidRequestId,
@@ -263,7 +332,7 @@ export class AuctionGateway
@SubscribeMessage('open-bidding')
public async handleOpenBidding(
@ConnectedSocket() socket: Socket,
@ConnectedSocket() socket: AuctionSocket,
@MessageBody() payload: AuctionActionPayload,
@Ack() ack?: (response: Record<string, unknown>) => void,
) {
@@ -292,7 +361,7 @@ export class AuctionGateway
@SubscribeMessage('sold')
public async handleSold(
@ConnectedSocket() socket: Socket,
@ConnectedSocket() socket: AuctionSocket,
@MessageBody() payload: SoldPayload,
@Ack() ack?: (response: Record<string, unknown>) => void,
) {
@@ -322,7 +391,7 @@ export class AuctionGateway
@SubscribeMessage('next')
public async handleNext(
@ConnectedSocket() socket: Socket,
@ConnectedSocket() socket: AuctionSocket,
@MessageBody() payload: AuctionActionPayload,
@Ack() ack?: (response: Record<string, unknown>) => void,
) {
@@ -351,7 +420,7 @@ export class AuctionGateway
@SubscribeMessage('passed')
public async handlePassed(
@ConnectedSocket() socket: Socket,
@ConnectedSocket() socket: AuctionSocket,
@MessageBody() payload: AuctionActionPayload,
@Ack() ack?: (response: Record<string, unknown>) => void,
) {
@@ -380,7 +449,7 @@ export class AuctionGateway
@SubscribeMessage('chat-message')
public async handleChatMessage(
@ConnectedSocket() socket: Socket,
@ConnectedSocket() socket: AuctionSocket,
@MessageBody() payload: ChatMessagePayload,
) {
const matchId = this.requireJoinedMatchId(socket);
@@ -406,7 +475,7 @@ export class AuctionGateway
}
}
private requireJoinedMatchId(socket: Socket): string | null {
private requireJoinedMatchId(socket: AuctionSocket): string | null {
const matchId = this.getSocketMatchId(socket);
if (!matchId) {
this.emitError(socket, 'Join a match room before sending events.');
@@ -415,10 +484,9 @@ export class AuctionGateway
return matchId;
}
private consumeBidRateLimit(socket: Socket): boolean {
private consumeBidRateLimit(socket: AuctionSocket): boolean {
const currentTimestampMS = Date.now();
const previousState = socket.data
.auctionBidRateLimit as BidRateLimitState | undefined;
const previousState = socket.data.auctionBidRateLimit;
if (
!previousState ||
currentTimestampMS - previousState.windowStartedAtTimestampMS >=
@@ -436,10 +504,8 @@ export class AuctionGateway
return previousState.count <= BID_RATE_LIMIT_MAX_REQUESTS_PER_WINDOW;
}
private getSocketMatchId(socket: Socket): string | undefined {
return typeof socket.data.matchId === 'string'
? socket.data.matchId
: undefined;
private getSocketMatchId(socket: AuctionSocket): string | undefined {
return socket.data.matchId;
}
private toAuctionActionRequest(payload?: AuctionActionPayload) {
@@ -463,8 +529,9 @@ export class AuctionGateway
};
}
private readHandshakeUserId(socket: Socket): string | undefined {
const authUserId = socket.handshake.auth['x-auth-user-id'];
private readHandshakeUserId(socket: AuctionSocket): string | undefined {
const handshakeAuth = socket.handshake.auth as Record<string, unknown>;
const authUserId = handshakeAuth['x-auth-user-id'];
if (typeof authUserId === 'string') return authUserId;
const header = socket.handshake.headers['x-auth-user-id'];
@@ -472,16 +539,16 @@ export class AuctionGateway
}
private resolveSocketUserId(
socket: Socket,
socket: AuctionSocket,
): mongoose.Types.ObjectId | undefined {
return (socket.data.user as UserDocument | undefined)?._id;
return socket.data.user?._id;
}
private resolveChatDisplayName(
socket: Socket,
socket: AuctionSocket,
fallbackDisplayName?: string,
): string {
const user = socket.data.user as UserDocument | undefined;
const user = socket.data.user;
const primaryRiotAccount =
user?.riotAccounts.find((entry) => entry.isPrimary) ??
user?.riotAccounts[0];
@@ -494,14 +561,14 @@ export class AuctionGateway
if (user?.kakaoTalkNickname) return user.kakaoTalkNickname;
if (user?.discordNickname) return user.discordNickname;
const identity = socket.data.identity as IdentityDocument | undefined;
const identity = socket.data.identity;
if (identity?.displayName) return identity.displayName;
if (identity?.email) return identity.email;
return fallbackDisplayName ?? '관전자';
}
private async authenticateSocket(socket: Socket): Promise<void> {
private async authenticateSocket(socket: AuctionSocket): Promise<void> {
const fallback = await this.authService.resolveDevUserById(
this.readHandshakeUserId(socket),
);
@@ -531,14 +598,20 @@ export class AuctionGateway
});
}
private readHandshakeToken(socket: Socket): string | undefined {
const authToken = socket.handshake.auth.token;
private readHandshakeToken(socket: AuctionSocket): string | undefined {
const handshakeAuth = socket.handshake.auth as Record<string, unknown>;
const authToken = handshakeAuth.token;
if (typeof authToken === 'string' && authToken.trim()) {
return authToken.trim().replace(/^Bearer\s+/i, '');
}
const header = socket.handshake.headers.authorization;
const authorization = Array.isArray(header) ? header[0] : header;
const header: unknown = socket.handshake.headers.authorization;
const authorization =
typeof header === 'string'
? header
: Array.isArray(header) && typeof header[0] === 'string'
? header[0]
: undefined;
if (authorization?.startsWith('Bearer ')) {
return authorization.slice('Bearer '.length).trim();
}
@@ -546,10 +619,11 @@ export class AuctionGateway
}
private async resolveSocketUserForMatch(
socket: Socket,
socket: AuctionSocket,
matchId: string,
): Promise<void> {
if (socket.data.user || !socket.data.identity) return;
const identity = socket.data.identity;
const MatchModel = await this.connectionService.getModel('match');
const match = await MatchModel.findById(matchId).select({
@@ -558,10 +632,11 @@ export class AuctionGateway
if (!match) return;
const UserModel = await this.connectionService.getModel('user');
socket.data.user = await UserModel.findOne({
const user = await UserModel.findOne({
communityId: match.communityId,
identityId: (socket.data.identity as IdentityDocument)._id,
identityId: identity._id,
}).exec();
socket.data.user = user ?? undefined;
}
private requireStringClaim(payload: JWTPayload, key: string): string {
@@ -584,8 +659,11 @@ export class AuctionGateway
this.server.to(matchId).emit('bid', delta);
}
public broadcastReset(matchId: string) {
this.server.to(matchId).emit('reset', { matchId });
public broadcastReset(matchId: string, auctionLifecycleId?: string) {
this.server.to(matchId).emit('reset', {
matchId,
...(auctionLifecycleId ? { auctionLifecycleId } : {}),
});
}
public broadcastMatchSideEffect(
@@ -595,7 +673,7 @@ export class AuctionGateway
this.server.to(matchId).emit('match-side-effect', delta);
}
private emitChatHistory(socket: Socket, auction: AuctionDocument) {
private emitChatHistory(socket: AuctionSocket, auction: AuctionDocument) {
socket.emit('chat-history', {
messages: (auction.chatMessages ?? []).map((message) =>
this.serializeChatMessage(message),
@@ -603,16 +681,21 @@ export class AuctionGateway
});
}
private emitKnownError(socket: Socket, error: unknown) {
private emitKnownError(socket: AuctionSocket, error: unknown) {
this.emitError(socket, this.resolveErrorPayload(error).message);
}
private emitError(socket: Socket, message: string) {
private emitError(socket: AuctionSocket, message: string) {
socket.emit('error', { message });
}
private serializeAuction(auction: AuctionStateResponse) {
return JSON.parse(JSON.stringify(auction));
private serializeAuction(
auction: AuctionStateResponse,
): Record<string, unknown> {
const serialized: unknown = JSON.parse(JSON.stringify(auction));
return typeof serialized === 'object' && serialized !== null
? (serialized as Record<string, unknown>)
: {};
}
/**
@@ -633,7 +716,9 @@ export class AuctionGateway
typeof errorPayload.code === 'string' ? errorPayload.code : undefined,
errorPayload.message,
);
const resyncRecommended = isAuctionResyncRecommended(auctionRejectionReason);
const resyncRecommended = isAuctionResyncRecommended(
auctionRejectionReason,
);
const state = resyncRecommended
? await this.fetchSerializedAuctionState(matchId)
: undefined;
@@ -688,7 +773,9 @@ export class AuctionGateway
return {
code: error instanceof Error ? error.message : 'UNKNOWN',
message:
error instanceof Error ? error.message : 'Unexpected auction gateway error.',
error instanceof Error
? error.message
: 'Unexpected auction gateway error.',
};
}
@@ -716,7 +803,8 @@ export class AuctionGateway
bidDelta: Record<string, unknown> | null,
): Record<string, unknown> | null {
if (!bidDelta || !('bidServerTiming' in bidDelta)) return bidDelta;
const { bidServerTiming: _bidServerTiming, ...publicBidDelta } = bidDelta;
const publicBidDelta = { ...bidDelta };
delete publicBidDelta.bidServerTiming;
return publicBidDelta;
}
@@ -724,7 +812,7 @@ export class AuctionGateway
auction: AuctionStateResponse,
bidRequestId?: string,
): Record<string, unknown> | null {
const serialized = this.serializeAuction(auction) as Record<string, unknown>;
const serialized = this.serializeAuction(auction);
const revision = Number(serialized.revision);
const currentHighestBidPointAmount = Number(
serialized.currentHighestBidPointAmount ?? serialized.currentBid,
@@ -739,11 +827,13 @@ export class AuctionGateway
? Date.parse(serialized.currentDeadline)
: 0),
);
const redisBidHistory = Array.isArray(serialized.auctionBidHistory)
? serialized.auctionBidHistory
const redisBidHistory: unknown[] = Array.isArray(
serialized.auctionBidHistory,
)
? (serialized.auctionBidHistory as unknown[])
: [];
const legacyBidHistory = Array.isArray(serialized.bids)
? serialized.bids
const legacyBidHistory: unknown[] = Array.isArray(serialized.bids)
? (serialized.bids as unknown[])
: [];
const auctionBidHistoryEntry =
redisBidHistory[redisBidHistory.length - 1] ??
@@ -775,9 +865,7 @@ export class AuctionGateway
};
}
private isBidDeltaResponse(
value: unknown,
): value is AuctionBidDeltaResponse {
private isBidDeltaResponse(value: unknown): value is AuctionBidDeltaResponse {
return (
typeof value === 'object' &&
value !== null &&
@@ -804,7 +892,12 @@ export class AuctionGateway
};
}
private serializeChatMessage(message: AuctionChatMessage) {
return JSON.parse(JSON.stringify(message));
private serializeChatMessage(
message: AuctionChatMessage,
): Record<string, unknown> {
const serialized: unknown = JSON.parse(JSON.stringify(message));
return typeof serialized === 'object' && serialized !== null
? (serialized as Record<string, unknown>)
: {};
}
}
@@ -10,6 +10,7 @@ import { AuctionEventBusService } from './auction-event-bus.service';
import { AuctionRedisModule } from './redis/auction-redis.module';
import { AuctionSideEffectService } from './auction-side-effect.service';
import { AuctionService } from './auction.service';
import { AuctionBidArchiveService } from './auction-bid-archive.service';
@Module({
imports: [
@@ -21,6 +22,7 @@ import { AuctionService } from './auction.service';
controllers: [AuctionController],
providers: [
AuctionService,
AuctionBidArchiveService,
AuctionGateway,
AuctionEventBusService,
AuctionDeadlineScheduler,
@@ -2,6 +2,30 @@ import mongoose from 'mongoose';
import { AuctionService } from './auction.service';
describe('AuctionService', () => {
function requireRecord(
value: unknown,
label: string,
): Record<string, unknown> {
if (!value || typeof value !== 'object' || Array.isArray(value)) {
throw new Error(`${label} must be an object.`);
}
return value as Record<string, unknown>;
}
function requireArray(value: unknown, label: string): unknown[] {
if (!Array.isArray(value)) {
throw new Error(`${label} must be an array.`);
}
return value as unknown[];
}
function parseJsonRecord(value: unknown, label: string) {
if (typeof value !== 'string') {
throw new Error(`${label} must be a JSON string.`);
}
return requireRecord(JSON.parse(value) as unknown, label);
}
function createService(models: Record<string, unknown>) {
const auctionHistoryModel = {
findOne: jest.fn().mockReturnValue({
@@ -21,6 +45,10 @@ describe('AuctionService', () => {
const allModels = {
auctionHistory: auctionHistoryModel,
...models,
auction: {
updateOne: jest.fn().mockResolvedValue({ matchedCount: 1 }),
...((models.auction as object) ?? {}),
},
};
const connectionService = {
getModel: jest.fn((name: string) => allModels[name]),
@@ -158,12 +186,11 @@ describe('AuctionService', () => {
it('rejects non-positive or fractional bid amounts before loading auction state', async () => {
const matchId = new mongoose.Types.ObjectId();
const auctionFindOne = jest.fn();
const { service, auctionRedisCommandService, auctionRedisService } =
createService({
auction: {
findOne: auctionFindOne,
},
});
const { service, auctionRedisCommandService } = createService({
auction: {
findOne: auctionFindOne,
},
});
await expect(
service.placeBid({
@@ -674,7 +701,7 @@ describe('AuctionService', () => {
expect(auctionRedisService.raw().sendCommand).toHaveBeenCalledWith([
'EVAL',
expect.stringContaining('currentAuctionLifecycleId'),
'11',
'12',
`auction:${matchId.toString()}:liveAuctionState`,
'auction:bidRoundDeadlineQueue',
`auction:${matchId.toString()}:auctionStructureState`,
@@ -686,6 +713,7 @@ describe('AuctionService', () => {
`auction:${matchId.toString()}:auctionActionRequestResultOrder`,
`auction:${matchId.toString()}:rehydrateLock`,
`auction:${matchId.toString()}:auctionStateTransitionLock`,
`auction:${matchId.toString()}:rejectedBidRequestResultOrder`,
matchId.toString(),
'old-life-1',
]);
@@ -886,9 +914,9 @@ describe('AuctionService', () => {
shouldForceAuctionStateResync: true,
});
expect(auctionRedisService.acquireTokenLock).toHaveBeenCalledWith(
`auction:${matchId.toString()}:rehydrateLock`,
`auction:${matchId.toString()}:lifecycleMutationLock`,
expect.any(String),
5000,
30000,
);
expect(auctionRedisCommandService.hydrateState).toHaveBeenCalledWith(
matchId.toString(),
@@ -1008,7 +1036,12 @@ describe('AuctionService', () => {
);
const transitionInput =
auctionRedisCommandService.applyTransition.mock.calls[0][1];
expect(JSON.parse(transitionInput.durabilityPayloadJson)).toMatchObject({
expect(
parseJsonRecord(
transitionInput.durabilityPayloadJson,
'durabilityPayloadJson',
),
).toMatchObject({
afterAuctionMongoProjection: expect.objectContaining({
phase: 'bidding',
revision: 2,
@@ -1179,17 +1212,40 @@ describe('AuctionService', () => {
const transitionInput =
auctionRedisCommandService.applyTransition.mock.calls[0][1];
const durabilityPayload = JSON.parse(transitionInput.durabilityPayloadJson);
expect(durabilityPayload.snapshotBefore).toMatchObject({
const durabilityPayload = parseJsonRecord(
transitionInput.durabilityPayloadJson,
'durabilityPayloadJson',
);
const snapshotBefore = requireRecord(
durabilityPayload.snapshotBefore,
'snapshotBefore',
);
const snapshotBeforeTeams = requireArray(
snapshotBefore.auctionTeams,
'snapshotBefore.auctionTeams',
);
const snapshotBeforeTeam = requireRecord(
snapshotBeforeTeams[0],
'snapshotBefore.auctionTeams[0]',
);
const afterAuctionMongoProjection = requireRecord(
durabilityPayload.afterAuctionMongoProjection,
'afterAuctionMongoProjection',
);
const projectedTeams = requireArray(
afterAuctionMongoProjection.auctionTeams,
'afterAuctionMongoProjection.auctionTeams',
);
const projectedTeam = requireRecord(
projectedTeams[0],
'afterAuctionMongoProjection.auctionTeams[0]',
);
expect(snapshotBefore).toMatchObject({
phase: 'bidding',
revision: 4,
});
expect(durabilityPayload.snapshotBefore.auctionTeams[0].members).toEqual(
[],
);
expect(
durabilityPayload.afterAuctionMongoProjection.auctionTeams[0].members,
).toEqual([
expect(snapshotBeforeTeam.members).toEqual([]);
expect(projectedTeam.members).toEqual([
expect.objectContaining({
memberAcquisitionBidPointAmount: 120,
userId: playerUserId.toString(),
@@ -1314,6 +1370,267 @@ describe('AuctionService', () => {
}
});
describe('redis next safety', () => {
function createFortyPlayerAuction() {
const matchId = new mongoose.Types.ObjectId();
const participantIds = Array.from(
{ length: 40 },
() => new mongoose.Types.ObjectId(),
);
const auction = {
_id: new mongoose.Types.ObjectId(),
matchId,
auctionEngineVersion: 'redis-v1',
auctionLifecycleId: 'life-1',
};
const state = {
auctionLifecycleId: 'life-1',
auctionTeams: participantIds
.slice(0, 8)
.map((captainUserId, index) => ({
teamIndex: index + 1,
captainUserId: captainUserId.toString(),
remainingBidPointAmount: 960,
members: participantIds
.slice(8 + index * 4, 12 + index * 4)
.map((userId) => ({
userId: userId.toString(),
assignedPosition: 'MID',
memberAcquisitionBidPointAmount: 10,
})),
})),
auctionPlayerOrder: participantIds.slice(8).map((userId) => ({
userId: userId.toString(),
preferredPositions: [{ position: 'MID', priority: 1 }],
passCount: 0,
})),
bidRoundExtensionSeconds: 5,
currentAuctionHistorySequence: 121,
currentAuctionPlayerOrderIndex: 31,
currentAuctionRound: 1,
initialTeamBidPointAmount: 1000,
maximumBidRoundDurationSeconds: 15,
passedAuctionPlayerQueue: [] as Array<{
userId: string;
preferredPositions: Array<{ position: string; priority: number }>;
passCount: number;
}>,
phase: 'sold',
revision: 479,
topTierAuctionPriorityThreshold: 'NONE',
};
const match = {
_id: matchId,
participants: participantIds.map((userId) => ({
userId,
excluded: false,
preferredPositions: [{ position: 'MID', priority: 1 }],
})),
status: 'team-built',
teams: [],
save: jest.fn().mockResolvedValue(undefined),
};
const dependencies = createService({
auction: { findOne: jest.fn().mockResolvedValue(auction) },
match: { findById: jest.fn().mockResolvedValue(match) },
});
dependencies.auctionRedisStateReaderService.readAuctionStateView.mockResolvedValue(
state,
);
dependencies.auctionRedisCommandService.applyTransition.mockImplementation(
async (_matchId: string, input: Record<string, unknown>) => {
Object.assign(
state,
parseJsonRecord(
input.afterAuctionStructureStateJson,
'afterAuctionStructureStateJson',
),
input.liveStatePatch,
{
revision: Number(input.expectedRevision) + 1,
currentAuctionHistorySequence: input.auctionHistorySequence,
},
);
return {
auctionStateTransitionId: String(input.auctionStateTransitionId),
currentServerTimestampMS: 1780000000000,
ok: true,
revision: state.revision,
};
},
);
return { ...dependencies, matchId, match, state, participantIds };
}
it.each([12, 31])(
'rejects next for a presenting player at index %i without skipping or completing',
async (index) => {
const { service, matchId, state, auctionRedisCommandService } =
createFortyPlayerAuction();
state.phase = 'presenting';
state.currentAuctionPlayerOrderIndex = index;
const before = structuredClone(state);
await expect(service.next(matchId)).rejects.toThrow(
'Cannot advance from current phase.',
);
expect(state).toEqual(before);
expect(
auctionRedisCommandService.reserveActionRequest,
).not.toHaveBeenCalled();
expect(
auctionRedisCommandService.applyTransition,
).not.toHaveBeenCalled();
},
);
it('rejects completion when only 39 of the 40 participants are assigned', async () => {
const { service, matchId, state, match, auctionRedisCommandService } =
createFortyPlayerAuction();
state.auctionTeams[6].members.pop();
const before = structuredClone(state);
await expect(service.next(matchId)).rejects.toThrow(
'Auction roster validation failed.',
);
expect(state).toEqual(before);
expect(auctionRedisCommandService.applyTransition).not.toHaveBeenCalled();
expect(match.save).not.toHaveBeenCalled();
});
it('checks original eligible participants even if a missing player also disappeared from the order', async () => {
const { service, matchId, state, auctionRedisCommandService } =
createFortyPlayerAuction();
const missingPlayer = state.auctionTeams[6].members.pop()!;
state.auctionPlayerOrder = state.auctionPlayerOrder.filter(
(player) => player.userId !== missingPlayer.userId,
);
state.currentAuctionPlayerOrderIndex =
state.auctionPlayerOrder.length - 1;
const before = structuredClone(state);
await expect(service.next(matchId)).rejects.toThrow(
'Auction roster validation failed.',
);
expect(state).toEqual(before);
expect(auctionRedisCommandService.applyTransition).not.toHaveBeenCalled();
});
it('rejects a duplicate assignment even when the assigned count still equals 40', async () => {
const { service, matchId, state, auctionRedisCommandService } =
createFortyPlayerAuction();
state.auctionTeams[0].members[0].userId =
state.auctionTeams[1].members[0].userId;
await expect(service.next(matchId)).rejects.toThrow(
'Auction roster validation failed.',
);
expect(state.phase).toBe('sold');
expect(auctionRedisCommandService.applyTransition).not.toHaveBeenCalled();
});
it('rejects duplicate captain membership even when every expected user is present', async () => {
const { service, matchId, state, auctionRedisCommandService } =
createFortyPlayerAuction();
state.auctionTeams[0].members.push({
userId: state.auctionTeams[0].captainUserId,
assignedPosition: 'MID',
memberAcquisitionBidPointAmount: 10,
});
await expect(service.next(matchId)).rejects.toThrow(
'Auction roster validation failed.',
);
expect(state.phase).toBe('sold');
expect(auctionRedisCommandService.applyTransition).not.toHaveBeenCalled();
});
it('rejects an unexpected assigned user even when all 40 assignments are unique', async () => {
const { service, matchId, state, auctionRedisCommandService } =
createFortyPlayerAuction();
state.auctionTeams[0].members[0].userId =
new mongoose.Types.ObjectId().toString();
await expect(service.next(matchId)).rejects.toThrow(
'Auction roster validation failed.',
);
expect(state.phase).toBe('sold');
expect(auctionRedisCommandService.applyTransition).not.toHaveBeenCalled();
});
it('completes all 40 eligible participants once, allowing repeat order entries after passes and excluding cut participants', async () => {
const { service, matchId, state, match, auctionRedisCommandService } =
createFortyPlayerAuction();
state.auctionPlayerOrder.push({
...state.auctionPlayerOrder[12],
passCount: 1,
});
state.currentAuctionPlayerOrderIndex =
state.auctionPlayerOrder.length - 1;
state.currentAuctionRound = 2;
match.participants.push({
userId: new mongoose.Types.ObjectId(),
excluded: true,
preferredPositions: [{ position: 'MID', priority: 1 }],
});
await expect(service.next(matchId)).resolves.toMatchObject({
phase: 'complete',
revision: 480,
});
expect(auctionRedisCommandService.applyTransition).toHaveBeenCalledTimes(
1,
);
expect(state.auctionTeams).toHaveLength(8);
expect(
state.auctionTeams.every((team) => team.members.length === 4),
).toBe(true);
expect(match.save).not.toHaveBeenCalled();
});
it.each(['sold', 'passed'])(
'advances a nonterminal %s player without demanding a completed roster',
async (phase) => {
const { service, matchId, state } = createFortyPlayerAuction();
state.phase = phase;
state.currentAuctionPlayerOrderIndex = 12;
state.auctionTeams.forEach((team) => {
team.members = [];
});
await expect(service.next(matchId)).resolves.toMatchObject({
phase: 'presenting',
currentAuctionPlayerOrderIndex: 13,
});
},
);
it('requeues passed players for another round without completing an incomplete roster', async () => {
const { service, matchId, state } = createFortyPlayerAuction();
state.phase = 'passed';
state.auctionTeams[7].members.pop();
state.passedAuctionPlayerQueue.push({
...state.auctionPlayerOrder[31],
passCount: 1,
});
await expect(service.next(matchId)).resolves.toMatchObject({
phase: 'presenting',
currentAuctionPlayerOrderIndex: 32,
currentAuctionRound: 2,
passedAuctionPlayerQueue: [],
});
expect(state.auctionPlayerOrder).toHaveLength(33);
});
});
it('syncs match teams when a redis-v1 auction completes', async () => {
const matchId = new mongoose.Types.ObjectId();
const captainUserId = new mongoose.Types.ObjectId();
@@ -1397,7 +1714,12 @@ describe('AuctionService', () => {
});
const [, transitionInput] =
auctionRedisCommandService.applyTransition.mock.calls.at(-1) ?? [];
expect(JSON.parse(transitionInput.durabilityPayloadJson)).toMatchObject({
expect(
parseJsonRecord(
transitionInput.durabilityPayloadJson,
'durabilityPayloadJson',
),
).toMatchObject({
afterAuctionMongoProjection: {
matchSideEffectStatus: 'pending',
phase: 'complete',
@@ -1786,7 +2108,7 @@ describe('AuctionService', () => {
});
expect(auction.currentBid).toBe(970);
expect(auction.currentBidderTeamIndex).toBe(1);
expect(auction).toHaveProperty('currentBidderTeamIndex', 1);
expect(auction.bids).toEqual([
expect.objectContaining({
teamIndex: 1,
@@ -2080,7 +2402,7 @@ describe('AuctionService', () => {
await service.next(matchId);
expect(auction.phase).toBe('complete');
expect(auction.completedAt).toBeInstanceOf(Date);
expect(auction).toHaveProperty('completedAt', expect.any(Date));
expect(auction.save).toHaveBeenCalledTimes(1);
expect(match.save).toHaveBeenCalledTimes(2);
expect(match.teams).toEqual([
@@ -2304,8 +2626,14 @@ describe('AuctionService', () => {
auctionRedisCommandService.reserveActionRequest,
).not.toHaveBeenCalled();
expect(auctionRedisCommandService.applyTransition).not.toHaveBeenCalled();
expect(tournamentCodeService.releaseFromMatch).toHaveBeenCalledWith(match);
expect(tournamentResultService.cancelPolling).toHaveBeenCalledWith(match);
expect(tournamentCodeService.releaseFromMatch).toHaveBeenCalledWith(
match,
session,
);
expect(tournamentResultService.cancelPolling).toHaveBeenCalledWith(
match,
session,
);
expect(match).toMatchObject({
gameSchedule: [],
result: undefined,
@@ -2325,13 +2653,12 @@ describe('AuctionService', () => {
auctionId,
});
expect(auction.deleteOne).toHaveBeenCalledWith({ session });
expect(redisClient.sendCommand).toHaveBeenCalledWith(
expect.arrayContaining([
'auction:bidRoundDeadlineQueue',
matchId.toString(),
'life-1',
]),
);
expect(redisClient.sendCommand).not.toHaveBeenCalled();
expect(match).toMatchObject({
lastCancelledAuctionLifecycleId: 'life-1',
auctionCancellationCleanupPending: true,
auctionCancellationCleanupRetryAt: expect.any(Date),
});
expect(session.commitTransaction).toHaveBeenCalledTimes(1);
});
@@ -2415,8 +2742,14 @@ describe('AuctionService', () => {
service.undoTo({ matchId, communityId, sequence: 3 }),
).resolves.toBe(restored);
expect(tournamentCodeService.releaseFromMatch).toHaveBeenCalledWith(match);
expect(tournamentResultService.cancelPolling).toHaveBeenCalledWith(match);
expect(tournamentCodeService.releaseFromMatch).toHaveBeenCalledWith(
match,
session,
);
expect(tournamentResultService.cancelPolling).toHaveBeenCalledWith(
match,
session,
);
expect(match.status).toBe('team-built');
expect(match.result).toBeUndefined();
expect(auctionReplaceOne).toHaveBeenCalledWith(
@@ -2568,7 +2901,10 @@ describe('AuctionService', () => {
durationSeconds: 30,
mode: 'set-relative',
});
const durabilityPayload = JSON.parse(transitionInput.durabilityPayloadJson);
const durabilityPayload = parseJsonRecord(
transitionInput.durabilityPayloadJson,
'durabilityPayloadJson',
);
expect(durabilityPayload).toMatchObject({
auctionActionType: 'undo',
historyMutation: {
+465 -148
View File
@@ -5,8 +5,16 @@ import {
InternalServerErrorException,
Logger,
NotFoundException,
ServiceUnavailableException,
Optional,
} from '@nestjs/common';
import { randomUUID } from 'crypto';
import {
AuctionLifecycleLock,
AuctionLifecycleBusyError,
} from './auction-lifecycle-lock';
import { AUCTION_OPTIONAL_PROJECTION_FIELDS } from './auction-projection';
import { AuctionEventBusService } from './auction-event-bus.service';
import { performance } from 'perf_hooks';
import mongoose from 'mongoose';
import { ConnectionService } from '../global/database/connection.service';
@@ -39,6 +47,7 @@ import {
stringifyAuctionRedisStructureState,
} from './redis/auction-redis-projection';
import { AuctionRedisService } from './redis/auction-redis.service';
import { AUCTION_CLEANUP_DURABILITY_SCRIPT } from './redis/auction-redis.cleanup';
import { AuctionRedisStateReaderService } from './redis/auction-redis-state-reader.service';
import { shouldHydrateRedisAuctionState } from './redis/auction-redis.state';
// [AUCTION-DEBUG] 경매 "중복 멤버" 조사용 임시 계측. 조사 종료 후 제거 대상.
@@ -57,8 +66,6 @@ const AUCTION_BID_REQUEST_REPLAY_WINDOW_MS = 5 * 60 * 1000;
const AUCTION_MAX_STORED_ACTION_REQUEST_RESULT_COUNT = 500;
const AUCTION_ACTION_REQUEST_REPLAY_WINDOW_MS = 5 * 60 * 1000;
const AUCTION_ACTION_REQUEST_LEASE_DURATION_MS = 15 * 1000;
const AUCTION_REHYDRATE_LOCK_TTL_MS = 5 * 1000;
const AUCTION_REHYDRATE_LOCK_WAIT_MS = 50;
const AUCTION_HISTORY_LIST_LIMIT = 100;
const AUCTION_HISTORY_LIST_CACHE_TTL_MS = 2 * 1000;
const AUCTION_HISTORY_LIST_CACHE_MAX_ENTRIES = 256;
@@ -81,6 +88,7 @@ interface StartAuctionParams {
}
interface PlaceBidParams {
clientObservedBidRoundId?: string;
matchId: mongoose.Types.ObjectId;
teamIndex: number;
amount: number;
@@ -159,6 +167,7 @@ interface AuctionHistoryListCacheEntry {
export type AuctionStateResponse = AuctionDocument | Record<string, unknown>;
export interface AuctionBidDeltaResponse {
currentBidRoundId?: string;
auctionBidHistoryEntry: Record<string, unknown>;
auctionLifecycleId?: string;
bidServerTiming?: AuctionBidServerTiming;
@@ -211,9 +220,20 @@ export class AuctionService {
private readonly auctionRedisService: AuctionRedisService,
private readonly auctionRedisCommandService: AuctionRedisCommandService,
private readonly auctionRedisStateReaderService: AuctionRedisStateReaderService,
@Optional()
private readonly auctionEventBusService?: AuctionEventBusService,
) {}
public async start(params: StartAuctionParams): Promise<AuctionDocument> {
return new AuctionLifecycleLock(this.auctionRedisService).run(
params.matchId.toString(),
() => this.startLocked(params),
);
}
private async startLocked(
params: StartAuctionParams,
): Promise<AuctionDocument> {
const MatchModel = await this.connectionService.getModel('match');
const UserModel = await this.connectionService.getModel('user');
const AuctionModel = await this.connectionService.getModel('auction');
@@ -230,7 +250,7 @@ export class AuctionService {
const existing = await AuctionModel.findOne({ matchId: params.matchId });
if (existing) {
if (existing.startAuctionRequestId === params.startAuctionRequestId) {
return existing;
return this.finishAuctionStartup(existing, match);
}
if (this.isRestartableResetRedisAuction(existing)) {
await this.clearRedisAuctionRuntimeForLifecycle(
@@ -248,6 +268,19 @@ export class AuctionService {
}
}
// No Mongo auction owns this match. Remove runtime left by an interrupted
// cancellation before creating a new lifecycle (under the lifecycle lock).
const orphanedRuntime =
await this.auctionRedisStateReaderService.readLiveStateIdentity(
params.matchId.toString(),
);
if (orphanedRuntime?.auctionLifecycleId) {
await this.clearRedisAuctionRuntimeForLifecycle(
params.matchId.toString(),
orphanedRuntime.auctionLifecycleId,
);
}
const activeParticipants = this.applyAuctionCut(match);
const desiredAuctionCount = activeParticipants.length;
if (desiredAuctionCount < 10) {
@@ -380,6 +413,7 @@ export class AuctionService {
auctionStartedByUserId: params.actorUserId,
matchSideEffectStatus: 'none',
matchSideEffectRevision: 0,
startupCompleted: false,
teams: legacyTeams,
order: prioritizedOrder,
passedQueue: [],
@@ -418,12 +452,12 @@ export class AuctionService {
matchId: params.matchId,
});
if (raceWinner?.startAuctionRequestId === params.startAuctionRequestId) {
return raceWinner;
return this.finishAuctionStartup(raceWinner, match);
}
throw new BadRequestException('Auction already exists for this match.');
}
await this.recordSnapshot(auction, 'start');
await this.auctionRedisCommandService.hydrateState(
const hydration = await this.auctionRedisCommandService.hydrateState(
params.matchId.toString(),
{
auctionHistorySequence: 1,
@@ -436,9 +470,18 @@ export class AuctionService {
structureStateJson,
},
);
if ('rejected' in hydration)
throw new ConflictException(
`Auction initialization failed: ${hydration.code}.`,
);
match.status = 'team-built';
await match.save();
auction.startupCompleted = true;
await AuctionModel.updateOne(
{ _id: auction._id },
{ $set: { startupCompleted: true } },
);
this.enqueueBackgroundOrderEnrichment({
auctionId: auction._id,
targets: enrichTargets,
@@ -449,6 +492,61 @@ export class AuctionService {
return auction;
}
private async finishAuctionStartup(
auction: AuctionDocument,
match: MatchDocument,
): Promise<AuctionDocument> {
// Documents predating the startup marker already completed the old path.
if (auction.startupCompleted !== false) return auction;
// Retry the original cut; recruiting may have changed since Mongo creation.
const roster = new Set([
...auction.teams.map((team) => team.captainUserId.toString()),
...auction.order.map((player) => player.userId.toString()),
]);
const participants = new Set(
match.participants.map((entry) => entry.userId.toString()),
);
if ([...roster].some((id) => !participants.has(id))) {
throw new ConflictException(
'Auction startup roster has changed. Cancel and restart the auction.',
);
}
const History = await this.connectionService.getModel('auctionHistory');
await History.updateOne(
{ auctionId: auction._id, sequence: 1 },
{
$setOnInsert: {
auctionId: auction._id,
matchId: auction.matchId,
sequence: 1,
action: 'start',
snapshotBefore: this.cloneJson(
typeof auction.toObject === 'function'
? auction.toObject()
: auction,
),
takenAt: auction.startedAt ?? new Date(),
},
},
{ upsert: true },
);
await this.hydrateRedisStateFromAuctionDocument(auction);
if (match.status === 'recruiting') {
match.participants.forEach((participant) => {
participant.excluded = !roster.has(participant.userId.toString());
});
match.status = 'team-built';
await match.save();
}
const AuctionModel = await this.connectionService.getModel('auction');
await AuctionModel.updateOne(
{ _id: auction._id },
{ $set: { startupCompleted: true } },
);
auction.startupCompleted = true;
return auction;
}
public async getByMatchId(
matchId: mongoose.Types.ObjectId,
): Promise<AuctionDocument> {
@@ -461,18 +559,46 @@ export class AuctionService {
public async getStateByMatchId(
matchId: mongoose.Types.ObjectId,
): Promise<AuctionStateResponse> {
const auction = await this.getByMatchId(matchId);
for (let attempt = 0; ; attempt++) {
try {
return await this.getStateByMatchIdOnce(matchId);
} catch (error) {
if (!(error instanceof AuctionLifecycleBusyError)) throw error;
if (attempt >= 4)
throw new ServiceUnavailableException({
code: 'AUCTION_STATE_RECOVERING',
retryAfterMS: 500,
message: '경매 상태를 복구 중입니다. 잠시 후 다시 시도해 주세요.',
});
await new Promise((resolve) => setTimeout(resolve, 50 * (attempt + 1)));
}
}
}
private async getStateByMatchIdOnce(
matchId: mongoose.Types.ObjectId,
): Promise<AuctionStateResponse> {
let auction = await this.getByMatchId(matchId);
if (!this.isRedisV1Auction(auction)) return auction;
if (auction.startupCompleted === false) {
auction = await new AuctionLifecycleLock(this.auctionRedisService).run(
matchId.toString(),
async () => {
const current = await this.getByMatchId(matchId);
const MatchModel = await this.connectionService.getModel('match');
const match = await MatchModel.findById(matchId);
if (!match) throw new NotFoundException('Match not found.');
return this.finishAuctionStartup(current, match);
},
);
}
const redisState = await this.readRedisAuctionStateOrRehydrate(auction);
if (!redisState) return auction;
const mongoState =
typeof auction.toObject === 'function'
? auction.toObject({ depopulate: true })
: auction;
return {
...this.cloneJson(mongoState),
...this.buildAuctionSnapshotFromRedisState(auction, redisState),
...redisState,
chatMessages: auction.chatMessages ?? [],
};
@@ -484,12 +610,15 @@ export class AuctionService {
const matchId = auction.matchId.toString();
const mongoRevision = auction.revision ?? 0;
const mongoAuctionLifecycleId = auction.auctionLifecycleId;
if (!mongoAuctionLifecycleId || auction.phase === 'complete') {
if (!mongoAuctionLifecycleId) {
return this.auctionRedisStateReaderService.readAuctionStateView(matchId);
}
const liveIdentity =
await this.auctionRedisStateReaderService.readLiveStateIdentity(matchId);
// Completed runtimes expire after the retention period. Mongo remains the
// archive; viewing it must not create an immortal Redis runtime again.
if (!liveIdentity && auction.phase === 'complete') return null;
const shouldHydrate = shouldHydrateRedisAuctionState({
live: liveIdentity,
mongo: {
@@ -502,29 +631,32 @@ export class AuctionService {
return this.auctionRedisStateReaderService.readAuctionStateView(matchId);
}
const keys = buildAuctionRedisKeys(matchId);
const lockToken = randomUUID();
const lockAcquired = await this.auctionRedisService.acquireTokenLock(
keys.rehydrateLockKey,
lockToken,
AUCTION_REHYDRATE_LOCK_TTL_MS,
await new AuctionLifecycleLock(this.auctionRedisService).run(
matchId,
async () => {
const currentAuction = await this.getByMatchId(auction.matchId);
if (currentAuction.auctionLifecycleId !== mongoAuctionLifecycleId) {
throw new ConflictException(
'Auction lifecycle has changed. Refresh the auction.',
);
}
const currentLive =
await this.auctionRedisStateReaderService.readLiveStateIdentity(
matchId,
);
if (
currentLive?.auctionLifecycleId &&
currentLive.auctionLifecycleId !== mongoAuctionLifecycleId
) {
await this.clearRedisAuctionRuntimeForLifecycle(
matchId,
currentLive.auctionLifecycleId,
);
}
await this.hydrateRedisStateFromAuctionDocument(currentAuction);
},
);
if (lockAcquired) {
try {
await this.hydrateRedisStateFromAuctionDocument(auction);
} finally {
await this.auctionRedisService.releaseTokenLock(
keys.rehydrateLockKey,
lockToken,
);
}
} else {
await new Promise((resolve) =>
setTimeout(resolve, AUCTION_REHYDRATE_LOCK_WAIT_MS),
);
}
return this.auctionRedisStateReaderService.readAuctionStateView(matchId, {
shouldForceAuctionStateResync: true,
});
@@ -813,6 +945,7 @@ export class AuctionService {
bidderTeamIndex: params.teamIndex,
bidderUserId: bidContext.bidderTeamCaptainUserId,
bidRequestId: params.bidRequestId ?? randomUUID(),
clientObservedBidRoundId: params.clientObservedBidRoundId,
clientObservedAuctionLifecycleId: auctionLifecycleId,
clientObservedCurrentBidRoundPlayerUserId: currentBidRoundPlayerUserId,
matchId,
@@ -889,6 +1022,7 @@ export class AuctionService {
bidderTeamIndex: params.teamIndex,
bidderUserId: this.stringFromState(team.captainUserId),
bidRequestId: params.bidRequestId ?? randomUUID(),
clientObservedBidRoundId: params.clientObservedBidRoundId,
clientObservedAuctionLifecycleId: auctionLifecycleId,
clientObservedCurrentBidRoundPlayerUserId: currentBidRoundPlayerUserId,
matchId,
@@ -922,6 +1056,10 @@ export class AuctionService {
): AuctionBidDeltaResponse {
return {
auctionBidHistoryEntry: result.auctionBidHistoryEntry,
currentBidRoundId:
typeof result.auctionBidHistoryEntry.bidRoundId === 'string'
? result.auctionBidHistoryEntry.bidRoundId
: undefined,
auctionLifecycleId: this.stringFromState(state.auctionLifecycleId),
bidRequestId: result.bidRequestId,
currentBidRoundDeadlineTimestampMS:
@@ -1193,11 +1331,7 @@ export class AuctionService {
): Promise<AuctionStateResponse> {
const matchId = auction.matchId.toString();
const state = await this.requireRedisAuctionState(matchId);
if (
state.phase !== 'sold' &&
state.phase !== 'presenting' &&
state.phase !== 'passed'
) {
if (state.phase !== 'sold' && state.phase !== 'passed') {
throw new BadRequestException('Cannot advance from current phase.');
}
@@ -1218,6 +1352,10 @@ export class AuctionService {
structureInput.currentAuctionRound += 1;
structureInput.currentAuctionPlayerOrderIndex = nextIndex;
} else {
await this.assertCompleteAuctionRoster(
auction.matchId,
structureInput.auctionTeams,
);
action = 'complete';
nextPhase = 'complete';
}
@@ -1332,17 +1470,16 @@ export class AuctionService {
if (this.isRedisV1Auction(auction)) {
return this.advanceRedisAuction(auction, actionRequest);
}
if (
auction.phase !== 'sold' &&
auction.phase !== 'presenting' &&
auction.phase !== 'passed'
) {
if (auction.phase !== 'sold' && auction.phase !== 'passed') {
throw new BadRequestException('Cannot advance from current phase.');
}
const nextIndex = auction.currentIndex + 1;
const completesAuction =
nextIndex >= auction.order.length &&
(auction.passedQueue?.length ?? 0) === 0;
if (completesAuction) {
await this.assertCompleteAuctionRoster(matchId, auction.teams);
}
await this.recordSnapshot(auction, completesAuction ? 'complete' : 'next');
if (nextIndex >= auction.order.length) {
if ((auction.passedQueue?.length ?? 0) > 0) {
@@ -1408,6 +1545,34 @@ export class AuctionService {
matchId: mongoose.Types.ObjectId;
communityId: mongoose.Types.ObjectId;
}): Promise<void> {
let committed = false;
try {
await new AuctionLifecycleLock(this.auctionRedisService).run(
params.matchId.toString(),
() =>
this.resetLocked(params, () => {
committed = true;
}),
);
} catch (error) {
if (!committed) throw error;
// A committed cancellation is successful even if lock renewal/teardown
// fails afterward. Cleanup is durably queued in the same Mongo transaction.
this.logger.warn(
`Auction cancellation committed; post-commit coordination failed: ${String(error)}`,
);
}
}
private async resetLocked(
params: {
matchId: mongoose.Types.ObjectId;
communityId: mongoose.Types.ObjectId;
clientObservedAuctionLifecycleId?: string;
clientObservedRevision?: number;
},
onCommitted: () => void,
): Promise<void> {
const AuctionModel = await this.connectionService.getModel('auction');
const AuctionHistoryModel =
await this.connectionService.getModel('auctionHistory');
@@ -1419,70 +1584,155 @@ export class AuctionService {
if (!session) {
throw new InternalServerErrorException('Failed to start DB session.');
}
let redisRuntimeToClear: {
auctionLifecycleId?: string;
matchId: string;
} | null = null;
try {
session.startTransaction();
const auction = await AuctionModel.findOne({
matchId: params.matchId,
}).session(session);
if (!auction) throw new NotFoundException('Auction not found.');
const match = await MatchModel.findById(params.matchId).session(session);
if (!match) throw new NotFoundException('Match not found.');
if (!match.communityId.equals(params.communityId)) {
throw new BadRequestException('Community mismatch.');
}
this.assertCompetitionLifecycleMutable(match, 'reset the auction');
if (this.isRedisV1Auction(auction)) {
redisRuntimeToClear = {
auctionLifecycleId: auction.auctionLifecycleId,
matchId: params.matchId.toString(),
};
await this.resetMatchAfterAuctionCancellation(match, session);
await AuctionSideEffectApplicationModel.deleteMany({
auctionId: auction._id,
}).session(session);
await AuctionHistoryModel.deleteMany({
auctionId: auction._id,
}).session(session);
await auction.deleteOne({ session });
if (!auction) {
// 이미 커밋된 취소의 재전송이면 성공으로 응답하고 남은 Redis 정리만 재시도한다.
const cancelledMatch = params.clientObservedAuctionLifecycleId
? await MatchModel.findById(params.matchId).session(session)
: null;
if (
!cancelledMatch ||
cancelledMatch.lastCancelledAuctionLifecycleId !==
params.clientObservedAuctionLifecycleId
) {
throw new NotFoundException('Auction not found.');
}
if (!cancelledMatch.communityId.equals(params.communityId)) {
throw new BadRequestException('Community mismatch.');
}
cancelledMatch.auctionCancellationCleanupPending = true;
cancelledMatch.auctionCancellationCleanupRetryAt = new Date();
await cancelledMatch.save({ session });
} else {
await auction.deleteOne({ session });
await AuctionHistoryModel.deleteMany({
auctionId: auction._id,
}).session(session);
if (match.status === 'team-built') {
await this.tournamentCodeService.releaseFromMatch(match);
match.status = 'recruiting';
match.teams = [];
match.tournamentCodeIds = [];
match.gameSchedule = [];
match.participants.forEach((participant) => {
participant.excluded = false;
});
match.teamBuiltAt = undefined;
match.result = undefined;
match.resultPollState = undefined;
await match.save({ session });
if (
this.isRedisV1Auction(auction) &&
(!params.clientObservedAuctionLifecycleId ||
params.clientObservedAuctionLifecycleId !==
auction.auctionLifecycleId)
) {
throw new ConflictException(
'Auction lifecycle has changed. Refresh before cancelling.',
);
}
const match = await MatchModel.findById(params.matchId).session(
session,
);
if (!match) throw new NotFoundException('Match not found.');
if (!match.communityId.equals(params.communityId)) {
throw new BadRequestException('Community mismatch.');
}
this.assertCompetitionLifecycleMutable(match, 'reset the auction');
if (this.isRedisV1Auction(auction)) {
// 같은 트랜잭션에서 취소 완료를 기록해, 재전송을 멱등 처리한다.
match.lastCancelledAuctionLifecycleId = auction.auctionLifecycleId;
match.auctionCancellationCleanupPending = true;
match.auctionCancellationCleanupRetryAt = new Date();
match.auctionCancellationCleanupAttempts = 0;
match.auctionCancellationCleanupError = undefined;
await this.resetMatchAfterAuctionCancellation(match, session);
await AuctionSideEffectApplicationModel.deleteMany({
auctionId: auction._id,
}).session(session);
await AuctionHistoryModel.deleteMany({
auctionId: auction._id,
}).session(session);
await auction.deleteOne({ session });
} else {
await auction.deleteOne({ session });
await AuctionHistoryModel.deleteMany({
auctionId: auction._id,
}).session(session);
if (match.status === 'team-built') {
await this.tournamentCodeService.releaseFromMatch(match, session);
match.status = 'recruiting';
match.teams = [];
match.tournamentCodeIds = [];
match.gameSchedule = [];
match.participants.forEach((participant) => {
participant.excluded = false;
});
match.teamBuiltAt = undefined;
match.result = undefined;
match.resultPollState = undefined;
await match.save({ session });
}
}
}
await session.commitTransaction();
onCommitted();
} catch (err) {
await session.abortTransaction();
throw err;
} finally {
await session.endSession();
}
}
if (redisRuntimeToClear) {
await this.clearRedisAuctionRuntimeForLifecycle(
redisRuntimeToClear.matchId,
redisRuntimeToClear.auctionLifecycleId,
);
public async retryPendingCancellations(batchLimit = 20): Promise<void> {
const MatchModel = await this.connectionService.getModel('match');
const pending = await MatchModel.find({
auctionCancellationCleanupPending: true,
auctionCancellationCleanupRetryAt: { $lte: new Date() },
})
.sort({ auctionCancellationCleanupRetryAt: 1 })
.limit(batchLimit)
.lean()
.exec();
for (const match of pending) {
const lifecycle = match.lastCancelledAuctionLifecycleId;
if (!lifecycle) continue;
const filter = {
_id: match._id,
lastCancelledAuctionLifecycleId: lifecycle,
};
try {
await new AuctionLifecycleLock(this.auctionRedisService).run(
match._id.toString(),
async () => {
// Compare-and-delete in Redis also protects a newly started lifecycle.
await this.clearRedisAuctionRuntimeForLifecycle(
match._id.toString(),
lifecycle,
);
const AuctionModel =
await this.connectionService.getModel('auction');
if (!(await AuctionModel.exists({ matchId: match._id }))) {
this.auctionEventBusService?.broadcastReset(
match._id.toString(),
lifecycle,
);
}
await MatchModel.updateOne(filter, {
$set: { auctionCancellationCleanupPending: false },
$unset: {
auctionCancellationCleanupRetryAt: '',
auctionCancellationCleanupError: '',
},
});
},
);
} catch (error) {
const attempts = (match.auctionCancellationCleanupAttempts ?? 0) + 1;
await MatchModel.updateOne(filter, {
$set: {
auctionCancellationCleanupPending: true,
auctionCancellationCleanupRetryAt: new Date(
Date.now() + Math.min(60000, 1000 * 2 ** Math.min(attempts, 6)),
),
auctionCancellationCleanupError: String(error).slice(0, 2000),
},
$inc: { auctionCancellationCleanupAttempts: 1 },
});
this.logger.warn(
`Auction cancellation cleanup will retry for ${match._id.toString()}: ${String(error)}`,
);
}
}
}
@@ -1497,6 +1747,19 @@ export class AuctionService {
communityId: mongoose.Types.ObjectId;
sequence: number;
}): Promise<AuctionStateResponse> {
return new AuctionLifecycleLock(this.auctionRedisService).run(
params.matchId.toString(),
() => this.undoToLocked(params),
);
}
private async undoToLocked(
params: AuctionStructureActionRequestParams & {
matchId: mongoose.Types.ObjectId;
communityId: mongoose.Types.ObjectId;
sequence: number;
},
): Promise<AuctionStateResponse> {
const AuctionModel = await this.connectionService.getModel('auction');
const AuctionHistoryModel =
await this.connectionService.getModel('auctionHistory');
@@ -1508,6 +1771,7 @@ export class AuctionService {
}
let redisUndoContext: {
state?: Record<string, unknown>;
actionRequestParams?: AuctionStructureActionRequestParams;
auction: AuctionDocument;
snapshot: Record<string, unknown>;
@@ -1543,8 +1807,12 @@ export class AuctionService {
throw new BadRequestException('Auction history snapshot is invalid.');
}
const undoingCompletedAuction =
Boolean(auction.completedAt) && !('completedAt' in snapshot);
const liveState = this.isRedisV1Auction(auction)
? await this.requireRedisAuctionState(params.matchId.toString())
: undefined;
const undoingCompletedAuction = liveState
? liveState.phase === 'complete' && snapshot.phase !== 'complete'
: Boolean(auction.completedAt) && !('completedAt' in snapshot);
if (undoingCompletedAuction) {
this.assertCompetitionLifecycleMutable(
match,
@@ -1553,6 +1821,7 @@ export class AuctionService {
}
if (this.isRedisV1Auction(auction)) {
redisUndoContext = {
state: liveState,
auction,
actionRequestParams: params,
snapshot: snapshot,
@@ -1562,8 +1831,8 @@ export class AuctionService {
await session.commitTransaction();
} else {
if (undoingCompletedAuction) {
await this.tournamentCodeService.releaseFromMatch(match);
await this.tournamentResultService.cancelPolling(match);
await this.tournamentCodeService.releaseFromMatch(match, session);
await this.tournamentResultService.cancelPolling(match, session);
match.status = 'team-built';
match.result = undefined;
await match.save({ session });
@@ -1758,6 +2027,14 @@ export class AuctionService {
currentAuctionHistorySequence: auctionHistorySequence,
lastAppliedAuctionStateTransitionId: auctionStateTransitionId,
revision: expectedRevision + 1,
currentBidRoundId:
params.deadline.mode === 'set-relative'
? auctionStateTransitionId
: params.state.currentBidRoundId,
currentBidRoundDeadlineTimestampMS:
params.deadline.mode === 'remove'
? 0
: params.state.currentBidRoundDeadlineTimestampMS,
};
const afterAuctionMongoProjection =
this.buildAuctionMongoProjectionFromState(params.auction, afterState);
@@ -1769,8 +2046,18 @@ export class AuctionService {
if (matchSideEffectMutation.type !== 'none') {
afterAuctionMongoProjection.matchSideEffectStatus = 'pending';
afterAuctionMongoProjection.matchSideEffectRevision =
(params.auction.matchSideEffectRevision ?? 0) + 1;
Math.max(
params.auction.matchSideEffectRevision ?? 0,
this.numberFromState(params.state.matchSideEffectRevision),
) + 1;
afterAuctionMongoProjection.matchSideEffectError = undefined;
afterAuctionMongoProjection.matchSideEffectTransitionId =
auctionStateTransitionId;
params.liveStatePatch.matchSideEffectTransitionId =
auctionStateTransitionId;
params.liveStatePatch.matchSideEffectStatus = 'pending';
params.liveStatePatch.matchSideEffectRevision =
afterAuctionMongoProjection.matchSideEffectRevision as number;
}
const durabilityPayload = {
@@ -1925,6 +2212,7 @@ export class AuctionService {
}
private async undoRedisAuction(params: {
state?: Record<string, unknown>;
actionRequestParams?: AuctionStructureActionRequestParams;
auction: AuctionDocument;
snapshot: Record<string, unknown>;
@@ -1932,7 +2220,8 @@ export class AuctionService {
undoingCompletedAuction: boolean;
}): Promise<AuctionStateResponse> {
const matchId = params.auction.matchId.toString();
const state = await this.requireRedisAuctionState(matchId);
const state =
params.state ?? (await this.requireRedisAuctionState(matchId));
const actionRequest = await this.reserveRedisStructureActionRequest({
action: 'undo',
matchId,
@@ -2118,8 +2407,11 @@ export class AuctionService {
typeof auction.toObject === 'function'
? (auction.toObject({ depopulate: true }) as Record<string, unknown>)
: (auction as unknown as Record<string, unknown>);
const snapshotBase = this.cloneJson(base);
for (const field of AUCTION_OPTIONAL_PROJECTION_FIELDS)
delete snapshotBase[field];
return {
...this.cloneJson(base),
...snapshotBase,
...this.buildAuctionMongoProjectionFromState(auction, state),
_id: auction._id,
matchId: auction.matchId,
@@ -2145,6 +2437,7 @@ export class AuctionService {
);
const phase = this.stringFromState(state.phase) || 'presenting';
const projection: Record<string, unknown> = {
currentBidRoundId: state.currentBidRoundId || undefined,
auctionBidHistory,
auctionCompletedAtTimestampMS:
phase === 'complete' &&
@@ -2285,6 +2578,8 @@ export class AuctionService {
private formatRedisBidRejectCode(code: string): string {
switch (code) {
case 'BID_CLIENT_UPDATE_REQUIRED':
return '경매 화면이 업데이트되었습니다. 새로고침한 뒤 다시 입찰해 주세요.';
case 'PHASE':
return 'Auction is not in bidding phase.';
case 'STALE_BID_ROUND':
@@ -2515,6 +2810,52 @@ export class AuctionService {
return ordered.slice(0, desiredAuctionCount);
}
private async assertCompleteAuctionRoster(
matchId: mongoose.Types.ObjectId,
teams: Array<{
captainUserId: mongoose.Types.ObjectId;
members: Array<{ userId: mongoose.Types.ObjectId }>;
}>,
): Promise<void> {
const MatchModel = await this.connectionService.getModel('match');
const match = await MatchModel.findById(matchId);
if (!match) throw new NotFoundException('Match not found.');
// The queue can contain reauction entries or be corrupted; use the original roster.
const expectedIds = match.participants
.filter((participant) => !participant.excluded)
.map((participant) => participant.userId.toString());
const expected = new Set(expectedIds);
const assignedIds = teams.flatMap((team) => [
team.captainUserId.toString(),
...team.members.map((member) => member.userId.toString()),
]);
const assigned = new Set(assignedIds);
const missingUserIds = expectedIds.filter((id) => !assigned.has(id));
const unexpectedUserIds = [...assigned].filter((id) => !expected.has(id));
if (
expected.size === 0 ||
expected.size !== expectedIds.length ||
assigned.size !== assignedIds.length ||
missingUserIds.length > 0 ||
unexpectedUserIds.length > 0
) {
this.logger.error({
event: 'auction_roster_validation_failed',
matchId: matchId.toString(),
expectedCount: expectedIds.length,
assignedCount: assignedIds.length,
assignedUniqueCount: assigned.size,
missingUserIds,
unexpectedUserIds,
});
throw new BadRequestException({
code: 'AUCTION_ROSTER_INVALID',
message: 'Auction roster validation failed.',
});
}
}
private assertCaptainAssignments(
captains: StartAuctionParams['captains'],
activeParticipants: Array<{ userId: mongoose.Types.ObjectId }>,
@@ -2655,8 +2996,8 @@ export class AuctionService {
match: MatchDocument,
session: mongoose.ClientSession,
): Promise<void> {
await this.tournamentCodeService.releaseFromMatch(match);
await this.tournamentResultService.cancelPolling(match);
await this.tournamentCodeService.releaseFromMatch(match, session);
await this.tournamentResultService.cancelPolling(match, session);
match.status = 'recruiting';
match.teams = [];
match.tournamentCodeIds = [];
@@ -2671,6 +3012,11 @@ export class AuctionService {
}
private assertLiveAuctionOperationSupported(auction: AuctionDocument): void {
if (auction.startupCompleted === false) {
throw new ConflictException(
'Auction startup is not complete. Refresh to resume initialization.',
);
}
if (auction.auctionEngineVersion && !this.isRedisV1Auction(auction)) {
throw new BadRequestException(
'Legacy auction live operations are not supported.',
@@ -2835,7 +3181,7 @@ export class AuctionService {
auction.topTierThreshold ??
'NONE',
};
await this.auctionRedisCommandService.hydrateState(
const hydration = await this.auctionRedisCommandService.hydrateState(
auction.matchId.toString(),
{
auctionHistorySequence: auction.currentAuctionHistorySequence ?? 0,
@@ -2843,6 +3189,10 @@ export class AuctionService {
auction.auctionLifecycleId ??
`auction:${auction._id.toString()}:rehydrated`,
liveStatePatch: {
currentBidRoundId: auction.phase === 'bidding' ? randomUUID() : '',
matchSideEffectTransitionId: auction.matchSideEffectTransitionId,
matchSideEffectRevision: auction.matchSideEffectRevision,
matchSideEffectStatus: auction.matchSideEffectStatus,
...buildAuctionRedisLiveStatePatchFromStructure(structureInput),
currentHighestBidPointAmount:
auction.currentHighestBidPointAmount ?? auction.currentBid ?? 0,
@@ -2859,6 +3209,10 @@ export class AuctionService {
structureStateJson: stringifyAuctionRedisStructureState(structureInput),
},
);
if ('rejected' in hydration)
throw new ConflictException(
`Auction recovery failed: ${hydration.code}.`,
);
}
private async clearRedisAuctionRuntimeForLifecycle(
@@ -2879,10 +3233,10 @@ export class AuctionService {
' end',
'end',
"redis.call('ZREM', KEYS[2], ARGV[1])",
"redis.call('DEL', KEYS[1], KEYS[3], KEYS[4], KEYS[5], KEYS[6], KEYS[7], KEYS[8], KEYS[9], KEYS[10], KEYS[11])",
"redis.call('DEL', KEYS[1], KEYS[3], KEYS[4], KEYS[5], KEYS[6], KEYS[7], KEYS[8], KEYS[9], KEYS[10], KEYS[11], KEYS[12])",
'return 1',
].join('\n'),
'11',
'12',
keys.liveStateKey,
keys.deadlineQueueKey,
keys.structureStateKey,
@@ -2894,6 +3248,7 @@ export class AuctionService {
keys.actionRequestResultOrderKey,
keys.rehydrateLockKey,
keys.stateTransitionLockKey,
keys.rejectedBidRequestResultOrderKey,
matchId,
expectedAuctionLifecycleId ?? '',
]);
@@ -2925,54 +3280,16 @@ export class AuctionService {
const payloadKeys = Array.isArray(reply[1]) ? reply[1].map(String) : [];
if (payloadKeys.length === 0) continue;
const values = await this.auctionRedisService
.raw()
.sendCommand(['MGET', ...payloadKeys]);
const payloadKeysToDelete = payloadKeys.filter((payloadKey, index) =>
this.shouldDeleteRedisDurabilityPayload(
Array.isArray(values) ? values[index] : undefined,
expectedAuctionLifecycleId,
payloadKey,
),
);
if (payloadKeysToDelete.length === 0) continue;
await this.auctionRedisService
.raw()
.sendCommand([
'ZREM',
await this.auctionRedisService.evalScript(
AUCTION_CLEANUP_DURABILITY_SCRIPT,
[
keys.durabilityRetryQueueKey,
...payloadKeysToDelete,
]);
await this.auctionRedisService
.raw()
.sendCommand([
'ZREM',
keys.durabilityDeadLetterQueueKey,
...payloadKeysToDelete,
]);
await this.auctionRedisService
.raw()
.sendCommand(['DEL', ...payloadKeysToDelete]);
} while (cursor !== '0');
}
private shouldDeleteRedisDurabilityPayload(
payloadValue: unknown,
expectedAuctionLifecycleId: string | undefined,
payloadKey: string,
): boolean {
if (!expectedAuctionLifecycleId) return true;
if (typeof payloadValue !== 'string') return false;
try {
const payload = JSON.parse(payloadValue) as Record<string, unknown>;
return payload.auctionLifecycleId === expectedAuctionLifecycleId;
} catch {
this.logger.warn(
`Failed to parse auction durability payload ${payloadKey}.`,
...payloadKeys,
],
[expectedAuctionLifecycleId ?? ''],
);
return false;
}
} while (cursor !== '0');
}
private enqueueBackgroundOrderEnrichment(params: {
@@ -72,6 +72,10 @@ export class StartAuctionDto {
}
export class PlaceBidDto {
@IsOptional()
@IsString()
clientObservedBidRoundId?: string;
@IsOptional()
@IsUUID()
bidRequestId?: string;
@@ -210,21 +210,25 @@ describe('AuctionRedisCommandService', () => {
it('parses apply transition replay and rejected replies', async () => {
await expect(
makeService(['REPLAY', 'APPLIED', 'transition-1', '2100'])
.service.applyTransition('match-1', {
afterAuctionStructureStateJson: '{}',
auctionHistorySequence: 5,
auctionLifecycleId: 'life-1',
auctionStateTransitionId: 'transition-1',
broadcastStateRevision: 11,
deadline: { mode: 'none' },
durabilityPayloadJson: '{}',
expectedPhase: 'sold',
expectedRevision: 10,
liveStatePatch: {},
matchId: 'match-1',
shouldBroadcastState: false,
}),
makeService([
'REPLAY',
'APPLIED',
'transition-1',
'2100',
]).service.applyTransition('match-1', {
afterAuctionStructureStateJson: '{}',
auctionHistorySequence: 5,
auctionLifecycleId: 'life-1',
auctionStateTransitionId: 'transition-1',
broadcastStateRevision: 11,
deadline: { mode: 'none' },
durabilityPayloadJson: '{}',
expectedPhase: 'sold',
expectedRevision: 10,
liveStatePatch: {},
matchId: 'match-1',
shouldBroadcastState: false,
}),
).resolves.toEqual({
auctionStateTransitionId: 'transition-1',
currentServerTimestampMS: 2100,
@@ -233,21 +237,25 @@ describe('AuctionRedisCommandService', () => {
});
await expect(
makeService(['REJECTED', 'CONFLICT', 'transition-1', '2200'])
.service.applyTransition('match-1', {
afterAuctionStructureStateJson: '{}',
auctionHistorySequence: 5,
auctionLifecycleId: 'life-1',
auctionStateTransitionId: 'transition-1',
broadcastStateRevision: 11,
deadline: { mode: 'none' },
durabilityPayloadJson: '{}',
expectedPhase: 'sold',
expectedRevision: 10,
liveStatePatch: {},
matchId: 'match-1',
shouldBroadcastState: false,
}),
makeService([
'REJECTED',
'CONFLICT',
'transition-1',
'2200',
]).service.applyTransition('match-1', {
afterAuctionStructureStateJson: '{}',
auctionHistorySequence: 5,
auctionLifecycleId: 'life-1',
auctionStateTransitionId: 'transition-1',
broadcastStateRevision: 11,
deadline: { mode: 'none' },
durabilityPayloadJson: '{}',
expectedPhase: 'sold',
expectedRevision: 10,
liveStatePatch: {},
matchId: 'match-1',
shouldBroadcastState: false,
}),
).resolves.toEqual({
auctionStateTransitionId: 'transition-1',
code: 'CONFLICT',
@@ -288,12 +296,17 @@ describe('AuctionRedisCommandService', () => {
it('parses expire prepare replay and noop replies', async () => {
await expect(
makeService(['REPLAY', 'passed', 'expire-1', '12', '3100'])
.service.expirePrepare('match-1', {
auctionStateTransitionId: 'expire-1',
bidRoundExpiryRetryDelayMS: 3000,
matchId: 'match-1',
}),
makeService([
'REPLAY',
'passed',
'expire-1',
'12',
'3100',
]).service.expirePrepare('match-1', {
auctionStateTransitionId: 'expire-1',
bidRoundExpiryRetryDelayMS: 3000,
matchId: 'match-1',
}),
).resolves.toMatchObject({
auctionStateTransitionId: 'expire-1',
bidRoundExpiryDecision: 'passed',
@@ -360,16 +373,19 @@ describe('AuctionRedisCommandService', () => {
});
await expect(
makeService(['REJECTED', 'INVALID_PATCH_ARITY', '4200'])
.service.hydrateState('match-1', {
auctionHistorySequence: 3,
auctionLifecycleId: 'life-1',
maximumBidRoundDurationSeconds: 30,
matchId: 'match-1',
phase: 'presenting',
revision: 6,
structureStateJson: '{}',
}),
makeService([
'REJECTED',
'INVALID_PATCH_ARITY',
'4200',
]).service.hydrateState('match-1', {
auctionHistorySequence: 3,
auctionLifecycleId: 'life-1',
maximumBidRoundDurationSeconds: 30,
matchId: 'match-1',
phase: 'presenting',
revision: 6,
structureStateJson: '{}',
}),
).resolves.toEqual({
code: 'INVALID_PATCH_ARITY',
currentServerTimestampMS: 4200,
@@ -85,7 +85,9 @@ export function stringifyAuctionRedisStructureState(
return JSON.stringify(buildAuctionRedisStructureState(input));
}
function countAuctionTeamMembersIncludingCaptain(team: RedisAuctionTeam): number {
function countAuctionTeamMembersIncludingCaptain(
team: RedisAuctionTeam,
): number {
const userIds = new Set<string>([team.captainUserId.toString()]);
for (const member of team.members) {
userIds.add(member.userId.toString());
@@ -1,10 +1,19 @@
import { AuctionRedisService } from './auction-redis.service';
import { AuctionRedisStateReaderService } from './auction-redis-state-reader.service';
function makeService(commandReplies: unknown[], currentServerTimestampMS = 1000) {
function makeService(
commandReplies: unknown[],
currentServerTimestampMS = 1000,
) {
const sendCommand = jest
.fn()
.mockImplementation(() => Promise.resolve(commandReplies.shift()));
.mockImplementation((command: string[]) =>
Promise.resolve(
command[0] === 'EVAL'
? [currentServerTimestampMS, ...commandReplies.splice(0, 3)]
: commandReplies.shift(),
),
);
const auctionRedisService = {
getCurrentRedisTimestampMS: jest
.fn()
@@ -122,19 +131,14 @@ describe('AuctionRedisStateReaderService', () => {
});
expect(view).not.toHaveProperty('team:2:remainingBidPointAmount');
expect(view).not.toHaveProperty('bidRoundExpiryDecision');
expect(sendCommand).toHaveBeenNthCalledWith(1, [
'HGETALL',
expect(sendCommand).toHaveBeenCalledTimes(1);
expect(sendCommand).toHaveBeenCalledWith([
'EVAL',
expect.stringContaining("redis.call('TIME')"),
'3',
'auction:match-1:liveAuctionState',
]);
expect(sendCommand).toHaveBeenNthCalledWith(2, [
'GET',
'auction:match-1:auctionStructureState',
]);
expect(sendCommand).toHaveBeenNthCalledWith(3, [
'LRANGE',
'auction:match-1:auctionBidHistory',
'0',
'-1',
]);
});
@@ -149,7 +153,9 @@ describe('AuctionRedisStateReaderService', () => {
[],
]);
await expect(service.readAuctionStateView('match-1')).resolves.toMatchObject({
await expect(
service.readAuctionStateView('match-1'),
).resolves.toMatchObject({
auctionLifecycleId: 'life-1',
auctionTeams: [],
phase: 'presenting',
@@ -181,7 +187,6 @@ describe('AuctionRedisStateReaderService', () => {
});
});
it('returns null when live or structure state is absent', async () => {
await expect(
makeService([[], '{"auctionTeams":[]}', []]).service.readAuctionStateView(
@@ -42,12 +42,14 @@ export class AuctionRedisStateReaderService {
matchId: string,
): Promise<AuctionRedisLiveStateIdentity | null> {
const keys = buildAuctionRedisKeys(matchId);
const reply = await this.auctionRedisService.raw().sendCommand([
'HMGET',
keys.liveStateKey,
'auctionLifecycleId',
'revision',
]);
const reply = await this.auctionRedisService
.raw()
.sendCommand([
'HMGET',
keys.liveStateKey,
'auctionLifecycleId',
'revision',
]);
if (!Array.isArray(reply)) return null;
const auctionLifecycleId =
typeof reply[0] === 'string' && reply[0] ? reply[0] : undefined;
@@ -68,14 +70,16 @@ export class AuctionRedisStateReaderService {
): Promise<AuctionRedisBidContext | null> {
const keys = buildAuctionRedisKeys(matchId);
const bidderTeamCaptainUserIdField = `team:${bidderTeamIndex}:captainUserId`;
const liveReply = await this.auctionRedisService.raw().sendCommand([
'HMGET',
keys.liveStateKey,
'phase',
'auctionLifecycleId',
'currentBidRoundPlayerUserId',
bidderTeamCaptainUserIdField,
]);
const liveReply = await this.auctionRedisService
.raw()
.sendCommand([
'HMGET',
keys.liveStateKey,
'phase',
'auctionLifecycleId',
'currentBidRoundPlayerUserId',
bidderTeamCaptainUserIdField,
]);
if (!Array.isArray(liveReply)) return null;
const phase = stringValue(liveReply[0]);
@@ -102,18 +106,16 @@ export class AuctionRedisStateReaderService {
options: AuctionRedisStateViewReadOptions = {},
): Promise<Record<string, unknown> | null> {
const keys = buildAuctionRedisKeys(matchId);
const [currentServerTimestampMS, liveReply, structureStateJson, bidEntries] =
await Promise.all([
this.auctionRedisService.getCurrentRedisTimestampMS(),
this.auctionRedisService.raw().sendCommand(['HGETALL', keys.liveStateKey]),
this.auctionRedisService.raw().sendCommand(['GET', keys.structureStateKey]),
this.auctionRedisService.raw().sendCommand([
'LRANGE',
keys.bidHistoryKey,
'0',
'-1',
]),
]);
const [
currentServerTimestampMS,
liveReply,
structureStateJson,
bidEntries,
] = await this.auctionRedisService
.raw()
.sendCommand<
unknown[]
>(['EVAL', ["local now = redis.call('TIME')", 'local timestamp = tonumber(now[1]) * 1000 + math.floor(tonumber(now[2]) / 1000)', "return {tostring(timestamp), redis.call('HGETALL', KEYS[1]), redis.call('GET', KEYS[2]), redis.call('LRANGE', KEYS[3], 0, -1)}"].join('\n'), '3', keys.liveStateKey, keys.structureStateKey, keys.bidHistoryKey]);
const liveState = parseHashReply(liveReply, {
includeInternalLiveStateFields:
@@ -135,14 +137,14 @@ export class AuctionRedisStateReaderService {
auctionBidHistoryEntries: Array.isArray(bidEntries)
? bidEntries.map(String)
: [],
currentServerTimestampMS,
currentServerTimestampMS: Number(currentServerTimestampMS),
liveState: liveState as Record<string, unknown> & {
auctionLifecycleId: string;
phase: string;
revision: number;
},
shouldForceAuctionStateResync: options.shouldForceAuctionStateResync,
structureState: JSON.parse(structureStateJson) as Record<string, unknown>,
structureState: parseJsonRecord(structureStateJson),
});
view.matchId = matchId;
if (options.includeInternalLiveStateFields) {
@@ -161,12 +163,9 @@ export class AuctionRedisStateReaderService {
if (typeof structureStateJson !== 'string' || !structureStateJson) {
return undefined;
}
const structureState = JSON.parse(structureStateJson) as Record<
string,
unknown
>;
const auctionTeams = Array.isArray(structureState.auctionTeams)
? structureState.auctionTeams
const structureState = parseJsonRecord(structureStateJson);
const auctionTeams: unknown[] = Array.isArray(structureState.auctionTeams)
? (structureState.auctionTeams as unknown[])
: [];
const bidderTeam = auctionTeams.find((entry) => {
if (!entry || typeof entry !== 'object') return false;
@@ -183,6 +182,13 @@ function stringValue(value: unknown): string | undefined {
return typeof value === 'string' && value ? value : undefined;
}
function parseJsonRecord(json: string): Record<string, unknown> {
const value: unknown = JSON.parse(json);
return typeof value === 'object' && value !== null
? (value as Record<string, unknown>)
: {};
}
function parseHashReply(
reply: unknown,
options: { includeInternalLiveStateFields?: boolean } = {},
@@ -210,7 +216,10 @@ function parseHashEntries(
): Record<string, unknown> {
const result: Record<string, unknown> = {};
for (const [field, rawValue] of entries) {
if (!options.includeInternalLiveStateFields && isInternalLiveStateField(field)) {
if (
!options.includeInternalLiveStateFields &&
isInternalLiveStateField(field)
) {
continue;
}
const value = String(rawValue);
@@ -46,6 +46,7 @@ describe('auction apply transition redis script contract', () => {
'auction:match-1:bidRequestResults',
'auction:match-1:bidRequestResultOrder',
'auction:bidRoundDeadlineQueue',
'auction:match-1:rejectedBidRequestResultOrder',
]);
expect(invocation.values.slice(0, 19)).toEqual([
'match-1',
@@ -91,9 +92,7 @@ describe('auction apply transition redis script contract', () => {
expect(AUCTION_APPLY_TRANSITION_SCRIPT.lua).toContain(
'shouldBroadcastState',
);
expect(AUCTION_APPLY_TRANSITION_SCRIPT.lua).toContain(
"redis.call('SADD'",
);
expect(AUCTION_APPLY_TRANSITION_SCRIPT.lua).toContain("redis.call('SADD'");
expect(AUCTION_APPLY_TRANSITION_SCRIPT.lua).toContain(
"redis.call('HINCRBY'",
);
@@ -79,6 +79,7 @@ export function buildAuctionApplyTransitionScriptInvocation(
keys.bidRequestResultsKey,
keys.bidRequestResultOrderKey,
keys.deadlineQueueKey,
keys.rejectedBidRequestResultOrderKey,
],
script: AUCTION_APPLY_TRANSITION_SCRIPT,
values: [
@@ -128,6 +129,7 @@ local auctionBidHistoryKey = KEYS[8]
local bidRequestResultsKey = KEYS[9]
local bidRequestResultOrderKey = KEYS[10]
local bidRoundDeadlineQueueKey = KEYS[11]
local rejectedBidRequestResultOrderKey = KEYS[12]
local matchId = ARGV[1]
local auctionLifecycleId = ARGV[2]
@@ -270,16 +272,27 @@ for i = 1, liveStatePatchPairCount do
end
redis.call('HSET', unpack(hsetArgs))
local committedBidRoundDeadlineTimestampMS = ''
if deadlineMode == 'set-relative' then
local currentBidRoundDeadlineTimestampMS = currentRedisTimestampMS + (deadlineDurationSeconds * 1000)
committedBidRoundDeadlineTimestampMS = tostring(currentBidRoundDeadlineTimestampMS)
redis.call('HSET', liveAuctionStateKey, 'currentBidRoundDeadlineTimestampMS', tostring(currentBidRoundDeadlineTimestampMS))
redis.call('HSET', liveAuctionStateKey, 'currentBidRoundId', auctionStateTransitionId)
redis.call('ZADD', bidRoundDeadlineQueueKey, currentBidRoundDeadlineTimestampMS, matchId)
elseif deadlineMode == 'remove' then
redis.call('ZREM', bidRoundDeadlineQueueKey, matchId)
redis.call('HDEL', liveAuctionStateKey, 'currentBidRoundDeadlineTimestampMS')
end
-- A resumed auction must not disappear when its former completion TTL elapses.
if redis.call('HGET', liveAuctionStateKey, 'phase') ~= 'complete' then
for _, index in ipairs({1, 2, 3, 6, 7, 8, 9, 10, 12}) do
redis.call('PERSIST', KEYS[index])
end
end
if shouldResetBidRuntime == '1' then
redis.call('DEL', auctionBidHistoryKey, bidRequestResultsKey, bidRequestResultOrderKey)
redis.call('DEL', auctionBidHistoryKey, bidRequestResultsKey, bidRequestResultOrderKey, rejectedBidRequestResultOrderKey)
end
redis.call('SADD', appliedAuctionStateTransitionIdsKey, transitionDedupeMember)
@@ -288,6 +301,8 @@ redis.call(
durabilityPayloadKey,
'payloadJson',
durabilityPayloadJson,
'committedBidRoundDeadlineTimestampMS',
committedBidRoundDeadlineTimestampMS,
'preparedAtRedisTimestampMS',
tostring(currentRedisTimestampMS),
'committedAtRedisTimestampMS',
@@ -317,7 +332,7 @@ if actionRequestScopeKey ~= '' then
actionRequestPrefix .. 'responseServerTimestampMS',
tostring(currentRedisTimestampMS)
)
redis.call('RPUSH', auctionActionRequestResultOrderKey, actionRequestScopeKey)
-- The reservation already inserted this request into the order list.
end
return {'OK', auctionStateTransitionId, tostring(newRevision), tostring(currentRedisTimestampMS)}
@@ -30,6 +30,9 @@ describe('auction bid redis script contract', () => {
'auction:match-1:bidRequestResults',
'auction:match-1:bidRequestResultOrder',
'auction:bidRoundDeadlineQueue',
'auction:match-1:rejectedBidRequestResultOrder',
'auction:bidArchiveQueue',
'auction:bidArchivePayloads',
]);
expect(invocation.values).toEqual([
'match-1',
@@ -45,6 +48,7 @@ describe('auction bid redis script contract', () => {
'100',
'60000',
'200',
'',
]);
});
@@ -64,9 +68,7 @@ describe('auction bid redis script contract', () => {
expect(AUCTION_BID_SCRIPT.lua).toContain("redis.call('TIME')");
expect(AUCTION_BID_SCRIPT.lua).toContain("redis.call('HINCRBY'");
expect(AUCTION_BID_SCRIPT.lua).toContain('BID_REQUEST_RESULT_LIMIT');
expect(AUCTION_BID_SCRIPT.lua).toContain(
'currentHighestBidPointAmount',
);
expect(AUCTION_BID_SCRIPT.lua).toContain('currentHighestBidPointAmount');
expect(AUCTION_BID_SCRIPT.lua).not.toContain('cjson.decode');
});
});
@@ -1,4 +1,8 @@
import type { AuctionRedisKeys } from './auction-redis.keys';
import {
AUCTION_BID_ARCHIVE_QUEUE_KEY,
AUCTION_BID_ARCHIVE_PAYLOADS_KEY,
} from './auction-redis.keys';
import { defineAuctionRedisScript } from './auction-redis.scripts';
export interface AuctionBidScriptInput {
@@ -8,6 +12,7 @@ export interface AuctionBidScriptInput {
bidderUserId: string;
clientObservedAuctionLifecycleId: string;
clientObservedCurrentBidRoundPlayerUserId: string;
clientObservedBidRoundId?: string;
maximumAuctionTeamMemberCount: number;
maximumStoredAuctionBidHistoryCount: number;
maximumStoredBidRequestResultCount: number;
@@ -40,15 +45,19 @@ export function buildBidRequestPayloadFingerprint(params: {
bidPointAmount: number;
clientObservedAuctionLifecycleId: string;
clientObservedCurrentBidRoundPlayerUserId: string;
clientObservedBidRoundId?: string;
matchId: string;
}): string {
return [
const parts = [
params.matchId,
params.clientObservedAuctionLifecycleId,
params.clientObservedCurrentBidRoundPlayerUserId,
params.bidderTeamIndex,
params.bidPointAmount,
].join('|');
];
if (params.clientObservedBidRoundId)
parts.push(params.clientObservedBidRoundId);
return parts.join('|');
}
export function buildAuctionBidScriptInvocation(
@@ -62,6 +71,9 @@ export function buildAuctionBidScriptInvocation(
keys.bidRequestResultsKey,
keys.bidRequestResultOrderKey,
keys.deadlineQueueKey,
keys.rejectedBidRequestResultOrderKey,
AUCTION_BID_ARCHIVE_QUEUE_KEY,
AUCTION_BID_ARCHIVE_PAYLOADS_KEY,
],
script: AUCTION_BID_SCRIPT,
values: [
@@ -78,6 +90,7 @@ export function buildAuctionBidScriptInvocation(
String(input.maximumStoredBidRequestResultCount),
String(input.minimumBidRequestResultReplayWindowMS),
String(input.maximumStoredAuctionBidHistoryCount),
input.clientObservedBidRoundId ?? '',
],
};
}
@@ -90,6 +103,9 @@ local auctionBidHistoryKey = KEYS[2]
local bidRequestResultsKey = KEYS[3]
local bidRequestResultOrderKey = KEYS[4]
local bidRoundDeadlineQueueKey = KEYS[5]
local rejectedBidRequestResultOrderKey = KEYS[6]
local bidArchiveQueueKey = KEYS[7]
local bidArchivePayloadsKey = KEYS[8]
local matchId = ARGV[1]
local bidderTeamIndex = ARGV[2]
@@ -104,6 +120,7 @@ local bidRequestPayloadFingerprint = ARGV[10]
local maximumStoredBidRequestResultCount = tonumber(ARGV[11])
local minimumBidRequestResultReplayWindowMS = tonumber(ARGV[12])
local maximumStoredAuctionBidHistoryCount = tonumber(ARGV[13])
local clientObservedBidRoundId = ARGV[14] or ''
local redisTime = redis.call('TIME')
local currentRedisTimestampMS = (tonumber(redisTime[1]) * 1000) + math.floor(tonumber(redisTime[2]) / 1000)
@@ -168,12 +185,23 @@ if existingFingerprint then
return replayExistingRequest()
end
trimOldBidRequestResults()
if redis.call('LLEN', bidRequestResultOrderKey) >= maximumStoredBidRequestResultCount then
return {'REJECTED', 'BID_REQUEST_RESULT_LIMIT', bidRequestId, tostring(currentRedisTimestampMS)}
-- Upgrade the old shared queue once, preserving every accepted replay record.
if redis.call('HSETNX', bidRequestResultsKey, '_acceptedOnlyOrderV1', '1') == 1 then
for _, oldRequestId in ipairs(redis.call('LRANGE', bidRequestResultOrderKey, 0, -1)) do
if redis.call('HGET', bidRequestResultsKey, oldRequestId .. ':status') == 'rejected' then
redis.call('LREM', bidRequestResultOrderKey, 0, oldRequestId)
hdelBidRequest(oldRequestId)
end
end
end
local function storeRejectedRequest(rejectCode)
-- Rejections have their own bounded retention. They must never consume the
-- protected replay capacity of accepted bids.
while redis.call('LLEN', rejectedBidRequestResultOrderKey) >= maximumStoredBidRequestResultCount do
local oldest = redis.call('LPOP', rejectedBidRequestResultOrderKey)
if oldest then hdelBidRequest(oldest) end
end
local rejectedCurrentBidRoundDeadlineTimestampMS = redis.call('HGET', liveAuctionStateKey, 'currentBidRoundDeadlineTimestampMS') or ''
redis.call(
'HSET',
@@ -191,7 +219,7 @@ local function storeRejectedRequest(rejectCode)
requestField('createdAtTimestampMS'),
tostring(currentRedisTimestampMS)
)
redis.call('RPUSH', bidRequestResultOrderKey, bidRequestId)
redis.call('RPUSH', rejectedBidRequestResultOrderKey, bidRequestId)
return {'REJECTED', rejectCode, bidRequestId, tostring(currentRedisTimestampMS), rejectedCurrentBidRoundDeadlineTimestampMS}
end
@@ -202,9 +230,16 @@ end
local auctionLifecycleId = redis.call('HGET', liveAuctionStateKey, 'auctionLifecycleId')
local currentBidRoundPlayerUserId = redis.call('HGET', liveAuctionStateKey, 'currentBidRoundPlayerUserId')
local currentBidRoundId = redis.call('HGET', liveAuctionStateKey, 'currentBidRoundId') or ''
if currentBidRoundId ~= '' and clientObservedBidRoundId == '' then
return storeRejectedRequest('BID_CLIENT_UPDATE_REQUIRED')
end
if auctionLifecycleId ~= clientObservedAuctionLifecycleId or currentBidRoundPlayerUserId ~= clientObservedCurrentBidRoundPlayerUserId then
return storeRejectedRequest('STALE_BID_ROUND')
end
if currentBidRoundId ~= clientObservedBidRoundId then
return storeRejectedRequest('STALE_BID_ROUND')
end
local currentBidRoundDeadlineTimestampMS = tonumber(redis.call('HGET', liveAuctionStateKey, 'currentBidRoundDeadlineTimestampMS') or '0')
if currentBidRoundDeadlineTimestampMS <= currentRedisTimestampMS then
@@ -235,8 +270,9 @@ if bidPointAmount + requiredReserveAfterBid > remainingBidPointAmount then
return storeRejectedRequest('INSUFFICIENT')
end
if redis.call('LLEN', auctionBidHistoryKey) >= maximumStoredAuctionBidHistoryCount then
return storeRejectedRequest('BID_HISTORY_LIMIT')
trimOldBidRequestResults()
if redis.call('LLEN', bidRequestResultOrderKey) >= maximumStoredBidRequestResultCount then
return {'REJECTED', 'BID_REQUEST_RESULT_LIMIT', bidRequestId, tostring(currentRedisTimestampMS)}
end
local maximumBidRoundDurationSeconds = tonumber(redis.call('HGET', liveAuctionStateKey, 'maximumBidRoundDurationSeconds') or '0')
@@ -254,14 +290,36 @@ end
local nextBidRoundDeadlineTimestampMS = currentRedisTimestampMS + nextRemainingBidRoundTimeMS
local revision = redis.call('HINCRBY', liveAuctionStateKey, 'revision', 1)
local auctionBidHistoryEntryJson =
'{"bidderTeamIndex":' .. bidderTeamIndex ..
',"bidPointAmount":' .. tostring(bidPointAmount) ..
',"bidderUserId":"' .. bidderUserId ..
'","bidPlacedAtTimestampMS":' .. tostring(currentRedisTimestampMS) ..
'}'
local auctionBidHistoryEntryJson = cjson.encode({
bidRequestId = bidRequestId,
revision = revision,
bidderTeamIndex = tonumber(bidderTeamIndex),
bidPointAmount = bidPointAmount,
bidderUserId = bidderUserId,
playerUserId = currentBidRoundPlayerUserId,
bidRoundId = currentBidRoundId,
bidPlacedAtTimestampMS = currentRedisTimestampMS
})
-- Accepted replay returns above this point. Persist every accepted event before
-- trimming the recent view; the durable archive worker removes only saved events.
local archiveId = matchId .. ':' .. auctionLifecycleId .. ':' .. string.format('%016d', revision)
redis.call('HSET', bidArchivePayloadsKey, archiveId, cjson.encode({
_id = archiveId,
matchId = matchId,
auctionLifecycleId = auctionLifecycleId,
revision = revision,
bidRequestId = bidRequestId,
bidderTeamIndex = tonumber(bidderTeamIndex),
bidPointAmount = bidPointAmount,
bidderUserId = bidderUserId,
playerUserId = currentBidRoundPlayerUserId,
bidRoundId = currentBidRoundId,
bidPlacedAtTimestampMS = currentRedisTimestampMS
}))
redis.call('ZADD', bidArchiveQueueKey, currentRedisTimestampMS, archiveId)
redis.call('RPUSH', auctionBidHistoryKey, auctionBidHistoryEntryJson)
redis.call('LTRIM', auctionBidHistoryKey, -maximumStoredAuctionBidHistoryCount, -1)
redis.call(
'HSET',
liveAuctionStateKey,
@@ -0,0 +1,27 @@
import { defineAuctionRedisScript } from './auction-redis.scripts';
// Compare the lifecycle and remove the payload and its indexes atomically.
export const AUCTION_CLEANUP_DURABILITY_SCRIPT = defineAuctionRedisScript(
'auction.cleanupDurability',
`
local deleted = 0
for i = 3, #KEYS do
local key = KEYS[i]
local keyType = redis.call('TYPE', key).ok
local matches = ARGV[1] == ''
if not matches and keyType == 'hash' then
matches = redis.call('HGET', key, 'auctionLifecycleId') == ARGV[1]
elseif not matches and keyType == 'string' then
-- Retain compatibility with payloads written before the Hash format.
local ok, payload = pcall(cjson.decode, redis.call('GET', key))
matches = ok and type(payload) == 'table' and payload.auctionLifecycleId == ARGV[1]
end
if matches then
redis.call('ZREM', KEYS[1], key)
redis.call('ZREM', KEYS[2], key)
deleted = deleted + redis.call('UNLINK', key)
end
end
return deleted
`,
);
@@ -3,9 +3,11 @@ import { buildAuctionRedisKeys } from './auction-redis.keys';
describe('auction redis keys', () => {
it('builds lifecycle-safe key names from match id', () => {
expect(buildAuctionRedisKeys('match-1')).toMatchObject({
actionRequestResultOrderKey: 'auction:match-1:auctionActionRequestResultOrder',
actionRequestResultOrderKey:
'auction:match-1:auctionActionRequestResultOrder',
actionRequestResultsKey: 'auction:match-1:auctionActionRequestResults',
appliedTransitionIdsKey: 'auction:match-1:appliedAuctionStateTransitionIds',
appliedTransitionIdsKey:
'auction:match-1:appliedAuctionStateTransitionIds',
bidHistoryKey: 'auction:match-1:auctionBidHistory',
bidRequestResultOrderKey: 'auction:match-1:bidRequestResultOrder',
bidRequestResultsKey: 'auction:match-1:bidRequestResults',
@@ -4,6 +4,14 @@ export const AUCTION_DURABILITY_RETRY_QUEUE_KEY =
'auction:auctionDurabilityRetryQueue';
export const AUCTION_DURABILITY_DEAD_LETTER_QUEUE_KEY =
'auction:auctionDurabilityDeadLetterQueue';
export const AUCTION_DEAD_LETTER_STATUS_QUEUE_KEY =
'auction:deadLetterStatusQueue';
export const AUCTION_BID_ARCHIVE_QUEUE_KEY = 'auction:bidArchiveQueue';
export const AUCTION_BID_ARCHIVE_PAYLOADS_KEY = 'auction:bidArchivePayloads';
export const AUCTION_BID_ARCHIVE_DEAD_LETTER_QUEUE_KEY =
'auction:bidArchiveDeadLetterQueue';
export const AUCTION_BID_ARCHIVE_DEAD_LETTER_PAYLOADS_KEY =
'auction:bidArchiveDeadLetterPayloads';
export interface AuctionRedisKeys {
actionRequestResultOrderKey: string;
@@ -12,6 +20,7 @@ export interface AuctionRedisKeys {
bidHistoryKey: string;
bidRequestResultOrderKey: string;
bidRequestResultsKey: string;
rejectedBidRequestResultOrderKey: string;
deadlineQueueKey: string;
durabilityDeadLetterQueueKey: string;
durabilityPayloadKey: (auctionStateTransitionId: string) => string;
@@ -33,6 +42,7 @@ export function buildAuctionRedisKeys(matchId: string): AuctionRedisKeys {
bidHistoryKey: `${prefix}:auctionBidHistory`,
bidRequestResultOrderKey: `${prefix}:bidRequestResultOrder`,
bidRequestResultsKey: `${prefix}:bidRequestResults`,
rejectedBidRequestResultOrderKey: `${prefix}:rejectedBidRequestResultOrder`,
deadlineQueueKey: AUCTION_BID_ROUND_DEADLINE_QUEUE_KEY,
durabilityDeadLetterQueueKey: AUCTION_DURABILITY_DEAD_LETTER_QUEUE_KEY,
durabilityPayloadKey: (auctionStateTransitionId: string) =>
@@ -2,10 +2,7 @@ import { Logger, Module } from '@nestjs/common';
import { createClient } from 'redis';
import { SecretModule } from '../../global/secret/secret.module';
import { SecretService } from '../../global/secret/secret.service';
import {
assertDistinctRedisInstances,
resolveRedisClientOptions,
} from '../../global/redis/redis.config';
import { loadRedisClientOptions } from '../../global/redis/redis.config';
import { AUCTION_REDIS_CLIENT } from './auction-redis.constants';
import {
AuctionRedisService,
@@ -14,18 +11,6 @@ import {
import { AuctionRedisCommandService } from './auction-redis-command.service';
import { AuctionRedisStateReaderService } from './auction-redis-state-reader.service';
async function readFirstSecret(
secretService: SecretService,
keys: string[],
): Promise<string | undefined> {
for (const key of keys) {
const value = await secretService.get<string>(key, '');
const trimmed = value.trim();
if (trimmed) return trimmed;
}
return undefined;
}
@Module({
imports: [SecretModule],
providers: [
@@ -35,48 +20,15 @@ async function readFirstSecret(
useFactory: async (
secretService: SecretService,
): Promise<AuctionRedisClient> => {
await secretService.ready();
const [
redisUrl,
redisEndpoint,
auctionRedisUrl,
auctionRedisEndpoint,
auctionRedisUsername,
auctionRedisPassword,
] = await Promise.all([
readFirstSecret(secretService, ['REDIS_URL', 'GARNET_URL']),
readFirstSecret(secretService, ['REDIS_ENDPOINT', 'GARNET_ENDPOINT']),
readFirstSecret(secretService, ['AUCTION_REDIS_URL']),
readFirstSecret(secretService, ['AUCTION_REDIS_ENDPOINT']),
readFirstSecret(secretService, [
'AUCTION_REDIS_USERNAME',
'AUCTION_REDIS_USERID',
]),
readFirstSecret(secretService, ['AUCTION_REDIS_PASSWORD']),
]);
const redisOptions = resolveRedisClientOptions({
endpoint: redisEndpoint,
endpointEnvName: 'REDIS_ENDPOINT',
url: redisUrl,
urlEnvName: 'REDIS_URL',
});
const auctionRedisOptions = resolveRedisClientOptions({
endpoint: auctionRedisEndpoint,
endpointEnvName: 'AUCTION_REDIS_ENDPOINT',
password: auctionRedisPassword,
url: auctionRedisUrl,
urlEnvName: 'AUCTION_REDIS_URL',
username: auctionRedisUsername,
});
assertDistinctRedisInstances(redisOptions.url, auctionRedisOptions.url);
const logger = new Logger('AuctionRedisClient');
const client = createClient(auctionRedisOptions);
client.on('error', (error) => {
const client = createClient(
await loadRedisClientOptions(secretService),
);
client.on('error', (error: unknown) => {
logger.error(
`Auction Redis client error: ${error?.message ?? error}`,
`Auction Redis client error: ${
error instanceof Error ? error.message : String(error)
}`,
);
});
@@ -15,7 +15,9 @@ function makeService(sendCommand: jest.Mock) {
describe('AuctionRedisService', () => {
it('uses Redis TIME as the timestamp source', async () => {
const service = makeService(jest.fn().mockResolvedValue(['1781700000', '123000']));
const service = makeService(
jest.fn().mockResolvedValue(['1781700000', '123000']),
);
await expect(service.getCurrentRedisTimestampMS()).resolves.toBe(
1_781_700_000_123,
@@ -22,7 +22,11 @@ export class AuctionRedisNoscriptError extends Error {
function isNoscriptError(error: unknown): boolean {
if (error instanceof AuctionRedisNoscriptError) return true;
const message =
error instanceof Error ? error.message : typeof error === 'string' ? error : '';
error instanceof Error
? error.message
: typeof error === 'string'
? error
: '';
return /\bNOSCRIPT\b/iu.test(message);
}
@@ -81,9 +85,15 @@ export class AuctionRedisService implements OnModuleDestroy {
if (!isNoscriptError(error)) throw error;
}
const loadedSha = String(
await this.client.sendCommand(['SCRIPT', 'LOAD', params.script]),
);
const loadedShaReply = await this.client.sendCommand([
'SCRIPT',
'LOAD',
params.script,
]);
if (typeof loadedShaReply !== 'string') {
throw new Error('Redis SCRIPT LOAD returned a non-string SHA.');
}
const loadedSha = loadedShaReply;
return (await this.client.sendCommand(
buildEvalShaCommand(loadedSha, params.keys, params.values),
)) as T;
@@ -107,7 +117,7 @@ export class AuctionRedisService implements OnModuleDestroy {
token: string,
ttlMS: number,
): Promise<boolean> {
const result = await this.client.sendCommand([
const result = await this.client.sendCommand<string | null>([
'SET',
key,
token,
@@ -115,17 +125,11 @@ export class AuctionRedisService implements OnModuleDestroy {
String(ttlMS),
'NX',
]);
return String(result) === 'OK';
return result === 'OK';
}
public async releaseTokenLock(key: string, token: string): Promise<boolean> {
const result = await this.client.sendCommand([
'EVAL',
'if redis.call("GET", KEYS[1]) == ARGV[1] then return redis.call("DEL", KEYS[1]) else return 0 end',
'1',
key,
token,
]);
const result = await this.client.sendCommand(['DELEX', key, 'IFEQ', token]);
return Number(result) === 1;
}
}
@@ -24,7 +24,7 @@ describe('auction redis state assembly', () => {
mongo: { auctionLifecycleId: 'new-life', revision: 2 },
},
{
expected: false,
expected: true,
live: { auctionLifecycleId: 'redis-life', revision: 3 },
mongo: { auctionLifecycleId: 'mongo-life', revision: 2 },
},
@@ -100,9 +100,7 @@ describe('auction redis state assembly', () => {
'1000',
]);
expect(AUCTION_HYDRATE_STATE_SCRIPT.lua).toContain("redis.call('TIME')");
expect(AUCTION_HYDRATE_STATE_SCRIPT.lua).toContain(
'INVALID_PATCH_ARITY',
);
expect(AUCTION_HYDRATE_STATE_SCRIPT.lua).toContain('INVALID_PATCH_ARITY');
expect(AUCTION_HYDRATE_STATE_SCRIPT.lua).toContain(
'mongoRevision > redisRevision',
);
@@ -62,13 +62,11 @@ export function shouldHydrateRedisAuctionState(
params: ShouldHydrateRedisAuctionStateParams,
): boolean {
if (!params.live) return true;
if (params.mongo.auctionLifecycleId !== params.live.auctionLifecycleId)
return true;
const redisRevision = params.live.revision ?? -1;
const mongoRevision = params.mongo.revision;
if (mongoRevision > redisRevision) return true;
return (
mongoRevision === redisRevision &&
params.mongo.auctionLifecycleId !== params.live.auctionLifecycleId
);
return mongoRevision > redisRevision;
}
export function assembleAuctionViewFromRedisState(
@@ -78,9 +76,7 @@ export function assembleAuctionViewFromRedisState(
return {
...params.structureState,
...params.liveState,
auctionBidHistory: params.auctionBidHistoryEntries.map((entry) =>
JSON.parse(entry),
),
auctionBidHistory: params.auctionBidHistoryEntries.map(parseJsonValue),
canPlaceBidInCurrentBidRound: !isExpiring,
currentServerTimestampMS: params.currentServerTimestampMS,
isAuctionStateTransitionInProgress: isExpiring,
@@ -90,6 +86,11 @@ export function assembleAuctionViewFromRedisState(
};
}
function parseJsonValue(json: string): unknown {
const value: unknown = JSON.parse(json);
return value;
}
export function buildHydrateAuctionStateScriptInvocation(
keys: AuctionRedisKeys,
input: HydrateAuctionStateScriptInput,
@@ -137,13 +138,17 @@ if not liveStatePatchPairCount or #ARGV ~= 8 + (liveStatePatchPairCount * 2) the
return {'REJECTED', 'INVALID_PATCH_ARITY', tostring(currentRedisTimestampMS)}
end
-- A lifecycle replacement requires Mongo authority and an explicit cleanup
-- under the lifecycle lock. Revision numbers from different runs are unrelated.
if redisAuctionLifecycleId and redisAuctionLifecycleId ~= mongoAuctionLifecycleId then
return {'REJECTED', 'LIFECYCLE_CONFLICT', tostring(currentRedisTimestampMS)}
end
local shouldHydrate = false
if redisRevision < 0 then
shouldHydrate = true
elseif mongoRevision > redisRevision then
shouldHydrate = true
elseif mongoRevision == redisRevision and mongoAuctionLifecycleId ~= redisAuctionLifecycleId then
shouldHydrate = true
end
if not shouldHydrate then
@@ -181,6 +186,7 @@ if phase == 'bidding' then
redis.call('ZADD', bidRoundDeadlineQueueKey, currentBidRoundDeadlineTimestampMS, matchId)
else
redis.call('ZREM', bidRoundDeadlineQueueKey, matchId)
redis.call('HDEL', liveAuctionStateKey, 'currentBidRoundDeadlineTimestampMS')
end
return {'OK', tostring(hydratedRevision), tostring(currentRedisTimestampMS)}
+1 -4
View File
@@ -1,8 +1,5 @@
import type { JWTHeaderParameters, JWTPayload } from 'jose';
import type {
IdentityDocument,
UserDocument,
} from '../global/database/schema';
import type { IdentityDocument, UserDocument } from '../global/database/schema';
import type { IdentityProviderName } from './jwt.service';
declare module 'express' {
+1 -4
View File
@@ -2,10 +2,7 @@ import { Injectable } from '@nestjs/common';
import type { Request } from 'express';
import mongoose from 'mongoose';
import { ConnectionService } from '../global/database/connection.service';
import {
IdentityDocument,
UserDocument,
} from '../global/database/schema';
import { IdentityDocument, UserDocument } from '../global/database/schema';
import { SecretService } from '../global/secret/secret.service';
import './auth-request';
+4 -4
View File
@@ -26,8 +26,7 @@ export class JwtAuthGuard implements CanActivate {
METADATA_KEY_IS_PUBLIC_ACCESS_ALLOWED,
[context.getHandler(), context.getClass()],
);
const authz = request.headers?.authorization;
const authzHeader = Array.isArray(authz) ? authz[0] : authz;
const authzHeader = request.get('authorization');
if (!authzHeader) {
const fallback =
@@ -74,7 +73,7 @@ export class JwtAuthGuard implements CanActivate {
private pickIdPFromToken(token: string): IdentityProviderName {
try {
const { iss } = decodeJwt(token) as { iss?: string };
const { iss } = decodeJwt(token);
if (!iss) {
throw new Error('Token has no issuer (iss) claim');
}
@@ -84,7 +83,8 @@ export class JwtAuthGuard implements CanActivate {
}
throw new Error(`Unknown issuer: ${iss}`);
} catch (err) {
const message = err instanceof Error ? err.message : 'Unable to decode token';
const message =
err instanceof Error ? err.message : 'Unable to decode token';
throw new UnauthorizedException(message);
}
}
+32 -9
View File
@@ -35,11 +35,13 @@ export class JwtService {
throw new Error('Empty token');
}
if (identityProvider !== 'MICROSOFT_ENTRAID') {
throw new Error(`Identity provider not configured: ${identityProvider}`);
const provider =
identityProvider === 'MICROSOFT_ENTRAID'
? await this.getEntraConfig()
: undefined;
if (!provider) {
throw new Error('Identity provider not configured.');
}
const provider = await this.getEntraConfig();
const result = await jwtVerify(token, provider.jwks, {
issuer: provider.issuer,
audience: provider.audience,
@@ -48,14 +50,22 @@ export class JwtService {
});
const { payload, protectedHeader } = result;
if (!provider.allowedAlgs.includes(protectedHeader.alg as string)) {
if (!provider.allowedAlgs.includes(protectedHeader.alg)) {
throw new Error(`Unexpected alg: ${protectedHeader.alg}`);
}
if (payload.ver && payload.ver !== '2.0') {
throw new Error(`Unsupported Entra token version: ${payload.ver}`);
if (
payload.ver !== undefined &&
(typeof payload.ver !== 'string' || payload.ver !== '2.0')
) {
throw new Error(
`Unsupported Entra token version: ${formatClaimValue(payload.ver)}`,
);
}
if (payload.tid && payload.tid !== provider.tenantId) {
throw new Error(`Unexpected tenant: ${payload.tid}`);
if (
payload.tid !== undefined &&
(typeof payload.tid !== 'string' || payload.tid !== provider.tenantId)
) {
throw new Error(`Unexpected tenant: ${formatClaimValue(payload.tid)}`);
}
return result;
@@ -98,3 +108,16 @@ export class JwtService {
return this.entraConfig;
}
}
function formatClaimValue(value: unknown): string {
if (
typeof value === 'string' ||
typeof value === 'number' ||
typeof value === 'boolean' ||
typeof value === 'bigint'
) {
return String(value);
}
if (value === null) return 'null';
return JSON.stringify(value) ?? typeof value;
}
+2 -2
View File
@@ -7,7 +7,7 @@ import {
} from '@nestjs/common';
import { Reflector } from '@nestjs/core';
import type { Request } from 'express';
import { CommunityRole, UserDocument } from '../global/database/schema';
import type { CommunityRole } from '../global/database/schema';
import { ROLES_KEY } from './roles.decorator';
import './auth-request';
@@ -23,7 +23,7 @@ export class RolesGuard implements CanActivate {
if (!requiredRoles || requiredRoles.length === 0) return true;
const req = context.switchToHttp().getRequest<Request>();
const user = req.user as UserDocument | undefined;
const user = req.user;
if (!user && req.identity) {
throw new ForbiddenException('No membership in this community.');
}
@@ -4,6 +4,7 @@ import { ConnectionService } from '../global/database/connection.service';
import { IdentityDocument, UserDocument } from '../global/database/schema';
import { UserResolverGuard } from './user-resolver.guard';
import './auth-request';
import type { Request } from 'express';
function createContext(request: Record<string, unknown>): ExecutionContext {
return {
@@ -24,7 +25,7 @@ describe('UserResolverGuard', () => {
const connectionService = {
getModel: jest.fn().mockResolvedValue({ findOne }),
} as unknown as ConnectionService;
const request = {
const request: Pick<Request, 'params' | 'identity' | 'user'> = {
params: { communityId: communityId.toString() },
identity: { _id: identityId } as IdentityDocument,
};
@@ -7,9 +7,10 @@ import {
import mongoose from 'mongoose';
@Injectable()
export class ParseObjectIdPipe
implements PipeTransform<string, mongoose.Types.ObjectId>
{
export class ParseObjectIdPipe implements PipeTransform<
string,
mongoose.Types.ObjectId
> {
public transform(
value: string,
metadata: ArgumentMetadata,
@@ -1,8 +1,67 @@
import { Injectable, Logger } from '@nestjs/common';
import { randomUUID } from 'crypto';
import { RedisService } from '../global/redis/redis.service';
const COMMUNITY_STATS_TTL_SECONDS = 5 * 60;
const COMMUNITY_STATS_DETAIL_TTL_SECONDS = 24 * 60 * 60;
const CACHE_SCOPES = [
'matches',
'leaderboard',
'teamInsights',
'matchDetail',
'userInternal',
] as const;
type CacheScope = (typeof CACHE_SCOPES)[number];
function communityPrefix(communityId: string): string {
return `riot:communitystats:v2:{${communityId}}`;
}
export class CommunityStatsCacheKey {
public readonly generationKey: string;
public readonly hashKey: string;
public generation?: string;
constructor(
communityId: string,
scope: CacheScope,
public readonly field: string,
) {
const prefix = communityPrefix(communityId);
this.generationKey = `${prefix}:generation`;
this.hashKey = `${prefix}:${scope}`;
}
public get identity(): string {
return JSON.stringify([this.hashKey, this.generation, this.field]);
}
}
const READ_CACHE_SCRIPT = `
local generation = redis.call('GET', KEYS[1])
if not generation then
generation = ARGV[1]
redis.call('SET', KEYS[1], generation)
end
return {generation, redis.call('HGET', KEYS[2], ARGV[2])}
`;
const WRITE_CACHE_SCRIPT = `
if redis.call('GET', KEYS[1]) ~= ARGV[1] then return 0 end
redis.call('HSETEX', KEYS[2], 'EX', ARGV[4], 'FIELDS', 1, ARGV[2], ARGV[3])
return 1
`;
const INVALIDATE_CACHE_SCRIPT = `
-- A fill started before invalidation cannot publish into the new generation.
redis.call('SET', KEYS[1], ARGV[1])
local deleted = 0
for i = 2, #KEYS do
deleted = deleted + redis.call('HLEN', KEYS[i])
redis.call('UNLINK', KEYS[i])
end
return deleted
`;
@Injectable()
export class CommunityStatsCacheService {
@@ -10,48 +69,72 @@ export class CommunityStatsCacheService {
constructor(private readonly redisService: RedisService) {}
public get<T>(key: string): Promise<T | null> {
return this.redisService.getJson<T>(key);
public async get<T>(key: CommunityStatsCacheKey): Promise<T | null> {
const reply = await this.redisService
.raw()
.sendCommand<
[string, string | null]
>(['EVAL', READ_CACHE_SCRIPT, '2', key.generationKey, key.hashKey, randomUUID(), key.field]);
key.generation = reply[0];
if (!reply[1]) return null;
try {
return JSON.parse(reply[1]) as T;
} catch {
this.logger.warn(
`Failed to parse community stats cache field in ${key.hashKey}.`,
);
return null;
}
}
public set(
key: string,
public async set(
key: CommunityStatsCacheKey,
value: unknown,
ttlSeconds = COMMUNITY_STATS_TTL_SECONDS,
): Promise<void> {
return this.redisService.setJson(key, value, ttlSeconds);
if (!key.generation)
throw new Error(
'Read the cache generation before starting a cache fill.',
);
if (!Number.isInteger(ttlSeconds) || ttlSeconds <= 0)
throw new Error('Cache TTL must be a positive integer.');
await this.redisService
.raw()
.sendCommand([
'EVAL',
WRITE_CACHE_SCRIPT,
'2',
key.generationKey,
key.hashKey,
key.generation,
key.field,
JSON.stringify(value),
String(ttlSeconds),
]);
}
public setDetail(key: string, value: unknown): Promise<void> {
public setDetail(key: CommunityStatsCacheKey, value: unknown): Promise<void> {
return this.set(key, value, COMMUNITY_STATS_DETAIL_TTL_SECONDS);
}
public async invalidateCommunity(communityId: string): Promise<number> {
const prefix = `riot:communitystats:`;
const match = `${prefix}*${communityId}*`;
const client = this.redisService.raw();
let cursor = '0';
let deleted = 0;
do {
const reply = (await client.sendCommand([
'SCAN',
cursor,
'MATCH',
match,
'COUNT',
'100',
])) as [string, string[]];
cursor = reply[0];
const keys = reply[1] ?? [];
if (keys.length > 0) {
deleted += await client.del(keys);
}
} while (cursor !== '0');
const prefix = communityPrefix(communityId);
const deleted = Number(
await this.redisService
.raw()
.sendCommand([
'EVAL',
INVALIDATE_CACHE_SCRIPT,
String(CACHE_SCOPES.length + 1),
`${prefix}:generation`,
...CACHE_SCOPES.map((scope) => `${prefix}:${scope}`),
randomUUID(),
]),
);
if (deleted > 0) {
this.logger.debug(
`Invalidated ${deleted} community stats cache keys for ${communityId}.`,
`Invalidated ${deleted} community stats cache entries for ${communityId}.`,
);
}
return deleted;
@@ -23,7 +23,14 @@ export class CommunityStatsController {
) {
return this.communityStatsService.getMatches({
communityId,
filters: this.toFilters({ seasonId, from, to, championId, cursor, limit }),
filters: this.toFilters({
seasonId,
from,
to,
championId,
cursor,
limit,
}),
});
}
@@ -85,7 +92,14 @@ export class CommunityStatsController {
return this.communityStatsService.getUserInternalHistory({
communityId,
userId,
filters: this.toFilters({ seasonId, from, to, championId, cursor, limit }),
filters: this.toFilters({
seasonId,
from,
to,
championId,
cursor,
limit,
}),
});
}
@@ -1,6 +1,9 @@
import mongoose from 'mongoose';
import { ConnectionService } from '../global/database/connection.service';
import { CommunityStatsCacheService } from './community-stats-cache.service';
import {
CommunityStatsCacheKey,
CommunityStatsCacheService,
} from './community-stats-cache.service';
import { CommunityStatsService } from './community-stats.service';
import type {
InternalMatchCardView,
@@ -281,7 +284,7 @@ describe('CommunityStatsService', () => {
expect(setDetail).toHaveBeenCalledTimes(2);
expect(setDetail).toHaveBeenNthCalledWith(
2,
expect.stringContaining(':r4:'),
expect.objectContaining({ field: expect.stringContaining(':r4:') }),
invalidCheckpointResponse,
);
});
@@ -338,7 +341,7 @@ describe('CommunityStatsService', () => {
const set = jest
.fn()
.mockImplementation(
(_key: string, value: InternalMatchDetailResponse) => {
(_key: CommunityStatsCacheKey, value: InternalMatchDetailResponse) => {
cachedResponse = value;
return Promise.resolve();
},
@@ -346,7 +349,7 @@ describe('CommunityStatsService', () => {
const setDetail = jest
.fn()
.mockImplementation(
(_key: string, value: InternalMatchDetailResponse) => {
(_key: CommunityStatsCacheKey, value: InternalMatchDetailResponse) => {
cachedResponse = value;
return Promise.resolve();
},
@@ -377,7 +380,7 @@ describe('CommunityStatsService', () => {
expect(backedOff).toBe(fallback);
expect(buildAndUpsert).toHaveBeenCalledTimes(1);
expect(set).toHaveBeenCalledWith(
expect.stringContaining(':r4:'),
expect.objectContaining({ field: expect.stringContaining(':r4:') }),
fallback,
60,
);
@@ -389,7 +392,7 @@ describe('CommunityStatsService', () => {
expect(buildAndUpsert).toHaveBeenCalledTimes(2);
expect(setDetail).toHaveBeenCalledTimes(1);
expect(setDetail).toHaveBeenCalledWith(
expect.stringContaining(':r4:'),
expect.objectContaining({ field: expect.stringContaining(':r4:') }),
recovered,
);
});
@@ -547,7 +550,9 @@ describe('CommunityStatsService', () => {
).toEqual([matchId.toString()]);
expect(buildBaseDataset).not.toHaveBeenCalled();
expect(cacheService.set).toHaveBeenCalledWith(
expect.stringContaining(`userInternal:v3:${userId.toString()}`),
expect.objectContaining({
field: expect.stringContaining(`userInternal:v3:${userId.toString()}`),
}),
response,
);
});
@@ -11,7 +11,10 @@ import type {
HistorySeasonDto,
RecentMatchView,
} from '../match-history/match-history.types';
import { CommunityStatsCacheService } from './community-stats-cache.service';
import {
CommunityStatsCacheKey,
CommunityStatsCacheService,
} from './community-stats-cache.service';
import type {
CommunityStatsFilters,
InternalMatchCardView,
@@ -219,21 +222,25 @@ export class CommunityStatsService {
communityId: mongoose.Types.ObjectId;
matchId: mongoose.Types.ObjectId;
}): Promise<InternalMatchDetailResponse> {
const key = `riot:communitystats:matchDetail:v${MATCH_STATS_BUILDER_VERSION}:r${MATCH_DETAIL_RESPONSE_CACHE_VERSION}:${params.communityId.toString()}:${params.matchId.toString()}`;
const key = new CommunityStatsCacheKey(
params.communityId.toString(),
'matchDetail',
`v${MATCH_STATS_BUILDER_VERSION}:r${MATCH_DETAIL_RESPONSE_CACHE_VERSION}:${params.matchId.toString()}`,
);
const cached =
await this.cacheService.get<InternalMatchDetailResponse>(key);
if (cached && isCompleteMatchDetailResponse(cached)) return cached;
const inFlight = this.matchDetailInFlight.get(key);
const inFlight = this.matchDetailInFlight.get(key.identity);
if (inFlight) return inFlight;
const promise = this.buildMatchDetailResponse(params, key);
this.matchDetailInFlight.set(key, promise);
this.matchDetailInFlight.set(key.identity, promise);
try {
return await promise;
} finally {
if (this.matchDetailInFlight.get(key) === promise) {
this.matchDetailInFlight.delete(key);
if (this.matchDetailInFlight.get(key.identity) === promise) {
this.matchDetailInFlight.delete(key.identity);
}
}
}
@@ -243,7 +250,7 @@ export class CommunityStatsService {
communityId: mongoose.Types.ObjectId;
matchId: mongoose.Types.ObjectId;
},
key: string,
key: CommunityStatsCacheKey,
): Promise<InternalMatchDetailResponse> {
const dataset = await this.buildBaseDataset(params.communityId, {
seasonId: 'all',
@@ -346,16 +353,16 @@ export class CommunityStatsService {
// Auction viewers can all request the same next player's internal history
// at once. Coalesce local cache misses so one player change does one DB read.
const inFlight = this.userInternalHistoryInFlight.get(key);
const inFlight = this.userInternalHistoryInFlight.get(key.identity);
if (inFlight) return inFlight;
const promise = this.buildUserInternalHistoryResponse(params, key);
this.userInternalHistoryInFlight.set(key, promise);
this.userInternalHistoryInFlight.set(key.identity, promise);
try {
return await promise;
} finally {
if (this.userInternalHistoryInFlight.get(key) === promise) {
this.userInternalHistoryInFlight.delete(key);
if (this.userInternalHistoryInFlight.get(key.identity) === promise) {
this.userInternalHistoryInFlight.delete(key.identity);
}
}
}
@@ -428,7 +435,7 @@ export class CommunityStatsService {
userId: mongoose.Types.ObjectId;
filters: CommunityStatsFilters;
},
cacheKey: string,
cacheKey: CommunityStatsCacheKey,
): Promise<UserInternalHistoryResponse> {
const context = await this.resolveContext(
params.communityId,
@@ -1138,18 +1145,31 @@ export class CommunityStatsService {
scope: string,
communityId: mongoose.Types.ObjectId,
filters: CommunityStatsFilters,
): string {
return [
'riot:communitystats',
scope,
): CommunityStatsCacheKey {
const cacheScope = scope.startsWith('userInternal:')
? 'userInternal'
: scope;
if (
cacheScope !== 'matches' &&
cacheScope !== 'leaderboard' &&
cacheScope !== 'teamInsights' &&
cacheScope !== 'userInternal'
) {
throw new Error(`Unsupported community stats cache scope: ${scope}`);
}
return new CommunityStatsCacheKey(
communityId.toString(),
filters.seasonId ?? 'current',
filters.from ?? '',
filters.to ?? '',
filters.championId ?? '',
filters.cursor ?? '',
filters.limit ?? '',
].join(':');
cacheScope,
JSON.stringify([
scope,
filters.seasonId ?? 'current',
filters.from ?? '',
filters.to ?? '',
filters.championId ?? '',
filters.cursor ?? '',
filters.limit ?? '',
]),
);
}
private clampLimit(
@@ -7,7 +7,10 @@ import type {
RiotLane,
TeamSide,
} from '../global/database/schema';
import type { RecentMatchView, HistorySeasonDto } from '../match-history/match-history.types';
import type {
RecentMatchView,
HistorySeasonDto,
} from '../match-history/match-history.types';
export interface CommunityStatsFilters {
seasonId?: string;
@@ -80,7 +83,9 @@ export interface LeaderboardRow {
avgCsPerMin: number;
avgDamageShare: number;
avgVisionScore: number;
byLane: Partial<Record<RiotLane, { games: number; wins: number; kda: number }>>;
byLane: Partial<
Record<RiotLane, { games: number; wins: number; kda: number }>
>;
topChampions: Array<{ championId: number; games: number; winRate: number }>;
}
@@ -106,6 +106,8 @@ describe('MatchStatsFragmentBuilder', () => {
puuid: 'puuid-2',
gameName: 'Opponent',
profileIconId: 8,
preferredPositions: [],
joinedAt: new Date('2026-05-03T00:00:00.000Z'),
});
match.teams[1].members.push({ userId: redUserId, assignedPosition: 'TOP' });
match.result?.games[0].participants.push({
@@ -269,7 +271,7 @@ describe('MatchStatsFragmentBuilder', () => {
teamId: 200,
win: false,
});
const timeline = {
const timeline: RiotMatchTimelineDto = {
metadata: {
dataVersion: '2',
matchId: 'KR_1',
@@ -280,6 +282,7 @@ describe('MatchStatsFragmentBuilder', () => {
frames: [
{
timestamp: 0,
events: [],
participantFrames: {
'1': {
participantId: 1,
@@ -507,9 +510,7 @@ describe('MatchStatsFragmentBuilder', () => {
const fragment = builder.buildFragment({
match,
rawByRiotMatchId: new Map([['KR_1', raw as RiotMatchDto]]),
timelineByRiotMatchId: new Map([
['KR_1', timeline as RiotMatchTimelineDto],
]),
timelineByRiotMatchId: new Map([['KR_1', timeline]]),
});
expect(fragment.gameDetails[0]).toMatchObject({
@@ -794,9 +795,7 @@ describe('MatchStatsFragmentBuilder', () => {
} as RiotMatchDto,
],
]),
timelineByRiotMatchId: new Map([
['KR_1', timeline as RiotMatchTimelineDto],
]),
timelineByRiotMatchId: new Map([['KR_1', timeline]]),
});
expect(
shortFragment.records.every((record) => record.checkpoints === undefined),
@@ -227,9 +227,7 @@ export class MatchStatsFragmentBuilder {
participant,
rawParticipant,
buildEvents: rawParticipant
? buildEventsByParticipantId.get(
rawParticipant.participantId,
)
? buildEventsByParticipantId.get(rawParticipant.participantId)
: undefined,
checkpoints: rawParticipant
? checkpointsByParticipantId.get(rawParticipant.participantId)
@@ -420,7 +418,10 @@ export class MatchStatsFragmentBuilder {
private toBuildEventsByParticipantId(
timeline?: RiotMatchTimelineDto,
): Map<number, ParticipantBuildEvents> {
const buildEventsByParticipantId = new Map<number, ParticipantBuildEvents>();
const buildEventsByParticipantId = new Map<
number,
ParticipantBuildEvents
>();
if (!timeline?.info.frames.length) return buildEventsByParticipantId;
const getEvents = (participantId: number): ParticipantBuildEvents => {
@@ -796,15 +797,18 @@ export class MatchStatsFragmentBuilder {
? timelineDragon
: (rawObjectives?.dragon?.kills ?? 0),
inhibitor: rawObjectives?.inhibitor?.kills ?? 0,
baron: (timelineObjectives?.baron ?? 0) > 0
? (timelineObjectives?.baron ?? 0)
: (rawObjectives?.baron?.kills ?? 0),
riftHerald: (timelineObjectives?.riftHerald ?? 0) > 0
? (timelineObjectives?.riftHerald ?? 0)
: (rawObjectives?.riftHerald?.kills ?? 0),
voidGrub: (timelineObjectives?.voidGrub ?? 0) > 0
? (timelineObjectives?.voidGrub ?? 0)
: (rawObjectives?.horde?.kills ?? 0),
baron:
(timelineObjectives?.baron ?? 0) > 0
? (timelineObjectives?.baron ?? 0)
: (rawObjectives?.baron?.kills ?? 0),
riftHerald:
(timelineObjectives?.riftHerald ?? 0) > 0
? (timelineObjectives?.riftHerald ?? 0)
: (rawObjectives?.riftHerald?.kills ?? 0),
voidGrub:
(timelineObjectives?.voidGrub ?? 0) > 0
? (timelineObjectives?.voidGrub ?? 0)
: (rawObjectives?.horde?.kills ?? 0),
elderDragon: hasProjectedDragon ? timelineElder : 0,
};
}
@@ -0,0 +1,173 @@
import mongoose from 'mongoose';
import { ConnectionService } from '../global/database/connection.service';
import { MatchStatsFragmentBuilder } from './match-stats-fragment.builder';
import { MatchStatsRepository } from './match-stats.repository';
import { MatchStatsService } from './match-stats.service';
import { MATCH_STATS_BUILDER_VERSION } from './match-stats.types';
describe('MatchStatsService outbox idempotency', () => {
it('reuses the latest stored revision when an older outbox event is delivered', async () => {
const h = createHarness();
h.isCurrent.mockResolvedValue(true);
await h.service.buildAndUpsert(h.matchId, { sourceRevision: 10 });
expect(h.isCurrent).toHaveBeenCalledWith({
matchId: h.matchId,
sourceCompetitionId: h.competitionId,
sourceRevision: 12,
projectorVersion: 3,
builderVersion: MATCH_STATS_BUILDER_VERSION,
});
expect(h.riotFind).not.toHaveBeenCalled();
expect(h.builder.buildFragment).not.toHaveBeenCalled();
expect(h.upsert).not.toHaveBeenCalled();
});
it('builds once across repeated deliveries after the write succeeds', async () => {
const h = createHarness();
h.upsert.mockImplementation(async () => {
h.isCurrent.mockResolvedValue(true);
});
await h.service.buildAndUpsert(h.matchId, { sourceRevision: 12 });
await h.service.buildAndUpsert(h.matchId, { sourceRevision: 12 });
expect(h.riotFind).toHaveBeenCalledTimes(1);
expect(h.builder.buildFragment).toHaveBeenCalledTimes(1);
expect(h.upsert).toHaveBeenCalledTimes(1);
});
it('retries a failed write without treating an attempted build as complete', async () => {
const h = createHarness();
h.upsert.mockRejectedValueOnce(new Error('database unavailable'));
await expect(
h.service.buildAndUpsert(h.matchId, { sourceRevision: 12 }),
).rejects.toThrow('database unavailable');
await h.service.buildAndUpsert(h.matchId, { sourceRevision: 12 });
expect(h.builder.buildFragment).toHaveBeenCalledTimes(2);
expect(h.upsert).toHaveBeenCalledTimes(2);
});
it.each([{}, { sourceRevision: 12, includeTimeline: true }])(
'still performs explicit rebuilds and timeline hydration (%j)',
async (options) => {
const h = createHarness();
h.isCurrent.mockResolvedValue(true);
await h.service.buildAndUpsert(h.matchId, options);
expect(h.isCurrent).not.toHaveBeenCalled();
expect(h.builder.buildFragment).toHaveBeenCalledTimes(1);
expect(h.upsert).toHaveBeenCalledTimes(1);
if ('includeTimeline' in options) {
expect(h.getMatchTimeline).toHaveBeenCalledWith('KR_1', {
region: 'asia',
});
}
},
);
it('deletes reversed zero-game stats even if their versions were current', async () => {
const h = createHarness();
h.competition.projection.games = [];
h.isCurrent.mockResolvedValue(true);
await h.service.buildAndUpsert(h.matchId, { sourceRevision: 12 });
expect(h.isCurrent).not.toHaveBeenCalled();
expect(h.deleteByMatch).toHaveBeenCalledWith(h.matchId, {
sourceCompetitionId: h.competitionId,
sourceRevision: 12,
});
});
});
function createHarness() {
const matchId = new mongoose.Types.ObjectId();
const competitionId = new mongoose.Types.ObjectId();
const teamAId = new mongoose.Types.ObjectId();
const teamBId = new mongoose.Types.ObjectId();
const match = {
_id: matchId,
communityId: new mongoose.Types.ObjectId(),
status: 'in-progress',
scheduledAt: new Date(),
teams: [],
};
const competition = {
_id: competitionId,
revision: 12,
projectorVersion: 3,
teams: [
{ teamId: teamAId, displayOrder: 1 },
{ teamId: teamBId, displayOrder: 2 },
],
projection: {
phase: 'running',
games: [
{
displayNumber: 1,
evidence: { type: 'riot', riotMatchId: 'KR_1' },
teams: { blue: { teamId: teamAId }, red: { teamId: teamBId } },
winnerTeamId: teamAId,
},
],
},
};
const riotFind = jest.fn(() => query([{ matchId: 'KR_1', raw: {} }]));
const models = {
match: { findById: () => query(match) },
competition: { findOne: () => query(competition) },
riotMatch: { find: riotFind },
community: { findById: () => query({ riotRegion: 'asia' }) },
};
const connection = {
getModel: async (name: keyof typeof models) => models[name],
} as unknown as ConnectionService;
const isCurrent = jest.fn().mockResolvedValue(false);
const upsert = jest.fn().mockResolvedValue(undefined);
const deleteByMatch = jest.fn().mockResolvedValue(undefined);
const repository = {
hasCurrentCompetitionFragment: isCurrent,
upsert,
deleteByMatch,
} as unknown as MatchStatsRepository;
const builder = {
buildFragment: jest.fn().mockReturnValue({
matchCard: {},
records: [],
gameDetails: [],
userIds: [],
championIds: [],
gameCreationMin: 1,
gameCreationMax: 2,
}),
} as unknown as jest.Mocked<MatchStatsFragmentBuilder>;
const getMatchTimeline = jest.fn().mockResolvedValue(undefined);
const service = new MatchStatsService(connection, repository, builder, {
getMatchTimeline,
} as never);
return {
service,
matchId,
competitionId,
competition,
isCurrent,
upsert,
deleteByMatch,
riotFind,
builder,
getMatchTimeline,
};
}
function query<T>(value: T) {
return {
select: jest.fn().mockReturnThis(),
lean: jest.fn().mockReturnThis(),
exec: async () => value,
};
}
@@ -4,6 +4,35 @@ import type { MatchStats } from '../global/database/schema';
import { MatchStatsRepository } from './match-stats.repository';
describe('MatchStatsRepository', () => {
it.each([null, { _id: new Types.ObjectId() }])(
'checks persisted source identity and every build version without loading payloads (%j)',
async (stored) => {
const exists = jest.fn(() => ({ exec: async () => stored }));
const connection = {
getModel: jest.fn().mockResolvedValue({ exists }),
} as unknown as ConnectionService;
const repository = new MatchStatsRepository(connection);
const source = {
matchId: new Types.ObjectId(),
sourceCompetitionId: new Types.ObjectId(),
sourceRevision: 12,
projectorVersion: 3,
builderVersion: 10,
};
await expect(
repository.hasCurrentCompetitionFragment(source),
).resolves.toBe(Boolean(stored));
expect(exists).toHaveBeenCalledWith({
matchId: source.matchId,
sourceCompetitionId: source.sourceCompetitionId,
sourceRevision: { $gte: 12 },
projectorVersion: { $gte: 3 },
builderVersion: { $gte: 10 },
});
},
);
it('does not let a legacy upsert overwrite a Competition-backed fragment', async () => {
const fragment = {
...statsFragment(12),
@@ -125,8 +154,8 @@ describe('MatchStatsRepository', () => {
if (
stored &&
stored.sourceCompetitionId?.equals(fragment.sourceCompetitionId!) &&
stored.sourceRevision! <= fragment.sourceRevision!
stored.sourceCompetitionId?.equals(fragment.sourceCompetitionId) &&
stored.sourceRevision <= fragment.sourceRevision
) {
stored = fragment;
return { matchedCount: 1, upsertedCount: 0 };
@@ -22,6 +22,25 @@ export interface MatchStatsDeleteGuard {
export class MatchStatsRepository {
constructor(private readonly connectionService: ConnectionService) {}
public async hasCurrentCompetitionFragment(params: {
matchId: mongoose.Types.ObjectId;
sourceCompetitionId: mongoose.Types.ObjectId;
sourceRevision: number;
projectorVersion: number;
builderVersion: number;
}): Promise<boolean> {
const MatchStatsModel = await this.connectionService.getModel('matchStats');
return Boolean(
await MatchStatsModel.exists({
matchId: params.matchId,
sourceCompetitionId: params.sourceCompetitionId,
sourceRevision: { $gte: params.sourceRevision },
projectorVersion: { $gte: params.projectorVersion },
builderVersion: { $gte: params.builderVersion },
}).exec(),
);
}
public async upsert(
fragment: Omit<MatchStats, 'createdAt' | 'updatedAt'>,
): Promise<void> {
@@ -24,6 +24,7 @@ describe('MatchStatsService', () => {
}),
} as unknown as ConnectionService;
const repository = {
hasCurrentCompetitionFragment: jest.fn().mockResolvedValue(false),
deleteByMatch: jest.fn().mockResolvedValue(undefined),
upsert: jest.fn(),
} as unknown as jest.Mocked<MatchStatsRepository>;
@@ -72,6 +73,7 @@ describe('MatchStatsService', () => {
}),
} as unknown as ConnectionService;
const repository = {
hasCurrentCompetitionFragment: jest.fn().mockResolvedValue(false),
deleteByMatch: jest.fn().mockResolvedValue(undefined),
upsert: jest.fn(),
} as unknown as jest.Mocked<MatchStatsRepository>;
@@ -132,6 +134,7 @@ describe('MatchStatsService', () => {
}),
} as unknown as ConnectionService;
const repository = {
hasCurrentCompetitionFragment: jest.fn().mockResolvedValue(false),
upsert: jest.fn().mockResolvedValue(undefined),
deleteByMatch: jest.fn(),
} as unknown as jest.Mocked<MatchStatsRepository>;
@@ -273,6 +276,7 @@ describe('MatchStatsService', () => {
}),
} as unknown as ConnectionService;
const repository = {
hasCurrentCompetitionFragment: jest.fn().mockResolvedValue(false),
upsert: jest.fn().mockResolvedValue(undefined),
deleteByMatch: jest.fn(),
deleteLegacyByMatch: jest.fn(),
@@ -281,15 +285,26 @@ describe('MatchStatsService', () => {
MatchStatsFragmentBuilder['buildFragment']
>[0];
const buildCalls: BuildParams[] = [];
const builtFragment = {
matchCard: { matchId: matchId.toString() },
const builtFragment: ReturnType<
MatchStatsFragmentBuilder['buildFragment']
> = {
matchCard: {
matchId: matchId.toString(),
title: '내전',
scheduledAt: match.scheduledAt.toISOString(),
status: 'finished',
gameCount: 1,
games: [],
teams: [],
seriesResults: [],
},
records: [],
gameDetails: [],
userIds: [],
championIds: [],
gameCreationMin: 1_000,
gameCreationMax: 2_000,
} as ReturnType<MatchStatsFragmentBuilder['buildFragment']>;
};
const buildFragment = jest.fn((params: BuildParams) => {
buildCalls.push(params);
return builtFragment;
@@ -397,6 +412,7 @@ describe('MatchStatsService', () => {
}),
} as unknown as ConnectionService;
const repository = {
hasCurrentCompetitionFragment: jest.fn().mockResolvedValue(false),
upsert: jest.fn().mockResolvedValue(undefined),
deleteByMatch: jest.fn(),
} as unknown as jest.Mocked<MatchStatsRepository>;
@@ -501,6 +517,7 @@ describe('MatchStatsService', () => {
}),
} as unknown as ConnectionService;
const repository = {
hasCurrentCompetitionFragment: jest.fn().mockResolvedValue(false),
upsert: jest.fn().mockResolvedValue(undefined),
deleteByMatch: jest.fn().mockResolvedValue(undefined),
deleteLegacyByMatch: jest.fn(),
@@ -562,6 +579,7 @@ describe('MatchStatsService', () => {
}),
} as unknown as ConnectionService;
const repository = {
hasCurrentCompetitionFragment: jest.fn().mockResolvedValue(false),
upsert: jest.fn(),
deleteByMatch: jest.fn(),
} as unknown as jest.Mocked<MatchStatsRepository>;
@@ -59,6 +59,24 @@ export class MatchStatsService {
return;
}
// Outbox redelivery (including older events observing the latest revision)
// must not reload Riot payloads or replace an already enriched fragment.
// Explicit rebuilds and timeline hydration still run at the same revision.
if (
options.sourceRevision !== undefined &&
!options.includeTimeline &&
competitionSource &&
(await this.repository.hasCurrentCompetitionFragment({
matchId,
sourceCompetitionId: competitionSource.sourceCompetitionId,
sourceRevision: competitionSource.sourceRevision,
projectorVersion: competitionSource.projectorVersion,
builderVersion: MATCH_STATS_BUILDER_VERSION,
}))
) {
return;
}
const riotIds = competitionSource?.riotMatchIds ?? [
...new Set(
(match.result?.games ?? [])
@@ -6,10 +6,7 @@ import {
} from '@nestjs/common';
import mongoose from 'mongoose';
import { ConnectionService } from '../global/database/connection.service';
import {
CommunityDocument,
UserDocument,
} from '../global/database/schema';
import { CommunityDocument, UserDocument } from '../global/database/schema';
export interface CreateCommunityInput {
name: string;
@@ -10,7 +10,7 @@ describe('CompetitionBootstrapService', () => {
it('creates a deterministic paired-Series Competition and immutable snapshots', async () => {
const firstHarness = createHarness();
const firstService = new CompetitionBootstrapService(
firstHarness.connectionService as ConnectionService,
firstHarness.connectionService,
);
const match = matchSnapshot({ gameMode: 'pair', teamCount: 2 });
@@ -88,7 +88,7 @@ describe('CompetitionBootstrapService', () => {
const secondHarness = createHarness();
const secondService = new CompetitionBootstrapService(
secondHarness.connectionService as ConnectionService,
secondHarness.connectionService,
);
await secondService.bootstrap({
...match,
@@ -106,9 +106,7 @@ describe('CompetitionBootstrapService', () => {
it('maps round-robin configuration and preserves a limited round count', async () => {
const harness = createHarness();
const service = new CompetitionBootstrapService(
harness.connectionService as ConnectionService,
);
const service = new CompetitionBootstrapService(harness.connectionService);
await service.bootstrap(
matchSnapshot({
@@ -132,9 +130,7 @@ describe('CompetitionBootstrapService', () => {
it('maps double elimination seeds and stage-specific Series rules', async () => {
const harness = createHarness();
const service = new CompetitionBootstrapService(
harness.connectionService as ConnectionService,
);
const service = new CompetitionBootstrapService(harness.connectionService);
const match = matchSnapshot({
gameMode: 'double-elimination',
teamCount: 4,
@@ -177,14 +173,14 @@ describe('CompetitionBootstrapService', () => {
{ legacyTeamIndex: 4, seedNumber: 3 },
]);
expect(
inserted.seriesGraph.find(({ code }) => code === 'WB_R1_M1').rule,
inserted.seriesGraph.find(({ code }) => code === 'WB_R1_M1')?.rule,
).toEqual({ type: 'first-to', winsRequired: 3, maxGames: 5 });
expect(
inserted.seriesGraph.find(({ code }) => code?.startsWith('LB_')).rule,
inserted.seriesGraph.find(({ code }) => code?.startsWith('LB_'))?.rule,
).toEqual({ type: 'first-to', winsRequired: 1, maxGames: 1 });
expect(
inserted.seriesGraph.find(({ code }) => code === 'GF')?.rule,
).toEqual({ type: 'first-to', winsRequired: 1, maxGames: 1 });
expect(inserted.seriesGraph.find(({ code }) => code === 'GF').rule).toEqual(
{ type: 'first-to', winsRequired: 1, maxGames: 1 },
);
expect(
inserted.seriesGraph.find(({ code }) => code === 'GF_RESET'),
).toMatchObject({
@@ -195,9 +191,7 @@ describe('CompetitionBootstrapService', () => {
it('rejects double elimination until authoritative seeds are persisted', async () => {
const harness = createHarness();
const service = new CompetitionBootstrapService(
harness.connectionService as ConnectionService,
);
const service = new CompetitionBootstrapService(harness.connectionService);
await expect(
service.bootstrap(
@@ -253,7 +247,7 @@ describe('CompetitionBootstrapService', () => {
for (const [label, mutate] of cases) {
const harness = createHarness();
const service = new CompetitionBootstrapService(
harness.connectionService as ConnectionService,
harness.connectionService,
);
const match = matchSnapshot({ gameMode: 'pair', teamCount: 2 });
mutate(match);
@@ -272,7 +266,7 @@ describe('CompetitionBootstrapService', () => {
it('rejects bracket mode live but explicitly maps it for legacy migration', async () => {
const liveHarness = createHarness();
const liveService = new CompetitionBootstrapService(
liveHarness.connectionService as ConnectionService,
liveHarness.connectionService,
);
const match = matchSnapshot({ gameMode: 'bracket', teamCount: 2 });
@@ -285,7 +279,7 @@ describe('CompetitionBootstrapService', () => {
const migrationHarness = createHarness();
const migrationService = new CompetitionBootstrapService(
migrationHarness.connectionService as ConnectionService,
migrationHarness.connectionService,
);
await migrationService.bootstrap(match, { source: 'legacy-migration' });
@@ -296,9 +290,7 @@ describe('CompetitionBootstrapService', () => {
it('upserts once and links only an unlinked or already-linked Match in one transaction', async () => {
const harness = createHarness();
const service = new CompetitionBootstrapService(
harness.connectionService as ConnectionService,
);
const service = new CompetitionBootstrapService(harness.connectionService);
const competition = await service.bootstrap(
matchSnapshot({ gameMode: 'pair', teamCount: 2 }),
@@ -342,9 +334,7 @@ describe('CompetitionBootstrapService', () => {
revision: 4,
};
const harness = createHarness({ existingCompetition: existing });
const service = new CompetitionBootstrapService(
harness.connectionService as ConnectionService,
);
const service = new CompetitionBootstrapService(harness.connectionService);
const result = await service.bootstrap(
matchSnapshot({ gameMode: 'pair', teamCount: 2 }),
@@ -372,9 +362,7 @@ describe('CompetitionBootstrapService', () => {
competitionResults: [duplicateKey, winner],
sessionCount: 2,
});
const service = new CompetitionBootstrapService(
harness.connectionService as ConnectionService,
);
const service = new CompetitionBootstrapService(harness.connectionService);
const result = await service.bootstrap(
matchSnapshot({ gameMode: 'pair', teamCount: 2 }),
@@ -391,9 +379,7 @@ describe('CompetitionBootstrapService', () => {
it('aborts when the Match is already linked to a different Competition', async () => {
const harness = createHarness({ matchUpdateResult: { matchedCount: 0 } });
const service = new CompetitionBootstrapService(
harness.connectionService as ConnectionService,
);
const service = new CompetitionBootstrapService(harness.connectionService);
await expect(
service.bootstrap(matchSnapshot({ gameMode: 'pair', teamCount: 2 })),
@@ -485,11 +471,7 @@ function createHarness(
let competitionCall = 0;
const competitionModel = {
findOneAndUpdate: jest.fn(
(
_filter: unknown,
update: { $setOnInsert: InsertPayload },
_queryOptions: unknown,
) => {
(_filter: unknown, update: { $setOnInsert: InsertPayload }) => {
insertedPayloads.push(update.$setOnInsert);
const selected = options.competitionResults?.[competitionCall++];
if (selected instanceof Error) return rejectedQuery(selected);
@@ -512,7 +494,7 @@ function createHarness(
const connectionService = {
createSession: jest.fn(() => Promise.resolve(sessions[sessionIndex++])),
getModel: jest.fn((name: string) => Promise.resolve(models[name])),
};
} as unknown as jest.Mocked<ConnectionService>;
return {
sessions,
@@ -22,9 +22,7 @@ describe('CompetitionCommandService', () => {
it('rejects a stale expected revision and aborts without writing', async () => {
const harness = createHarness({ competitionRevision: 8 });
const service = new CompetitionCommandService(
harness.connectionService as ConnectionService,
);
const service = new CompetitionCommandService(harness.connectionService);
await expect(service.acceptGame(acceptGameCommand())).rejects.toMatchObject(
{
@@ -44,9 +42,7 @@ describe('CompetitionCommandService', () => {
it('uses the expected revision in the persistence CAS and aborts a lost race', async () => {
const harness = createHarness({ casResult: null });
const service = new CompetitionCommandService(
harness.connectionService as ConnectionService,
);
const service = new CompetitionCommandService(harness.connectionService);
await expect(service.acceptGame(acceptGameCommand())).rejects.toMatchObject(
{
@@ -86,9 +82,7 @@ describe('CompetitionCommandService', () => {
return Promise.resolve([receipt]);
},
);
const service = new CompetitionCommandService(
harness.connectionService as ConnectionService,
);
const service = new CompetitionCommandService(harness.connectionService);
const command = acceptGameCommand();
const first = await service.acceptGame(command);
@@ -133,9 +127,7 @@ describe('CompetitionCommandService', () => {
});
},
);
const service = new CompetitionCommandService(
harness.connectionService as ConnectionService,
);
const service = new CompetitionCommandService(harness.connectionService);
await expect(
service.acceptGame(acceptGameCommand()),
@@ -162,9 +154,7 @@ describe('CompetitionCommandService', () => {
revision: 8,
}),
);
const service = new CompetitionCommandService(
harness.connectionService as ConnectionService,
);
const service = new CompetitionCommandService(harness.connectionService);
await expect(service.acceptGame(acceptGameCommand())).rejects.toMatchObject(
{
@@ -180,9 +170,7 @@ describe('CompetitionCommandService', () => {
it('atomically accepts a code-backed game, projects it, and enqueues an event', async () => {
const harness = createHarness();
const service = new CompetitionCommandService(
harness.connectionService as ConnectionService,
);
const service = new CompetitionCommandService(harness.connectionService);
const command = {
...acceptGameCommand(),
tournamentCode: {
@@ -279,9 +267,7 @@ describe('CompetitionCommandService', () => {
it('appends an administrative adjudication through the same command runner', async () => {
const harness = createHarness();
const service = new CompetitionCommandService(
harness.connectionService as ConnectionService,
);
const service = new CompetitionCommandService(harness.connectionService);
const result = await service.adjudicateSeries({
competitionId: COMPETITION_ID,
@@ -316,9 +302,7 @@ describe('CompetitionCommandService', () => {
facts: reversal.facts,
assignments: reversal.assignments,
});
const service = new CompetitionCommandService(
harness.connectionService as ConnectionService,
);
const service = new CompetitionCommandService(harness.connectionService);
const preview = await service.previewSeriesReversal({
competitionId: COMPETITION_ID,
@@ -348,9 +332,7 @@ describe('CompetitionCommandService', () => {
it('rejects a reversal preview at a stale revision', async () => {
const reversal = reversalFixture();
const harness = createHarness({ competition: reversal.competition });
const service = new CompetitionCommandService(
harness.connectionService as ConnectionService,
);
const service = new CompetitionCommandService(harness.connectionService);
await expect(
service.previewSeriesReversal({
@@ -372,9 +354,7 @@ describe('CompetitionCommandService', () => {
facts: reversal.facts,
assignments: reversal.assignments,
});
const service = new CompetitionCommandService(
harness.connectionService as ConnectionService,
);
const service = new CompetitionCommandService(harness.connectionService);
const preview = await service.previewSeriesReversal({
competitionId: COMPETITION_ID,
expectedRevision: 7,
@@ -485,9 +465,7 @@ describe('CompetitionCommandService', () => {
}),
)
.mockResolvedValueOnce([]);
const service = new CompetitionCommandService(
harness.connectionService as ConnectionService,
);
const service = new CompetitionCommandService(harness.connectionService);
const preview = await service.previewSeriesReversal({
competitionId: COMPETITION_ID,
expectedRevision: 7,
@@ -635,7 +613,7 @@ function createHarness(
const connectionService = {
createSession: jest.fn().mockResolvedValue(session),
getModel: jest.fn((name: string) => Promise.resolve(models[name])),
};
} as unknown as jest.Mocked<ConnectionService>;
return {
session,
@@ -160,9 +160,7 @@ const SERIES_ID = 'series-1';
const GAME_SLOT_ID = 'slot-1';
function createService(harness: ReturnType<typeof createHarness>) {
return new CompetitionQueryService(
harness.connectionService as ConnectionService,
);
return new CompetitionQueryService(harness.connectionService);
}
function createHarness(options: { competition?: unknown } = {}) {
@@ -244,7 +242,7 @@ function createHarness(options: { competition?: unknown } = {}) {
factModel,
connectionService: {
getModel: jest.fn((name: string) => Promise.resolve(models[name])),
},
} as unknown as jest.Mocked<ConnectionService>,
};
}
@@ -127,7 +127,7 @@ describe('Competition persistence schemas', () => {
function expectIndexes(
schema: {
indexes(): Array<[Record<string, number>, Record<string, unknown>]>;
indexes(): ReturnType<typeof CompetitionSchema.indexes>;
},
expected: Array<{
keys: Record<string, number>;
@@ -429,8 +429,14 @@ export function applyCompetitionDomainInvariantIndexes(
}
}
export type CompetitionModelName =
| 'competition'
| 'competitionFact'
| 'competitionOutbox'
| 'tournamentCodeAssignment';
export const competitionModelDefinitions: Array<{
name: string;
name: CompetitionModelName;
schema: mongoose.Schema;
schemaName: string;
}> = [
@@ -1,4 +1,8 @@
import { projectCompetition } from './competition-projector';
import {
CompetitionDomainError,
type CompetitionDomainErrorCode,
} from './domain-error';
import { generateSeriesGraph } from './series-graph';
describe('projectCompetition', () => {
@@ -323,20 +327,18 @@ describe('projectCompetition', () => {
'team-1',
);
expect(() =>
projectCompetition({
competitionId,
revision: 1,
projectorVersion: 1,
teams,
format,
seriesGraph,
facts: [{ ...accepted, seriesId: 'series-does-not-exist' }],
}),
).toThrow(
expect.objectContaining({
code: 'GAME_SERIES_MISMATCH',
}),
expectCompetitionDomainError(
() =>
projectCompetition({
competitionId,
revision: 1,
projectorVersion: 1,
teams,
format,
seriesGraph,
facts: [{ ...accepted, seriesId: 'series-does-not-exist' }],
}),
'GAME_SERIES_MISMATCH',
);
});
@@ -356,20 +358,18 @@ describe('projectCompetition', () => {
'team-1',
);
expect(() =>
projectCompetition({
competitionId,
revision: 1,
projectorVersion: 1,
teams,
format,
seriesGraph,
facts: [{ ...accepted, gameSlotId: 'slot-does-not-exist' }],
}),
).toThrow(
expect.objectContaining({
code: 'GAME_SLOT_INVALID',
}),
expectCompetitionDomainError(
() =>
projectCompetition({
competitionId,
revision: 1,
projectorVersion: 1,
teams,
format,
seriesGraph,
facts: [{ ...accepted, gameSlotId: 'slot-does-not-exist' }],
}),
'GAME_SLOT_INVALID',
);
});
@@ -382,36 +382,34 @@ describe('projectCompetition', () => {
};
const seriesGraph = generateSeriesGraph({ competitionId, teams, format });
expect(() =>
projectCompetition({
competitionId,
revision: 1,
projectorVersion: 1,
teams,
format,
seriesGraph,
facts: [
{
id: 'fact-unknown-adjudication-series',
type: 'series-adjudicated',
competitionId,
revision: 1,
ordinalWithinRevision: 1,
commandId: 'command-unknown-adjudication-series',
schemaVersion: 1,
actor: { type: 'user' },
occurredAt: new Date('2026-07-12T00:00:01.000Z'),
recordedAt: new Date('2026-07-12T00:00:02.000Z'),
seriesId: 'series-does-not-exist',
decision: { type: 'administrative', winnerTeamId: 'team-1' },
reason: 'Manual correction',
},
],
}),
).toThrow(
expect.objectContaining({
code: 'ADJUDICATION_INVALID',
}),
expectCompetitionDomainError(
() =>
projectCompetition({
competitionId,
revision: 1,
projectorVersion: 1,
teams,
format,
seriesGraph,
facts: [
{
id: 'fact-unknown-adjudication-series',
type: 'series-adjudicated',
competitionId,
revision: 1,
ordinalWithinRevision: 1,
commandId: 'command-unknown-adjudication-series',
schemaVersion: 1,
actor: { type: 'user' },
occurredAt: new Date('2026-07-12T00:00:01.000Z'),
recordedAt: new Date('2026-07-12T00:00:02.000Z'),
seriesId: 'series-does-not-exist',
decision: { type: 'administrative', winnerTeamId: 'team-1' },
reason: 'Manual correction',
},
],
}),
'ADJUDICATION_INVALID',
);
});
@@ -591,9 +589,10 @@ function acceptedGameFactory(competitionId: string) {
};
}
function projectedSeries<
T extends { series: Array<{ code?: string; seriesId: string }> },
>(projection: T, code: string) {
function projectedSeries<T extends { code?: string; seriesId: string }>(
projection: { series: T[] },
code: string,
) {
const series = projection.series.find((candidate) => candidate.code === code);
if (!series) throw new Error(`Missing projected series ${code}`);
return series;
@@ -617,3 +616,23 @@ interface GameSlotLike {
id: string;
ordinal: number;
}
function expectCompetitionDomainError(
action: () => unknown,
expectedCode: CompetitionDomainErrorCode,
): void {
let thrown: unknown;
try {
action();
} catch (error: unknown) {
thrown = error;
}
expect(thrown).toBeInstanceOf(CompetitionDomainError);
if (!(thrown instanceof CompetitionDomainError)) {
throw new Error(
`Expected CompetitionDomainError, received ${String(thrown)}`,
);
}
expect(thrown.code).toBe(expectedCode);
}
@@ -1,6 +1,7 @@
import {
assertReversalPreview,
buildReversalFacts,
CompetitionReversalError,
previewSeriesReversal,
} from './competition-reversal';
@@ -19,18 +20,18 @@ describe('Competition reversal planning', () => {
];
it('rejects strict reversal when a descendant has result activity', () => {
expect(() =>
previewSeriesReversal({
competitionId: 'competition-1',
revision: 2,
seriesId: 'series-parent',
mode: 'strict',
graph,
facts,
assignments,
}),
).toThrow(
expect.objectContaining({ code: 'REVERSAL_DESCENDANT_ACTIVITY' }),
expectCompetitionReversalError(
() =>
previewSeriesReversal({
competitionId: 'competition-1',
revision: 2,
seriesId: 'series-parent',
mode: 'strict',
graph,
facts,
assignments,
}),
'REVERSAL_DESCENDANT_ACTIVITY',
);
});
@@ -105,20 +106,22 @@ describe('Competition reversal planning', () => {
assignments,
});
expect(() =>
assertReversalPreview(
{
competitionId: 'competition-1',
revision: 3,
seriesId: 'series-parent',
mode: 'cascade',
graph,
facts,
assignments,
},
preview.impactHash,
),
).toThrow(expect.objectContaining({ code: 'REVERSAL_PREVIEW_STALE' }));
expectCompetitionReversalError(
() =>
assertReversalPreview(
{
competitionId: 'competition-1',
revision: 3,
seriesId: 'series-parent',
mode: 'cascade',
graph,
facts,
assignments,
},
preview.impactHash,
),
'REVERSAL_PREVIEW_STALE',
);
});
it('emits one append-only reversal fact for every active result fact', () => {
@@ -160,6 +163,26 @@ describe('Competition reversal planning', () => {
});
});
function expectCompetitionReversalError(
action: () => unknown,
expectedCode: CompetitionReversalError['code'],
): void {
let thrown: unknown;
try {
action();
} catch (error: unknown) {
thrown = error;
}
expect(thrown).toBeInstanceOf(CompetitionReversalError);
if (!(thrown instanceof CompetitionReversalError)) {
throw new Error(
`Expected CompetitionReversalError, received ${String(thrown)}`,
);
}
expect(thrown.code).toBe(expectedCode);
}
function series(id: string, sources: Array<Record<string, unknown>>) {
return {
id,
@@ -9,7 +9,8 @@ import { DakaoOutboxService } from './dakao-outbox.service';
const SWEEP_INTERVAL_MS = 60 * 1000;
const STALE_OUTBOX_MS = 5 * 60 * 1000;
const SWEEP_LOCK_KEY = 'distributed-lock:dakao-outbox:sweep-stale-publish-leases';
const SWEEP_LOCK_KEY =
'distributed-lock:dakao-outbox:sweep-stale-publish-leases';
const SWEEP_LOCK_EXPIRATION_DURATION_MILLISECONDS = 55_000;
@Injectable()
@@ -78,35 +78,29 @@ export class DakaoOutboxService {
await this.natsService.publishJetStream(params.subject, params.envelope, {
messageId: params.eventId,
});
await OutboxModel.updateOne(
updateFilter,
{
$set: {
state: 'published',
publishedAt: new Date(),
},
$inc: { publishAttempts: 1 },
$unset: {
lastPublishError: '',
publishLeaseOwnerIdentifier: '',
publishLeaseExpiresAt: '',
},
await OutboxModel.updateOne(updateFilter, {
$set: {
state: 'published',
publishedAt: new Date(),
},
).exec();
$inc: { publishAttempts: 1 },
$unset: {
lastPublishError: '',
publishLeaseOwnerIdentifier: '',
publishLeaseExpiresAt: '',
},
}).exec();
} catch (err) {
await OutboxModel.updateOne(
updateFilter,
{
$inc: { publishAttempts: 1 },
$set: {
lastPublishError: (err as Error)?.message ?? String(err),
},
$unset: {
publishLeaseOwnerIdentifier: '',
publishLeaseExpiresAt: '',
},
await OutboxModel.updateOne(updateFilter, {
$inc: { publishAttempts: 1 },
$set: {
lastPublishError: (err as Error)?.message ?? String(err),
},
).exec();
$unset: {
publishLeaseOwnerIdentifier: '',
publishLeaseExpiresAt: '',
},
}).exec();
this.logger.error(
`Failed to publish Dakao outbox eventId=${params.eventId}: ${
(err as Error)?.stack ?? err
@@ -0,0 +1,122 @@
import mongoose from 'mongoose';
import { ConnectionService } from '../global/database/connection.service';
import { RiotAccountService } from '../riot/riot-account.service';
import { RiotAccountEnrichmentService } from '../riot/riot-account-enrichment.service';
import { DakaoUserService } from './dakao-user.service';
const communityId = new mongoose.Types.ObjectId();
const params = {
communityId,
kakaoTalkId: 'new-id',
previousNickname: '예전 닉',
};
function setup() {
const user = {
_id: new mongoose.Types.ObjectId(),
communityId,
kakaoTalkId: 'old-id',
kakaoTalkNickname: '예전 닉',
riotAccounts: [{ puuid: 'puuid', gameName: '소환사', tagLine: 'KR1' }],
role: 'member',
};
const find = jest.fn().mockReturnValue({
limit: jest
.fn()
.mockReturnValue({ exec: jest.fn().mockResolvedValue([user]) }),
});
const findOne = jest
.fn()
.mockReturnValue({ exec: jest.fn().mockResolvedValue(null) });
const update = jest
.fn()
.mockImplementation(async () => ({ ...user, kakaoTalkId: 'new-id' }));
const findOneAndUpdate = jest.fn().mockReturnValue({ exec: update });
const service = new DakaoUserService(
{
getModel: jest
.fn()
.mockResolvedValue({ find, findOne, findOneAndUpdate }),
} as unknown as ConnectionService,
{} as RiotAccountService,
{} as RiotAccountEnrichmentService,
);
return { service, user, find, findOne, findOneAndUpdate, update };
}
describe('DakaoUserService.transferKakaoTalkId', () => {
it('selects registered users by exact nickname in the current community and changes only the ID', async () => {
const { service, user, find, findOneAndUpdate } = setup();
expect(await service.transferKakaoTalkId(params)).toBe('transferred');
expect(find).toHaveBeenCalledWith({
communityId,
kakaoTalkNickname: '예전 닉',
'riotAccounts.0': { $exists: true },
});
expect(findOneAndUpdate).toHaveBeenCalledWith(
{
_id: user._id,
communityId,
kakaoTalkId: 'old-id',
kakaoTalkNickname: '예전 닉',
'riotAccounts.0': { $exists: true },
},
{ $set: { kakaoTalkId: 'new-id' } },
{ returnDocument: 'after' },
);
});
it.each([
['not-found', 0],
['ambiguous', 2],
] as const)('returns %s without mutation', async (status, count) => {
const { service, user, find, findOneAndUpdate } = setup();
find.mockReturnValue({
limit: () => ({
exec: async () => Array.from({ length: count }, () => user),
}),
});
expect(await service.transferKakaoTalkId(params)).toBe(status);
expect(findOneAndUpdate).not.toHaveBeenCalled();
});
it('does not mutate an already linked user', async () => {
const { service, user, findOneAndUpdate } = setup();
user.kakaoTalkId = 'new-id';
expect(await service.transferKakaoTalkId(params)).toBe('already-linked');
expect(findOneAndUpdate).not.toHaveBeenCalled();
});
it('refuses an ID occupied by another user', async () => {
const { service, findOne, findOneAndUpdate } = setup();
findOne.mockReturnValue({
exec: async () => ({ _id: new mongoose.Types.ObjectId() }),
});
expect(await service.transferKakaoTalkId(params)).toBe('id-conflict');
expect(findOne).toHaveBeenCalledWith({
communityId,
kakaoTalkId: 'new-id',
});
expect(findOneAndUpdate).not.toHaveBeenCalled();
});
it('reports a concurrent change instead of overwriting it', async () => {
const { service, update } = setup();
update.mockResolvedValue(null);
expect(await service.transferKakaoTalkId(params)).toBe('changed');
});
it('handles a concurrent ID collision', async () => {
const { service, update } = setup();
update.mockRejectedValue({ code: 11000 });
expect(await service.transferKakaoTalkId(params)).toBe('id-conflict');
});
it('propagates unexpected database failures for retry', async () => {
const { service, update } = setup();
update.mockRejectedValue(new Error('database unavailable'));
await expect(service.transferKakaoTalkId(params)).rejects.toThrow(
'database unavailable',
);
});
});
@@ -105,7 +105,7 @@ describe('DakaoUserService', () => {
tagLine: 'KR2',
isPrimary: false,
});
expect((result.user.riotAccounts as RiotAccount[])[0]).toMatchObject({
expect(result.user.riotAccounts[0]).toMatchObject({
puuid: 'puuid-1',
isPrimary: true,
});
@@ -223,11 +223,21 @@ describe('DakaoUserService', () => {
puuid: 'puuid-1',
gameName: '기존소환사',
tagLine: 'KR1',
profileIconId: 1,
revisionDate: 0,
summonerLevel: 30,
tiers: [],
tierHistory: [],
matchIds: [],
championMasteries: [],
championRecords: {},
isPrimary: true,
createdAt: new Date('2026-05-03T00:00:00.000Z'),
updatedAt: new Date('2026-05-03T00:00:00.000Z'),
},
],
save,
} as Partial<UserDocument>,
} satisfies Partial<UserDocument>,
});
await expect(
@@ -60,6 +60,14 @@ interface ResolvedRiotIdentity {
const DEFAULT_RIOT_PLATFORM: RiotPlatformRoute = 'kr';
const DEFAULT_RIOT_REGION: RiotRegionalRoute = 'asia';
export type KakaoDataTransferResult =
| 'transferred'
| 'already-linked'
| 'not-found'
| 'ambiguous'
| 'id-conflict'
| 'changed';
@Injectable()
export class DakaoUserService {
private readonly logger = new Logger(DakaoUserService.name);
@@ -87,7 +95,7 @@ export class DakaoUserService {
if (!community) {
throw new DakaoUserError('community_not_found', dakaoProjectId);
}
return community._id as mongoose.Types.ObjectId;
return community._id;
}
public async upsertUser(params: {
@@ -127,6 +135,44 @@ export class DakaoUserService {
}).exec();
}
public async transferKakaoTalkId(params: {
communityId: mongoose.Types.ObjectId;
kakaoTalkId: string;
previousNickname: string;
}): Promise<KakaoDataTransferResult> {
const UserModel = await this.connectionService.getModel('user');
const targetFilter = {
communityId: params.communityId,
kakaoTalkNickname: params.previousNickname,
'riotAccounts.0': { $exists: true },
};
const candidates = await UserModel.find(targetFilter).limit(2).exec();
if (candidates.length === 0) return 'not-found';
if (candidates.length > 1) return 'ambiguous';
const user = candidates[0];
if (user.kakaoTalkId === params.kakaoTalkId) return 'already-linked';
const occupied = await this.findUserByKakaoTalkId(params);
if (occupied) return 'id-conflict';
try {
// Compare the previous ID so concurrent transfers cannot overwrite one another.
const updated = await UserModel.findOneAndUpdate(
{
...targetFilter,
_id: user._id,
kakaoTalkId: user.kakaoTalkId ?? null,
},
{ $set: { kakaoTalkId: params.kakaoTalkId } },
{ returnDocument: 'after' },
).exec();
return updated ? 'transferred' : 'changed';
} catch (error) {
if ((error as { code?: number })?.code === 11000) return 'id-conflict';
throw error;
}
}
public async resolveRiotAccount(
context: ResolveContext,
): Promise<ResolveResult> {
@@ -12,6 +12,7 @@ import { DakaoUserService } from './dakao-user.service';
import { DakaoSendResultSubscriber } from './dakao-send-result.subscriber';
import { DakaoUrlShortenerService } from './dakao-url-shortener.service';
import { AccountRegisterHandler } from './handlers/account-register.handler';
import { DataTransferHandler } from './handlers/data-transfer.handler';
import { MatchCancelHandler } from './handlers/match-cancel.handler';
import { MatchJoinHandler } from './handlers/match-join.handler';
import { MatchListHandler } from './handlers/match-list.handler';
@@ -35,6 +36,7 @@ import { PrimaryAccountChangeHandler } from './handlers/primary-account-change.h
DakaoUserService,
DakaoUrlShortenerService,
AccountRegisterHandler,
DataTransferHandler,
MatchListHandler,
MatchJoinHandler,
MatchCancelHandler,
@@ -16,6 +16,7 @@ function makeSubscriber(): DakaoSubscriber {
{} as never,
{} as never,
{} as never,
{} as never,
);
}
@@ -39,6 +40,48 @@ const event = {
} satisfies DakaoInboundEvent;
describe('DakaoSubscriber', () => {
it('routes data transfer with the current sender ID and publishes its reply', async () => {
const subscriber = makeSubscriber();
const segments = [{ kind: 'text', text: ' 데이터 이관 완료' }];
const handle = jest.fn().mockResolvedValue(segments);
const sendMessage = jest.fn();
const markProcessed = jest.fn();
Object.assign(subscriber, {
dakaoUserService: {
resolveCommunityIdByDakaoProjectId: async () => event.projectId,
},
dataTransferHandler: { handle },
publisher: { sendMessage },
inbox: { claim: async () => ({ status: 'claimed' }), markProcessed },
});
await (
subscriber as unknown as {
handleEvent: (input: DakaoInboundEvent) => Promise<void>;
}
).handleEvent({
...event,
origin: {
...event.origin,
chatLog: {
...event.origin.chatLog,
message: '!내전 데이터이관 예전 닉',
},
},
});
expect(handle).toHaveBeenCalledWith({
communityId: event.projectId,
senderUserId: '12345',
senderNickname: '프리리',
previousNickname: '예전 닉',
});
expect(sendMessage).toHaveBeenCalledWith({
chatroomId: 'chatroom-1',
segments,
correlationId: 'log-1',
});
expect(markProcessed).toHaveBeenCalled();
});
it('renders usage help with star emoticon command lines', () => {
const subscriber = makeSubscriber() as unknown as {
parseErrorReply: (
@@ -65,6 +108,8 @@ describe('DakaoSubscriber', () => {
text: ' !내전 신청 코드 소환사이름#태그 포지션1,포지션2\u3000\n',
},
{ kind: 'emoticon', id: '1200281_035', altText: '스타' },
{ kind: 'text', text: ' !내전 취소 코드\u3000\n' },
{ kind: 'emoticon', id: '1200281_035', altText: '스타' },
{ kind: 'text', text: ' !내전 계정등록 소환사이름#태그\u3000\n' },
{ kind: 'emoticon', id: '1200281_035', altText: '스타' },
{
@@ -74,8 +119,10 @@ describe('DakaoSubscriber', () => {
{ kind: 'emoticon', id: '1200281_035', altText: '스타' },
{
kind: 'text',
text: ' !내전 대표계정변경 소환사이름#태그',
text: ' !내전 대표계정변경 소환사이름#태그\u3000\n',
},
{ kind: 'emoticon', id: '1200281_035', altText: '스타' },
{ kind: 'text', text: ' !내전 데이터이관 이전카카오톡채팅방닉네임' },
]);
});
+13 -1
View File
@@ -7,6 +7,7 @@ import { DakaoInboundEvent, DakaoLong, DakaoSegment } from './dakao.types';
import { DakaoPublisher } from './dakao.publisher';
import { DakaoUserError, DakaoUserService } from './dakao-user.service';
import { AccountRegisterHandler } from './handlers/account-register.handler';
import { DataTransferHandler } from './handlers/data-transfer.handler';
import { MatchCancelHandler } from './handlers/match-cancel.handler';
import { MatchJoinHandler } from './handlers/match-join.handler';
import { MatchListHandler } from './handlers/match-list.handler';
@@ -24,9 +25,11 @@ export class DakaoSubscriber implements OnModuleInit {
private readonly usageCommands = [
'!내전 일정',
'!내전 신청 코드 소환사이름#태그 포지션1,포지션2',
'!내전 취소 코드',
'!내전 계정등록 소환사이름#태그',
'!내전 선호포지션등록 포지션1,포지션2',
'!내전 대표계정변경 소환사이름#태그',
'!내전 데이터이관 이전카카오톡채팅방닉네임',
];
constructor(
@@ -42,6 +45,7 @@ export class DakaoSubscriber implements OnModuleInit {
private readonly matchCancelHandler: MatchCancelHandler,
private readonly preferredPositionRegisterHandler: PreferredPositionRegisterHandler,
private readonly primaryAccountChangeHandler: PrimaryAccountChangeHandler,
private readonly dataTransferHandler: DataTransferHandler,
) {}
async onModuleInit() {
@@ -119,6 +123,14 @@ export class DakaoSubscriber implements OnModuleInit {
const command = parseCommand(event.origin.chatLog.message);
switch (command.kind) {
case 'data-transfer':
segments = await this.dataTransferHandler.handle({
communityId,
senderUserId: event.userId,
senderNickname,
previousNickname: command.previousNickname,
});
break;
case 'match-list':
segments = await this.matchListHandler.handle({
communityId,
@@ -301,7 +313,7 @@ export class DakaoSubscriber implements OnModuleInit {
text:
index === this.usageCommands.length - 1
? ` ${command}`
: ` ${command} \n`,
: ` ${command}\u3000\n`,
} as const,
]);
}
@@ -0,0 +1,49 @@
import mongoose from 'mongoose';
import {
DakaoUserService,
KakaoDataTransferResult,
} from '../dakao-user.service';
import { DataTransferHandler } from './data-transfer.handler';
const params = {
communityId: new mongoose.Types.ObjectId(),
senderUserId: 'new-id',
senderNickname: '현재 닉',
previousNickname: '예전 닉',
};
describe('DataTransferHandler', () => {
it.each<[KakaoDataTransferResult, string]>([
['transferred', '데이터 이관 완료'],
['already-linked', '이미 현재 카카오톡 계정에 연결'],
['not-found', '찾을 수 없습니다'],
['ambiguous', '여러 명'],
['id-conflict', '이미 다른 사용자'],
['changed', '변경되었습니다'],
])('replies to the sender for %s', async (result, message) => {
const transferKakaoTalkId = jest.fn().mockResolvedValue(result);
const handler = new DataTransferHandler({
transferKakaoTalkId,
} as unknown as DakaoUserService);
expect(await handler.handle(params)).toEqual([
{ kind: 'mention', userId: 'new-id', displayText: '현재 닉' },
{ kind: 'text', text: expect.stringContaining(message) },
]);
expect(transferKakaoTalkId).toHaveBeenCalledWith({
communityId: params.communityId,
kakaoTalkId: 'new-id',
previousNickname: '예전 닉',
});
});
it('propagates unexpected failures', async () => {
const handler = new DataTransferHandler({
transferKakaoTalkId: jest
.fn()
.mockRejectedValue(new Error('database unavailable')),
} as unknown as DakaoUserService);
await expect(handler.handle(params)).rejects.toThrow(
'database unavailable',
);
});
});
@@ -0,0 +1,46 @@
import { Injectable } from '@nestjs/common';
import mongoose from 'mongoose';
import {
DakaoUserService,
KakaoDataTransferResult,
} from '../dakao-user.service';
import { DakaoSegment } from '../dakao.types';
const RESULT_MESSAGES: Record<KakaoDataTransferResult, string> = {
transferred:
'데이터 이관 완료. 기존 라이엇 계정과 내전 기록이 현재 카카오톡 계정에 연결되었습니다.',
'already-linked': '이미 현재 카카오톡 계정에 연결된 사용자입니다.',
'not-found':
'해당 예전 닉네임으로 라이엇 계정이 등록된 사용자를 찾을 수 없습니다.',
ambiguous:
'같은 예전 닉네임으로 등록된 사용자가 여러 명입니다. 운영자에게 문의해주세요.',
'id-conflict':
'현재 카카오톡 계정에 이미 다른 사용자가 등록되어 있습니다. 운영자에게 문의해주세요.',
changed: '이관 중 사용자 정보가 변경되었습니다. 다시 시도해주세요.',
};
@Injectable()
export class DataTransferHandler {
constructor(private readonly dakaoUserService: DakaoUserService) {}
public async handle(params: {
communityId: mongoose.Types.ObjectId;
senderUserId: string;
senderNickname: string;
previousNickname: string;
}): Promise<DakaoSegment[]> {
const result = await this.dakaoUserService.transferKakaoTalkId({
communityId: params.communityId,
kakaoTalkId: params.senderUserId,
previousNickname: params.previousNickname,
});
return [
{
kind: 'mention',
userId: params.senderUserId,
displayText: params.senderNickname,
},
{ kind: 'text', text: ` ${RESULT_MESSAGES[result]}` },
];
}
}
@@ -104,9 +104,11 @@ describe('MatchCancelHandler', () => {
const handler = makeHandler({
matchService: {
cancelJoin,
list: jest.fn().mockResolvedValue([
{ _id: matchId, title: '저녁 내전', shortCode: 'AB12' },
]),
list: jest
.fn()
.mockResolvedValue([
{ _id: matchId, title: '저녁 내전', shortCode: 'AB12' },
]),
} as Partial<MatchService>,
dakaoUserService: {
findUserByKakaoTalkId,
@@ -230,9 +230,11 @@ describe('MatchJoinHandler', () => {
const resolveRiotAccount = jest.fn();
const handler = makeHandler({
matchService: {
list: jest.fn().mockResolvedValue([
{ _id: matchId, title: '저녁 내전', shortCode: 'AB12' },
]),
list: jest
.fn()
.mockResolvedValue([
{ _id: matchId, title: '저녁 내전', shortCode: 'AB12' },
]),
join,
} as Partial<MatchService>,
dakaoUserService: {
@@ -282,9 +284,11 @@ describe('MatchJoinHandler', () => {
const join = jest.fn();
const handler = makeHandler({
matchService: {
list: jest.fn().mockResolvedValue([
{ _id: matchId, title: '저녁 내전', shortCode: 'AB12' },
]),
list: jest
.fn()
.mockResolvedValue([
{ _id: matchId, title: '저녁 내전', shortCode: 'AB12' },
]),
join,
} as Partial<MatchService>,
dakaoUserService: {
@@ -44,9 +44,7 @@ export class MatchJoinHandler {
return this.errorReply(params, joinTarget);
}
let resolved:
| { user: UserDocument; riotAccount: RiotAccount }
| string;
let resolved: { user: UserDocument; riotAccount: RiotAccount } | string;
try {
resolved =
joinTarget.gameName && joinTarget.tagLine
@@ -243,10 +241,7 @@ export class MatchJoinHandler {
const gameName = normalizeRiotIdPart(value.slice(splitAt + 1));
if (!matchTitlePrefix || !gameName) continue;
const result = resolveRecruitingMatchReference(
matchTitlePrefix,
matches,
);
const result = resolveRecruitingMatchReference(matchTitlePrefix, matches);
if (result.kind === 'matched') {
return { kind: 'matched', match: result.match, gameName };
}
@@ -22,6 +22,33 @@ function makeHandler(params: {
}
describe('MatchListHandler', () => {
afterEach(() => {
jest.useRealTimers();
});
it('queries only matches scheduled at or after command processing time', async () => {
const now = new Date('2026-07-25T07:30:00.000Z');
jest.useFakeTimers().setSystemTime(now);
const communityId = objectId('111111111111111111111111');
const list = jest.fn().mockResolvedValue([]);
const handler = makeHandler({
matchService: { list },
});
await handler.handle({
communityId,
senderUserId: 'kakao-user-1',
senderNickname: '프리리',
});
expect(list).toHaveBeenCalledWith({
communityId,
status: 'recruiting',
scheduledFrom: now,
limit: 10,
});
});
it('prints short codes, compact KST dates, and short links', async () => {
const match = {
_id: objectId('333333333333333333333333'),
@@ -19,9 +19,11 @@ export class MatchListHandler {
senderUserId: string;
senderNickname: string;
}): Promise<DakaoSegment[]> {
const scheduledFrom = new Date();
const matches = await this.matchService.list({
communityId: params.communityId,
status: 'recruiting',
scheduledFrom,
limit: 10,
});
@@ -20,8 +20,8 @@ export class IdempotencyCache {
public remember(key: string): void {
this.evictExpired();
if (this.entries.size >= MAX_ENTRIES) {
const oldestKey = this.entries.keys().next().value;
if (oldestKey !== undefined) this.entries.delete(oldestKey);
const oldestKey: unknown = this.entries.keys().next().value;
if (typeof oldestKey === 'string') this.entries.delete(oldestKey);
}
this.entries.set(key, Date.now() + TTL_MS);
}
@@ -1,6 +1,19 @@
import { CommandParseError, parseCommand } from './command.parser';
describe('parseCommand', () => {
it('parses data transfer with the complete previous nickname', () => {
expect(parseCommand(' !내전 데이터이관 예전 닉.* ')).toEqual({
kind: 'data-transfer',
previousNickname: '예전 닉.*',
});
});
it('requires a previous nickname for data transfer', () => {
expect(() => parseCommand('!내전 데이터이관 ')).toThrow(
new CommandParseError('usage'),
);
});
it('parses match-list command (목록)', () => {
expect(parseCommand('!내전 목록')).toEqual({ kind: 'match-list' });
});
@@ -22,7 +35,7 @@ describe('parseCommand', () => {
matchAndRiotId: '69b63bc96da18dfdb218ee8c 프리리#KR1',
});
if (result.kind === 'match-join') {
expect(result.positions.positions).toEqual(['MID', 'TOP']);
expect(result.positions?.positions).toEqual(['MID', 'TOP']);
}
});
@@ -7,6 +7,7 @@ import { normalizeRiotIdPart } from '../riot-id.util';
export type DakaoCommand =
| { kind: 'match-list' }
| { kind: 'data-transfer'; previousNickname: string }
| {
kind: 'account-register';
gameName: string;
@@ -75,6 +76,9 @@ export function parseCommand(rawMessage: string): DakaoCommand {
return parseCancelArgs(args);
case '계정등록':
return parseAccountRegisterArgs(args);
case '데이터이관':
if (!args) throw new CommandParseError('usage');
return { kind: 'data-transfer', previousNickname: args };
case '대표계정변경':
return parsePrimaryAccountChangeArgs(args);
case '선호포지션등록':
@@ -144,7 +144,7 @@ export function buildDoubleEliminationBracket(
teamIndex,
}));
const bracket: DoubleEliminationBracket = {
teamCount: seededTeamIndexes.length as 4 | 8,
teamCount: seededTeamIndexes.length,
resetFinalEnabled: options.resetFinalEnabled,
resetFinalCreated: false,
seeds,
@@ -0,0 +1,7 @@
export const AUCTION_CANCELLATION_CLEANUP_INDEX = {
key: { auctionCancellationCleanupRetryAt: 1 as const },
options: {
name: 'auction_cancellation_cleanup_due',
partialFilterExpression: { auctionCancellationCleanupPending: true },
},
};
@@ -19,7 +19,9 @@ describe('auction Redis schema foundation', () => {
expect(AuctionSchema.path('revision')).toBeDefined();
expect(AuctionSchema.path('auctionEngineVersion')).toBeDefined();
expect(AuctionSchema.path('auctionLifecycleId')).toBeDefined();
expect(AuctionSchema.path('lastAppliedAuctionStateTransitionId')).toBeDefined();
expect(
AuctionSchema.path('lastAppliedAuctionStateTransitionId'),
).toBeDefined();
expect(AuctionSchema.path('currentAuctionHistorySequence')).toBeDefined();
expect(AuctionSchema.path('startAuctionRequestId')).toBeDefined();
expect(AuctionSchema.path('startAuctionStateTransitionId')).toBeDefined();
@@ -36,46 +38,73 @@ describe('auction Redis schema foundation', () => {
expect(AuctionSchema.path('auctionBidHistory')).toBeDefined();
expect(AuctionSchema.path('currentHighestBidPointAmount')).toBeDefined();
expect(AuctionSchema.path('currentHighestBidderTeamIndex')).toBeDefined();
expect(AuctionSchema.path('currentBidRoundDeadlineTimestampMS')).toBeDefined();
expect(
AuctionSchema.path('currentBidRoundDeadlineTimestampMS'),
).toBeDefined();
expect(AuctionSchema.path('maximumBidRoundDurationSeconds')).toBeDefined();
expect(AuctionSchema.path('bidRoundExtensionSeconds')).toBeDefined();
expect(AuctionSchema.path('initialTeamBidPointAmount')).toBeDefined();
expect(AuctionSchema.path('topTierAuctionPriorityThreshold')).toBeDefined();
expect(AuctionSchema.path('manualTopTierAuctionPriorityUserIds')).toBeDefined();
expect(
AuctionSchema.path('manualTopTierAuctionPriorityUserIds'),
).toBeDefined();
expect(AuctionSchema.path('auctionStartedAtTimestampMS')).toBeDefined();
expect(AuctionSchema.path('auctionCompletedAtTimestampMS')).toBeDefined();
});
it('adds history transition fields and reset/undo action enum values', () => {
expect(AuctionHistoryEntrySchema.path('auctionStateTransitionId')).toBeDefined();
expect(
AuctionHistoryEntrySchema.path('auctionStateTransitionId'),
).toBeDefined();
expect(AuctionHistoryEntrySchema.path('auctionLifecycleId')).toBeDefined();
expect(AuctionHistoryEntrySchema.path('revision')).toBeDefined();
expect(AuctionHistoryEntrySchema.path('historyMutation')).toBeDefined();
expect(AuctionHistoryEntrySchema.path('matchSideEffectMutation')).toBeDefined();
expect(
AuctionHistoryEntrySchema.path<string>('action').options.enum,
).toEqual(
expect.arrayContaining(['start', 'open-bidding', 'bid', 'sold', 'passed', 'next', 'complete', 'reset', 'undo']),
AuctionHistoryEntrySchema.path('matchSideEffectMutation'),
).toBeDefined();
expect(AuctionHistoryEntrySchema.path('action').options.enum).toEqual(
expect.arrayContaining([
'start',
'open-bidding',
'bid',
'sold',
'passed',
'next',
'complete',
'reset',
'undo',
]),
);
});
it('adds unique history indexes for sequence and transition idempotency', () => {
const indexes = AuctionHistoryEntrySchema.indexes();
expect(indexWithKeys(indexes, { auctionId: 1, sequence: 1 })?.[1]).toMatchObject({
expect(
indexWithKeys(indexes, { auctionId: 1, sequence: 1 })?.[1],
).toMatchObject({
unique: true,
});
expect(
indexWithKeys(indexes, { auctionId: 1, auctionStateTransitionId: 1 })?.[1],
indexWithKeys(indexes, {
auctionId: 1,
auctionStateTransitionId: 1,
})?.[1],
).toMatchObject({ unique: true, sparse: true });
});
it('registers auction side effect application model with lease fields and unique idempotency index', () => {
expect(AuctionSideEffectApplicationSchema.path('processingOwnerToken')).toBeDefined();
expect(
AuctionSideEffectApplicationSchema.path('processingLeaseExpiresAtTimestampMS'),
AuctionSideEffectApplicationSchema.path('processingOwnerToken'),
).toBeDefined();
expect(
AuctionSideEffectApplicationSchema.path(
'processingLeaseExpiresAtTimestampMS',
),
).toBeDefined();
expect(
AuctionSideEffectApplicationSchema.path('payloadChecksum'),
).toBeDefined();
expect(AuctionSideEffectApplicationSchema.path('payloadChecksum')).toBeDefined();
const indexes = AuctionSideEffectApplicationSchema.indexes();
expect(
Loaded 100 of 253 files, more files were not shown because too many files have changed in this diff. Show more