diff --git a/apps/api/src/modules/riot/riot-api.client.spec.ts b/apps/api/src/modules/riot/riot-api.client.spec.ts index e3a4417..f1006c6 100644 --- a/apps/api/src/modules/riot/riot-api.client.spec.ts +++ b/apps/api/src/modules/riot/riot-api.client.spec.ts @@ -122,6 +122,25 @@ describe('RiotApiClient', () => { ); }); + it('accepts current Summoner-V4 by-puuid responses without legacy id fields', async () => { + const fetchMock = createFetchMock().mockResolvedValue( + jsonResponse({ + profileIconId: 7, + puuid: 'puuid-1', + revisionDate: 1_783_056_144_000, + summonerLevel: 30, + }), + ); + const { client } = createClient(fetchMock); + + await expect(client.getSummonerByPuuid('puuid-1', 'kr')).resolves.toEqual({ + profileIconId: 7, + puuid: 'puuid-1', + revisionDate: 1_783_056_144_000, + summonerLevel: 30, + }); + }); + it('honors Retry-After for 429 responses and retries', async () => { const sleep = jest .fn, [number]>() diff --git a/apps/api/src/modules/riot/riot-api.client.ts b/apps/api/src/modules/riot/riot-api.client.ts index 72b8f21..16278ea 100644 --- a/apps/api/src/modules/riot/riot-api.client.ts +++ b/apps/api/src/modules/riot/riot-api.client.ts @@ -29,7 +29,7 @@ export interface RiotAccountDto { export interface RiotSummonerDto { accountId?: string; - id: string; + id?: string; profileIconId: number; puuid: string; revisionDate?: number; @@ -404,7 +404,7 @@ export class RiotApiClient { private parseSummoner(value: unknown): RiotSummonerDto { const record = requireRecord(value, 'summoner'); return { - id: requireString(record, 'id', 'summoner'), + id: optionalString(record, 'id'), accountId: optionalString(record, 'accountId'), puuid: requireString(record, 'puuid', 'summoner'), profileIconId: numberOrFallback(record, 'profileIconId', 0),