From 304f157b914d3628a43c0c23caf887ef144eaac6 Mon Sep 17 00:00:00 2001 From: dahyeon Date: Thu, 2 Jul 2026 22:32:17 -0700 Subject: [PATCH] Accept League V4 entries without league ids --- .../src/modules/riot/riot-api.client.spec.ts | 38 +++++++++++++++++++ apps/api/src/modules/riot/riot-api.client.ts | 2 - 2 files changed, 38 insertions(+), 2 deletions(-) diff --git a/apps/api/src/modules/riot/riot-api.client.spec.ts b/apps/api/src/modules/riot/riot-api.client.spec.ts index 96c7691..89f741b 100644 --- a/apps/api/src/modules/riot/riot-api.client.spec.ts +++ b/apps/api/src/modules/riot/riot-api.client.spec.ts @@ -140,6 +140,44 @@ describe('RiotApiClient', () => { }); }); + it('accepts current League-V4 by-puuid entries without league ids', async () => { + const fetchMock = createFetchMock().mockResolvedValue( + jsonResponse([ + { + queueType: 'RANKED_SOLO_5x5', + tier: 'DIAMOND', + rank: 'IV', + puuid: 'puuid-1', + leaguePoints: 0, + wins: 164, + losses: 152, + veteran: false, + inactive: false, + freshBlood: false, + hotStreak: false, + }, + ]), + ); + const { client } = createClient(fetchMock); + + await expect( + client.getLeagueEntriesByPuuid('puuid-1', 'kr'), + ).resolves.toEqual([ + { + queueType: 'RANKED_SOLO_5x5', + tier: 'DIAMOND', + rank: 'IV', + leaguePoints: 0, + wins: 164, + losses: 152, + veteran: false, + inactive: false, + freshBlood: false, + hotStreak: false, + }, + ]); + }); + it('honors Retry-After for 429 responses and retries', async () => { const sleep = jest .fn, [number]>() diff --git a/apps/api/src/modules/riot/riot-api.client.ts b/apps/api/src/modules/riot/riot-api.client.ts index e7b51db..a7189df 100644 --- a/apps/api/src/modules/riot/riot-api.client.ts +++ b/apps/api/src/modules/riot/riot-api.client.ts @@ -38,7 +38,6 @@ export interface RiotLeagueEntryDto { freshBlood: boolean; hotStreak: boolean; inactive: boolean; - leagueId: string; leaguePoints: number; losses: number; queueType: string; @@ -414,7 +413,6 @@ export class RiotApiClient { return value.map((entry) => { const record = requireRecord(entry, 'league entry'); return { - leagueId: requireString(record, 'leagueId', 'league entry'), queueType: requireString(record, 'queueType', 'league entry'), tier: requireString(record, 'tier', 'league entry'), rank: requireString(record, 'rank', 'league entry'),