Pin vulnerable transitive dependencies to patched releases and replace Infisical SDK bootstrap calls with a compatible HTTP client. Add dependency-security and secret-loading regression coverage.
156 lines
5.3 KiB
TypeScript
156 lines
5.3 KiB
TypeScript
import { ConfigService } from '@nestjs/config';
|
|
import { SecretService } from './secret.service';
|
|
|
|
function makeConfig(values: Record<string, string | undefined> = {}) {
|
|
return {
|
|
get: jest.fn((key: string) => values[key] ?? process.env[key]),
|
|
} as unknown as ConfigService;
|
|
}
|
|
|
|
describe('SecretService', () => {
|
|
const originalEnv = process.env;
|
|
const originalFetch = global.fetch;
|
|
let fetchMock: jest.Mock;
|
|
|
|
beforeEach(() => {
|
|
process.env = { ...originalEnv };
|
|
delete process.env.SECRET_SOURCE;
|
|
delete process.env.TEST_SECRET;
|
|
fetchMock = jest
|
|
.fn()
|
|
.mockRejectedValue(new Error('network calls are disabled in tests'));
|
|
global.fetch = fetchMock;
|
|
});
|
|
|
|
afterEach(() => {
|
|
process.env = originalEnv;
|
|
global.fetch = originalFetch;
|
|
jest.restoreAllMocks();
|
|
});
|
|
|
|
function infisicalConfig() {
|
|
return makeConfig({
|
|
SECRET_SOURCE: 'infisical',
|
|
INFISICAL_SITE_URL: 'https://infisical.example.test/',
|
|
INFISICAL_CLIENT_ID: 'test-client',
|
|
INFISICAL_CLIENT_SECRET: 'test-secret',
|
|
INFISICAL_PROJECT_ID: 'test-project',
|
|
CONFIG_FALLBACK: 'config-value',
|
|
});
|
|
}
|
|
|
|
it.each([
|
|
['prod', 'prod'],
|
|
['staging', 'staging'],
|
|
['dev', 'dev'],
|
|
['production', 'dev'],
|
|
])('preserves environment mapping %s -> %s', async (nodeEnv, environment) => {
|
|
process.env.NODE_ENV = nodeEnv;
|
|
fetchMock
|
|
.mockResolvedValueOnce(Response.json({ accessToken: 'token' }))
|
|
.mockResolvedValueOnce(Response.json({ secrets: [] }));
|
|
await new SecretService(infisicalConfig()).ready();
|
|
const url = new URL(fetchMock.mock.calls[1][0] as string);
|
|
expect(url.searchParams.get('environment')).toBe(environment);
|
|
});
|
|
|
|
it('shares initialization, caches secrets, and preserves empty values and fallbacks', async () => {
|
|
process.env.TEST_EMPTY = 'existing-value';
|
|
fetchMock
|
|
.mockResolvedValueOnce(Response.json({ accessToken: 'token' }))
|
|
.mockResolvedValueOnce(
|
|
Response.json({
|
|
secrets: [
|
|
{ secretKey: 'TEST_SECRET', secretValue: 'first' },
|
|
{ secretKey: 'TEST_SECRET', secretValue: 'last' },
|
|
{ secretKey: 'TEST_EMPTY', secretValue: '' },
|
|
],
|
|
imports: [
|
|
{ secrets: [{ secretKey: 'TEST_IMPORT', secretValue: 'ignored' }] },
|
|
],
|
|
}),
|
|
);
|
|
const service = new SecretService(infisicalConfig());
|
|
await Promise.all([
|
|
service.ready(),
|
|
service.get('TEST_SECRET'),
|
|
service.ready(),
|
|
]);
|
|
await expect(service.get('TEST_SECRET')).resolves.toBe('last');
|
|
await expect(service.get('TEST_EMPTY')).resolves.toBe('');
|
|
await expect(service.get('CONFIG_FALLBACK')).resolves.toBe('config-value');
|
|
await expect(service.get('TEST_IMPORT', 'missing')).resolves.toBe(
|
|
'missing',
|
|
);
|
|
expect(process.env.TEST_SECRET).toBe('last');
|
|
expect(process.env.TEST_EMPTY).toBe('existing-value');
|
|
expect(fetchMock).toHaveBeenCalledTimes(2);
|
|
});
|
|
|
|
it('does not publish partial secrets after failure and permits a later retry', async () => {
|
|
fetchMock
|
|
.mockResolvedValueOnce(Response.json({ accessToken: 'token' }))
|
|
.mockResolvedValueOnce(
|
|
Response.json({
|
|
secrets: [
|
|
{ secretKey: 'TEST_SECRET', secretValue: 'partial' },
|
|
{ secretKey: 'INVALID', secretValue: 123 },
|
|
],
|
|
}),
|
|
)
|
|
.mockResolvedValueOnce(Response.json({ accessToken: 'new-token' }))
|
|
.mockResolvedValueOnce(
|
|
Response.json({
|
|
secrets: [{ secretKey: 'TEST_SECRET', secretValue: 'complete' }],
|
|
}),
|
|
);
|
|
const service = new SecretService(infisicalConfig());
|
|
await expect(service.ready()).rejects.toThrow('invalid secrets response');
|
|
expect(process.env.TEST_SECRET).toBeUndefined();
|
|
await service.ready();
|
|
await expect(service.get('TEST_SECRET')).resolves.toBe('complete');
|
|
expect(fetchMock).toHaveBeenCalledTimes(4);
|
|
});
|
|
|
|
it('defaults to environment-provided secrets without IMDS lookup', async () => {
|
|
process.env.TEST_SECRET = 'from-env';
|
|
const service = new SecretService(makeConfig());
|
|
|
|
await service.ready();
|
|
|
|
await expect(service.get('TEST_SECRET')).resolves.toBe('from-env');
|
|
expect(fetchMock).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it('uses environment-provided secrets when SECRET_SOURCE is env', async () => {
|
|
process.env.SECRET_SOURCE = 'env';
|
|
process.env.TEST_SECRET = 'from-env-source';
|
|
const service = new SecretService(makeConfig());
|
|
|
|
await service.ready();
|
|
|
|
await expect(service.get('TEST_SECRET')).resolves.toBe('from-env-source');
|
|
expect(fetchMock).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it('uses the IMDS and Infisical bootstrap path only when SECRET_SOURCE is infisical', async () => {
|
|
process.env.SECRET_SOURCE = 'infisical';
|
|
const service = new SecretService(makeConfig());
|
|
|
|
await expect(service.ready()).rejects.toThrow(
|
|
'Missing required bootstrap secret: INFISICAL_CLIENT_ID',
|
|
);
|
|
expect(fetchMock).toHaveBeenCalled();
|
|
});
|
|
|
|
it('rejects unsupported SECRET_SOURCE values', async () => {
|
|
process.env.SECRET_SOURCE = 'kubernetes';
|
|
const service = new SecretService(makeConfig());
|
|
|
|
await expect(service.ready()).rejects.toThrow(
|
|
'Invalid SECRET_SOURCE="kubernetes". Expected "env" or "infisical".',
|
|
);
|
|
expect(fetchMock).not.toHaveBeenCalled();
|
|
});
|
|
});
|