fix(auction): harden lifecycle and durable bid storage

Serialize lifecycle changes and make cancellation, deadlines, and match side effects recoverable and idempotent.

Archive accepted bids durably, quarantine invalid payloads, and preserve compatibility with empty round IDs. Synchronize HTTP polling and socket state with scoped resync events.

Add cancellation cleanup index migration and regression coverage. Validated with 744 API tests, 65 Redis integration tests, and 28 Mongo integration tests.
This commit is contained in:
dahyeon committed 2026-11-09 23:24:11 +09:00
1 parent f2eec479d9
commit f649490cd2
55 files changed
+5374 -522

No files matched your search

@@ -1,3 +1,5 @@
import { AuctionLifecycleLock } from './auction-lifecycle-lock';
import { buildAuctionProjectionUnset } from './auction-projection';
import {
AuctionDurabilityScheduler,
buildAuctionHistoryUpsert,
@@ -23,6 +25,12 @@ const payload = {
} as const;
describe('auction durability projection helpers', () => {
beforeEach(() => {
jest
.spyOn(AuctionLifecycleLock.prototype, 'run')
.mockImplementation(async (_id, work) => work());
});
afterEach(() => jest.restoreAllMocks());
it('builds idempotent history upsert by auction and transition id', () => {
expect(buildAuctionHistoryUpsert(payload)).toEqual({
updateOne: {
@@ -59,6 +67,9 @@ describe('auction durability projection helpers', () => {
},
update: {
$set: { phase: 'sold', revision: 9 },
$unset: buildAuctionProjectionUnset(
payload.afterAuctionMongoProjection,
),
},
});
});
@@ -210,7 +221,12 @@ describe('auction durability projection helpers', () => {
auctionLifecycleId: 'life-1',
revision: { $lt: 9 },
},
{ $set: { phase: 'sold', revision: 9 } },
{
$set: { phase: 'sold', revision: 9 },
$unset: buildAuctionProjectionUnset(
payload.afterAuctionMongoProjection,
),
},
{ session },
);
expect(session.commitTransaction).toHaveBeenCalledTimes(1);
@@ -370,7 +386,7 @@ describe('auction durability projection helpers', () => {
expect(historyDeleteMany).toHaveBeenCalledWith(
{
auctionId: 'auction-1',
sequence: { $gt: 2 },
sequence: { $gt: 2, $lt: 4 },
},
{ session },
);
@@ -811,21 +827,14 @@ describe('auction durability projection helpers', () => {
skipped: 0,
});
expect(sendCommand).toHaveBeenNthCalledWith(5, [
'ZREM',
'EVAL',
expect.stringContaining("redis.call('HEXISTS'"),
'4',
'payload-1',
'auction:auctionDurabilityRetryQueue',
'payload-1',
]);
expect(sendCommand).toHaveBeenNthCalledWith(6, [
'HSET',
'payload-1',
'deadLetteredAtRedisTimestampMS',
'1000',
]);
expect(sendCommand).toHaveBeenNthCalledWith(7, [
'ZADD',
'auction:auctionDurabilityDeadLetterQueue',
'auction:deadLetterStatusQueue',
'1000',
'payload-1',
]);
});
@@ -1030,11 +1039,20 @@ describe('auction durability projection helpers', () => {
{
_id: 'auction-1',
auctionLifecycleId: 'life-1',
matchSideEffectRevision: 1,
$or: [
{ matchSideEffectTransitionId: 'transition-1' },
{
matchSideEffectTransitionId: { $exists: false },
matchSideEffectRevision: 1,
},
],
},
{
$inc: { matchSideEffectRevision: 1 },
$set: { matchSideEffectStatus: 'processing' },
$set: {
matchSideEffectStatus: 'processing',
matchSideEffectTransitionId: 'transition-1',
},
$unset: { matchSideEffectError: '' },
},
expect.objectContaining({ returnDocument: 'after' }),
@@ -1045,34 +1063,42 @@ describe('auction durability projection helpers', () => {
_id: 'auction-1',
auctionLifecycleId: 'life-1',
matchSideEffectRevision: 2,
matchSideEffectTransitionId: 'transition-1',
},
{
$inc: { matchSideEffectRevision: 1 },
$set: { matchSideEffectStatus: 'completed' },
$set: {
matchSideEffectStatus: 'completed',
matchSideEffectTransitionId: 'transition-1',
},
$unset: { matchSideEffectError: '' },
},
expect.objectContaining({ returnDocument: 'after' }),
);
expect(mirrorMatchSideEffectStatus).toHaveBeenCalledWith({
auctionLifecycleId: 'life-1',
auctionStateTransitionId: 'transition-1',
matchId: 'match-1',
matchSideEffectRevision: 2,
matchSideEffectStatus: 'processing',
});
expect(mirrorMatchSideEffectStatus).toHaveBeenLastCalledWith({
auctionLifecycleId: 'life-1',
auctionStateTransitionId: 'transition-1',
matchId: 'match-1',
matchSideEffectRevision: 3,
matchSideEffectStatus: 'completed',
});
expect(broadcastMatchSideEffect).toHaveBeenNthCalledWith(1, 'match-1', {
auctionLifecycleId: 'life-1',
auctionStateTransitionId: 'transition-1',
currentServerTimestampMS: 2000,
matchSideEffectRevision: 2,
matchSideEffectStatus: 'processing',
});
expect(broadcastMatchSideEffect).toHaveBeenNthCalledWith(2, 'match-1', {
auctionLifecycleId: 'life-1',
auctionStateTransitionId: 'transition-1',
currentServerTimestampMS: 3000,
matchSideEffectRevision: 3,
matchSideEffectStatus: 'completed',
@@ -1080,7 +1106,7 @@ describe('auction durability projection helpers', () => {
expect(sendCommand).toHaveBeenCalledWith([
'EVAL',
expect.stringContaining("redis.call('EXPIRE'"),
'11',
'12',
'auction:match-1:liveAuctionState',
'auction:bidRoundDeadlineQueue',
'auction:match-1:auctionStructureState',
@@ -1092,6 +1118,7 @@ describe('auction durability projection helpers', () => {
'auction:match-1:auctionActionRequestResultOrder',
'auction:match-1:rehydrateLock',
'auction:match-1:auctionStateTransitionLock',
'auction:match-1:rejectedBidRequestResultOrder',
'match-1',
'life-1',
String(7 * 24 * 60 * 60),
@@ -1263,7 +1290,12 @@ describe('auction durability projection helpers', () => {
const broadcastMatchSideEffect = jest.fn();
const scheduler = new AuctionDurabilityScheduler(
{
createSession: jest.fn().mockResolvedValue(null),
createSession: jest.fn().mockResolvedValueOnce(null).mockResolvedValue({
startTransaction: jest.fn(),
commitTransaction: jest.fn(),
abortTransaction: jest.fn(),
endSession: jest.fn(),
}),
getModel: jest.fn((name: string) => {
if (name === 'auctionHistory') {
return {
@@ -1282,7 +1314,11 @@ describe('auction durability projection helpers', () => {
return { updateOne: sideEffectUpdateOne };
}
if (name === 'match')
return { findById: jest.fn().mockReturnValue(match) };
return {
findById: jest.fn().mockReturnValue({
session: jest.fn().mockResolvedValue(match),
}),
};
return {};
}),
} as never,
@@ -1301,8 +1337,8 @@ describe('auction durability projection helpers', () => {
await scheduler.applyDurabilityPayload(resetPayload);
expect(releaseFromMatch).toHaveBeenCalledWith(match);
expect(cancelPolling).toHaveBeenCalledWith(match);
expect(releaseFromMatch).toHaveBeenCalledWith(match, expect.any(Object));
expect(cancelPolling).toHaveBeenCalledWith(match, expect.any(Object));
expect(match).toMatchObject({
gameSchedule: [],
result: undefined,
@@ -1328,12 +1364,14 @@ describe('auction durability projection helpers', () => {
);
expect(mirrorMatchSideEffectStatus).toHaveBeenLastCalledWith({
auctionLifecycleId: 'life-1',
auctionStateTransitionId: 'transition-1',
matchId: 'match-1',
matchSideEffectRevision: 3,
matchSideEffectStatus: 'completed',
});
expect(broadcastMatchSideEffect).toHaveBeenLastCalledWith('match-1', {
auctionLifecycleId: 'life-1',
auctionStateTransitionId: 'transition-1',
currentServerTimestampMS: 3000,
matchSideEffectRevision: 3,
matchSideEffectStatus: 'completed',