refactor: rebuild stats from competition revision

This commit is contained in:
dahyeon committed 2026-07-12 19:28:04 +00:00
1 parent 28e9ac1529
commit e6e434d13f
4 files changed
+412 -7

No files matched your search

@@ -17,6 +17,7 @@ describe('MatchStatsService', () => {
const connectionService = {
getModel: jest.fn().mockImplementation(async (name: string) => {
if (name === 'match') return { findById };
if (name === 'competition') return { findOne: () => queryResult(null) };
if (name === 'riotMatch') return {};
throw new Error(`Unexpected model: ${name}`);
}),
@@ -73,6 +74,7 @@ describe('MatchStatsService', () => {
const connectionService = {
getModel: jest.fn().mockImplementation(async (name: string) => {
if (name === 'match') return { findById };
if (name === 'competition') return { findOne: () => queryResult(null) };
if (name === 'riotMatch') return { find: riotFind };
throw new Error(`Unexpected model: ${name}`);
}),
@@ -118,4 +120,149 @@ describe('MatchStatsService', () => {
}),
);
});
it('builds from the Competition projection and records its source revision', async () => {
const matchId = new mongoose.Types.ObjectId();
const communityId = new mongoose.Types.ObjectId();
const competitionId = new mongoose.Types.ObjectId();
const teamAId = new mongoose.Types.ObjectId();
const teamBId = new mongoose.Types.ObjectId();
const userAId = new mongoose.Types.ObjectId();
const userBId = new mongoose.Types.ObjectId();
const match = {
_id: matchId,
communityId,
scheduledAt: new Date('2026-07-12T10:00:00.000Z'),
status: 'in-progress',
teams: [],
result: { games: [{ riotMatchId: 'KR_LEGACY_MUST_NOT_BE_USED' }] },
};
const competition = {
_id: competitionId,
revision: 12,
projectorVersion: 3,
teams: [
{ teamId: teamAId, legacyTeamIndex: 8, displayOrder: 1 },
{ teamId: teamBId, legacyTeamIndex: 3, displayOrder: 2 },
],
projection: {
phase: 'running',
games: [
{
displayNumber: 4,
evidence: { type: 'riot', riotMatchId: 'KR_COMPETITION' },
teams: {
blue: { teamId: teamAId.toString() },
red: { teamId: teamBId.toString() },
},
winnerTeamId: teamAId.toString(),
startedAt: '2026-07-12T10:00:00.000Z',
durationSeconds: 1800,
participants: [
participant(userAId, teamAId, 'blue', true),
participant(userBId, teamBId, 'red', false),
],
},
],
},
};
const riotFind = jest.fn().mockReturnValue({
lean: () => ({
exec: jest
.fn()
.mockResolvedValue([{ matchId: 'KR_COMPETITION', raw: {} }]),
}),
});
const connectionService = {
getModel: jest.fn().mockImplementation(async (name: string) => {
if (name === 'match')
return { findById: () => queryResult(match, false) };
if (name === 'competition') {
return { findOne: () => queryResult(competition) };
}
if (name === 'riotMatch') return { find: riotFind };
throw new Error(`Unexpected model: ${name}`);
}),
} as unknown as ConnectionService;
const repository = {
upsert: jest.fn().mockResolvedValue(undefined),
deleteByMatch: jest.fn(),
} as unknown as jest.Mocked<MatchStatsRepository>;
const builder = {
buildFragment: jest.fn().mockReturnValue({
matchCard: {},
records: [],
gameDetails: [],
userIds: [],
championIds: [],
gameCreationMin: 1,
gameCreationMax: 2,
}),
} as unknown as jest.Mocked<MatchStatsFragmentBuilder>;
const service = new MatchStatsService(
connectionService,
repository,
builder,
{ getMatchTimeline: jest.fn() } as never,
);
await service.buildAndUpsert(matchId);
expect(riotFind).toHaveBeenCalledWith({
matchId: { $in: ['KR_COMPETITION'] },
});
expect(builder.buildFragment).toHaveBeenCalledWith(
expect.objectContaining({
match: expect.objectContaining({
result: expect.objectContaining({
riotMatchIds: ['KR_COMPETITION'],
games: [
expect.objectContaining({
gameNumber: 4,
blueTeamIndex: 8,
redTeamIndex: 3,
winnerTeamIndex: 8,
}),
],
}),
}),
}),
);
expect(repository.upsert).toHaveBeenCalledWith(
expect.objectContaining({
sourceCompetitionId: competitionId,
sourceRevision: 12,
projectorVersion: 3,
}),
);
});
});
function participant(
userId: mongoose.Types.ObjectId,
teamId: mongoose.Types.ObjectId,
side: 'blue' | 'red',
win: boolean,
) {
return {
userId: userId.toString(),
teamId: teamId.toString(),
side,
summonerName: 'player',
tagLine: 'KR1',
championId: 1,
kills: 1,
deaths: 1,
assists: 1,
win,
};
}
function queryResult<T>(value: T, lean = true) {
const query = {
lean: jest.fn(),
exec: jest.fn().mockResolvedValue(value),
};
query.lean.mockReturnValue(query);
return lean ? query : { exec: query.exec };
}