fix(riot): persist refreshed tier state

This commit is contained in:
dahyeon committed 2026-06-07 07:59:11 -07:00
1 parent ef693fcf4a
commit be5383a2e9
2 files changed
+292 -2

No files matched your search

@@ -70,9 +70,11 @@ function makeAccount(overrides: Partial<FakeAccount> = {}): FakeAccount {
function makeUser(account: FakeAccount) { function makeUser(account: FakeAccount) {
const _id = new mongoose.Types.ObjectId(); const _id = new mongoose.Types.ObjectId();
const communityId = new mongoose.Types.ObjectId();
const save = jest.fn().mockResolvedValue(undefined); const save = jest.fn().mockResolvedValue(undefined);
return { return {
_id, _id,
communityId,
riotAccounts: [account], riotAccounts: [account],
save, save,
}; };
@@ -86,6 +88,7 @@ function makeService(overrides?: {
mastery?: Partial<RiotChampionMasteryService>; mastery?: Partial<RiotChampionMasteryService>;
recentMatches?: Partial<RiotRecentMatchesService>; recentMatches?: Partial<RiotRecentMatchesService>;
recentStats?: Partial<RiotRecentStatsService>; recentStats?: Partial<RiotRecentStatsService>;
match?: any;
}) { }) {
const user = overrides?.user; const user = overrides?.user;
const userFindById = jest.fn().mockReturnValue({ const userFindById = jest.fn().mockReturnValue({
@@ -98,10 +101,15 @@ function makeService(overrides?: {
Promise.resolve({ Promise.resolve({
riotPlatform: 'kr', riotPlatform: 'kr',
riotRegion: 'asia', riotRegion: 'asia',
}), }),
}), }),
}), }),
}); });
const matchUpdateManyExec = jest.fn().mockResolvedValue({ modifiedCount: 0 });
const matchModel = {
updateMany: jest.fn().mockReturnValue({ exec: matchUpdateManyExec }),
...overrides?.match,
};
const connectionService = { const connectionService = {
getModel: jest.fn().mockImplementation(async (modelName: string) => { getModel: jest.fn().mockImplementation(async (modelName: string) => {
if (modelName === 'user') { if (modelName === 'user') {
@@ -110,6 +118,9 @@ function makeService(overrides?: {
if (modelName === 'community') { if (modelName === 'community') {
return { findById: communityFindById }; return { findById: communityFindById };
} }
if (modelName === 'match') {
return matchModel;
}
throw new Error(`Unexpected model: ${modelName}`); throw new Error(`Unexpected model: ${modelName}`);
}), }),
} as unknown as ConnectionService; } as unknown as ConnectionService;
@@ -160,6 +171,8 @@ function makeService(overrides?: {
masteryService, masteryService,
recentMatchesService, recentMatchesService,
recentStatsService, recentStatsService,
matchModel,
matchUpdateManyExec,
}; };
} }
@@ -437,6 +450,206 @@ describe('RiotAccountEnrichmentService', () => {
expect(user.save).toHaveBeenCalledTimes(1); expect(user.save).toHaveBeenCalledTimes(1);
}); });
it('appends tier history when LP changes without tier or rank changes', async () => {
const recent = new Date(Date.now() - 60_000);
const account = makeAccount({
revisionDate: Date.now() - 60_000,
tiers: [
{
leagueId: 'L1',
queueType: 'RANKED_SOLO_5x5',
tier: 'GOLD',
rank: 'II',
puuid: 'puuid-1',
leaguePoints: 10,
wins: 20,
losses: 12,
fetchedAt: recent,
},
],
tierHistory: [
{
queueType: 'RANKED_SOLO_5x5',
tier: 'GOLD',
rank: 'II',
leaguePoints: 10,
wins: 20,
losses: 12,
recordedAt: recent,
},
],
recentStatsFetchedAt: recent,
recentStatsSummary: createEmptyRiotRecentStatsSummary(),
});
const user = makeUser(account);
const { service } = makeService({
user,
league: {
getEntriesByPuuid: jest.fn().mockResolvedValue([
{
leagueId: 'L1',
queueType: 'RANKED_SOLO_5x5',
tier: 'GOLD',
rank: 'II',
puuid: 'puuid-1',
leaguePoints: 44,
wins: 21,
losses: 12,
},
]),
} as Partial<RiotLeagueService>,
});
await service.refreshLeagueEntries({
userId: user._id,
puuid: 'puuid-1',
platform: 'kr',
});
expect(account.tierHistory).toHaveLength(2);
expect(account.tierHistory.at(-1)).toMatchObject({
queueType: 'RANKED_SOLO_5x5',
tier: 'GOLD',
rank: 'II',
leaguePoints: 44,
wins: 21,
losses: 12,
});
});
it('syncs refreshed league tier into active match participant snapshots', async () => {
const recent = new Date(Date.now() - 60_000);
const account = makeAccount({
revisionDate: Date.now() - 60_000,
tiers: [
{
leagueId: 'L1',
queueType: 'RANKED_SOLO_5x5',
tier: 'GOLD',
rank: 'II',
puuid: 'puuid-1',
leaguePoints: 1,
wins: 1,
losses: 1,
fetchedAt: recent,
},
],
recentStatsFetchedAt: recent,
recentStatsSummary: createEmptyRiotRecentStatsSummary(),
});
const user = makeUser(account);
const { service, matchModel } = makeService({
user,
league: {
getEntriesByPuuid: jest.fn().mockResolvedValue([
{
leagueId: 'L2',
queueType: 'RANKED_SOLO_5x5',
tier: 'PLATINUM',
rank: 'IV',
puuid: 'puuid-1',
leaguePoints: 20,
wins: 10,
losses: 8,
},
]),
} as Partial<RiotLeagueService>,
});
await service.refreshLeagueEntries({
userId: user._id,
puuid: 'puuid-1',
platform: 'kr',
});
expect(matchModel.updateMany).toHaveBeenCalledWith(
{
status: { $in: ['recruiting', 'team-built', 'in-progress'] },
participants: {
$elemMatch: {
userId: user._id,
puuid: 'puuid-1',
},
},
},
{
$set: {
'participants.$[participant].tier': expect.objectContaining({
leagueId: 'L2',
queueType: 'RANKED_SOLO_5x5',
tier: 'PLATINUM',
rank: 'IV',
leaguePoints: 20,
}),
},
},
{
arrayFilters: [
{
'participant.userId': user._id,
'participant.puuid': 'puuid-1',
},
],
},
);
});
it('clears active match participant tier when refreshed league entries are empty', async () => {
const recent = new Date(Date.now() - 60_000);
const account = makeAccount({
revisionDate: Date.now() - 60_000,
tiers: [
{
leagueId: 'L1',
queueType: 'RANKED_SOLO_5x5',
tier: 'GOLD',
rank: 'II',
puuid: 'puuid-1',
leaguePoints: 1,
wins: 1,
losses: 1,
fetchedAt: recent,
},
],
recentStatsFetchedAt: recent,
recentStatsSummary: createEmptyRiotRecentStatsSummary(),
});
const user = makeUser(account);
const { service, matchModel } = makeService({
user,
league: {
getEntriesByPuuid: jest.fn().mockResolvedValue([]),
} as Partial<RiotLeagueService>,
});
await service.refreshLeagueEntries({
userId: user._id,
puuid: 'puuid-1',
platform: 'kr',
});
expect(matchModel.updateMany).toHaveBeenCalledWith(
{
status: { $in: ['recruiting', 'team-built', 'in-progress'] },
participants: {
$elemMatch: {
userId: user._id,
puuid: 'puuid-1',
},
},
},
{ $unset: { 'participants.$[participant].tier': '' } },
{
arrayFilters: [
{
'participant.userId': user._id,
'participant.puuid': 'puuid-1',
},
],
},
);
});
it('records failed for individual failing fetches but updates the rest', async () => { it('records failed for individual failing fetches but updates the rest', async () => {
const account = makeAccount(); const account = makeAccount();
const user = makeUser(account); const user = makeUser(account);
@@ -3,6 +3,7 @@ import mongoose from 'mongoose';
import { ConnectionService } from '../global/database/connection.service'; import { ConnectionService } from '../global/database/connection.service';
import { import {
ChampionMasteryEntry, ChampionMasteryEntry,
MatchStatus,
RiotAccount, RiotAccount,
TierInfo, TierInfo,
} from '../global/database/schema'; } from '../global/database/schema';
@@ -33,6 +34,11 @@ const DEFAULT_SUMMONER_TTL_MS = 24 * 60 * 60 * 1000; // 24h
const DEFAULT_LEAGUE_TTL_MS = 60 * 60 * 1000; // 1h const DEFAULT_LEAGUE_TTL_MS = 60 * 60 * 1000; // 1h
const DEFAULT_MASTERY_TTL_MS = 6 * 60 * 60 * 1000; // 6h const DEFAULT_MASTERY_TTL_MS = 6 * 60 * 60 * 1000; // 6h
const DEFAULT_RECENT_MATCHES_TTL_MS = 6 * 60 * 60 * 1000; // 6h const DEFAULT_RECENT_MATCHES_TTL_MS = 6 * 60 * 60 * 1000; // 6h
const ACTIVE_MATCH_STATUSES: MatchStatus[] = [
'recruiting',
'team-built',
'in-progress',
];
export interface EnrichOptions { export interface EnrichOptions {
platform?: RiotPlatformRoute; platform?: RiotPlatformRoute;
@@ -117,6 +123,11 @@ export class RiotAccountEnrichmentService {
this.applyLeagueEntries(account, outcome.dto); this.applyLeagueEntries(account, outcome.dto);
await user.save(); await user.save();
await this.syncActiveMatchParticipantTier(
user._id,
params.puuid,
account.tiers,
);
return 'updated'; return 'updated';
} }
@@ -243,6 +254,13 @@ export class RiotAccountEnrichmentService {
) { ) {
await user.save(); await user.save();
} }
if (leagueOutcome.status === 'updated') {
await this.syncActiveMatchParticipantTier(
user._id,
params.puuid,
account.tiers,
);
}
return { return {
summoner: summonerOutcome.status, summoner: summonerOutcome.status,
@@ -425,7 +443,10 @@ export class RiotAccountEnrichmentService {
const changed = const changed =
!last || !last ||
last.tier !== entry.tier || last.tier !== entry.tier ||
(last.rank ?? '') !== (entry.rank ?? ''); (last.rank ?? '') !== (entry.rank ?? '') ||
last.leaguePoints !== entry.leaguePoints ||
last.wins !== entry.wins ||
last.losses !== entry.losses;
if (!changed) continue; if (!changed) continue;
account.tierHistory.push({ account.tierHistory.push({
@@ -463,6 +484,62 @@ export class RiotAccountEnrichmentService {
account.matchIdsFetchedAt = fetchedAt; account.matchIdsFetchedAt = fetchedAt;
} }
private async syncActiveMatchParticipantTier(
userId: mongoose.Types.ObjectId,
puuid: string,
tiers: TierInfo[],
): Promise<void> {
const MatchModel = await this.connectionService.getModel('match');
const tier = this.selectParticipantTier(tiers);
const update = tier
? { $set: { 'participants.$[participant].tier': tier } }
: { $unset: { 'participants.$[participant].tier': '' } };
await MatchModel.updateMany(
{
status: { $in: ACTIVE_MATCH_STATUSES },
participants: {
$elemMatch: {
userId,
puuid,
},
},
},
update,
{
arrayFilters: [
{
'participant.userId': userId,
'participant.puuid': puuid,
},
],
},
).exec();
}
private selectParticipantTier(tiers: TierInfo[]): TierInfo | undefined {
const tier =
tiers.find((entry) => entry.queueType === 'RANKED_SOLO_5x5') ?? tiers[0];
if (!tier) return undefined;
return {
leagueId: tier.leagueId,
queueType: tier.queueType,
tier: tier.tier,
rank: tier.rank,
puuid: tier.puuid,
leaguePoints: tier.leaguePoints,
wins: tier.wins,
losses: tier.losses,
veteran: tier.veteran,
inactive: tier.inactive,
freshBlood: tier.freshBlood,
hotStreak: tier.hotStreak,
miniSeries: tier.miniSeries,
fetchedAt: tier.fetchedAt,
};
}
private tiersOldestAt(tiers: TierInfo[]): number { private tiersOldestAt(tiers: TierInfo[]): number {
if (tiers.length === 0) return 0; if (tiers.length === 0) return 0;
let oldest = Infinity; let oldest = Infinity;