fix(api): keep zero-bid auction passes open

This commit is contained in:
dahyeon committed 2026-06-07 07:01:01 -07:00
1 parent 6a192276e8
commit b711c63dcd
2 files changed
+67 -90

No files matched your search

@@ -348,7 +348,7 @@ describe('AuctionService', () => {
expect(auction.save).not.toHaveBeenCalled(); expect(auction.save).not.toHaveBeenCalled();
}); });
it('marks a zero-bid player as passed and queues them for round two', async () => { it('marks a zero-bid player as passed and queues them for another round', async () => {
const matchId = new mongoose.Types.ObjectId(); const matchId = new mongoose.Types.ObjectId();
const playerId = new mongoose.Types.ObjectId(); const playerId = new mongoose.Types.ObjectId();
const auction = { const auction = {
@@ -383,25 +383,63 @@ describe('AuctionService', () => {
expect(auction.save).toHaveBeenCalledTimes(1); expect(auction.save).toHaveBeenCalledTimes(1);
}); });
it('force-assigns second-pass players to the open team with most points', async () => { it('queues zero-bid passes after the first auction round', async () => {
const matchId = new mongoose.Types.ObjectId();
const playerId = new mongoose.Types.ObjectId();
const auction = {
_id: new mongoose.Types.ObjectId(),
matchId,
phase: 'bidding',
currentBid: 0,
currentIndex: 0,
auctionRound: 2,
order: [
{
userId: playerId,
preferredPositions: [{ position: 'MID', priority: 1 }],
passCount: 1,
},
],
passedQueue: [],
save: jest.fn().mockResolvedValue(undefined),
toObject: jest.fn().mockReturnValue({ _id: 'auction', matchId }),
};
const { service } = createService({
auction: {
findOne: jest.fn().mockResolvedValue(auction),
},
});
await service.markPassed(matchId);
expect(auction.phase).toBe('passed');
expect(auction.order[0].passCount).toBe(2);
expect(auction.passedQueue).toHaveLength(1);
expect(auction.passedQueue[0]).toMatchObject({
userId: playerId.toString(),
preferredPositions: [{ position: 'MID', priority: 1 }],
passCount: 2,
});
});
it('requeues second-pass players instead of force-assigning them', async () => {
const matchId = new mongoose.Types.ObjectId(); const matchId = new mongoose.Types.ObjectId();
const captainOneId = new mongoose.Types.ObjectId(); const captainOneId = new mongoose.Types.ObjectId();
const captainTwoId = new mongoose.Types.ObjectId(); const captainTwoId = new mongoose.Types.ObjectId();
const passedPlayerId = new mongoose.Types.ObjectId(); const passedPlayerId = new mongoose.Types.ObjectId();
const passedPlayer = {
userId: passedPlayerId,
preferredPositions: [{ position: 'SUP', priority: 1 }],
passCount: 2,
};
const auction = { const auction = {
_id: new mongoose.Types.ObjectId(), _id: new mongoose.Types.ObjectId(),
matchId, matchId,
phase: 'passed', phase: 'passed',
currentIndex: 0, currentIndex: 0,
auctionRound: 2, auctionRound: 2,
order: [ order: [passedPlayer],
{ passedQueue: [passedPlayer],
userId: passedPlayerId,
preferredPositions: [{ position: 'SUP', priority: 1 }],
passCount: 2,
},
],
passedQueue: [],
teams: [ teams: [
{ {
teamIndex: 1, teamIndex: 1,
@@ -419,46 +457,28 @@ describe('AuctionService', () => {
save: jest.fn().mockResolvedValue(undefined), save: jest.fn().mockResolvedValue(undefined),
toObject: jest.fn().mockReturnValue({ _id: 'auction', matchId }), toObject: jest.fn().mockReturnValue({ _id: 'auction', matchId }),
}; };
const match = {
participants: [
{
userId: captainOneId,
preferredPositions: [{ position: 'TOP', priority: 1 }],
},
{
userId: captainTwoId,
preferredPositions: [{ position: 'JGL', priority: 1 }],
},
{
userId: passedPlayerId,
preferredPositions: [{ position: 'SUP', priority: 1 }],
},
],
status: 'team-built',
teams: [],
teamBuiltAt: undefined,
save: jest.fn().mockResolvedValue(undefined),
};
const { service } = createService({ const { service } = createService({
auction: { auction: {
findOne: jest.fn().mockResolvedValue(auction), findOne: jest.fn().mockResolvedValue(auction),
}, },
match: {
findById: jest.fn().mockResolvedValue(match),
},
}); });
await service.next(matchId); await service.next(matchId);
expect(auction.phase).toBe('complete'); expect(auction.phase).toBe('presenting');
expect(auction.teams[1].members).toEqual([ expect(auction.auctionRound).toBe(3);
{ expect(auction.currentIndex).toBe(1);
userId: passedPlayerId, expect(auction.order).toHaveLength(2);
assignedPosition: 'SUP', expect(auction.order[1]).toMatchObject({
cost: 1, userId: passedPlayerId.toString(),
}, preferredPositions: [{ position: 'SUP', priority: 1 }],
]); passCount: 2,
expect(auction.teams[1].points).toBe(49); });
expect(auction.passedQueue).toEqual([]);
expect(auction.teams[0].members).toEqual([]);
expect(auction.teams[1].members).toEqual([]);
expect(auction.teams[0].points).toBe(10);
expect(auction.teams[1].points).toBe(50);
}); });
it('syncs completed auction teams into the match document', async () => { it('syncs completed auction teams into the match document', async () => {
@@ -345,9 +345,8 @@ export class AuctionService {
await this.recordSnapshot(auction, 'passed'); await this.recordSnapshot(auction, 'passed');
current.passCount = (current.passCount ?? 0) + 1; current.passCount = (current.passCount ?? 0) + 1;
if ((auction.auctionRound ?? 1) === 1) { auction.passedQueue ??= [];
auction.passedQueue.push(this.cloneAuctionPlayerSnapshot(current)); auction.passedQueue.push(this.cloneAuctionPlayerSnapshot(current));
}
auction.phase = 'passed'; auction.phase = 'passed';
auction.currentDeadline = undefined; auction.currentDeadline = undefined;
await auction.save(); await auction.save();
@@ -368,29 +367,22 @@ export class AuctionService {
const nextIndex = auction.currentIndex + 1; const nextIndex = auction.currentIndex + 1;
const completesAuction = const completesAuction =
nextIndex >= auction.order.length && nextIndex >= auction.order.length &&
!( (auction.passedQueue?.length ?? 0) === 0;
(auction.auctionRound ?? 1) === 1 &&
(auction.passedQueue?.length ?? 0) > 0
);
await this.recordSnapshot(auction, completesAuction ? 'complete' : 'next'); await this.recordSnapshot(auction, completesAuction ? 'complete' : 'next');
if (nextIndex >= auction.order.length) { if (nextIndex >= auction.order.length) {
if ( if ((auction.passedQueue?.length ?? 0) > 0) {
(auction.auctionRound ?? 1) === 1 &&
(auction.passedQueue?.length ?? 0) > 0
) {
auction.order.push( auction.order.push(
...auction.passedQueue.map((player) => ...auction.passedQueue.map((player) =>
this.cloneAuctionPlayerSnapshot(player), this.cloneAuctionPlayerSnapshot(player),
), ),
); );
auction.passedQueue = []; auction.passedQueue = [];
auction.auctionRound = 2; auction.auctionRound = (auction.auctionRound ?? 1) + 1;
auction.currentIndex = nextIndex; auction.currentIndex = nextIndex;
auction.phase = 'presenting'; auction.phase = 'presenting';
auction.currentBid = 0; auction.currentBid = 0;
auction.currentBidderTeamIndex = undefined; auction.currentBidderTeamIndex = undefined;
} else { } else {
this.forceAssignRemainingPasses(auction);
auction.phase = 'complete'; auction.phase = 'complete';
auction.completedAt = new Date(); auction.completedAt = new Date();
} }
@@ -603,41 +595,6 @@ export class AuctionService {
return shuffled; return shuffled;
} }
private forceAssignRemainingPasses(auction: AuctionDocument): void {
const forcedPlayers = auction.order.filter(
(player) =>
(player.passCount ?? 0) >= 2 &&
!this.isAuctionPlayerAssigned(auction, player.userId),
);
for (const player of forcedPlayers) {
const targetTeam = [...auction.teams]
.filter(
(team) => this.countTeamMembersIncludingCaptain(team) < AUCTION_MAX_TEAM_SIZE,
)
.sort((left, right) => right.points - left.points)[0];
if (!targetTeam) return;
const preferredPrimary = player.preferredPositions[0]?.position;
targetTeam.members.push({
userId: player.userId,
assignedPosition: preferredPrimary ?? 'MID',
cost: 1,
});
targetTeam.points = Math.max(0, targetTeam.points - 1);
}
}
private isAuctionPlayerAssigned(
auction: AuctionDocument,
userId: mongoose.Types.ObjectId,
): boolean {
const userIdText = userId.toString();
return auction.teams.some((team) =>
team.members.some((member) => member.userId.toString() === userIdText),
);
}
private cloneAuctionPlayerSnapshot( private cloneAuctionPlayerSnapshot(
player: AuctionPlayerSnapshot, player: AuctionPlayerSnapshot,
): AuctionPlayerSnapshot { ): AuctionPlayerSnapshot {