fix: recover stale auction durability history

This commit is contained in:
dahyeon committed 2026-06-26 04:02:11 -07:00
1 parent 37f1f4225d
commit 8567948084
2 files changed
+294

No files matched your search

@@ -446,6 +446,216 @@ describe('auction durability projection helpers', () => {
expect(auctionUpdateOne).not.toHaveBeenCalled();
});
it('recovers stale append payloads as history-only records', async () => {
const session = {
abortTransaction: jest.fn().mockResolvedValue(undefined),
commitTransaction: jest.fn().mockResolvedValue(undefined),
endSession: jest.fn().mockResolvedValue(undefined),
startTransaction: jest.fn(),
};
const historyFindOne = jest.fn().mockReturnValue({
session: jest.fn().mockReturnValue({
lean: jest.fn().mockReturnValue({
exec: jest.fn().mockResolvedValue(null),
}),
}),
});
const historyUpdateOne = jest.fn().mockReturnValue({
exec: jest.fn().mockResolvedValue({ upsertedCount: 1 }),
});
const auctionUpdateOne = jest.fn();
const sideEffectUpdateOne = jest.fn();
const projectionExec = jest.fn().mockResolvedValue({
auctionLifecycleId: 'life-1',
revision: 10,
});
const auctionFindById = jest.fn().mockReturnValue({
select: jest.fn().mockReturnValue({
session: jest.fn().mockReturnValue({
lean: jest.fn().mockReturnValue({ exec: projectionExec }),
}),
}),
});
const scheduler = new AuctionDurabilityScheduler(
{
createSession: jest.fn().mockResolvedValue(session),
getModel: jest.fn((name: string) => {
if (name === 'auctionHistory') {
return {
findOne: historyFindOne,
updateOne: historyUpdateOne,
};
}
if (name === 'auction') {
return { findById: auctionFindById, updateOne: auctionUpdateOne };
}
return { updateOne: sideEffectUpdateOne };
}),
} as never,
{ raw: jest.fn() } as never,
);
await scheduler.applyDurabilityPayload({
...payload,
matchSideEffectMutation: { type: 'syncMatchTeamsAfterComplete' },
});
expect(historyFindOne).toHaveBeenCalledWith(
expect.objectContaining({
auctionId: 'auction-1',
sequence: { $gt: 4 },
}),
);
expect(historyUpdateOne).toHaveBeenCalledWith(
{
auctionId: 'auction-1',
auctionStateTransitionId: 'transition-1',
},
expect.objectContaining({
$setOnInsert: expect.objectContaining({
sequence: 4,
}),
}),
{ session, upsert: true },
);
expect(auctionUpdateOne).not.toHaveBeenCalled();
expect(sideEffectUpdateOne).not.toHaveBeenCalled();
});
it('does not resurrect stale append payloads invalidated by later undo', async () => {
const session = {
abortTransaction: jest.fn().mockResolvedValue(undefined),
commitTransaction: jest.fn().mockResolvedValue(undefined),
endSession: jest.fn().mockResolvedValue(undefined),
startTransaction: jest.fn(),
};
const historyFindOne = jest.fn().mockReturnValue({
session: jest.fn().mockReturnValue({
lean: jest.fn().mockReturnValue({
exec: jest.fn().mockResolvedValue({
historyMutation: {
targetHistorySequence: 2,
type: 'deleteAfterSequenceAndAppendUndo',
},
}),
}),
}),
});
const historyUpdateOne = jest.fn();
const auctionUpdateOne = jest.fn();
const projectionExec = jest.fn().mockResolvedValue({
auctionLifecycleId: 'life-1',
revision: 10,
});
const auctionFindById = jest.fn().mockReturnValue({
select: jest.fn().mockReturnValue({
session: jest.fn().mockReturnValue({
lean: jest.fn().mockReturnValue({ exec: projectionExec }),
}),
}),
});
const scheduler = new AuctionDurabilityScheduler(
{
createSession: jest.fn().mockResolvedValue(session),
getModel: jest.fn((name: string) => {
if (name === 'auctionHistory') {
return {
findOne: historyFindOne,
updateOne: historyUpdateOne,
};
}
if (name === 'auction') {
return { findById: auctionFindById, updateOne: auctionUpdateOne };
}
return { updateOne: jest.fn() };
}),
} as never,
{ raw: jest.fn() } as never,
);
await scheduler.applyDurabilityPayload(payload);
expect(historyFindOne).toHaveBeenCalled();
expect(historyUpdateOne).not.toHaveBeenCalled();
expect(auctionUpdateOne).not.toHaveBeenCalled();
});
it('clears stale append payloads after history-only recovery', async () => {
const sendCommand = jest
.fn()
.mockResolvedValueOnce(['payload-1'])
.mockResolvedValueOnce({
committedAtRedisTimestampMS: '1780000000000',
payloadJson: JSON.stringify({
...payload,
matchSideEffectMutation: { type: 'syncMatchTeamsAfterComplete' },
}),
})
.mockResolvedValueOnce(1)
.mockResolvedValueOnce(1);
const historyFindOne = jest.fn().mockReturnValue({
session: jest.fn().mockReturnValue({
lean: jest.fn().mockReturnValue({
exec: jest.fn().mockResolvedValue(null),
}),
}),
});
const historyUpdateOne = jest.fn().mockReturnValue({
exec: jest.fn().mockResolvedValue({ upsertedCount: 1 }),
});
const auctionUpdateOne = jest.fn();
const sideEffectUpdateOne = jest.fn();
const auctionFindById = jest.fn().mockReturnValue({
select: jest.fn().mockReturnValue({
session: jest.fn().mockReturnValue({
lean: jest.fn().mockReturnValue({
exec: jest.fn().mockResolvedValue({
auctionLifecycleId: 'life-1',
revision: 10,
}),
}),
}),
}),
});
const scheduler = new AuctionDurabilityScheduler(
{
createSession: jest.fn().mockResolvedValue(null),
getModel: jest.fn((name: string) => {
if (name === 'auctionHistory') {
return {
findOne: historyFindOne,
updateOne: historyUpdateOne,
};
}
if (name === 'auction') {
return { findById: auctionFindById, updateOne: auctionUpdateOne };
}
return { updateOne: sideEffectUpdateOne };
}),
} as never,
{
getCurrentRedisTimestampMS: jest.fn().mockResolvedValue(1000),
raw: jest.fn().mockReturnValue({ sendCommand }),
} as never,
);
await expect(scheduler.processDueDurabilityPayloads(10)).resolves.toEqual({
applied: 1,
failed: 0,
skipped: 0,
});
expect(historyUpdateOne).toHaveBeenCalledTimes(1);
expect(auctionUpdateOne).not.toHaveBeenCalled();
expect(sideEffectUpdateOne).not.toHaveBeenCalled();
expect(sendCommand).toHaveBeenNthCalledWith(3, [
'ZREM',
'auction:auctionDurabilityRetryQueue',
'payload-1',
]);
expect(sendCommand).toHaveBeenNthCalledWith(4, ['DEL', 'payload-1']);
});
it('processes due payloads and clears successful outbox entries', async () => {
const sendCommand = jest
.fn()