refactor: harden competition persistence type boundaries

This commit is contained in:
dahyeon committed 2026-07-12 20:18:48 +00:00
1 parent ec92494211
commit 7ea2002975
7 files changed
+127 -62

No files matched your search

@@ -1469,9 +1469,24 @@ function canonicalize(value: unknown): string {
function opaqueString(value: unknown): string {
if (typeof value === 'string') return value.trim();
if (hasHexString(value)) {
const rendered = value.toHexString();
if (typeof rendered === 'string') return rendered.trim();
}
if (typeof value === 'number' || typeof value === 'boolean') {
return String(value);
}
if (value === undefined || value === null) return '';
const rendered = String(value);
return rendered === '[object Object]' ? '' : rendered;
return '';
}
function hasHexString(value: unknown): value is { toHexString(): unknown } {
return (
value !== null &&
typeof value === 'object' &&
'toHexString' in value &&
typeof value.toHexString === 'function'
);
}
function positiveInteger(value: unknown): number | undefined {
@@ -329,7 +329,7 @@ async function hydrateLegacyMatch(
.limit(0),
);
const result = isRecord(match.result) ? match.result : undefined;
const games = Array.isArray(result?.games) ? result.games : [];
const games = arrayOf(result?.games);
const riotMatchIds = uniqueStrings(
games.map((game) => (isRecord(game) ? game.riotMatchId : undefined)),
);
@@ -854,13 +854,9 @@ function optionalIdString(value: unknown): string | undefined {
function idString(value: unknown): string {
if (value instanceof mongoose.Types.ObjectId) return value.toHexString();
if (
value &&
typeof value === 'object' &&
'toHexString' in value &&
typeof value.toHexString === 'function'
) {
return String(value.toHexString());
if (hasHexString(value)) {
const rendered = value.toHexString();
if (typeof rendered === 'string') return rendered;
}
return String(value);
}
@@ -906,13 +902,9 @@ function canonicalJson(value: unknown): string {
function canonicalValue(value: unknown): unknown {
if (value instanceof mongoose.Types.ObjectId) return value.toHexString();
if (value instanceof Date) return value.toISOString();
if (
value &&
typeof value === 'object' &&
'toHexString' in value &&
typeof value.toHexString === 'function'
) {
return String(value.toHexString());
if (hasHexString(value)) {
const rendered = value.toHexString();
if (typeof rendered === 'string') return rendered;
}
if (Array.isArray(value)) return value.map(canonicalValue);
if (isRecord(value)) {
@@ -925,3 +917,12 @@ function canonicalValue(value: unknown): unknown {
}
return value;
}
function hasHexString(value: unknown): value is { toHexString(): unknown } {
return (
value !== null &&
typeof value === 'object' &&
'toHexString' in value &&
typeof value.toHexString === 'function'
);
}