feat: improve match game detail ux
This commit is contained in:
1 parent
7b5604873e
commit
747adfcb11
5 files changed
+767
-376
No files matched your search
@@ -0,0 +1,193 @@
|
|||||||
|
import mongoose from 'mongoose';
|
||||||
|
import { ConnectionService } from '../global/database/connection.service';
|
||||||
|
import { CommunityStatsCacheService } from './community-stats-cache.service';
|
||||||
|
import { CommunityStatsService } from './community-stats.service';
|
||||||
|
import type {
|
||||||
|
InternalMatchCardView,
|
||||||
|
InternalMatchDetailResponse,
|
||||||
|
} from './community-stats.types';
|
||||||
|
import { MatchStatsRepository } from './match-stats.repository';
|
||||||
|
import { MatchStatsService } from './match-stats.service';
|
||||||
|
import type { InternalGameDetail, InternalRecord } from './match-stats.types';
|
||||||
|
|
||||||
|
function objectives() {
|
||||||
|
return {
|
||||||
|
tower: 1,
|
||||||
|
dragon: 0,
|
||||||
|
inhibitor: 0,
|
||||||
|
baron: 0,
|
||||||
|
riftHerald: 0,
|
||||||
|
voidGrub: 0,
|
||||||
|
elderDragon: 0,
|
||||||
|
};
|
||||||
|
}
|
||||||
|
|
||||||
|
function record(matchId: mongoose.Types.ObjectId): InternalRecord {
|
||||||
|
return {
|
||||||
|
matchId: matchId.toString(),
|
||||||
|
title: '내전',
|
||||||
|
scheduledAt: new Date('2026-06-18T12:00:00.000Z'),
|
||||||
|
gameNumber: 1,
|
||||||
|
riotMatchId: 'KR_1',
|
||||||
|
gameCreation: 1_000,
|
||||||
|
gameDuration: 1_800,
|
||||||
|
userId: new mongoose.Types.ObjectId().toString(),
|
||||||
|
summonerName: 'Player',
|
||||||
|
profileIconId: 1,
|
||||||
|
teamIndex: 1,
|
||||||
|
side: 'blue',
|
||||||
|
championId: 266,
|
||||||
|
championLevel: 15,
|
||||||
|
teamPosition: 'TOP',
|
||||||
|
kills: 5,
|
||||||
|
deaths: 1,
|
||||||
|
assists: 7,
|
||||||
|
win: true,
|
||||||
|
cs: 200,
|
||||||
|
csPerMin: 6.7,
|
||||||
|
gold: 12_000,
|
||||||
|
gpm: 400,
|
||||||
|
damageDealtToChampions: 18_000,
|
||||||
|
damageTaken: 20_000,
|
||||||
|
damageShare: 30,
|
||||||
|
killParticipation: 60,
|
||||||
|
visionScore: 18,
|
||||||
|
controlWardsBought: 1,
|
||||||
|
wardsPlaced: 8,
|
||||||
|
wardsKilled: 2,
|
||||||
|
firstBloodKill: false,
|
||||||
|
firstBloodAssist: false,
|
||||||
|
items: [1054, 3071, 0, 0, 0, 0],
|
||||||
|
trinket: 3340,
|
||||||
|
summonerSpells: [4, 12],
|
||||||
|
perks: {
|
||||||
|
primaryStyle: 8000,
|
||||||
|
subStyle: 8400,
|
||||||
|
keystone: 8010,
|
||||||
|
selectedPerkIds: [8010, 9111, 9105, 8299, 8444, 8451],
|
||||||
|
styles: [
|
||||||
|
{ styleId: 8000, perkIds: [8010, 9111, 9105, 8299] },
|
||||||
|
{ styleId: 8400, perkIds: [8444, 8451] },
|
||||||
|
],
|
||||||
|
statPerks: { defense: 5001, flex: 5008, offense: 5005 },
|
||||||
|
},
|
||||||
|
itemBuild: [{ timestamp: 10, itemId: 1054, type: 'purchased' }],
|
||||||
|
skillBuild: [{ timestamp: 11, skillSlot: 1, level: 1 }],
|
||||||
|
rating: 8.5,
|
||||||
|
};
|
||||||
|
}
|
||||||
|
|
||||||
|
describe('CommunityStatsService', () => {
|
||||||
|
it('ignores stale detail cache entries missing timeline build fields', async () => {
|
||||||
|
const communityId = new mongoose.Types.ObjectId();
|
||||||
|
const matchId = new mongoose.Types.ObjectId();
|
||||||
|
const match: InternalMatchCardView = {
|
||||||
|
matchId: matchId.toString(),
|
||||||
|
title: '내전',
|
||||||
|
scheduledAt: '2026-06-18T12:00:00.000Z',
|
||||||
|
status: 'finished',
|
||||||
|
gameCount: 1,
|
||||||
|
games: [],
|
||||||
|
teams: [],
|
||||||
|
seriesResults: [],
|
||||||
|
};
|
||||||
|
const participant = record(matchId);
|
||||||
|
const gameDetail: InternalGameDetail = {
|
||||||
|
gameNumber: 1,
|
||||||
|
riotMatchId: 'KR_1',
|
||||||
|
gameCreation: 1_000,
|
||||||
|
gameDuration: 1_800,
|
||||||
|
winnerSide: 'blue',
|
||||||
|
timelineLoaded: true,
|
||||||
|
timeline: [
|
||||||
|
{
|
||||||
|
timestamp: 0,
|
||||||
|
blue: { gold: 500, xp: 0 },
|
||||||
|
red: { gold: 500, xp: 0 },
|
||||||
|
goldDiff: 0,
|
||||||
|
xpDiff: 0,
|
||||||
|
},
|
||||||
|
],
|
||||||
|
objectiveEvents: [],
|
||||||
|
teams: [
|
||||||
|
{
|
||||||
|
teamIndex: 1,
|
||||||
|
side: 'blue',
|
||||||
|
win: true,
|
||||||
|
objectives: objectives(),
|
||||||
|
bans: [],
|
||||||
|
participants: [participant],
|
||||||
|
},
|
||||||
|
],
|
||||||
|
};
|
||||||
|
const staleCache = {
|
||||||
|
match,
|
||||||
|
games: [
|
||||||
|
{
|
||||||
|
gameNumber: 1,
|
||||||
|
riotMatchId: 'KR_1',
|
||||||
|
gameCreation: 1_000,
|
||||||
|
gameDuration: 1_800,
|
||||||
|
teams: [
|
||||||
|
{
|
||||||
|
teamIndex: 1,
|
||||||
|
side: 'blue',
|
||||||
|
win: true,
|
||||||
|
objectives: { tower: 1, dragon: 0, baron: 0 },
|
||||||
|
participants: [
|
||||||
|
{
|
||||||
|
summonerName: 'Player',
|
||||||
|
perks: {
|
||||||
|
primaryStyle: 8000,
|
||||||
|
subStyle: 8400,
|
||||||
|
keystone: 8010,
|
||||||
|
},
|
||||||
|
},
|
||||||
|
],
|
||||||
|
},
|
||||||
|
],
|
||||||
|
},
|
||||||
|
],
|
||||||
|
} as unknown as InternalMatchDetailResponse;
|
||||||
|
const cacheService = {
|
||||||
|
get: jest.fn().mockResolvedValue(staleCache),
|
||||||
|
setDetail: jest.fn().mockResolvedValue(undefined),
|
||||||
|
} as unknown as jest.Mocked<CommunityStatsCacheService>;
|
||||||
|
const matchStatsService = {
|
||||||
|
buildAndUpsert: jest.fn().mockResolvedValue(undefined),
|
||||||
|
} as unknown as jest.Mocked<MatchStatsService>;
|
||||||
|
const service = new CommunityStatsService(
|
||||||
|
{} as ConnectionService,
|
||||||
|
cacheService,
|
||||||
|
{} as MatchStatsRepository,
|
||||||
|
matchStatsService,
|
||||||
|
);
|
||||||
|
(service as unknown as { buildBaseDataset: jest.Mock }).buildBaseDataset =
|
||||||
|
jest.fn().mockResolvedValue({
|
||||||
|
season: {
|
||||||
|
id: 'all',
|
||||||
|
label: '전체',
|
||||||
|
startTime: null,
|
||||||
|
endTime: null,
|
||||||
|
},
|
||||||
|
matches: [match],
|
||||||
|
records: [participant],
|
||||||
|
detailsByMatchId: new Map([[matchId.toString(), [gameDetail]]]),
|
||||||
|
});
|
||||||
|
|
||||||
|
const response = await service.getMatchDetail({ communityId, matchId });
|
||||||
|
|
||||||
|
expect(response.games[0].timeline).toHaveLength(1);
|
||||||
|
expect(response.games[0].teams[0].participants[0].itemBuild).toHaveLength(
|
||||||
|
1,
|
||||||
|
);
|
||||||
|
expect(response.games[0].teams[0].participants[0].perks).toMatchObject({
|
||||||
|
selectedPerkIds: [8010, 9111, 9105, 8299, 8444, 8451],
|
||||||
|
});
|
||||||
|
expect(matchStatsService.buildAndUpsert).not.toHaveBeenCalled();
|
||||||
|
expect(cacheService.setDetail).toHaveBeenCalledWith(
|
||||||
|
expect.stringContaining(':r2:'),
|
||||||
|
response,
|
||||||
|
);
|
||||||
|
});
|
||||||
|
});
|
||||||
@@ -36,6 +36,7 @@ const DEFAULT_LIST_LIMIT = 20;
|
|||||||
const MAX_LIST_LIMIT = 50;
|
const MAX_LIST_LIMIT = 50;
|
||||||
const MAX_MATCH_SCAN = 300;
|
const MAX_MATCH_SCAN = 300;
|
||||||
const MIN_HIGHLIGHT_GAMES = 5;
|
const MIN_HIGHLIGHT_GAMES = 5;
|
||||||
|
const MATCH_DETAIL_RESPONSE_CACHE_VERSION = 2;
|
||||||
|
|
||||||
interface CommunityStatsContext {
|
interface CommunityStatsContext {
|
||||||
community: CommunityDocument;
|
community: CommunityDocument;
|
||||||
@@ -205,10 +206,10 @@ export class CommunityStatsService {
|
|||||||
communityId: mongoose.Types.ObjectId;
|
communityId: mongoose.Types.ObjectId;
|
||||||
matchId: mongoose.Types.ObjectId;
|
matchId: mongoose.Types.ObjectId;
|
||||||
}): Promise<InternalMatchDetailResponse> {
|
}): Promise<InternalMatchDetailResponse> {
|
||||||
const key = `riot:communitystats:matchDetail:v${MATCH_STATS_BUILDER_VERSION}:${params.communityId.toString()}:${params.matchId.toString()}`;
|
const key = `riot:communitystats:matchDetail:v${MATCH_STATS_BUILDER_VERSION}:r${MATCH_DETAIL_RESPONSE_CACHE_VERSION}:${params.communityId.toString()}:${params.matchId.toString()}`;
|
||||||
const cached =
|
const cached =
|
||||||
await this.cacheService.get<InternalMatchDetailResponse>(key);
|
await this.cacheService.get<InternalMatchDetailResponse>(key);
|
||||||
if (cached) return cached;
|
if (cached && isCompleteMatchDetailResponse(cached)) return cached;
|
||||||
|
|
||||||
const dataset = await this.buildBaseDataset(params.communityId, {
|
const dataset = await this.buildBaseDataset(params.communityId, {
|
||||||
seasonId: 'all',
|
seasonId: 'all',
|
||||||
@@ -1013,3 +1014,22 @@ export class CommunityStatsService {
|
|||||||
return Math.round(value * 10) / 10;
|
return Math.round(value * 10) / 10;
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
function isCompleteMatchDetailResponse(
|
||||||
|
response: InternalMatchDetailResponse,
|
||||||
|
): boolean {
|
||||||
|
return response.games.every(
|
||||||
|
(game) =>
|
||||||
|
Array.isArray(game.timeline) &&
|
||||||
|
Array.isArray(game.objectiveEvents) &&
|
||||||
|
game.teams.every(
|
||||||
|
(team) =>
|
||||||
|
Array.isArray(team.bans) &&
|
||||||
|
team.participants.every(
|
||||||
|
(participant) =>
|
||||||
|
Array.isArray(participant.itemBuild) &&
|
||||||
|
Array.isArray(participant.skillBuild),
|
||||||
|
),
|
||||||
|
),
|
||||||
|
);
|
||||||
|
}
|
||||||
@@ -114,7 +114,7 @@ describe('MatchStatsService', () => {
|
|||||||
scheduledAt,
|
scheduledAt,
|
||||||
gameCreationMin: 1_000,
|
gameCreationMin: 1_000,
|
||||||
gameCreationMax: 2_000,
|
gameCreationMax: 2_000,
|
||||||
builderVersion: 7,
|
builderVersion: 8,
|
||||||
}),
|
}),
|
||||||
);
|
);
|
||||||
});
|
});
|
||||||
|
|||||||
@@ -4,7 +4,7 @@ import type {
|
|||||||
} from '../global/database/schema';
|
} from '../global/database/schema';
|
||||||
import type { InternalMatchCardView } from './community-stats.types';
|
import type { InternalMatchCardView } from './community-stats.types';
|
||||||
|
|
||||||
export const MATCH_STATS_BUILDER_VERSION = 7;
|
export const MATCH_STATS_BUILDER_VERSION = 8;
|
||||||
|
|
||||||
export type InternalRecord = MatchStatsRecord;
|
export type InternalRecord = MatchStatsRecord;
|
||||||
export type InternalGameDetail = MatchStatsGameDetail;
|
export type InternalGameDetail = MatchStatsGameDetail;
|
||||||
|
|||||||
File diff suppressed because it is too large.
Load diff
Reference in new issue
Block a user