feat: improve match game detail ux

This commit is contained in:
dahyeon committed 2026-06-19 16:57:28 -07:00
1 parent 7b5604873e
commit 747adfcb11
5 files changed
+767 -376

No files matched your search

@@ -36,6 +36,7 @@ const DEFAULT_LIST_LIMIT = 20;
const MAX_LIST_LIMIT = 50;
const MAX_MATCH_SCAN = 300;
const MIN_HIGHLIGHT_GAMES = 5;
const MATCH_DETAIL_RESPONSE_CACHE_VERSION = 2;
interface CommunityStatsContext {
community: CommunityDocument;
@@ -205,10 +206,10 @@ export class CommunityStatsService {
communityId: mongoose.Types.ObjectId;
matchId: mongoose.Types.ObjectId;
}): Promise<InternalMatchDetailResponse> {
const key = `riot:communitystats:matchDetail:v${MATCH_STATS_BUILDER_VERSION}:${params.communityId.toString()}:${params.matchId.toString()}`;
const key = `riot:communitystats:matchDetail:v${MATCH_STATS_BUILDER_VERSION}:r${MATCH_DETAIL_RESPONSE_CACHE_VERSION}:${params.communityId.toString()}:${params.matchId.toString()}`;
const cached =
await this.cacheService.get<InternalMatchDetailResponse>(key);
if (cached) return cached;
if (cached && isCompleteMatchDetailResponse(cached)) return cached;
const dataset = await this.buildBaseDataset(params.communityId, {
seasonId: 'all',
@@ -1013,3 +1014,22 @@ export class CommunityStatsService {
return Math.round(value * 10) / 10;
}
}
function isCompleteMatchDetailResponse(
response: InternalMatchDetailResponse,
): boolean {
return response.games.every(
(game) =>
Array.isArray(game.timeline) &&
Array.isArray(game.objectiveEvents) &&
game.teams.every(
(team) =>
Array.isArray(team.bans) &&
team.participants.every(
(participant) =>
Array.isArray(participant.itemBuild) &&
Array.isArray(participant.skillBuild),
),
),
);
}