diff --git a/apps/api/src/cors-origin.spec.ts b/apps/api/src/cors-origin.spec.ts new file mode 100644 index 00000000..e2d2a4d8 --- /dev/null +++ b/apps/api/src/cors-origin.spec.ts @@ -0,0 +1,67 @@ +import { + createCorsOrigin, + isAllowedCorsOrigin, + resolveWebOrigins, +} from './cors-origin'; + +describe('CORS origin resolution', () => { + it('allows Cloudflare Pages preview origins in dev and staging', () => { + const origin = 'https://807e0ea6.lolympus.pages.dev'; + + expect(isAllowedCorsOrigin(origin, 'dev')).toBe(true); + expect(isAllowedCorsOrigin(origin, 'staging')).toBe(true); + }); + + it('does not allow Cloudflare Pages preview origins in prod', () => { + expect( + isAllowedCorsOrigin('https://807e0ea6.lolympus.pages.dev', 'prod'), + ).toBe(false); + }); + + it('rejects similar but unsafe Pages origins', () => { + expect( + isAllowedCorsOrigin('http://807e0ea6.lolympus.pages.dev', 'staging'), + ).toBe(false); + expect(isAllowedCorsOrigin('https://lolympus.pages.dev', 'staging')).toBe( + false, + ); + expect( + isAllowedCorsOrigin('https://a.b.lolympus.pages.dev', 'staging'), + ).toBe(false); + expect( + isAllowedCorsOrigin( + 'https://807e0ea6.lolympus.pages.dev.evil.com', + 'staging', + ), + ).toBe(false); + }); + + it('keeps configured web origins allowed', () => { + expect( + isAllowedCorsOrigin('https://example.com', 'prod', [ + 'https://example.com', + ]), + ).toBe(true); + }); + + it('falls back to default web origins when WEB_ORIGIN is empty', () => { + expect(resolveWebOrigins('')).toContain('http://localhost:5173'); + }); + + it('creates a Nest CORS callback from the same rules', (done) => { + const corsOrigin = createCorsOrigin('staging'); + + expect(corsOrigin).not.toBe(true); + if (corsOrigin === true) return; + + corsOrigin('https://807e0ea6.lolympus.pages.dev', (error, allow) => { + expect(error).toBeNull(); + expect(allow).toBe(true); + done(); + }); + }); + + it('keeps dev CORS permissive for local development', () => { + expect(createCorsOrigin('dev')).toBe(true); + }); +}); diff --git a/apps/api/src/cors-origin.ts b/apps/api/src/cors-origin.ts new file mode 100644 index 00000000..ee26a0e2 --- /dev/null +++ b/apps/api/src/cors-origin.ts @@ -0,0 +1,101 @@ +import type { CustomOrigin } from '@nestjs/common/interfaces/external/cors-options.interface'; + +const DEFAULT_WEB_ORIGINS = [ + 'http://localhost:5173', + 'http://126.dahyeon.us:5173', + 'https://lolympus.dahyeon.us', +]; + +const PAGES_DEV_ORIGIN_HOST_PATTERN = + /^[a-z0-9](?:[a-z0-9-]{0,61}[a-z0-9])?\.lolympus\.pages\.dev$/i; + +const PAGES_DEV_CORS_ENVIRONMENTS = new Set(['dev', 'staging']); + +function parseOrigin(origin: string, allowPath: boolean): URL | null { + const trimmedOrigin = origin.trim(); + if (trimmedOrigin.length === 0) return null; + + try { + const url = new URL(trimmedOrigin); + if ( + !allowPath && + (url.pathname !== '/' || url.search !== '' || url.hash !== '') + ) { + return null; + } + + return url; + } catch { + return null; + } +} + +function normalizeOrigin(origin: string, allowPath = false): string | null { + const url = parseOrigin(origin, allowPath); + if (!url) return null; + + return `${url.protocol}//${url.host}`; +} + +export function resolveWebOrigins( + webOrigin = process.env.WEB_ORIGIN, +): string[] { + const configuredOrigins = webOrigin + ?.split(',') + .map((origin) => normalizeOrigin(origin, true)) + .filter((origin): origin is string => origin !== null); + + if (configuredOrigins && configuredOrigins.length > 0) { + return configuredOrigins; + } + + return [...DEFAULT_WEB_ORIGINS]; +} + +export function isLolympusPagesDevOrigin(origin: string): boolean { + const url = parseOrigin(origin, false); + if (!url) return false; + + return ( + url.protocol === 'https:' && + url.port === '' && + PAGES_DEV_ORIGIN_HOST_PATTERN.test(url.hostname) + ); +} + +export function isAllowedCorsOrigin( + requestOrigin: string | undefined, + nodeEnv = process.env.NODE_ENV, + webOrigins = resolveWebOrigins(), +): boolean { + if (!requestOrigin) return false; + + const normalizedRequestOrigin = normalizeOrigin(requestOrigin); + if (!normalizedRequestOrigin) return false; + + const normalizedWebOrigins = webOrigins + .map((origin) => normalizeOrigin(origin, true)) + .filter((origin): origin is string => origin !== null); + + if (normalizedWebOrigins.includes(normalizedRequestOrigin)) { + return true; + } + + return ( + PAGES_DEV_CORS_ENVIRONMENTS.has(nodeEnv ?? '') && + isLolympusPagesDevOrigin(requestOrigin) + ); +} + +export function createCorsOrigin( + nodeEnv = process.env.NODE_ENV, + webOrigin = process.env.WEB_ORIGIN, +): true | CustomOrigin { + if (nodeEnv === 'dev') return true; + + const webOrigins = resolveWebOrigins(webOrigin); + + return (requestOrigin, callback) => { + callback(null, isAllowedCorsOrigin(requestOrigin, nodeEnv, webOrigins)); + }; +} diff --git a/apps/api/src/main.ts b/apps/api/src/main.ts index 9efa99fa..375ab8a4 100644 --- a/apps/api/src/main.ts +++ b/apps/api/src/main.ts @@ -1,23 +1,18 @@ import { ValidationPipe } from '@nestjs/common'; import { NestFactory } from '@nestjs/core'; import { AppModule } from './app.module'; +import { createCorsOrigin } from './cors-origin'; async function bootstrap() { const app = await NestFactory.create(AppModule, { rawBody: true, }); - const isDev = process.env.NODE_ENV === 'dev'; - const webOrigins = process.env.WEB_ORIGIN?.split(',').map((origin) => - origin.trim(), - ) ?? [ - 'http://localhost:5173', - 'http://126.dahyeon.us:5173', - 'https://lolympus.dahyeon.us', - ]; + const nodeEnv = process.env.NODE_ENV; + const isDev = nodeEnv === 'dev'; app.enableCors({ - origin: isDev ? true : webOrigins, + origin: createCorsOrigin(nodeEnv), credentials: true, allowedHeaders: ['Authorization', 'Content-Type', 'X-Auth-User-Id'], }); @@ -31,4 +26,4 @@ async function bootstrap() { ); await app.listen(isDev ? 3000 : 10712); } -bootstrap(); +void bootstrap();