From 6aa2cb900932d5a4eff4e41f43e0667273118f71 Mon Sep 17 00:00:00 2001 From: Park Dahyeon Date: Sun, 12 Jul 2026 20:08:12 +0000 Subject: [PATCH] fix: reject ambiguous Riot winner evidence --- .../competition-result.adapter.spec.ts | 16 ++++++++++++++++ .../competition-result.adapter.ts | 7 ++++++- 2 files changed, 22 insertions(+), 1 deletion(-) diff --git a/apps/api/src/modules/tournament-result/competition-result.adapter.spec.ts b/apps/api/src/modules/tournament-result/competition-result.adapter.spec.ts index 0fdae862..08e3bedc 100644 --- a/apps/api/src/modules/tournament-result/competition-result.adapter.spec.ts +++ b/apps/api/src/modules/tournament-result/competition-result.adapter.spec.ts @@ -211,6 +211,22 @@ describe('Competition result Riot mapping', () => { ).toBeNull(); }); + it('rejects inconsistent Riot evidence with more than one winning team', () => { + const { competition, detail, lookup } = fixture(); + detail.info.teams.forEach((team) => { + team.win = true; + }); + + expect( + mapRiotGameToCompetitionSlot({ + competition, + target: competition.projection.gameSlots[0], + detail, + lookup, + }), + ).toBeNull(); + }); + it('orders collected Riot games by occurrence before first-to projection', () => { const { detail } = fixture(); const later = { diff --git a/apps/api/src/modules/tournament-result/competition-result.adapter.ts b/apps/api/src/modules/tournament-result/competition-result.adapter.ts index d54ce4d4..8630b188 100644 --- a/apps/api/src/modules/tournament-result/competition-result.adapter.ts +++ b/apps/api/src/modules/tournament-result/competition-result.adapter.ts @@ -155,7 +155,12 @@ export function mapRiotGameToCompetitionSlot(params: { const blueTeamId = normalOverlap > reversedOverlap ? slotATeamId : slotBTeamId; const redTeamId = normalOverlap > reversedOverlap ? slotBTeamId : slotATeamId; - const winningRiotTeam = detail.info.teams.find(({ win }) => win); + const winningRiotTeams = detail.info.teams.filter( + ({ teamId, win }) => + win && (teamId === RIOT_BLUE_TEAM_ID || teamId === RIOT_RED_TEAM_ID), + ); + if (winningRiotTeams.length !== 1) return null; + const winningRiotTeam = winningRiotTeams[0]; const winnerTeamId = winningRiotTeam?.teamId === RIOT_BLUE_TEAM_ID ? blueTeamId