fix: close competition cutover integrity gaps
This commit is contained in:
1 parent
7ea2002975
commit
683d602d63
57 files changed
+4805
-1582
No files matched your search
@@ -1,5 +1,6 @@
|
||||
/* eslint-disable @typescript-eslint/no-unsafe-assignment */
|
||||
import mongoose from 'mongoose';
|
||||
import { Logger } from '@nestjs/common';
|
||||
import { CommunityStatsService } from '../community-stats/community-stats.service';
|
||||
import { MatchStatsService } from '../community-stats/match-stats.service';
|
||||
import { ConnectionService } from '../global/database/connection.service';
|
||||
@@ -7,6 +8,10 @@ import { CompetitionAssignmentProvisioner } from './competition-assignment.provi
|
||||
import { CompetitionOutboxProcessor } from './competition-outbox.processor';
|
||||
|
||||
describe('CompetitionOutboxProcessor', () => {
|
||||
afterEach(() => {
|
||||
jest.restoreAllMocks();
|
||||
});
|
||||
|
||||
it('leases a projection event and applies idempotent downstream effects', async () => {
|
||||
const competitionId = new mongoose.Types.ObjectId();
|
||||
const matchId = new mongoose.Types.ObjectId();
|
||||
@@ -158,6 +163,59 @@ describe('CompetitionOutboxProcessor', () => {
|
||||
},
|
||||
);
|
||||
});
|
||||
|
||||
it('dead-letters a poison event after the delivery attempt limit', async () => {
|
||||
const event = {
|
||||
_id: new mongoose.Types.ObjectId(),
|
||||
competitionId: new mongoose.Types.ObjectId(),
|
||||
revision: 2,
|
||||
type: 'competition.projection-updated',
|
||||
state: 'pending',
|
||||
attemptCount: 10,
|
||||
};
|
||||
const updateOne = jest.fn(() => executable({ matchedCount: 1 }));
|
||||
const models = {
|
||||
competitionOutbox: {
|
||||
findOneAndUpdate: jest
|
||||
.fn()
|
||||
.mockReturnValueOnce(leanExecutable(event))
|
||||
.mockReturnValueOnce(leanExecutable(null)),
|
||||
updateOne,
|
||||
},
|
||||
competition: {
|
||||
findById: jest.fn(() => leanExecutable(null)),
|
||||
},
|
||||
match: {},
|
||||
};
|
||||
const errorLog = jest
|
||||
.spyOn(Logger.prototype, 'error')
|
||||
.mockImplementation(() => undefined);
|
||||
const processor = new CompetitionOutboxProcessor(
|
||||
{
|
||||
getModel: jest.fn((name: keyof typeof models) =>
|
||||
Promise.resolve(models[name]),
|
||||
),
|
||||
} as unknown as ConnectionService,
|
||||
{ provisionReadyAssignments: jest.fn() } as never,
|
||||
{ buildAndUpsert: jest.fn() } as never,
|
||||
{ invalidateCommunity: jest.fn() } as never,
|
||||
);
|
||||
|
||||
await expect(processor.drainOnce()).resolves.toBe(1);
|
||||
|
||||
expect(updateOne).toHaveBeenCalledWith(
|
||||
{ _id: event._id, state: 'pending', attemptCount: 10 },
|
||||
{
|
||||
$set: {
|
||||
state: 'dead-letter',
|
||||
lastError: 'Competition no longer exists.',
|
||||
},
|
||||
},
|
||||
);
|
||||
expect(errorLog).toHaveBeenCalledWith(
|
||||
expect.stringContaining('moved to dead-letter after 10 attempts'),
|
||||
);
|
||||
});
|
||||
});
|
||||
|
||||
function leanExecutable<T>(value: T) {
|
||||
|
||||
Reference in new issue
Block a user