From 61f1db0e6a73a0633325d33dfcae26cd74cbacc5 Mon Sep 17 00:00:00 2001 From: dahyeon Date: Wed, 15 Jul 2026 01:06:26 -0700 Subject: [PATCH] fix(web): align bracket score-card row geometry --- .../competition/SeriesScoreCard.tsx | 13 +++++++- .../web/test/series-score-card-layout.test.ts | 33 +++++++++++++++++++ 2 files changed, 45 insertions(+), 1 deletion(-) create mode 100644 apps/web/test/series-score-card-layout.test.ts diff --git a/apps/web/src/components/competition/SeriesScoreCard.tsx b/apps/web/src/components/competition/SeriesScoreCard.tsx index 4d48a418..3257e581 100644 --- a/apps/web/src/components/competition/SeriesScoreCard.tsx +++ b/apps/web/src/components/competition/SeriesScoreCard.tsx @@ -104,7 +104,11 @@ export function SeriesScoreCard({ {presentation.label} -
+
{series.entries.map((entry) => { const team = entry.teamId ? teamById.get(entry.teamId) : undefined; const isWinner = isSeriesEntryWinner(series, entry.teamId); @@ -129,6 +133,13 @@ export function SeriesScoreCard({ /> ); })} + {isBracket && ( +
); diff --git a/apps/web/test/series-score-card-layout.test.ts b/apps/web/test/series-score-card-layout.test.ts new file mode 100644 index 00000000..2341a0e3 --- /dev/null +++ b/apps/web/test/series-score-card-layout.test.ts @@ -0,0 +1,33 @@ +import assert from "node:assert/strict"; +import { readFile } from "node:fs/promises"; +import test from "node:test"; +import { SERIES_SCORE_CARD_GEOMETRY } from "../src/components/competition/series-score-card-geometry.ts"; + +const component = await readFile( + new URL( + "../src/components/competition/SeriesScoreCard.tsx", + import.meta.url, + ), + "utf8", +); + +test("keeps bracket entry rows equal by overlaying their divider", () => { + assert.equal( + SERIES_SCORE_CARD_GEOMETRY.height - + SERIES_SCORE_CARD_GEOMETRY.borderWidth * 2 - + SERIES_SCORE_CARD_GEOMETRY.headerHeight, + SERIES_SCORE_CARD_GEOMETRY.entryHeight * 2, + ); + assert.match( + component, + /className=\{\s*isBracket\s*\?\s*"relative"\s*:\s*"divide-y divide-base-content\/8"\s*\}/, + ); + assert.match( + component, + /className="pointer-events-none absolute inset-x-0 border-t border-base-content\/8"/, + ); + assert.match( + component, + /style=\{\{ top: SERIES_SCORE_CARD_GEOMETRY\.entryHeight \}\}/, + ); +});