fix: harden multi-instance scheduler and worker execution
This commit is contained in:
1 parent
df7dcd3a9c
commit
60a006008a
23 files changed
+1442
-299
No files matched your search
@@ -0,0 +1,146 @@
|
||||
import mongoose from 'mongoose';
|
||||
import { MatchStatsService } from '../community-stats/match-stats.service';
|
||||
import { CommunityStatsService } from '../community-stats/community-stats.service';
|
||||
import { ConnectionService } from '../global/database/connection.service';
|
||||
import { DistributedLockService } from '../global/redis/distributed-lock.service';
|
||||
import { RedisService } from '../global/redis/redis.service';
|
||||
import { RiotMatchService } from '../riot/riot-match.service';
|
||||
import { LegacyImportService } from './legacy-import.service';
|
||||
import type { LegacyImportMemberJob } from './legacy-import.types';
|
||||
|
||||
function execResult<T>(value: T) {
|
||||
return { exec: jest.fn().mockResolvedValue(value) };
|
||||
}
|
||||
|
||||
describe('LegacyImportService member job completion', () => {
|
||||
it('increments aggregate counters only once for the same member job id', async () => {
|
||||
const legacyImportJobModel = {
|
||||
findOne: jest
|
||||
.fn()
|
||||
.mockReturnValueOnce(
|
||||
execResult({
|
||||
jobId: 'legacy-job-1',
|
||||
state: 'running',
|
||||
processedMembers: 0,
|
||||
totalMembers: 1,
|
||||
averageMemberSeconds: 60,
|
||||
completedMemberJobIds: [],
|
||||
}),
|
||||
)
|
||||
.mockReturnValueOnce({
|
||||
select: jest.fn().mockReturnValue({
|
||||
lean: jest.fn().mockReturnValue(
|
||||
execResult({
|
||||
state: 'running',
|
||||
processedMembers: 1,
|
||||
totalMembers: 1,
|
||||
}),
|
||||
),
|
||||
}),
|
||||
})
|
||||
.mockReturnValueOnce(
|
||||
execResult({
|
||||
jobId: 'legacy-job-1',
|
||||
state: 'completed',
|
||||
processedMembers: 1,
|
||||
totalMembers: 1,
|
||||
averageMemberSeconds: 60,
|
||||
completedMemberJobIds: ['member-job-1'],
|
||||
}),
|
||||
),
|
||||
updateOne: jest.fn().mockReturnValue(execResult({ modifiedCount: 1 })),
|
||||
};
|
||||
const connectionService = {
|
||||
getModel: jest.fn().mockResolvedValue(legacyImportJobModel),
|
||||
} as unknown as jest.Mocked<ConnectionService>;
|
||||
const distributedLockService = {
|
||||
releaseLockIfOwned: jest.fn().mockResolvedValue(true),
|
||||
} as unknown as jest.Mocked<DistributedLockService>;
|
||||
const communityStatsService = {
|
||||
invalidateCommunity: jest.fn().mockResolvedValue(undefined),
|
||||
} as unknown as jest.Mocked<CommunityStatsService>;
|
||||
const service = new LegacyImportService(
|
||||
connectionService,
|
||||
{} as RedisService,
|
||||
{} as RiotMatchService,
|
||||
communityStatsService,
|
||||
{} as MatchStatsService,
|
||||
distributedLockService,
|
||||
);
|
||||
const job: LegacyImportMemberJob = {
|
||||
kind: 'legacy-import-member',
|
||||
jobId: 'member-job-1',
|
||||
parentJobId: 'legacy-job-1',
|
||||
communityId: new mongoose.Types.ObjectId().toString(),
|
||||
userId: new mongoose.Types.ObjectId().toString(),
|
||||
puuid: 'puuid-1',
|
||||
startTime: 1,
|
||||
endTime: 2,
|
||||
triggeredBy: new mongoose.Types.ObjectId().toString(),
|
||||
region: 'asia',
|
||||
};
|
||||
|
||||
await (
|
||||
service as unknown as {
|
||||
finishMemberJob: (
|
||||
job: LegacyImportMemberJob,
|
||||
stats: {
|
||||
discovered: number;
|
||||
imported: number;
|
||||
duplicates: number;
|
||||
errors: number;
|
||||
elapsedSeconds: number;
|
||||
},
|
||||
) => Promise<void>;
|
||||
}
|
||||
).finishMemberJob(job, {
|
||||
discovered: 3,
|
||||
imported: 2,
|
||||
duplicates: 1,
|
||||
errors: 0,
|
||||
elapsedSeconds: 30,
|
||||
});
|
||||
await (
|
||||
service as unknown as {
|
||||
finishMemberJob: (
|
||||
job: LegacyImportMemberJob,
|
||||
stats: {
|
||||
discovered: number;
|
||||
imported: number;
|
||||
duplicates: number;
|
||||
errors: number;
|
||||
elapsedSeconds: number;
|
||||
},
|
||||
) => Promise<void>;
|
||||
}
|
||||
).finishMemberJob(job, {
|
||||
discovered: 3,
|
||||
imported: 2,
|
||||
duplicates: 1,
|
||||
errors: 0,
|
||||
elapsedSeconds: 30,
|
||||
});
|
||||
|
||||
expect(legacyImportJobModel.updateOne).toHaveBeenNthCalledWith(
|
||||
1,
|
||||
{
|
||||
jobId: 'legacy-job-1',
|
||||
completedMemberJobIds: { $ne: 'member-job-1' },
|
||||
state: { $ne: 'cancelled' },
|
||||
},
|
||||
expect.objectContaining({
|
||||
$addToSet: { completedMemberJobIds: 'member-job-1' },
|
||||
$inc: expect.objectContaining({
|
||||
processedMembers: 1,
|
||||
totalDiscoveredMatchIds: 3,
|
||||
totalImportedMatches: 2,
|
||||
totalSkippedDuplicate: 1,
|
||||
totalErrors: 0,
|
||||
}),
|
||||
}),
|
||||
);
|
||||
expect(legacyImportJobModel.updateOne).toHaveBeenCalledTimes(2);
|
||||
expect(distributedLockService.releaseLockIfOwned).toHaveBeenCalledTimes(1);
|
||||
expect(communityStatsService.invalidateCommunity).toHaveBeenCalledTimes(1);
|
||||
});
|
||||
});
|
||||
Reference in new issue
Block a user