From 575cd911cbb0a0a8bc45e703f2567950646551e8 Mon Sep 17 00:00:00 2001 From: Park Dahyeon Date: Sun, 12 Jul 2026 20:05:25 +0000 Subject: [PATCH] refactor: remove live legacy bracket mode --- .../match/dto/create-match.dto.spec.ts | 33 +++++++++++++++++++ .../src/modules/match/dto/create-match.dto.ts | 18 +++++++--- .../match/match-public.presenter.spec.ts | 1 + .../modules/match/match-public.presenter.ts | 9 ++++- 4 files changed, 55 insertions(+), 6 deletions(-) create mode 100644 apps/api/src/modules/match/dto/create-match.dto.spec.ts diff --git a/apps/api/src/modules/match/dto/create-match.dto.spec.ts b/apps/api/src/modules/match/dto/create-match.dto.spec.ts new file mode 100644 index 00000000..99e8e941 --- /dev/null +++ b/apps/api/src/modules/match/dto/create-match.dto.spec.ts @@ -0,0 +1,33 @@ +import 'reflect-metadata'; +import { plainToInstance } from 'class-transformer'; +import { validateSync } from 'class-validator'; +import { CreateMatchDto } from './create-match.dto'; + +describe('CreateMatchDto game mode cutover', () => { + it('rejects the removed live bracket mode', () => { + const dto = plainToInstance(CreateMatchDto, { + title: 'legacy bracket', + scheduledAt: '2026-07-13T10:00:00.000Z', + gameMode: 'bracket', + }); + + expect(validateSync(dto)).toEqual( + expect.arrayContaining([ + expect.objectContaining({ property: 'gameMode' }), + ]), + ); + }); + + it.each(['pair', 'round-robin', 'double-elimination'] as const)( + 'accepts the live %s mode', + (gameMode) => { + const dto = plainToInstance(CreateMatchDto, { + title: 'Competition', + scheduledAt: '2026-07-13T10:00:00.000Z', + gameMode, + }); + + expect(validateSync(dto)).toEqual([]); + }, + ); +}); diff --git a/apps/api/src/modules/match/dto/create-match.dto.ts b/apps/api/src/modules/match/dto/create-match.dto.ts index 886ef1d5..5c5b418d 100644 --- a/apps/api/src/modules/match/dto/create-match.dto.ts +++ b/apps/api/src/modules/match/dto/create-match.dto.ts @@ -8,6 +8,7 @@ import { IsDate, IsEnum, IsInt, + IsIn, IsOptional, IsString, MaxLength, @@ -17,9 +18,16 @@ import { ValidationArguments, ValidationOptions, } from 'class-validator'; -import { MATCH_GAME_MODES, POSITIONS } from '../../global/database/schema'; +import { POSITIONS } from '../../global/database/schema'; import type { MatchGameMode, Position } from '../../global/database/schema'; +const LIVE_MATCH_GAME_MODES = [ + 'pair', + 'round-robin', + 'double-elimination', +] as const; +type LiveMatchGameMode = Exclude; + function IsMultipleOf( multiple: number, validationOptions?: ValidationOptions, @@ -99,8 +107,8 @@ export class CreateMatchDto { gameCount?: number; @IsOptional() - @IsEnum(MATCH_GAME_MODES) - gameMode?: MatchGameMode; + @IsIn(LIVE_MATCH_GAME_MODES) + gameMode?: LiveMatchGameMode; @IsOptional() @IsInt() @@ -163,8 +171,8 @@ export class UpdateMatchDto { gameCount?: number; @IsOptional() - @IsEnum(MATCH_GAME_MODES) - gameMode?: MatchGameMode; + @IsIn(LIVE_MATCH_GAME_MODES) + gameMode?: LiveMatchGameMode; @IsOptional() @IsInt() diff --git a/apps/api/src/modules/match/match-public.presenter.spec.ts b/apps/api/src/modules/match/match-public.presenter.spec.ts index a46064e8..c86fdfca 100644 --- a/apps/api/src/modules/match/match-public.presenter.spec.ts +++ b/apps/api/src/modules/match/match-public.presenter.spec.ts @@ -59,6 +59,7 @@ describe('presentPublicMatch', () => { communityId: oid('2').toString(), competitionId: oid('3').toString(), title: '내전', + doubleEliminationResetFinalEnabled: false, scheduledAt: '2026-07-12T10:00:00.000Z', participants: [ expect.objectContaining({ diff --git a/apps/api/src/modules/match/match-public.presenter.ts b/apps/api/src/modules/match/match-public.presenter.ts index 6bd6120e..ccadcca3 100644 --- a/apps/api/src/modules/match/match-public.presenter.ts +++ b/apps/api/src/modules/match/match-public.presenter.ts @@ -20,6 +20,7 @@ interface PublicMatchSource { gameCount: number; gameMode: MatchGameMode; roundRobinMaxRounds?: number; + doubleElimination?: { resetFinalEnabled?: boolean }; hostUserId?: IdLike; participants: Array<{ userId: IdLike; @@ -71,10 +72,16 @@ export function presentPublicMatch( scheduledAt: asIso(source.scheduledAt), maxParticipants: source.maxParticipants, gameCount: source.gameCount, - gameMode: source.gameMode, + gameMode: source.gameMode === 'bracket' ? 'pair' : source.gameMode, ...(source.roundRobinMaxRounds === undefined ? {} : { roundRobinMaxRounds: source.roundRobinMaxRounds }), + ...(source.gameMode === 'double-elimination' + ? { + doubleEliminationResetFinalEnabled: + source.doubleElimination?.resetFinalEnabled ?? false, + } + : {}), ...(source.hostUserId ? { hostUserId: source.hostUserId.toString() } : {}), participants: source.participants.map((participant) => ({ userId: participant.userId.toString(),