fix: recover auction client from rejected transitions
거부(특히 낙관적 동시성 CONFLICT)를 받은 클라가 낡은 상태에 멈춰 후속 액션을 반복 거부받던 문제를 해결한다. - 서버: 거부 ack에 설명적 거부코드(auctionRejectionReason)와 resync 권장 여부, 그리고 resync 권장 거부에 한해 최신 권위 state를 동봉한다. 구조 전환 거부는 내부 code(CONFLICT 등)를 구조화해 던져 매핑 가능하게 한다. - 클라: 거부 시 동봉된 state로 즉시 rebaseline(없으면 join으로 재요청)하고, "낡은 화면" 거부면 구조 액션을 1회 자동 재시도한다. 거부 문구를 거부코드 기반 한국어로 매핑한다(error 이벤트 채널 포함). 신규 auction-rejection 모듈로 짧은 내부 코드를 맥락이 담긴 설명적 코드로 변환한다. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
1 parent
09d304d782
commit
55b80e62cd
6 files changed
+477
-15
No files matched your search
@@ -0,0 +1,82 @@
|
||||
import {
|
||||
AUCTION_REJECTION_REASON,
|
||||
isAuctionResyncRecommended,
|
||||
resolveAuctionRejectionReason,
|
||||
} from './auction-rejection';
|
||||
|
||||
describe('resolveAuctionRejectionReason', () => {
|
||||
it('maps the internal CONFLICT code to the descriptive transition reason', () => {
|
||||
expect(resolveAuctionRejectionReason('CONFLICT')).toBe(
|
||||
AUCTION_REJECTION_REASON.AUCTION_TRANSITION_REJECTED_BECAUSE_LIVE_STATE_CHANGED_BEFORE_APPLY,
|
||||
);
|
||||
});
|
||||
|
||||
it('maps internal bid codes to descriptive bid reasons', () => {
|
||||
expect(resolveAuctionRejectionReason('EXPIRED')).toBe(
|
||||
AUCTION_REJECTION_REASON.BID_REJECTED_BECAUSE_BID_ROUND_DEADLINE_PASSED,
|
||||
);
|
||||
expect(resolveAuctionRejectionReason('TOO_LOW')).toBe(
|
||||
AUCTION_REJECTION_REASON.BID_REJECTED_BECAUSE_AMOUNT_NOT_HIGHER_THAN_CURRENT_HIGHEST,
|
||||
);
|
||||
});
|
||||
|
||||
it('maps known BadRequest messages without a structured code', () => {
|
||||
expect(
|
||||
resolveAuctionRejectionReason(undefined, 'Cannot advance from current phase.'),
|
||||
).toBe(
|
||||
AUCTION_REJECTION_REASON.AUCTION_TRANSITION_REJECTED_BECAUSE_PHASE_DOES_NOT_ALLOW_ADVANCE,
|
||||
);
|
||||
});
|
||||
|
||||
it('falls back via the message when the code carries the full sentence', () => {
|
||||
// 구조 전환 경로는 code 자리에 message 문장이 들어올 수 있다.
|
||||
expect(
|
||||
resolveAuctionRejectionReason('Auction is not in bidding phase.'),
|
||||
).toBe(
|
||||
AUCTION_REJECTION_REASON.AUCTION_TRANSITION_REJECTED_BECAUSE_AUCTION_NOT_IN_BIDDING_PHASE,
|
||||
);
|
||||
});
|
||||
|
||||
it('treats internal coordination codes as retryable', () => {
|
||||
expect(resolveAuctionRejectionReason('ACTION_REQUEST_LEASE_EXPIRED')).toBe(
|
||||
AUCTION_REJECTION_REASON.AUCTION_TRANSITION_REJECTED_BECAUSE_REQUEST_COORDINATION_RETRYABLE,
|
||||
);
|
||||
expect(resolveAuctionRejectionReason('INVALID_DEADLINE_MODE')).toBe(
|
||||
AUCTION_REJECTION_REASON.AUCTION_TRANSITION_REJECTED_BECAUSE_REQUEST_COORDINATION_RETRYABLE,
|
||||
);
|
||||
});
|
||||
|
||||
it('falls back to the unrecognized reason for unknown input', () => {
|
||||
expect(resolveAuctionRejectionReason('SOMETHING_NEW', 'weird')).toBe(
|
||||
AUCTION_REJECTION_REASON.AUCTION_REQUEST_REJECTED_FOR_UNRECOGNIZED_REASON,
|
||||
);
|
||||
});
|
||||
});
|
||||
|
||||
describe('isAuctionResyncRecommended', () => {
|
||||
it('recommends resync for stale-view rejections', () => {
|
||||
expect(
|
||||
isAuctionResyncRecommended(
|
||||
AUCTION_REJECTION_REASON.AUCTION_TRANSITION_REJECTED_BECAUSE_LIVE_STATE_CHANGED_BEFORE_APPLY,
|
||||
),
|
||||
).toBe(true);
|
||||
expect(
|
||||
isAuctionResyncRecommended(
|
||||
AUCTION_REJECTION_REASON.BID_REJECTED_BECAUSE_BID_ROUND_DEADLINE_PASSED,
|
||||
),
|
||||
).toBe(true);
|
||||
});
|
||||
|
||||
it('does not recommend resync for genuine constraint rejections', () => {
|
||||
expect(
|
||||
isAuctionResyncRecommended(
|
||||
AUCTION_REJECTION_REASON.BID_REJECTED_BECAUSE_TEAM_ROSTER_FULL,
|
||||
),
|
||||
).toBe(false);
|
||||
expect(
|
||||
isAuctionResyncRecommended(
|
||||
AUCTION_REJECTION_REASON.AUCTION_REQUEST_REJECTED_FOR_UNRECOGNIZED_REASON,
|
||||
),
|
||||
).toBe(false);
|
||||
});
|
||||
});
|
||||
Reference in new issue
Block a user