fix: prevent auction snapshot mutation

This commit is contained in:
dahyeon committed 2026-06-26 03:12:13 -07:00
1 parent 6dbc643c44
commit 37f1f4225d
5 files changed
+166 -19

No files matched your search

+32 -18
View File
@@ -40,6 +40,7 @@ import {
import { AuctionRedisService } from './redis/auction-redis.service';
import { AuctionRedisStateReaderService } from './redis/auction-redis-state-reader.service';
import { shouldHydrateRedisAuctionState } from './redis/auction-redis.state';
// [AUCTION-DEBUG] 경매 "중복 멤버" 조사용 임시 계측. 조사 종료 후 제거 대상.
import { recordNewRelicCustomEvent } from '../global/observability/new-relic';
const AUCTION_MAX_TEAM_SIZE = 5;
@@ -910,8 +911,8 @@ export class AuctionService {
return this.resolveReplayedRedisActionRequest(matchId, actionRequest);
}
// 중복 멤버 버그 스모킹건: 낙찰 직전, 이 선수가 이미 어느 팀에 들어있는지.
// (markRedisSold는 검사 없이 append하므로 true면 그대로 중복이 만들어진다)
// [AUCTION-DEBUG] 중복 멤버 버그 스모킹건: 낙찰 직전, 이 선수가 이미 어느 팀에
// 들어있는지. (markRedisSold는 검사 없이 append하므로 true면 그대로 중복) — 제거 대상
const soldUserId = String(currentPlayer.userId);
const existingTeamIndex = structureInput.auctionTeams.find((entry) =>
(entry.members ?? []).some(
@@ -1699,6 +1700,7 @@ export class AuctionService {
(params.auction.matchSideEffectRevision ?? 0) + 1;
afterAuctionMongoProjection.matchSideEffectError = undefined;
}
const durabilityPayload = {
afterAuctionMongoProjection,
auctionActionType: params.action,
@@ -1749,7 +1751,7 @@ export class AuctionService {
actionRequest: params.actionRequest?.actionRequest,
},
);
// 모든 redis 전환(sold/undo/next/open-bidding/complete)의 백본 타임라인.
// [AUCTION-DEBUG] 제거 대상. 모든 redis 전환(sold/undo/next/open-bidding/complete)의 백본 타임라인.
// auctionStateTransitionId = `${action}:${lifecycleId}:${auctionActionRequestId}`
// 라서 클라의 auctionActionRequestId와 조인된다.
recordNewRelicCustomEvent('AuctionServerTransition', {
@@ -1884,12 +1886,15 @@ export class AuctionService {
0,
);
// undo가 "어느 시점으로" 복원하는지 + 복원된 팀 구성을 기록한다. 라이브 revision과
// [AUCTION-DEBUG] 제거 대상. undo가 "어느 시점으로" 복원하는지 + 복원된 팀 구성. 라이브 revision과
// 복원 스냅샷 revision의 간격(restoredRevisionLag)이 사용자가 본 "2~3 뒤처짐".
// 이 이벤트 직후의 AuctionServerSold가 playerAlreadyInTeam:true면 "undo가 선수를
// 안 지운 채 재낙찰 → 중복"이 한 타임라인으로 증명된다.
const liveRevisionBeforeUndo = this.numberFromState(state.revision);
const restoredRevision = this.numberFromState(params.snapshot.revision);
const restoredMemberUserIds = structureInput.auctionTeams.flatMap((entry) =>
(entry.members ?? []).map((member) => String(member.userId)),
);
recordNewRelicCustomEvent('AuctionServerUndo', {
matchId,
auctionActionRequestId:
@@ -1904,10 +1909,9 @@ export class AuctionService {
),
restoredPhase: phase,
restoredOrderIndex: structureInput.currentAuctionPlayerOrderIndex,
restoredAssignedMemberCount: structureInput.auctionTeams.reduce(
(sum, entry) => sum + (entry.members?.length ?? 0),
0,
),
restoredAssignedMemberCount: restoredMemberUserIds.length,
restoredHasDuplicateMember:
restoredMemberUserIds.length !== new Set(restoredMemberUserIds).size,
undoingCompletedAuction: params.undoingCompletedAuction,
});
@@ -1952,8 +1956,10 @@ export class AuctionService {
state: Record<string, unknown>,
): Parameters<typeof stringifyAuctionRedisStructureState>[0] {
return {
auctionPlayerOrder: this.arrayFromState(state.auctionPlayerOrder),
auctionTeams: this.arrayFromState(state.auctionTeams),
auctionPlayerOrder: this.cloneRedisStructureArray(
state.auctionPlayerOrder,
),
auctionTeams: this.cloneRedisStructureArray(state.auctionTeams),
bidRoundExtensionSeconds: this.numberFromState(
state.bidRoundExtensionSeconds,
5,
@@ -1966,14 +1972,14 @@ export class AuctionService {
state.initialTeamBidPointAmount,
1000,
),
manualTopTierAuctionPriorityUserIds: this.arrayFromState(
manualTopTierAuctionPriorityUserIds: this.cloneRedisStructureArray(
state.manualTopTierAuctionPriorityUserIds,
),
maximumBidRoundDurationSeconds: this.numberFromState(
state.maximumBidRoundDurationSeconds,
30,
),
passedAuctionPlayerQueue: this.arrayFromState(
passedAuctionPlayerQueue: this.cloneRedisStructureArray(
state.passedAuctionPlayerQueue,
),
topTierAuctionPriorityThreshold: this.isAuctionTopTierThreshold(
@@ -1987,14 +1993,15 @@ export class AuctionService {
private buildRedisStructureInputFromAuctionSnapshot(
snapshot: Record<string, unknown>,
): Parameters<typeof stringifyAuctionRedisStructureState>[0] {
const legacyTeams = this.arrayFromState(snapshot.teams);
const legacyTeams = this.cloneRedisStructureArray(snapshot.teams);
const auctionTeams = this.cloneRedisStructureArray(snapshot.auctionTeams);
return {
auctionPlayerOrder: this.arrayFromState(
auctionPlayerOrder: this.cloneRedisStructureArray(
snapshot.auctionPlayerOrder ?? snapshot.order,
),
auctionTeams:
this.arrayFromState(snapshot.auctionTeams).length > 0
? this.arrayFromState(snapshot.auctionTeams)
auctionTeams.length > 0
? auctionTeams
: convertLegacyAuctionTeamsToRedisTeams(legacyTeams as never),
bidRoundExtensionSeconds: this.numberFromState(
snapshot.bidRoundExtensionSeconds ?? snapshot.bidExtensionSeconds,
@@ -2011,7 +2018,7 @@ export class AuctionService {
snapshot.initialTeamBidPointAmount ?? snapshot.initialPoints,
1000,
),
manualTopTierAuctionPriorityUserIds: this.arrayFromState(
manualTopTierAuctionPriorityUserIds: this.cloneRedisStructureArray(
snapshot.manualTopTierAuctionPriorityUserIds ??
snapshot.manualTopTierUserIds,
),
@@ -2019,7 +2026,7 @@ export class AuctionService {
snapshot.maximumBidRoundDurationSeconds ?? snapshot.maxTimerSeconds,
30,
),
passedAuctionPlayerQueue: this.arrayFromState(
passedAuctionPlayerQueue: this.cloneRedisStructureArray(
snapshot.passedAuctionPlayerQueue ?? snapshot.passedQueue,
),
topTierAuctionPriorityThreshold: this.isAuctionTopTierThreshold(
@@ -2172,6 +2179,13 @@ export class AuctionService {
return Array.isArray(value) ? (value as T[]) : [];
}
private cloneRedisStructureArray<T = never>(value: unknown): T[] {
// 구조 전환 핸들러가 이 작업본을 변이하므로 snapshotBefore 원본과 참조를 공유하면 안 된다.
// structuredClone은 ObjectId를 [object Object]로 망가뜨리므로, 코드베이스 관행대로
// JSON 클론으로 깊은 복사 + ObjectId/Date 정규화를 함께 수행한다.
return JSON.parse(JSON.stringify(this.arrayFromState<T>(value))) as T[];
}
private numberFromState(value: unknown, fallback = 0): number {
const parsed = Number(value);
return Number.isFinite(parsed) ? parsed : fallback;