Default secrets to environment source

This commit is contained in:
dahyeon committed 2026-06-06 13:12:48 -07:00
1 parent 85ba8044da
commit 33abda997f
2 files changed
+133 -35

No files matched your search

@@ -0,0 +1,69 @@
import { ConfigService } from '@nestjs/config';
import { SecretService } from './secret.service';
function makeConfig(values: Record<string, string | undefined> = {}) {
return {
get: jest.fn((key: string) => values[key] ?? process.env[key]),
} as unknown as ConfigService;
}
describe('SecretService', () => {
const originalEnv = process.env;
let fetchMock: jest.Mock;
beforeEach(() => {
process.env = { ...originalEnv };
delete process.env.SECRET_SOURCE;
delete process.env.TEST_SECRET;
fetchMock = jest
.fn()
.mockRejectedValue(new Error('network calls are disabled in tests'));
global.fetch = fetchMock;
});
afterEach(() => {
process.env = originalEnv;
jest.restoreAllMocks();
});
it('defaults to environment-provided secrets without IMDS lookup', async () => {
process.env.TEST_SECRET = 'from-env';
const service = new SecretService(makeConfig());
await service.ready();
await expect(service.get('TEST_SECRET')).resolves.toBe('from-env');
expect(fetchMock).not.toHaveBeenCalled();
});
it('uses environment-provided secrets when SECRET_SOURCE is env', async () => {
process.env.SECRET_SOURCE = 'env';
process.env.TEST_SECRET = 'from-env-source';
const service = new SecretService(makeConfig());
await service.ready();
await expect(service.get('TEST_SECRET')).resolves.toBe('from-env-source');
expect(fetchMock).not.toHaveBeenCalled();
});
it('uses the IMDS and Infisical bootstrap path only when SECRET_SOURCE is infisical', async () => {
process.env.SECRET_SOURCE = 'infisical';
const service = new SecretService(makeConfig());
await expect(service.ready()).rejects.toThrow(
'Missing required bootstrap secret: INFISICAL_CLIENT_ID',
);
expect(fetchMock).toHaveBeenCalled();
});
it('rejects unsupported SECRET_SOURCE values', async () => {
process.env.SECRET_SOURCE = 'kubernetes';
const service = new SecretService(makeConfig());
await expect(service.ready()).rejects.toThrow(
'Invalid SECRET_SOURCE="kubernetes". Expected "env" or "infisical".',
);
expect(fetchMock).not.toHaveBeenCalled();
});
});