Add secret coverage and NATS subject ACL
- KNOWN_SECRET_KEYS now covers LLM, embedding, and Phoenix API keys - Logger redaction paths extended to cover the new credential keys - nats-skill-acl maps each skill to allowed publish/subscribe subjects - NATS publish runs ACL check with log-only/enforce/off modes
This commit is contained in:
1 parent
d011a2829c
commit
bc0f8e0773
5 files changed
+151
No files matched your search
@@ -0,0 +1,41 @@
|
||||
import { afterEach, describe, expect, it, vi } from "vitest";
|
||||
|
||||
import { runWithContext } from "../observability/context.js";
|
||||
import { NatsClient } from "./nats.js";
|
||||
import { AGENT_ALERT_SUBJECT, DISCORD_MEMBER_LOOKUP_SUBJECT } from "./nats-subjects.js";
|
||||
import { checkPublishAllowed } from "./nats-skill-acl.js";
|
||||
|
||||
describe("NATS skill ACL", () => {
|
||||
afterEach(() => {
|
||||
vi.unstubAllEnvs();
|
||||
});
|
||||
|
||||
it("allows declared publish subjects", () => {
|
||||
expect(checkPublishAllowed("onboarding", DISCORD_MEMBER_LOOKUP_SUBJECT)).toBe(
|
||||
true,
|
||||
);
|
||||
expect(checkPublishAllowed("supervisor", AGENT_ALERT_SUBJECT)).toBe(true);
|
||||
expect(checkPublishAllowed("onboarding", AGENT_ALERT_SUBJECT)).toBe(false);
|
||||
});
|
||||
|
||||
it("enforces denied publish subjects when enabled", async () => {
|
||||
vi.stubEnv("AGENT_NATS_ACL_MODE", "enforce");
|
||||
const client = new NatsClient();
|
||||
|
||||
await expect(
|
||||
runWithContext(
|
||||
{
|
||||
chatroomId: "room-1",
|
||||
requestId: "req-1",
|
||||
skill: "onboarding",
|
||||
startedAt: "2026-05-18T00:00:00.000Z",
|
||||
trigger: "user-message",
|
||||
userId: "user-1",
|
||||
},
|
||||
() => client.publish(AGENT_ALERT_SUBJECT, { ok: true }),
|
||||
),
|
||||
).rejects.toThrow(
|
||||
`NATS publish denied for skill onboarding on subject ${AGENT_ALERT_SUBJECT}`,
|
||||
);
|
||||
});
|
||||
});
|
||||
Reference in new issue
Block a user